feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
82,976 Commits 108 Branches 368 Tags
673bcb644c6041cb2893bf11d3da8f13479246cc
Commit Graph

82976 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
hjk
ec7abcf98c Utils: Make FilePathAspect::setDefaultValue take a QString 
This sets the unexpanded value, so going to a "cooked" FilePath can
at least theoretically break. On the user side it saves a
roundtrip in a few cases, but is more ugly when the input is already
a proper FilePath.

Change-Id: I8a7e8f6d46fcc34c96b55e41d656dca933fbef4e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
 2023-08-17 11:58:41 +00:00
hjk
3fa4fa5cf3 Wizards: Use simpler init() signature in the Creator Plugin template 
This is the most common case by far. Also add a hint for special needs.

Change-Id: Ib4d708d90a3b2dd91d18fa53c3fb597304145697
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2023-08-17 11:56:35 +00:00
Jarek Kobus
886205b149 FileUtils: Use Process::startDetached() instead of QProcess 
Reading data from the detached process is no-op.

Change-Id: I128ecc5298e0e6d4a73ecfceba55bc147ffd3a58
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 11:05:58 +00:00
Jarek Kobus
0ffc4ac89e LanguageClient: Rename clientrequesttask.{cpp,h} -> clientrequest.{cpp,h} 
Change-Id: Ia6a1b65564795c8f2931efb1030d7a189a18d68b
Reviewed-by: David Schulz <david.schulz@qt.io>
 2023-08-17 11:04:58 +00:00
Jarek Kobus
5b8600fd37 LanguageClient: Rename ClientRequestTask -> ClientRequest 
Make naming consistent.

Fixes: QTCREATORBUG-29102
Change-Id: I215cdc524168df2783497a56c7daf87563db716d
Reviewed-by: David Schulz <david.schulz@qt.io>
 2023-08-17 11:04:50 +00:00
Artem Sokolovskii
0192c3c26d DAP : Refactor DapEngine 
Extracted client part to additional class DapClient.

Change-Id: Iba472d2fb2c2390f38ad9a3a75e9e1d9a76f912c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 11:02:13 +00:00
Jarek Kobus
98026b29c6 TaskTree: Get rid of registration macros 
Alias task types manually.
Don't require the alias to be inside the Tasking namespace.
Addresses the 22th point of the jira ticket below.

Task-number: QTCREATORBUG-28741
Change-Id: I1bdda7fe5a01e4bcb5052ec328f4e0eace878651
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 10:23:52 +00:00
Jarek Kobus
36e0ea27b9 VariousPlugins: Fix forward declarations 
The pattern is to use QT_[BEGIN/END]_NAMESPACE, instead of
QT_FORWARD_DECLARE_CLASS.

Change-Id: I9da39ee003e1d477a5f56980c218e275706bb3f4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2023-08-17 09:13:35 +00:00
Christian Stenger
8542c982b4 CompilerExplorer: Add plugin to qbs build 
Amends e34762c844.

Change-Id: I6da9820b35df1783a6e99279f18d7e23a25c2a7e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
 2023-08-17 09:13:25 +00:00
Jarek Kobus
dd253a3940 Valgrind: Squash nested namespaces 
Change-Id: I45fd17c091ac588c30cd360efb6116365ebd73d7
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 08:31:39 +00:00
Jarek Kobus
78a034f721 ValgrindProcess: Make it taskable 
Change-Id: I39af67619b7808e349d3a71414e0eebb956331f6
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 08:29:22 +00:00
Jarek Kobus
6c5f39c5d2 Valgrind: Rename valgrindrunner.{cpp,h} -> valgrindprocess.{cpp.h} 
Change-Id: I17f8e55ee97567b98f2260d1a79413bd26d02314
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 08:26:36 +00:00
Jarek Kobus
1d5102781d Valgrind: Rename ValgrindRunner -> ValgrindProcess 
Change-Id: I5e7d704c749e53672915c5f7aab64abb68353f24
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 08:11:28 +00:00
Jarek Kobus
e8510501d8 Valgrind: Fix includes 
Change-Id: I30248edc9f536cd3865799dd0b56c1360e72aa2f
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 08:10:10 +00:00
Jarek Kobus
f4eb25ccec Process: Add setRunData() helper 
It allows to set command/workingDir/env in one go.

Fix condition for setCommand() to match the one for setWorkingDir().

Change-Id: I0aa4639f3357c387a0fe8da321e94e34a3ea232d
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 08:08:09 +00:00
hjk
8cf7ac4ac7 Android: Avoid some cast for tool chains 
targetAbi() is available in the base and non-virtual.

Change-Id: I1c65dccec98b7df5211b2ecfa1e91a4bb4b6e98f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2023-08-17 08:00:08 +00:00
Cristian Adam
8642dd3b68 CMake: Fix build for Windows 
The `env_with_default` function is part of Utils.cmake, which would need
to be deployed. But it can't be part of QtCreatorAPIInternal.cmake due
to its usage before the inclusion of QtCreatorAPIInternal.cmake in the
main QtCreator CMakeLists.txt file.

A sepparate function needs to do the task.

Amends 1036c776f5

Change-Id: I95344dd98c5fa0258303ed8d02855584a1945144
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2023-08-17 07:55:11 +00:00
Jarek Kobus
121d73b30f Utils: Rename ProjectExplorer::Runnable into Utils::ProcessRunData 
Move it into Utils lib.

Change-Id: I3b6c16d18439cabddf59afc03116f13c1970102c
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 07:44:34 +00:00
Jarek Kobus
123eb073ca Runnable: Keep extraData separately 
It's rarely used.

Change-Id: I11e6546e5991ba2332943eb4900190f937d1db1d
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 07:42:48 +00:00
Christian Stenger
635fc9bb1f Fix accidental submodule update 
Amends e34762c844.

Change-Id: I22b5599289ba314fb9d8897f8f5b45cb099ef9d7
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 07:42:10 +00:00
Jarek Kobus
a9ac5b7b6e ProjectExplorer: Remove unused function 
Change-Id: I7c0ea4445283fb38ca46aa3cd9690778389f3afa
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 07:22:16 +00:00
Marcus Tillmanns
e34762c844 Add CompilerExplorer plugin 
Change-Id: I534dea195a0b74f177fc227483752777485be177
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 07:11:45 +00:00
Marcus Tillmanns
92355bf40d Terminal: Lazily open remote terminals 
Move the burden of finding the shell of a device from the shell menu
to the TerminalWidget, so that opening the shell menu does not block
the ui.

Change-Id: I7f2e5a891f20faa53a1e3eec879866219f9bee0b
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 07:09:48 +00:00
Christian Stenger
d611fe6821 Axivion: Add generated files to qbs build 
They have been added for future use for the cmake
build. Do so as well for qbs.

Change-Id: I0cb9bb161090a9c84e8c36567d6555bc0096b0e4
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 06:58:47 +00:00
Marcus Tillmanns
ccb66ea64d Copilot: Don't use app_version 
Change-Id: I10c1bfaa6befe49ba7261afe14c457a5f33c887f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2023-08-17 06:50:59 +00:00
hjk
62969fe567 ProjectExplorer: Remove unneeded #include 
Change-Id: Ib835409781ad1ebf8efa184e69c5adf20436b6ad
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2023-08-17 06:36:36 +00:00
Christian Stenger
a93040185d AutoTest: Fix used IDs 
Amends f53e18ee73.

Change-Id: Ib807eaaa6f211d3661a447e5d02bc0cce108ff2f
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 06:31:45 +00:00
Marcus Tillmanns
5e70029e87 Utils: ShowPwdButton paint while not enabled 
Change-Id: Ie76413b91d91e703e108192b04e8bbfeed2774f0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2023-08-17 06:29:54 +00:00
Christian Stenger
8815d5974e Copilot: Fix build 
Change-Id: I4fb0df318ec6eff50f2ddca476195882f1c6910d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
 2023-08-17 05:38:24 +00:00
David Schulz
f1411c580d LanguageClient: only restart successfully initialized clients 
Change-Id: I09174ae1b5cec088e22e5de8634af90687faf109
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2023-08-17 05:33:11 +00:00
Marcus Tillmanns
ec4c85bab4 Copilot: Enabler readSettings workaround 
readSettings does not trigger signals when values change, so
other aspects that have setEnabler set will not realize that
the enablers changed and possibly not update.

Calling setEnabler after read settings ensures that the correct
value is used.

Change-Id: Ifff3ff13d9c78e16bddf8032b891a5004a035496
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2023-08-17 04:42:55 +00:00
Jarek Kobus
b1304de6cf ValgrindRunner: Employ task tree internally 
Change-Id: I32f674d7ea93e5825eba0912c98cc0280802c483
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 16:21:40 +00:00
hjk
9335cca249 ProjectExplorer: Hide CustomToolChain implementation 
Also un-unexport it.

Change-Id: If2b47fbaaedd15f0d5b9de62a6964dacb09f8ae9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2023-08-16 16:12:49 +00:00
Jarek Kobus
2119a6c254 ValgrindRunner: Get rid of errorString() 
Change-Id: I5ef4d911f0986a721855525f6b2b7645253606fe
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 16:10:59 +00:00
hjk
8dc3b0abc5 ProjectExplorer: Hide CustomToolChainConfigWidget implementation 
Also, remove unneeded Q_OBJECT.

Change-Id: I6cefce78356011d97f281d4fcb023806d52d9452
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2023-08-16 16:00:55 +00:00
Jarek Kobus
b32333343b Valgrind: Make socket parentless when passed to Parser 
Otherwise, when the socket is a child of QTcpServer,
it may be deleted together with a server, while it's
still held in Parser instance.

Change-Id: I600e9cef1268ffc93e1e86d317e087df8b4d70cb
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 15:57:45 +00:00
Jarek Kobus
45246834cc ValgrindRunner: Rename finished() into done() 
Add bool success arg into done signal.

Change-Id: Id39a727860e0e705513917f69ecd38e455078b5a
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 15:57:37 +00:00
Jarek Kobus
3ca0a9d23c ValgrindRunner: Add valgrindCommand() helper 
Change-Id: I8c480911a13aa80b2d58e49c6b03da55b37090a6
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 15:57:31 +00:00
Jarek Kobus
62ed7f7c39 ValgrindRunner: Add setupValgrindProcess() helper 
Move all process related setup there.

Change-Id: I26943a844bef5411ee018cc2b1d390aa33b4c257
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 15:57:25 +00:00
hjk
e02de2ddde ProjectExplorer: More KitAspect related renamings 
Change-Id: I10ad7aacaaf7346f91cadec479f4bba8481b1502
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
 2023-08-16 15:09:32 +00:00
hjk
aa093c1e91 Axivion: Move query error handling closer to query code 
Change-Id: I6c57c0578b284f20e23312bf748c5efbe0ac3c3e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2023-08-16 13:26:55 +00:00
Christian Stenger
397cd1ba3d AutoTest: Fix using target information after kit change 
Fixes: QTCREATORBUG-29477
Change-Id: I5d1f8d65ed074d912740b87eac1c7d4413ed2588
Reviewed-by: David Schulz <david.schulz@qt.io>
 2023-08-16 13:26:24 +00:00
Jarek Kobus
19bc9e69c9 ValgrindRunner: Inline some slots 
Change-Id: I29b099694fd0cbbd29bbd34362f2d93074b125d1
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 13:11:03 +00:00
Jarek Kobus
89343f6574 ValgrindRunner: Store the input data outside of the process 
Apply it when process is started. This is a preparation
step before employing the task tree inside the ValgrindRunner.

Change-Id: I4cb64ef72b353af7ca97ae61fded23d9cea5e365
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 12:20:56 +00:00
Jarek Kobus
604cf67a0c ValgrindRunner: Get rid of valgrindExecuted() signal 
Use appendMessage() signal instead.

Change-Id: I2beb70d1c9f59e6b8b3b1ad03ec7707d67aa50cd
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 12:20:50 +00:00
Jarek Kobus
74c7ec35bc ValgrindRunner: Establish connections in private c'tor 
Change-Id: I3238c1dc09008484b270a0904688bc4a7b6e10cc
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 12:20:44 +00:00
Jarek Kobus
054394eec2 Valgrind: Add task adapter for Parser 
Change-Id: I164305299edf4ce3c665034c7c1f8d7ad2ee9b66
Reviewed-by: hjk <hjk@qt.io>
 2023-08-16 12:20:38 +00:00
hjk
6f2b237ecf ProjectExplorer: Change KitManager::sortKits() 
... to sortedKits(). Simplifies the caller side and saves one temporary
container.

Change-Id: Id87a1ba0779e6f09cd6575808c4d05c126900f0f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2023-08-16 10:58:41 +00:00
hjk
c40a802e70 ProjectExplorer: Postpone set up of kit save connection 
Does not require early access to ICore::instance(), and there's
no point in attempting to save kits before they werde set up.

Change-Id: I68953c6019e14e88655ddb46b30ebb9f1916ec46
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2023-08-16 10:50:02 +00:00
hjk
f21282cb2d ProjectExplorer: Simplify KitManagerPrivate access 
Change-Id: Ia4e97a93899c7cd90d97a4cfaa6098cd2b395cc8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2023-08-16 10:38:47 +00:00