Commit Graph

12 Commits

Author SHA1 Message Date
hjk
bac4667497 ProjectExplorer: Remove ExecutableAspect
It's unused, wrong, and unwanted.

Change-Id: I1ee5474338b4d7ea9455fa2c3b9671d6a83042c9
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-06-10 09:53:58 +00:00
hjk
cf1c8a06aa ProjectExplorer: Fix connection lifetime in WorkingDirectory aspect
Also add some sanity checks before accessing related pointers.

Change-Id: Ic9576ad3b28333210adc1187d4a0a26d52b0538e
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-27 09:58:43 +00:00
Nikolai Kosjar
04a03106ce ProjectExplorer: Compile fix
Change-Id: Ia820f95a54175b1bb15014fd828ac6e722c6e037
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-20 02:26:25 +00:00
hjk
85a6b37702 QtSupport: Use ArgumentsAspect in CustomExecutableRunConfiguration
Change-Id: I739d41d917cd72f7be093ceb5200b8c947d09f4a
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-19 13:51:39 +00:00
hjk
039a29d50d Qbs: Use TerminalAspect in QbsRunConfiguration
Change-Id: I6f1ddec10abda39149dd3743bdff1d0186d1de31
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-05-18 12:52:56 +00:00
hjk
75784cd266 QtSupport: Use TerminalAspect in CustomExecutableRunConfiguration
Change-Id: I4fddb145ed03b3bd28836cdd1d7b9f810a0ad111
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-18 11:20:51 +00:00
hjk
b03c3ef86d ProjectExplorer: Use covariant return types for aspect creation
... and cloning.  Most aspects already did, it does no harm, might
save a cast later, so follow suit.

Change-Id: Id6275806657b723d4352a4b772b220cb9a2d9a5f
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-18 07:31:32 +00:00
hjk
b45bfbf69c Add TerminalAspect convenience accessor
Unbreaks build after 90f19ce.

Change-Id: I0f1ddec10abda39149dd3743bdff1d0186d1de31
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-12 12:43:53 +00:00
hjk
98c0713a41 ProjectExplorer: Rename TerminalAspect::m_isForced -> m_userSet
Change-Id: I209abef3e6682b2d3725e0e58e0289cd5757c497
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-05-12 10:37:28 +00:00
Alexander Drozdov
2de9de7ef3 Fix loading project settings
Incorrect conversion from the Variant to the String is fixed.

Change-Id: I082cdbeee1568d0b6b567232b50419d76572a197
Task-number: QTCREATORBUG-14404
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-05-07 14:15:48 +00:00
hjk
7c8a43cac3 ProjectExplorer: Merge terminalaspect.* into runconfigurationaspects.*
Change-Id: I24c61feac5e25171f5878c4f87e760481eff7996
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-04-29 10:52:21 +00:00
hjk
652d50012f ProjectExplorer: Introduce more RunConfigurationAspects
- WorkingDirectory
- Arguments
- Executable

Change-Id: I6bc83b32d33ec3b27b04ec1b334f75ae3b9d13cb
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-04-29 09:41:42 +00:00