Commit Graph

58363 Commits

Author SHA1 Message Date
illiteratecoder
7236e340a9 Debugger: Fix std::{unordered_,}{map,set} dumper for libc++
Task-number: QTCREATORBUG-18536
Change-Id: I2842a525e99e4fcd9544a1f15bd42fd5c8c0c16e
(cherry picked from commit 7b39db9e8a)
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-06 14:15:14 +00:00
Ivan Donchevskii
6b5b5692e4 ClangFormat: Fix UTF-16 line and column for 0 offset
Change-Id: I348a32d623da1c2da7f3e7f18cad8c9c06dc7b06
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-06 13:57:46 +00:00
Ivan Donchevskii
70661a57f0 ClangFormat: Change plugin from "experimental" to "disabled by default"
Change-Id: I81a2c21c6d4aea6febd4ac68cc79045b803eba05
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-06 11:47:25 +00:00
Robert Loehning
6146ff4495 ClangTools: Remove misused plural
Change-Id: I1d88f2b94621988b671ce18a4bfb7d9741994e82
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-03-06 11:35:07 +00:00
Marco Bubke
70d4e46552 Clang: Rename ProjectParts in ProjectPartsManager
Change-Id: Ia60d78e34a296b0b379339ebc14efd0e81dc8989
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-06 11:27:27 +00:00
Marco Bubke
e7fd132d47 Clang: Disable warnings in CommandLineBuilder
Change-Id: I7597d57a0bb97facefb08c9c1bbe6e909c146080
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-06 11:24:45 +00:00
Marco Bubke
3e1faec230 Clang: Don't filter source with missing includes
We do now tag and save them. So we can reliably track them.

Task-number: QTCREATORBUG-22035
Change-Id: I49aaeeb76150b7e2d77b863eeb0aedefc9ab50f4
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-06 11:24:28 +00:00
Marco Bubke
1a63297d9b Clang: Improve dependency building
We want to use the cached values in the database because it is faster than
to parse the the files again.

Task-number: QTCREATORBUG-22035
Change-Id: I7ada7073887b1d89a06332fdb617701cb69ccd68
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-06 11:24:20 +00:00
Christian Kandeler
776d54e435 Remove DebuggerKitInformation::defaultValue()
The defaultValue() function was a half-baked version of the setup()
function and prevented that one from working properly.
It does not appear that anyone relies on defaultValue() having run; in
fact, this function should probably be removed from the KitInformation
interface entirely and its implementations be merged into setup().

Fixes: QTCREATORBUG-21994
Change-Id: I78525df8201ebd5e1883718ea7655297c9f58eb5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-03-06 11:01:48 +00:00
Robert Loehning
1b581308be Nim: Remove translated string which would not be shown anyway
Change-Id: Ic5773b19e6d020d8d778fc864b3adb9f8e75885a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-03-06 10:13:13 +00:00
Eike Ziller
177bebabea Fix qmake warning
"src/shared/syntax/syntax_shared.pri:6: exists(file) requires one
argument."

Change-Id: Ia4151228a05cc3777d38b52bf4811647c17f4f18
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-06 09:20:44 +00:00
Christian Kandeler
7cfc18276f ProjectExplorer: Fix Kit::setup()
This function traversed the kit aspects in the wrong order, presumably
based on outdated assumptions.

Change-Id: I1cbb9ed74b9ef165f410b88cac3f1ca9983d1647
Reviewed-by: hjk <hjk@qt.io>
2019-03-06 09:17:13 +00:00
Christian Stenger
3d1efce0a4 LanguageClient: Fix possible crash on shutdown
If a shutdown is in progress we need an immediately delete
of the client to avoid accessing an already deleted
TextMarkRegistry instance when deleteLater() is triggered
too late.

Change-Id: I274f40532cec0bfc026322a633441a1856cb848c
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-03-06 09:05:52 +00:00
David Schulz
762bcc5c39 Debugger: inform user about misconfigured debugger settings
Change-Id: I304ae5147e04a89cd93800f8c44e82bd507f2d20
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-06 08:49:13 +00:00
David Schulz
b0eec87e39 TextEditor: add tooltip to reset highlight definitions button
Task-number: QTCREATORBUG-22075
Change-Id: I6d1d55fd171d412cddb3cecb160fa6d267421a8a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-06 08:47:59 +00:00
David Schulz
1c0f83cd90 Utils: fix memory leak in normalizePathName on windows
The PIDLIST_ABSOLUTE item returned by SHParseDisplayName has to be freed
again by ILFree according to the documentation of ITEMIDLIST structure.

Change-Id: I29eb7576600287cdc8380e81a83ce2af79e13e33
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2019-03-06 08:47:20 +00:00
Ivan Donchevskii
ad8cabdf45 ClangFormat: Do not remove empty lines while only indenting
Insert dummy text into empty lines also for the electic characters
not to remove empty lines when only indentation is intended.

Fixes: QTCREATORBUG-22050
Change-Id: Ife5374459feb510a0587880a6772c90a2d68d70e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-06 08:44:22 +00:00
Ivan Donchevskii
dc9c9249fc ClangFormat: Try to use existing file to override settings
If there is a .clang-format file in the project use it as
a base for the custom file that creator uses to override
the project settings.

Change-Id: I0786dbdd6077b87d4dd428981e24d503668f1031
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-06 08:44:05 +00:00
Ivan Donchevskii
5bb8e67846 ClangFormat: Do not save settings if they are not overridden
Apply only settings from checkboxes in that case.

Change-Id: Ic6740ab9d769730bba4d04dcdde7ad1e2a464614
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-06 08:43:28 +00:00
Christian Stenger
31e549a7dc Debugger: Improve lldb breakpoint handling
Inform QC about changed breakpoints on the LLDB side.

Fixes: QTCREATORBUG-21997
Change-Id: Icec25725f92d8a0b47f7dab2971c0c5eb5b23757
Reviewed-by: hjk <hjk@qt.io>
2019-03-06 05:43:12 +00:00
hjk
4a3d6f4694 Debugger: Filter out lldb-mi entries from autodetected debuggers
lldb-mi is not mimicing a full GDB, and it a safe assumption that
there's a working LLDB nearby.

Change-Id: I2711a7a72fad4c44e430166ede186be148a6fc7c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
v4.9.0-beta2
2019-03-05 17:25:07 +00:00
Leena Miettinen
cde7ae47aa Timeline Editor: Fix UI text
Change-Id: I705605b1bfc799fad8805a87925165bef0aec3a7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-03-05 16:13:33 +00:00
Ivan Donchevskii
bf972bcb01 ClangFormat: Change the logic how configuration is picked
Let's use by default the configuration that clang-format picks itself
for the source file. The Qt Creator configuration will now only
override the default one with global or project settings and can be
turned off with the checkbox.

This behavior is clearer than always picking some configuration
which Qt Creator prefers best.

Change-Id: If5ed3d67eb6b4b47a6d0fd5259f7efbb608914d1
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-03-05 14:48:59 +00:00
Ivan Donchevskii
2484a5e209 ClangFormat: Do not apply "smart" formatting before new lines
In the concept that behavior seemed fine but in practive it
looks quite strange.

Add comma to the dummy text inserted into the empty line to have
a proper indentation for the following empty lines.

Change-Id: I770af02a475e6489bdc8f44d9f84eb3c5e7398d7
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-05 13:06:30 +00:00
Christian Stenger
f670e80c88 TextEditor: Allow using KSyntaxHighlighting from system
Set KSYNTAXHIGHLIGHTING_LIB_DIR to the directory that
contains the KSyntaxHighlighting library file
(e.g. libKF5SyntaxHighlighting.{dll,dylib,so}).
This will use the respective files from there and its
related include files instead of the files provided by QC.

If deducing the include directory depending on the library
does not work you can additionally specify
KSYNTAXHIGHLIGHTING_INCLUDE_DIR as well.

Both variables can be set either as qmake variable or
environment variable.

Task-number: QTCREATORBUG-21980
Change-Id: Ie021489d930dfc46ad3e37f9fa02d09fa146ac87
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-05 12:29:26 +00:00
Orgad Shaneh
495f98b256 UnitTest: Add missing enum
Amends commit f009dad9ef.

Change-Id: I5288297525edc153c1aea81d2cabb1f230a8fcce
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-05 12:19:35 +00:00
Eike Ziller
6db2552868 Update 4.9 change log
Change-Id: I29e12da2c147fc5cacee80381dbb24ee6119e5b4
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-03-05 11:16:30 +00:00
Eike Ziller
71c6ad7f9e Help: Improve handling of results from index lookup
If help is only found by looking up in the index, show a selection
dialog to the user even if there is only one result. Otherwise we create
the impression that we really think that the help we find is the correct
one.

Also do not add the help text to the tool tip in this case.

Test case: struct Foo { static void objectCreated() {} };

Change-Id: I9579302843ea2923e06f56f4b646dd101f183b3f
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-03-05 10:33:51 +00:00
Robert Loehning
90bc1c91da Fix quotation marks
Change-Id: I26bd4b9e965a5313569b6e0ef6f606da57b31bff
Reviewed-by: Filip Bucek <fbucek@atlas.cz>
Reviewed-by: Rainer Keller <Rainer.Keller@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-05 09:40:54 +00:00
Robert Loehning
8b7e8abe1b Fix description of empty python project
Change-Id: I9ccf09afc0fa6348454a0a23cf86812e50ecaaa0
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-03-05 09:40:34 +00:00
Robert Loehning
118406346e Clang: Fix plurals
Change-Id: I150b9ccdec73ade8826b90036b59332687b84448
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-05 09:40:03 +00:00
Leena Miettinen
26f6cbf8b5 Perf profiler: Fix UI text
Change-Id: I3a2e7a67db1259f847f04ff523bd9a2b12863510
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-03-05 08:06:45 +00:00
Marco Bubke
0c177cd0d1 Add ICore::cacheResourcePath()
We need some directory where we save the index database and the precompiled
headers. This files should be persistent but the user can delete them
if he wants because we will rebuild them.

Task-number: QTCREATORBUG-22012
Change-Id: I9f25eb48a9992d6385a96427ef9c10bc739a3567
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-04 16:43:09 +00:00
Christian Kandeler
15777d11ef Revert "Preserve non-breaking space on saving text files"
The reverted patch resulted in corrupted text files that
had Unicode paragraph separators instead of newlines.
This reverts commit c6b6a6a077.

Change-Id: Ia2559937afefbe39213ac73551377220b8077cef
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-04 15:46:26 +00:00
Alessandro Portale
af318f9723 CppTools: Fit ClangDiagnosticConfigsWidget on manager's laptop screen
Managers have laptops with small screens. ClangDiagnosticConfigsWidget
had a widget with too big height as minimum size. The Clang Diagnostics
dialog did therefore not fit of Portale's screen.

This patch removes the minimumSize and makes the dialog fit.

Change-Id: I056c10c8a4e51ba4652c30616035a7c649287f58
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-03-04 14:48:50 +00:00
Marco Bubke
75f74791a1 Sqlite: Use exclusive lock for table initialization
We cannot change tables if other connections access the database.

Change-Id: I1915ab491952d9684cb9839957c84c8f7a15c308
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-04 13:40:53 +00:00
Marco Bubke
a7de90d0d5 Clang: Use system PCH if projectpart PCH does not exists
Then entry can be empty or null, so we test for both.

Task-number: QTCREATORBUG-21978
Change-Id: Ic824d897b3c38051a2304c9487ea5f2f7c9eeef8
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-04 13:40:45 +00:00
Marco Bubke
2358415b58 Clang: Move fetchPrecompiledHeader to PrecompiledHeaderStorage
It went for historical reasons in the symbol storage.

Change-Id: If05edb868901884f3951d0eb2f152566e99b4d1a
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-04 13:40:39 +00:00
Marco Bubke
211aef94e6 Clang: Share executeInLoop
Change-Id: Id02902e1e7abdb8b3430e7b228547c4372a424ce
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-04 13:40:32 +00:00
Leena Miettinen
3824fcbe28 Doc: Describe selecting base environment for running external tools
Change-Id: I3f63f23fae8730e8bcff063d52ac96e6592547a6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-04 13:07:12 +00:00
Christian Stenger
6aed8223a9 SyntaxHighlighter: Update to latest master
Adapt the respective include inside the TextEditor.

Change-Id: Ie3cb17f1b0e3c0639840bc135156edd354a0aeda
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-03-04 12:55:55 +00:00
Eike Ziller
c6b6a6a077 Preserve non-breaking space on saving text files
Use toRawText instead of toPlainText, see QTBUG-56538.

Fixes: QTCREATORBUG-22052
Change-Id: I01eaa57d2d1afed12e45ee88568667b161fd89fd
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-03-04 11:42:10 +00:00
Christian Stenger
10a04ce40d AutoTest: Fix updating of parent
Amends d886285ff0.

Fixes: QTCREATORBUG-22028
Change-Id: Ief97520a7db9bc90ed43a0b463008fc57ced0cea
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-03-04 11:36:28 +00:00
David Schulz
51e24f5ad4 TextEditor: Hide controls in scheme editor for builtin schemes
Show a label instead with a link that copies the current color scheme.

Fixes: QTCREATORBUG-21874
Change-Id: I74083bac8d7124341b4b63d8e172172235c5e184
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-03-04 10:16:19 +00:00
Leena Miettinen
473352940f QNX: Fix UI text
Change-Id: Idb059a21bd85bb55b0d0596e024472e6fa3cfd36
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: James McDonnell <jmcdonnell@blackberry.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-03-04 09:02:24 +00:00
Leena Miettinen
2a7a4f08a3 Clang: Fix UI text
Change-Id: I395aa4311aca8f880a9181e639dddebb306566fb
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-03-04 09:02:09 +00:00
Leena Miettinen
031a82cd71 Android: Fix UI text
Change-Id: I918ded69e64ec3f91d7deeda086d36c6b73fdf8d
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2019-03-04 09:01:50 +00:00
Leena Miettinen
1825a05f58 Bin editor: Fix UI text
Change-Id: Id32a861c832360f8e559947da5911ed91820c7d0
Reviewed-by: hjk <hjk@qt.io>
2019-03-04 09:01:34 +00:00
Leena Miettinen
d722edb772 SSH: Fix UI text
Change-Id: Iabd0a3278ac2f241b8880f41d0cfad729cdea1fd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-03-04 09:01:19 +00:00
Leena Miettinen
c0cd990ab8 Doc: Fix typo in Bare Metal instructions
Fixes: QTCREATORBUG-22062
Change-Id: Ie3b57768c946b59b95e6d1c8c245e1287d6b749f
Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
2019-03-04 09:01:00 +00:00