Commit Graph

7 Commits

Author SHA1 Message Date
Marcus Tillmanns
9d6597105b Terminal: Fix process staying alive
When starting a Terminal Process with TerminalMode::Detached,
the Process object was not deleted on app exit and therefor
created warnings on exit.

This patch changes it so that the osascript does not wait for the
process to exit and therefor exits pretty much immediately which
deletes the Process object.

Fixes: QTCREATORBUG-29375
Change-Id: I08e8b753c98011fdafc32f03886b5c0be7aec801
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-07 07:08:22 +00:00
Marcus Tillmanns
f23103467a Terminal: Remove unnecessary echo
Fixes: QTCREATORBUG-29354
Change-Id: Ie6ddd127fecef3f48e56ca17335b21afaab31365
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-07-05 08:28:17 +00:00
Marcus Tillmanns
43862f4cd4 Terminal: Fix setting environment for stub process
The TerminalInterface was setting the environment of the target process
for the stub, this is uneccessary.

The ExternalTerminalProcessImpl was not using the environment
of the stub process which will be important later.

The TerminalProcessImpl was not setting the right environment either.

Task-number: QTCREATORBUG-27519
Change-Id: I89238feedd755d1f1cbe2255b71711e0d5c149d0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-14 13:50:13 +00:00
Eike Ziller
33449bc880 Add full stops to various error messages
Change-Id: Ic4e07c5063a2e42af643faa4a5acb8445b12d6a1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-06-14 06:09:54 +00:00
Marcus Tillmanns
8e16822d73 Terminal: Close Terminal.app window automatically
Change-Id: I6756c55b644e0db55b6d0b7ca892a890805e7285
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-13 09:02:24 +00:00
Marcus Tillmanns
38c64e5419 Utils: Fix opening external Terminal
Change-Id: Id5c650f6f40f4ab8233360e20673dd9f0277c09d
Reviewed-by: hjk <hjk@qt.io>
2023-05-25 11:21:58 +00:00
Marcus Tillmanns
06365fa39f Terminal: External terminal if blocked by modal
Change-Id: I89ba438c7a9f4d593e849b9b7ca2daf202cca625
Reviewed-by: hjk <hjk@qt.io>
2023-05-25 09:24:36 +00:00