there is no logical difference between a hung or crashed process and one
that exited non-zero.
blocking execution already behaved that way.
Change-Id: Ifb80d050f9771cb9ea4021329ffef8e646e43ac9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
QProcess is fully buffered, so there is no point in trying to feed it
chunk-wise.
amends 25264d9b.
Change-Id: Ie1a32a6ac56f8e21a452b26dfaca4237d3f08d9f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
the conditions on the waitForFinished() calls were inverted. the visible
effect of this was that 'Hang' was never reported.
Change-Id: I9937fce58189eebf891000840597158b4bffd028
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
one instance had drifted away from its relevant location, while another
instance was a bogus c&p.
Change-Id: I0148f08ca2741efd82bf10a042fe341bafcfc087
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It shouldn't change the semantics, and it helps on some systems with
strange line endings.
Fixes: QTCREATORBUG-24556
Change-Id: I8158ddda458e5500bce6ce7b9ff4d5d981f88d7d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
And use QProcess::setChildProcessModifier when compiling against Qt6.
Task-number: QTCREATORBUG-24098
Change-Id: I4166a8e27f8f63dd661df119413cd2eb2ae1dc2e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This reverts commit 6a66ced594.
The patch that will introduce the alternative to setupChildProcess
(QProcess::setChildProcessModifier()) has not yet found its
way to qtbase and current Qt dev already identifies itself as
version 6.0.0, rendering the code here uncompilable.
Change-Id: I570b01598005070f0c17604226d245a3a381250e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This helps to debug e.g. runGcc(), which is used for detecting
predefined macros or header paths for the code model.
The log gives also a (limited) overview of the (blocking) processes that
are run on Qt Creator start up.
The produced command line is copy-pastable.
The generated output looks like this:
qtc.utils.synchronousprocess: Starting blocking: /usr/bin/x86_64-linux-gnu-gcc-8 -dumpmachine
qtc.utils.synchronousprocess: SynchronousProcessResponse: result=0 ex=0
17 bytes stdout, stderr=""
qtc.utils.synchronousprocess: Starting blocking: /usr/lib/icecc/bin/clang++ -x c++ -E -dM -
qtc.utils.synchronousprocess: SynchronousProcessResponse: result=1 ex=115
0 bytes stdout, stderr="ICECC[9867] 2019-07-03 13:00:35: couldn't find any clang++\nICECC[9867] 2019-07-03 13:00:35: could not find clang++ in PATH.\n"
"The command \"/usr/lib/icecc/bin/clang++\" terminated with exit code 115."
Change-Id: I9bc7b24121801b0c98c52416848734d850aa9f4d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and use it from within new SynchronousProcess functions
taking CommandLine arguments.
Change-Id: I5d7f83727cbb22f03b1a79b1645db95514c66033
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Mainly to get rid of the QProcess::finished deprecation warning.
Also adjust coding style in the surrounding connects when needed.
Change-Id: I12f9b248c7974b892c4a069356e578e80f8c59e9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Quoting of arguments on Windows behaves differently
depending on the used start() overload of QProcess.
Setting the program and arguments before calling start()
with only the QIODevice::OpenMode parameter allows to
preserve the wanted quoting.
Task-number: QTCREATORBUG-21547
Done-with: Oliver Wolff <oliver.wolff@qt.io>
Change-Id: I644ea0737d51d6114facb19a0ad70f10aeb79f2c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
On Android 64, there is no lib/ symlink anymore, so we need to upload
gdbserver from QtCreator.
Change-Id: Ib6f6d9b623dc61b72dd434ce1b3b409e880bdeaa
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Many issues, mostly in headers, were not addressed in
e38410b76c
modernize-use-auto
modernize-use-nullptr
modernize-use-override
modernize-use-using
modernize-use-default-member-init
modernize-use-equals-default
Change-Id: I320a51726db881e582b898948d53735ebb06887a
Reviewed-by: hjk <hjk@qt.io>
Make runBlocking handle the case where the process starts up too fast
for waitForStarted.
Change-Id: Id8f3522c7c23bc8d7cdbbc94da6fa6c0b8e45454
Reviewed-by: David Schulz <david.schulz@qt.io>
It is not an impossible condition that a process keeps hanging.
Change-Id: I87cfdb72ff8528c71b2add09e41bdf742cdfc8b6
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This overload of error is deprecated in 5.6.
Replace with errorOccurred, which was introduced in 5.6.
Change-Id: Iccfba7e7103b7ce377471696f1f2ec217e52c840
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Do not reserve QString before replacing it with another
* Do not append \n when there's only stdout
Change-Id: If75eade473949437a4b5fea2ac0153fa2853b3c8
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Do pass on the character that caused the line split in the signal from
SynchronousProcess. That way the UI can handle '\r' properly, leading
to a nicer git output.
Task-number: QTCREATORBUG-16611
Change-Id: I1d73ec9061689267dfffd776f32ab9c10108d10e
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Only convert the raw output later in a stdOut() and stdErr() method of
the SynchronousProcessResponse.
This is necessary since we have processes that use different encodings
for different sections of the file (I am looking at you, git).
Also remove the signals for raw data on stdout/stderr, leaving only the
signals returning buffered QString lines. This should be safe, even
with UTF-16 output.
Change-Id: Ida613fa86d1468cbd33bc6b3a1506a849c2d1c0a
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* result is initialized to StartFailed, so after executing, we should
always set the result, unless previously set to Hang.
If the process really fails to start, we return earlier.
* Setting m_maxHangTimerCount to INT_MAX is bad, since it is later
multiplied by 1000 (the original value is in seconds), but still
remains an int, so we get -1000...
Change-Id: Ie990105894fe223a93ece29df4574592a122f94b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
waitForFinish returns false if the process is no longer running at
the time of the call. Handle that throughout the codebase.
Change-Id: Ia7194095454e82efbd4eb88f2d55926bdd09e094
Reviewed-by: hjk <hjk@theqtcompany.com>
* Reorder members to avoid padding
* Use C++11 member initialization
Change-Id: Ib04c2d59dfcf54f5df7afddc6e21197f1095e829
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Makes much more sense than plain 0.
Fixes Git interactive rebase that should have no timeout.
Change-Id: I48b4d4dc35c8e5ed13e074d431d05d6795eb8797
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Qt 5.3 is the minimum requirement these days. Remove all fallback code
from sources and project files.
Change-Id: If6188a471197acadda4d6baee71804ba1a8026c6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This patch fixes ~1100 warnings from qdoc
Change-Id: Ia9555db675acbf8083b2f87d9855a62a3a34ccb9
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
