Commit Graph

859 Commits

Author SHA1 Message Date
Alessandro Portale
df1f975252 FakeVim: Modernize
modernize-use-auto
modernize-use-nullptr
modernize-use-override
modernize-use-using
modernize-use-equals-default

Change-Id: I320a08a99a1d18ab87aec207ec1e03190009b592
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-08 21:32:29 +00:00
Tobias Hunger
9fe5733ef3 FakeVim: Fix clang complaining about register storage type
Change-Id: I9bbc2835c3311f46fdb3df83d56a8ab1ddd41f5a
Reviewed-by: hjk <hjk@qt.io>
2018-10-05 13:06:33 +00:00
Alessandro Portale
ad474f5fcb Fix: member initializer for 'm_fooBar' is redundant
warning: member initializer for 'm_isValid' is redundant
[modernize-use-default-member-init]

Change-Id: Icd521e7d77054512bc0ed6b95cf08440320b0ce0
Reviewed-by: hjk <hjk@qt.io>
2018-07-12 08:19:00 +00:00
hjk
3290de7a4e FakeVim: Remove Utils dependencies from fakevimhandler.cpp
There have been requests to easily re-use FakeVim in other projects.
To make that easy, cut the few explicit ties to libUtils in
fakevimhandler.cpp.

Change-Id: I090d50fb1fd4e62d97e9430e94a84d1f267773a4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-04-12 06:50:31 +00:00
Orgad Shaneh
eea6a7c3b3 Utils: Purge qtcfallthrough.h
No longer needed.

Change-Id: I9b0bee014df89d4c567f1d2431b5ff9404f5f925
Reviewed-by: hjk <hjk@qt.io>
2018-04-09 09:04:13 +00:00
hjk
ae560fcc49 FakeVim: Implement :<range>sor[t][!]
None of the other options yet.

Change-Id: Iabf18c1be4d228c97d2de9cb17e71c307e9ec5a2
Task-number: QTCREATORBUG-20022
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-03-13 06:48:42 +00:00
hjk
3ea4b0156c FakeVim: Experiment with hand-written signals
Change-Id: If76c68d3abb42240a279c15cf4b3d4b9e04460bd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-03-02 09:07:33 +00:00
Friedemann Kleint
f482270432 Introduce Q_FALLTHROUGH()
Silence g++ 7.X warnings.

Change-Id: I9d06d04b496c9ec060e13e1be6f43d8fbadb1f3b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-01-24 14:50:43 +00:00
Robert Loehning
7a8d1aca1b FakeVim: Remove unused variable
Change-Id: Idc45215175702feb6521e872a566462b6e085a42
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@qt.io>
2017-10-23 13:47:43 +00:00
hjk
8037d5e02f FakeVim: Properly recognize tabp...tabprevious
Note that this does not fully solve the linked issue as the
triggered GOTOPREVINHISTORY action does not have the same
behavior as :tabprevious

Task-number: QTCREATORBUG-18843
Change-Id: I26a719f77d2c1727bb18da46e13f5a0be48473bc
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-09-11 09:03:54 +00:00
hjk
e829ca8e31 FakeVim: Fix gt/gT/:tabnext/:tabprevious
The mapping was there, but not connected to the core actions.

Change-Id: I9faa1c47afe409caaa0462740a6865d99d959b44
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@qt.io>
2017-07-07 15:31:18 +00:00
Tim Jenssen
2631ffabd5 Remove spaces in initializer lists
Format initializer lists code style like.

Change-Id: Ib82c235e4ba7dc75ee96a7abc0c47eff7b0a9013
Reviewed-by: hjk <hjk@qt.io>
2017-02-22 16:25:09 +00:00
hjk
ef80d060e7 FakeVim: Remove a few uses of QObject::sender()
Considered bad style...

Change-Id: Idc1d39bd55fa30dfa854bbc99094f5f6ec9afc4d
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@qt.io>
2017-01-24 11:10:12 +00:00
hjk
4721888fa7 FakeVim: Force leaving input mode when switching editors
Change-Id: I9c871cf7b0cba027b8a0ec201dd57f1039c9f4a5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2016-12-13 08:54:12 +00:00
Daniel Langner
920386220b FakeVim: make cursor navigation via arrow keys more like vim's
Change-Id: I2da45281e0f8d2e3a0460a8631241e09aa67b869
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@qt.io>
2016-10-04 08:56:50 +00:00
Daniel Langner
137a34b9ca FakeVim: don't ignore ESC while holding SHIFT
Change-Id: Iddd843353e582607d6acd0cddf0df6930f09f4b9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Lukas Holecek <hluk@email.cz>
2016-10-04 07:17:21 +00:00
Orgad Shaneh
b57ed862e9 FakeVim: Remove unused meta object
Change-Id: If20fe6c1a68470a5f0731f42d94af6123095a1d2
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-06-21 08:02:35 +00:00
hjk
90137a54c4 FakeVim: Parse <AltGr>
Change-Id: Ib8412b02b2cf7b82b34bbdbae10560b6f8dd34e2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Lukas Holecek <hluk@email.cz>
2016-06-10 09:52:20 +00:00
hjk
40a9463c56 FakeVim: Expand ~ in some file names
For :read and :source.

Task-number: QTCREATORBUG-11160
Change-Id: I636593a16f9e39c25585c221c5d978e842f4c1d4
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-06-03 11:16:36 +00:00
Lukas Holecek
a8a1b3b573 FakeVim: Ignore external changes in insert mode
Task-number: QTCREATORBUG-16208
Change-Id: Ic357b855f740e6c86900c13f616cd58a27175413
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-05-31 10:47:24 +00:00
Orgad Shaneh
28367148ec FakeVim: Use Qt5-style connects
Change-Id: I85bc7b6e951515768da8473cadcec02cd58d30d3
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-05-25 07:49:30 +00:00
hjk
d4f5cab923 FakeVim: Modernize
Take advantage of QT_RESTRICTED_CAST_TO_ASCII, auto, etc.

Change-Id: I4602fd6ef5f24b12cb9fe09ce39ad907e76fe259
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-04-21 11:49:49 +00:00
hjk
f25bd123eb FakeVim: Simplify FakeVimSettings object
Change-Id: Ic4f4d23af021ed779a500183ca4b145dd3bc3443
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-03-03 10:14:17 +00:00
Friedemann Kleint
97af238656 Preferably use QStringRef::toInt().
Avoid allocations for converting to int.

Change-Id: Id8c79334f4809ec075ffe7e6b7635be4873eafd8
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-02-04 07:56:58 +00:00
Tobias Hunger
397e7f4843 Update License according to agreement with Free Qt Foundation
* Update files in src/plugins

Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-19 15:57:01 +00:00
Lukas Holecek
ecf3eb1d9e FakeVim: Handle Ctrl+[ with Russian keyboard layout
Task-number: QTCREATORBUG-15261
Change-Id: I6b63fdce965347dc883c72223b482883beccbb80
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-16 14:54:43 +00:00
Lukas Holecek
a5b85651dd FakeVim: Add checks before handling keyboard input
Some inputs can be unrecognized with some keyboard layouts
(QKeyEvent::key() will return 0).

Change-Id: If7b49330ac00a2493a956331c7bbe8ea2a4305ae
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-16 14:54:30 +00:00
hjk
40edcd0813 FakeVim: (Un)escape special chars in replacements
Task-number: QTCREATORBUG-15512
Change-Id: Idd625a1ea400e4d2dcae314ddd1a77551c6bb787
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-16 11:41:25 +00:00
Jakub Golebiewski
0b5b7ef67a FakeVim: Fix caps lock in macros.
This fixes the bug that while recording a macrom, hitting caps lock
(scroll lock, num lock) inserts some key into the buffer (for caps '$')
so when you replay the macro you get incorrect output.

Other keys that are not in vimKeyNames may behave similarly but It is
important that macros support those three (especially caps lock).

Change-Id: I2854266f86a22e9d38fb1c6c5d923b11a56a5995
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-09-17 06:36:06 +00:00
Jarek Kobus
716f43f357 FakeVimPlugin: Introduce member initialization.
Change-Id: I0e09933ededd48133662a65da701c228e6c08419
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-06-18 12:19:21 +00:00
Lukas Holecek
a439335500 FakeVim: Disable visual navigation for text cursor
Change-Id: I04a05ae034dbe5e891df5e39275ce0430eabb649
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-05-20 07:58:27 +00:00
hjk
f9f9feb7ea FakeVim: Use more direct construction in vimKeyNames
Change-Id: Ic230eaa95e4e9a4ad614af50297d6028fefaae6b
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-05-12 07:58:14 +00:00
Lukas Holecek
1ef66857cb FakeVim: Allow to remap shortcuts
Allows to remap main window shortcuts with command for passing keys.

    noremap <C-S> ,<C-S>
    noremap ZZ ,<C-S>,<C-W>
    noremap f<C-O> ,<C-O>
    noremap f<C-F> ,<C-F>

Task-number: QTCREATORBUG-14413
Change-Id: Ib86637d55223b1f4ce31a88c1c7ae2e05cb2aff1
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-05-11 14:36:44 +00:00
Thorben Kroeger
e4db1211ff FakeVim: C-R {register, C-W} in command mode
Change-Id: I15dd0b88b2e908dde398df06bc03394a700839a7
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-04-14 11:12:39 +00:00
Thorben Kroeger
a30e66f257 FakeVim: implement C-r{register} in insert mode
In normal mode:
input: |aaa bbb
keys: yiw A C-r 0
result: aaa bbbaaa

Change-Id: Ifb2ac8603adf9c897d169f4ab282a3ee97896684
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-04-14 11:12:05 +00:00
Lukas Holecek
549e227e7b FakeVim: Fix tests when editor doesn't have focus
Change-Id: I3cb5f7db5114bc2189ceada7b0c05f67d781e607
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-03-25 10:58:51 +00:00
Thorben Kroeger
161c07f605 FakeVim: C-h in insert mode acts like backspace
In insert mode:
input:  xyz|
keys:   C-h
result: xy|

Change-Id: I6832787683485be3031b1d9ff55d459cb25b74b4
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-03-24 15:04:07 +00:00
Thorben Kroeger
0f8b5ef436 FakeVim: fix black hole register
This fixes the following:

In normal mode:
input:  |aaa bbb ccc
keys:   yiw w "_diw P
result: aaa aaa ccc

Change-Id: If66d80660c1bef5be1466883db30a87254065f00
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-03-23 07:38:00 +00:00
Thorben Kroeger
0023eafc4c FakeVim: fix yank register
The yank register "0 is only used when using y{motion} commands.
This fixes the following:

In normal mode:
input:  |aaa bbb ccc
keys:   yiw w diw "0P
result: aaa aaa ccc

Change-Id: I7fb8a62aed29b753ff8b129b5a8aa5f8e965026e
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-03-23 07:33:54 +00:00
Thorben Kroeger
4f4de63721 FakeVim: implement C-u in insert mode
In insert mode:
input:  "aaa bbb ccc|"
keys:   C-u
result: ""

Change-Id: I1813369c401aaee1a634c363ca5f4c252062613c
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-03-23 07:24:36 +00:00
Eike Ziller
9926fc2ab1 Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
Conflicts:
	src/libs/utils/tooltip/tipcontents.cpp
	src/libs/utils/tooltip/tipcontents.h
	src/plugins/android/androiddeployqtstep.cpp
	src/plugins/baremetal/baremetalconstants.h
	src/plugins/baremetal/baremetaldevice.cpp
	src/plugins/baremetal/baremetaldevice.h
	src/plugins/baremetal/baremetaldeviceconfigurationwidget.cpp
	src/plugins/baremetal/baremetaldeviceconfigurationwidget.h
	src/plugins/baremetal/baremetaldeviceconfigurationwizard.cpp
	src/plugins/baremetal/baremetaldeviceconfigurationwizardpages.cpp
	src/plugins/baremetal/baremetaldeviceconfigurationwizardpages.h
	src/plugins/baremetal/baremetalplugin.cpp
	src/plugins/baremetal/baremetalplugin.h
	src/plugins/baremetal/baremetalruncontrolfactory.cpp
	src/plugins/baremetal/baremetalruncontrolfactory.h
	src/plugins/cppeditor/cppcodemodelinspectordialog.cpp
	src/plugins/cppeditor/cppdoxygen_test.cpp
	src/plugins/cppeditor/cppdoxygen_test.h
	src/plugins/debugger/breakpointmarker.cpp
	src/plugins/debugger/debuggeritemmodel.cpp
	src/plugins/debugger/debuggeritemmodel.h
	src/plugins/debugger/loadcoredialog.cpp
	src/plugins/genericprojectmanager/cppmodelmanagerhelper.cpp
	src/plugins/projectexplorer/addnewmodel.cpp
	src/plugins/projectexplorer/addnewmodel.h
	src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp
	src/plugins/qmlprofiler/abstracttimelinemodel.cpp
	src/plugins/qmlprofiler/abstracttimelinemodel.h
	src/plugins/qmlprofiler/notesmodel.cpp
	src/plugins/qmlprofiler/qml/CategoryLabel.qml
	src/plugins/qmlprofiler/qml/MainView.qml
	src/plugins/qmlprofiler/qml/Overview.js
	src/plugins/qmlprofiler/qml/Overview.qml
	src/plugins/qmlprofiler/qml/TimeDisplay.qml
	src/plugins/qmlprofiler/qml/TimeMarks.qml
	src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp
	src/plugins/qmlprofiler/sortedtimelinemodel.cpp
	src/plugins/qmlprofiler/sortedtimelinemodel.h
	src/plugins/qmlprofiler/timelinemodelaggregator.cpp
	src/plugins/qmlprofiler/timelinemodelaggregator.h
	src/plugins/qmlprofiler/timelinerenderer.cpp
	src/plugins/qmlprofiler/timelinerenderer.h
	src/plugins/qmlprojectmanager/QmlProjectManager.json.in
	src/plugins/texteditor/findinfiles.cpp
	src/plugins/vcsbase/vcsconfigurationpage.cpp
	src/shared/qbs
	src/shared/scriptwrapper/interface_wrap_helpers.h
	src/shared/scriptwrapper/wrap_helpers.h
	tests/auto/qmlprofiler/abstracttimelinemodel/tst_abstracttimelinemodel.cpp
	tests/system/suite_debugger/tst_debug_empty_main/test.py
	tests/system/suite_debugger/tst_qml_js_console/test.py
	tests/system/suite_debugger/tst_qml_locals/test.py

Change-Id: I67540b648f8b162496f4aa606b04d50c7c9125c6
2015-02-12 17:29:21 +01:00
Eike Ziller
3c85058694 Update License
Change-Id: I711d5fb475ef814a1dc9d2822740e827f3f67125
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
2015-01-16 12:37:56 +01:00
Robert Loehning
c2e23b6fe2 FakeVim: Compile fix
Change-Id: I630c6603bf46a28942c71e9e67cc9745ea8e4c36
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-01-05 16:54:27 +01:00
Lukas Holecek
1203ef5b2f FakeVim: Update inserted text data only in focused editor
If there are multiple instance of FakeVim handler for single buffer
(this happens when there are splits with the same document), buffer data
are modified only in the instance that handles the last focused editor.

Task-number: QTCREATORBUG-13481
Change-Id: Idfd2727917262bfffb410396a911519e85dfd463
Reviewed-by: hjk <hjk121@nokiamail.com>
2015-01-05 09:19:55 +01:00
Tim Jenssen
ff658ccc99 fix spelling commmand -> command
Change-Id: I293a3d2be055634c3fd798c4f344a6d77d50206c
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2014-12-19 13:54:21 +01:00
Lukas Holecek
7e8db09c50 FakeVim: Set correct cursor shape if submitted search failed
Change-Id: I508ca523c70846924dc9b869ef105d273892e0bb
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-12-08 11:39:20 +01:00
Lukas Holecek
577fcd97d4 FakeVim: Select and modify paragraph object
Change-Id: Ib528fa2914bfcb17caed114d7da2d201079b0725
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-11-25 10:32:12 +01:00
Lukas Holecek
e8aecca215 FakeVim: Fix invalid cursor position warnings
Change-Id: If09f2cfeb58e9810ec3858c0a20d2f5e0a7fac14
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-11-25 10:31:58 +01:00
Lukas Holecek
07e3a032ff FakeVim: Uppercase register appends to lowercase
Change-Id: Ida1e796637ad37cbb3c2f403151d01af1f3b2ade
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-11-21 09:51:43 +01:00
Lukas Holecek
40fc14c191 FakeVim: Stop waiting for incomplete mapping after interval
Recent change (QTimer for waiting on input) broke this behavior.

If using ":inoremap jj <ESC>" pressing only "j" in input mode should
timeout and insert the letter.

Change-Id: Ic5a1961143e1847ef02d5063c5da9eeb63714893
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-11-21 09:51:35 +01:00