Commit Graph

30 Commits

Author SHA1 Message Date
Aurindam Jana
d4bb573585 Inspector: Refactor data insertions
Change-Id: I188c41a5335ff626cce519a0622e2201197df0fa
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
2012-10-11 17:04:20 +02:00
Aurindam Jana
388a21c826 QmlDebugger: Insert locals correctly
The watchhandler needs to be reset for locals before
inserting the values of a new frame. Also the DebuggerTooltipManager
needs to be notified. The values of the locals in the
LocalsAndExpressions window should be editable.

Task-number: QTCREATORBUG-7992
Change-Id: I556e23b408db09b510f1f2bc350ff55187ec87c2
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
2012-10-10 16:55:07 +02:00
hjk
386ca7c8dd Adjust license headers
Change-Id: Ice592c6de9951ee3b2c4cb52ed0bb3b6770e0825
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2012-10-05 17:12:56 +02:00
Aurindam Jana
9b68e81fea Inspector: Select only known objects for 4.x
Change-Id: If052b4a018d5d0c20086a0251d7d1b206e7d4192
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
2012-10-05 15:11:26 +02:00
Aurindam Jana
59f8c87659 QmlInspector: Fetch data when needed
Fetch data on demand for 4.x. Since, parentIds are not
known, the tree will be reset when new objects are created.
Related changes in Qt side:
https://codereview.qt-project.org/#change,35982

Task-number: QTCREATORBUG-7779
Change-Id: I8b53604979bbbc2e6f01bc7b785929811a76f398
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
2012-10-01 17:43:58 +02:00
Aurindam Jana
bb00f59d66 Debugger: Client for DeclarativeDebugger
A client for DeclarativeDebugger Service. The service is
a backport of QmlDebugger service.

Change-Id: I868a286756c2d6bcbb2f41904a13d7f691e9704c
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
2012-10-01 12:49:59 +02:00
Leena Miettinen
28c0929f9e UI text: fix capitalization and punctuation
Change-Id: I7a974072096689aaa4b1ec1cca93dcd9febe14d9
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
2012-10-01 12:00:54 +02:00
Friedemann Kleint
5b69bee198 Use QT_NO_CAST_FROM_ASCII for debugger plugin.
Fix gdmi escape routine by using a traits class to adapt
QByteArray/QString.

Change-Id: Ic6d2a0c927e4613aec9f69095bbb04a393e9edb9
Reviewed-by: hjk <qthjk@ovi.com>
2012-08-24 09:46:25 +02:00
Friedemann Kleint
2f51579fe4 Debugger: Fix string usages.
- Compile with QT_NO_CAST_FROM_ASCII.
- Remove single character string constants.

Change-Id: Icece98619b6c30e047d3fce00e6ae74bbcd53c67
Reviewed-by: hjk <qthjk@ovi.com>
2012-08-22 12:24:24 +02:00
Eike Ziller
e0e8cf3ada Contact -> qt-project.org
Change-Id: I7134d7de30bcf9f9dcfad42520dd45ee083a852d
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
2012-07-19 13:23:21 +02:00
Simjees Abraham
fdabb6d6f9 Debugger: resetting of newObjectsCreated done only for Qt5.x
done to correct the regression introduced in
2574a58469

Change-Id: I0d9fb8fabcd134f53f1a1c9d0fa04ca7b542a88c
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-06-11 09:58:10 +02:00
Simjees Abraham
953334967c Debugger: Adding objects to be watched corrected
Adding the objects to be watched corrected in case new objects
were created.

Task-number: QTCREATORBUG-7529
Change-Id: Ica5f852f47882242a0e97692c97c0ca4ee662a4e
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-06-11 09:57:54 +02:00
Simjees Abraham
2574a58469 Debugger:Clearing the object tree corrected.
newObjectsCreated reset while clearing the object tree.

Task-number: QTCREATORBUG-7519
Change-Id: Ie5ee9bfd0faafb60f968a0c219b372eea6679761
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-06-06 15:02:39 +02:00
Simjees Abraham
d40f41cd77 Debugger: Fetch object done only if parent Iname is known.
When an object is created, the properties are fetched and added
to the object tree only if the parent Iname is known.

Change-Id: Id49a1873e9ffaf33689fe11297341cf56472c1be
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-06-05 16:44:13 +02:00
Simjees Abraham
80180ba714 Debugger: Prompt for reload if set/reset binding fails.
QtCreator takes into account the result of message from
qtdeclarative for setting, resetting and updating the method
body.

Task-number: QTCREATORBUG-3264
Change-Id: I15d1a33990175e86bb3f2fee08f75dd5b7b1b628
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
2012-06-05 12:07:06 +02:00
Simjees Abraham
73e07c9f2f Debugger:Correctly added the object to be watched.
Correction done for the bug introduced with
commit fc1f265e87.

Task-number: QTCREATORBUG-7498
Change-Id: I322a564208d70c7778a208fe0d9360ce47b75b81
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-06-05 11:30:06 +02:00
Aurindam Jana
45540a30db QmlDebugging: Save few cycles
Change-Id: I6d094605e3983128b844f2156909b98a4016509f
Reviewed-by: hjk <qthjk@ovi.com>
2012-05-31 16:03:28 +02:00
Aurindam Jana
fc1f265e87 QmlJSInspector: Improve performance
Populating watchhandler can be expensive. Update
with just the necessary data.

Change-Id: I06c28e1c8f5437cc05d3f9cef139d3df9da10c81
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
2012-05-30 15:12:20 +02:00
Aurindam Jana
799fc18bd7 QmlJSInspector: Remove dependency on QmlJSTools
As Location information is already cached, there is no
need to fetch the information from the QmlJS Semantic info.

Task-number: QTCREATORBUG-7409
Change-Id: I9cc3dce0910632cfe517f7697d74691e6675793b
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
2012-05-29 16:54:12 +02:00
Simjees Abraham
bd5fe5243b Debugger: Change in response for message "destroyObject".
Response for "destroyObject" now has the debugId of the
destroyed object. This is used to fetch the parent object rather
than querying the engine context.

Change-Id: I2e5b7650cbe847117cce6952206dd479ee696f0e
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-05-29 11:20:48 +02:00
Aurindam Jana
a79e38ac6f QmlJSInspector: Set property values
QML property values could be set in the inspector.
Regression introduced by 7f09d0b756.
This patch is a partial fix. Only values can be assigned currently.
For expressions, use the console.

Change-Id: I945b11109cd7788dd0f5277af206bf9658844aee
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Reviewed-by: hjk <qthjk@ovi.com>
2012-05-25 11:20:49 +02:00
Aurindam Jana
023deff474 QmlJSInspectorAgent: Refactor code
Try to use the watchHandler for referring to the object tree
instead of caching the object tree locally.

Change-Id: I68624771ef49d50f2cf0d6d580b1b34d57483178
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
2012-05-25 11:20:36 +02:00
hjk
e11a3a7697 debugger: rework WatchModel
It's one model for all locals, watch, return, tooltip and inspector
data. This allows more streamlined code paths and better isolation
of the model data from the WatchHandler. WatchItems are now registered
in a hash indexed by iname, so inames can be used as the primary
handle to watch data in the WatchHandler interface.

Change-Id: Idac0a808b5d785307496d1de4198a1f2e9ce3880
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-05-24 14:33:34 +02:00
Aurindam Jana
b9d9bb7ba8 QmlJSInspector: New Objects created
Send the engineid, objectid and parentid.

Change-Id: I7b340c1f20ba3eb3f1690d45b28819f6efaae013
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
2012-05-22 10:43:41 +02:00
Kai Koehne
383b9e00ad Debugger: Add profiling output for objectTreeFetched()
Change-Id: I9407b7617c6e74ab71a72360a72b5f6d1e334ee7
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
2012-05-16 12:35:16 +02:00
Kai Koehne
13d36b2af3 QmlInspector: Don't show root element twice (4.x)
Change-Id: I1871f4c0d4ccb7339f4cea64e6119e0a74459630
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-05-14 09:33:58 +02:00
Aurindam Jana
b9bc68c370 QmlInspector: Fetch objects for location
Since the object tree is fetched lazily, we might have
objects whose debugIds are not known. In such cases,
objects can be fetched by passing the location info.

Change-Id: I2001460cc14401e011efef9be9194c9f7868d617
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
2012-05-13 18:24:27 +02:00
Kai Koehne
94300bf7a5 QmlInspector: Make sure children list is always displayed on expansion
Change-Id: I2c55e5a4c95088c1a1944916678483792ffaba95
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-05-11 15:32:47 +02:00
Kai Koehne
b2a2a7cc18 QmlDebug: Renaming
Move Status enum out of QmlDebugClient and drop "QmlDebug"
prefix for the different 'Reference' structs. Allows to
avoid 'using namespace in QmlDebug' in header files.

Change-Id: Id9857977300e86d637cf128ff3417d8b24c8e995
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-05-10 10:33:45 +02:00
Kai Koehne
7f09d0b756 Merge QML inspector into debugger plugin
Merge QmlJSInspector plugin into the debugger. Also merge the
extra Inspector window with the Locals & Watchers: It now shows
the QML object tree in the running state.

Change-Id: I59ae0c1b970a48ba10ecda92ed3ba765d94b1d9c
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
2012-05-09 12:42:44 +02:00