A QtcPlugin depends on ExtensionSystem, so there is no need to restate
the dependency.
Change-Id: I8e0cb5f94858e912f5ce528ee67b683d4d837c27
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Github and gitlab uses a different syntax when cloning with ssh:
git@github.com:qt-creator/qt-creator.git
Support this pattern for remote validatation also.
Change-Id: Ic67f2238b9cdd526e76715c86846542cdb73f503
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This changes export.py in a way that adding a scale factor becomes
easy.
Change-Id: Ib6649be931d36bf21df429fe5dd237b440913743
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... to the single user.
As effect, all but the ios re-implementation are not needed.
Change-Id: I3c8b8c5d4ab3c8eac70c0bd534c5f1b33f8a3063
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
With a 1:1 mapping of factory and created device types, the signatures
of the device factory methods are much simpler, and yield even in
the cases where a factory created more than one device type
(WinRt and Qdb) less code after duplication of the factory.
Change-Id: I1c6279a88e8483001e5603cfe1922029243be610
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Clang returns no result type when the virtual method
from the base class is called in the same method override
in the derived class.
This is not a problem for us because it's not a method definition
and therefore it does not require special handling.
Change-Id: I736989165c1f031dc1937c7935e26da8236d9e9e
Reviewed-by: hjk <hjk@qt.io>
pos was -1 for a value that should have been appended as
last element to the list. Unfortunately, list->insert
treats -1 as prepending in front of the list, which lead
to incorrectly sorted lists.
The function got broken during the review process of
the introducing commit 758544c058.
Change-Id: I693e4d79b0d493deeac0ea8781d637fe50d008b8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Refactor the code to use adb from AndroidManager, do cleanup
and improve logging
Change-Id: I77b682d37c9328e6aa978eaf05b3b5c131907f09
Reviewed-by: hjk <hjk@qt.io>
Instead of e.g. 'Interrupt "GDB for "test""' use 'Interrupt GDB for "test"'
for button tooltips.
Change-Id: Ibe08e0007800332696dbc7f298bf5119ea8e5338
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Registers had been not visible before 4.8 except the user
explicitly enables it.
Change-Id: Ie515a59b40a7f3cd3b9e62eca2707d8a76ab4ab1
Reviewed-by: hjk <hjk@qt.io>
... even if the action is disabled.
Change-Id: I7f5bb0abd73d25650fab4c9dafbe70c772d2cb0e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Apparently there is a different message box that commonly pops up while
we are waiting for the attach dialog. Just close it and try again. Also,
stop the timer once we have seen the dialog. Otherwise we might fail on
extra message boxes that pop up afterwards.
Change-Id: I06ae16eb3ad89c9a022ac6fae781f8465425d96f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
On Android 64, there is no lib/ symlink anymore, so we need to upload
gdbserver from QtCreator.
Change-Id: Ib6f6d9b623dc61b72dd434ce1b3b409e880bdeaa
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Basically upstreamed/pimpled from VxWorks::BaseNumberValueAspect
Change-Id: I1dbedbbdd55b684fe1bb823e57d4830fb2eb0b0e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The test frequently fails for unknown reasons. Check if we actually see
the attach dialog, or if some other dialog interfers.
Change-Id: Id279b8aa0a822dbdb565fe4105bfcb28ad704e3c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Make sure url has a proper size before accessing
its elements
* Also check for valid drive letter before ':'
Change-Id: I958cbd492caa8a6ad4a5bf424277d8287f8cf0d4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If the function is added to a class inside a class, these must be
prepended before the inner class name.
Fixes: QTCREATORBUG-7271
Change-Id: I07042cdd4927af3b630c6ab1b5587971754e1199
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Otherwise this is too annoying in case the function is called the way it
should be.
Fixes: QTCREATORBUG-8114
Change-Id: I51063a11e7979e24fc9020344aa5ff800b5064a9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
...by using Utils::ElidingLabel rather than a plain QLabel in
QbsKitInformation.
Change-Id: I4014ee918f0ea712a2975ffb4638c495fd8e0c71
Fixes: QTCREATORBUG-21102
Reviewed-by: hjk <hjk@qt.io>
With this change ClangCodeModel only needs to sort completions by prefix.
Also some other optimization have become possible and are implemented here:
1. Getting completions after '{' for constructor overloads by replacing
it with '(' inside usaved file.
2. Checking for all overloads requires only previous item check because
all Class completions are already sorted to go before all CXXConstructor
completions. Since they are not mixed no extra search is required.
Change-Id: Ie0187ad96a20857a63c1d71ddec74606b803f572
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Move the completion information to the tooltip and
show fix-it icon on the right of such item.
Change-Id: I7eff410384104387e547695171e4864760c07fb9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Using aspects is the standard pattern nowadays, there's nothing 'extra'
to them anymore.
Change-Id: I446f9d7b1db58a4899e5e44df33ce51f655e7be4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Retrieving the list is cheap, there's no reason to store it and pass
it through all these functions.
Change-Id: I394b512c113af92f60cfb8c2f6561d1617d9cd36
Reviewed-by: hjk <hjk@qt.io>
There are no external users left, so there's no need to expose
it in the header anymore. Also saves a cast.
Change-Id: I1ced368ebc9588cbc0058cc7d37f39ab80f9c595
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* QFile ctor does not open the file for read.
* Replace readLine with read(8) to avoid needless read.
This amends commit e9eeaf33b3.
Change-Id: I33c230497ad431091d7d6b271846f5af661b4e0d
Reviewed-by: André Hartmann <aha_1980@gmx.de>
