Commit Graph

61529 Commits

Author SHA1 Message Date
Eike Ziller
ed9177f74c CppTools: Move ProjectUpdateInfo to ProjectExplorer
Used for updating project parts, so move it near RawProjectPart.

Change-Id: I77aeffbdbfb3d2ec0de600f61dcf7fbb7a355a98
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-12 06:37:41 +00:00
David Schulz
a21df46481 Utils: do not use QIODevice::Text open mode when saving text documents
The mode replaces "\n" with "\r\n" in the byte array after encoding the
text, resulting in file contents that cannot be decoded.

Change-Id: I8010df56f28a479d516b8bcb887749905fd162ce
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-12 04:35:38 +00:00
Andre Hartmann
295fb99cc6 SerialTerminal: Some style fixes
Change-Id: I7415b613493540b250e1e5fba792a76c8e2d6b30
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-09-11 20:12:03 +00:00
Andre Hartmann
8deb1f3b4f SerialTerminal: Fix sign conversion warning
Change-Id: I503f9e9d556aa58807b552d0696fcd311ec5cf79
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-09-11 20:10:24 +00:00
Alessandro Portale
38a7cc17b7 QMakeProjectManager: Remove unused QtModulesInfo
amends bd7f53cef8

Change-Id: I1b193230d2f05abe68e22d87b4b8b0193299af42
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-11 18:49:43 +00:00
Orgad Shaneh
2aca0c1b28 Fix MSVC warnings
* Missing `this` captures
* Implicit size_t -> int conversion
* Unused argument
* Suppress warnings in clang headers

Change-Id: I7083ce6ab22ee22ecc1258539e77c790acc78df1
Reviewed-by: hjk <hjk@qt.io>
2019-09-11 15:20:34 +00:00
Cristian Adam
de7e2990ee CMake build: Fix multi config builds
This fix allows building with MSBuild / Xcode.

Change-Id: Id892cbc8a6f8f678602d44115907bce6cba1c005
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-09-11 14:40:12 +00:00
hjk
ddf0dd8734 Utils: Add a FilePath::isDir() convenience function
Change-Id: I1df0ee1b136299ae6e4f2e5bd0bdc24bfeca33dd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-11 12:46:10 +00:00
David Schulz
bf6fd00163 LanguageClient: remove unsigned cast for HighlightingResult
Change-Id: Iefcc316a4a471e39f52cd8c7709a9feb967263aa
Reviewed-by: hjk <hjk@qt.io>
2019-09-11 12:01:22 +00:00
hjk
110f6dece9 QtSupport: Remove unused QtVersionManager functions
Change-Id: Ic6bc4c56ebedc71ff4c136fd201b8a236384c3fd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-11 09:55:44 +00:00
David Schulz
75a0340a53 cdbext: fix arg order in function declaration
Fixes: QTCREATORBUG-22921
Change-Id: I1fa94565e550a5ca1fa68fc032136fd42fa4972f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-11 09:06:00 +00:00
Nikolai Kosjar
217332a48f ClangTools: Prepare for more ClangToolRunners
Change-Id: I6bbdbff496c0604367896d279df1a197f8a041bd
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2019-09-11 08:47:07 +00:00
hjk
a4022c6156 ClangTools: Simplify a few signatures
A runWorker's project and target cannot change and are obtainable via
the runControl.

Change-Id: I9ce62e94a964dde9b29abf0d1f05eddcd4b87c14
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-11 08:32:33 +00:00
Eike Ziller
4f19baaf7c Help: Remove hack for litehtml issue with inline tables
https://github.com/litehtml/litehtml/issues/91 is fixed.

Change-Id: I2f44975246831ef9b4b30cbd79407a1639988cb8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2019-09-11 08:17:43 +00:00
Eike Ziller
6574aaccfd Help: Remove useless "Reload" context menu item
Change-Id: Id9334fed185d703902c0af5d4d949f1264abaa09
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-11 08:17:07 +00:00
Eike Ziller
25935d2da9 Help: Remove indirection when synchronizing current page
Task-number: QTCREATORBUG-20558
Change-Id: Ia76b6a11ed39f6b65d1c949fe57f8c3c4064c3ed
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-11 08:16:50 +00:00
Eike Ziller
b34102ceea Add option for shortcut visibility in context menus
Fixes: QTCREATORBUG-22502
Change-Id: I49587a6a8b575a3a1453104a829cd91ad3566d7e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-09-11 08:15:16 +00:00
David Schulz
f0a3779513 LanguageClient: reset all assist providers
Instead of just unsetting the function assist provider and quick fix
assist provider reset it to the previous provider.

Change-Id: I46c5c2f14234e3da08480dd103e4634859447d57
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-11 07:37:17 +00:00
hjk
cd6b37d905 ClangTools: Rename *RunControls to *RunWorkers
That's what they are.

Change-Id: Icc167e87678f5888090d737325ac0067e6b3ea92
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-11 07:01:51 +00:00
Eike Ziller
9cc45fe1fb CppTools: Move RawProjectPart to ProjectExplorer
Doesn't have any dependencies into CppTools anymore, therefore moving it
reduces the dependencies of the project managers to CppTools as well.

Change-Id: Ibe728abe59eb88a8877943dca1f48a85163e27ac
Reviewed-by: hjk <hjk@qt.io>
2019-09-11 06:22:12 +00:00
Eike Ziller
f52c4f450d Help: Move viewer backend management from plugin to local help manager
which poses as a settings class.

Change-Id: Icb01f0d4750c2d197875954a648ae7358c4c217a
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-11 06:12:56 +00:00
Cristian Adam
24da5b14d4 CMake Build: Fix include directory for external yaml-cpp
On Linux one gets:
/usr/lib/x86_64-linux-gnu/cmake/yaml-cpp/../../../../include
which fails to compile.

Resolve the path so CMake can detect/remove the duplicate to fix this.

Change-Id: I4987c8edd99e60d31beb2d5075a949090996bc3a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-11 06:11:21 +00:00
hjk
e9d8ff21b0 Remove unused QObject parent arguments on options pages
In the new plugin setup scheme they are data members of the
plugin pimpl and never use the parent.

Change-Id: I28fe150393e8159064dcfbd113ce0320af50fd58
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-11 06:03:40 +00:00
David Schulz
a8fa9c5f89 LanguageClient: Fix wrong notification after will save signal
Change-Id: I9470dc7ea9058f43fcf61d4721c3aee1348a7d6e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-11 04:45:44 +00:00
Alessandro Portale
be7c215dd7 CMake build system: Depend designerintegrationv2 on Qt5::Designer
In case your Qt has not been built with the Widget Designer, don't let
the build fail, but skip the Qt Creator plugin, instead.

Done-by cristian.adam@qt.io

Change-Id: Ie00ff2b6885cef81ed0c2600762a6631302d8951
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2019-09-10 15:41:24 +00:00
Cristian Adam
486aaabd21 CMake Build: Use same Qt compiler defines for tests
Source code needed adjustments though.

Change-Id: I78b4610a6bb895a385c7c30a6c92c97a276b89dd
Reviewed-by: hjk <hjk@qt.io>
2019-09-10 15:05:59 +00:00
Eike Ziller
62d16e437a Help: Add context menu to litehtml backend
Change-Id: I051984e360b41d17d32cff80fd1d4017fc81dae6
Reviewed-by: hjk <hjk@qt.io>
2019-09-10 12:56:51 +00:00
Cristian Adam
3bb0ad62e2 CMake Build: Fix finding link library for DesignerComponents
On Windows the find_library call was finding the .dll file, and not
the .lib or .dll.a link library.

Change-Id: Ic20845f9ef4c77e0ae8c3ca3476a12fc1b45ef36
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-10 12:21:57 +00:00
Eike Ziller
52729892d3 Help/litehtml: Support under-/overline and strikethrough
Change-Id: If8bd9480475e78cd2b0382d1dbb8e5b56d69ae10
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2019-09-10 12:06:05 +00:00
Cristian Adam
423b5ad5c8 Utils: Remove build warning
Inline functions emit warnings when they have an export declaration.

Change-Id: Ia722429c04abc769cdf078b86eaaec439a0690e5
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-10 09:49:06 +00:00
Nikolai Kosjar
038a03e95f README: State ClangFormat dependencies
Amends 4d3bb1c858.

Change-Id: I72319c39144a161e5957953de5f395f33a080e63
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-10 09:25:16 +00:00
Andre Hartmann
d1b997474d CppLocatorFilter: Add highlighting auto-tests
Change-Id: Ibd5b8318040876b46bfb14561c69019abd8dd8b7
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-10 09:09:05 +00:00
Eike Ziller
b9a0c3ce99 ClangTools/cmake build: Fix build against external yaml-cpp
For some reason that doesn't set INTERFACE include directories,
so do it manually.

Change-Id: I3451252ff8c0651dc1dd13c8ffa7c0e3c952e732
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-10 08:07:05 +00:00
Andre Hartmann
92daed1f6c CppLocatorFilter: Fix highlighting in extra info column
Given the following example:

  typedef int value;
  void value_test(void) {}
  void test(value v) {}

searching for "value" findes both candidates; and
for the locator filters "m" and "." highlighting
already worked fine.

For the locator filter ":", however, the arguments
are displayed in the extraInfo column. To get proper
highlighting here, we have to repeat the regexp match
in this column.

While fixing that, make sure that full-qualified
searches (separated by "::") are still highlighted
properly.

For the Clang Code Model, there is still a bug not
addressed by this patch:

 Ctrl+K with ". value" -> "value" isn't highlighted yellow.

Change-Id: Idd5eeeedb893151cd5c7f70f6b11397db788b706
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-10 08:05:18 +00:00
Eike Ziller
8452264a18 CppTools: Move QtVersion and BuildTargetType
QtVersion to utils/cpplanguage_details.h which already contains similar
flags.

BuildTargetType to ProjectExplorer, next to BuildTargetInfo (but not in the
same header to not pull that in everywhere).

Removes dependency on ProjectPart from RawProjectPart.

Change-Id: I5791065e4266f20c2657ee4b1b594df04b238a1c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-10 07:31:21 +00:00
Eike Ziller
845fd8d533 Fix "Preserve case" in advanced find
Fixes: QTCREATORBUG-19696
Change-Id: Ife0bf9f68ff24f46e0ba1e5cc4a2db358f2a1a61
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2019-09-10 07:27:41 +00:00
Christian Stenger
a0352f24d0 LanguageClient: Fix compile
Change-Id: I3d105513c2807f4e7aebc705e6628c62acaba192
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-10 04:58:28 +00:00
Eike Ziller
6476c62065 macOS: Work around window stacking order issue after closing dialog
Fixes: QTCREATORBUG-22906
Change-Id: Id3c9f5e87ac83686b34c7f6d2e445312fc401ba6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-09 13:44:29 +00:00
David Schulz
332031d677 LanguageClient: open a document in just one client
Also show a menu when triggering the language client toolbar button that
allows you to manage and switch between different language clients. The
default language server used to open a specific file type is determined
by the order of the servers inside the settings.

Change-Id: Ib1b21dd2c04d4559f538705e6ba229af043e02ae
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-09 13:29:33 +00:00
David Schulz
d72632acd6 Debugger: add dumper for std::initializer_list
Change-Id: I223182cecf1f04dbc9908dc993a8800c1633c48b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-09 11:35:24 +00:00
Eike Ziller
e0e5621b80 Help: De-duplicate management of help viewer pages
For the help mode, the help viewer pages were managed both by the
OpenPagesModel and the HelpWidget, and needed manual keeping in sync.

Instead make the model just an aspect of the HelpWidget, manage
creation/deletion of pages via the HelpWidget, and use the model only
for the pure MVC API purposes.

Task-number: QTCREATORBUG-20558
Change-Id: Ib7d6f2561239b0d5f3328dfd30c84718f81af0a1
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-09 11:32:24 +00:00
Eike Ziller
f1e3484cd7 Bump version
Change-Id: Id326cb47ae86be52016850455eeac20a6fcfc4a0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-09 08:57:03 +00:00
Richard Weickelt
83e8b03549 Update qbs submodule
To HEAD of 1.14 branch. Makes Qbs work with Qt 5.13.1.

Change-Id: I1f6e5714f47faaa0521761bff2b1c1e411fff189
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2019-09-09 07:34:36 +00:00
Alexander Akulich
0e18503225 Doc: Small fix for 'Importing QML Modules / CMake' section
- Remove the unneeded curly braces around QML_IMPORT_PATH variable.
- Change the variable type format to upper-case to get rid CMake warning.

("CMake Warning: implicitly converting 'string' to 'STRING' type.")

Change-Id: I71827d3496093bc90fb5b45ab12b010108793818
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-09-09 07:27:45 +00:00
Christian Stenger
49942bc06a AutoTest: Re-order responsibilities
Keep the timer for syncing frameworks where it
is really used, do not create functions that are
not necessary at all.

Change-Id: Ie0a49a2611dc67510b72562455ea2a1af7b1c538
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-06 10:07:01 +00:00
Cristian Adam
ad0dcb9668 CMake build: Build fix for tst_debugger_simplifytypes
simplifytype.cpp is included also in tst_debugger_dumpers, which
has a GUI pch.

Because CMake has global internal file structures, simplifytype.cpp
will get the PCH flags from tst_debugger_dumpers, which will be
reused in tst_debugger_simplifytypes.

This patch makes sure the PCH from tst_debugger_dumpers has all
the dependencies in tst_debugger_simplifytypes

Change-Id: I715cb551f2f75a619b21999ea521976470068c3f
Reviewed-by: hjk <hjk@qt.io>
2019-09-06 09:25:59 +00:00
Eike Ziller
e9b38e2ef8 Help: Remove some unused API from OpenPagesManager
Change-Id: If93719b15a314534ca7a02e7dc370013ff6e3467
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-06 08:21:17 +00:00
Eike Ziller
142fa65ce1 Help: Do not use specific model where abstract model is enough
Change-Id: I1cbdd5d3ce1cf4735cff8bdfa71ea336a507c28a
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-06 08:21:05 +00:00
Thomas Hartmann
6e6ee2e9cb QmlDesigner: Use QmlObjectNode in QmlModelNodeProxy
Selected nodes in the property editor do not have to be items.

Change-Id: I0d4fff7f3069640ceb1c17f3d755abb340575667
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
qds/v1.3.0
2019-09-05 15:03:34 +00:00
Thomas Hartmann
9ca9a7e4a6 QmlDesigner: Add missing functionality to QtObjectPane
It should be also possible to change types for non items.

Change-Id: Ia44a8b4fda97c5fb25e513c6b3c3eed15abb1c1d
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-09-05 15:03:17 +00:00