This patch fixes an issue were a temporary value wasn't properly
written to the backend, when another item was selected in the form
view.
* Add a dirty flag to track user modifications
* Utilize onEditingFinished and onTextEdited from internal TextInput
* Add full qualification to a few property and function usages
Change-Id: Ib595d32bbc7f4caf92fbef5829aead50958fd830
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This unifies the remaining paths of RunWorker creation to always
use RunWorkerFactories in the plugin pimpls.
There were, and are, still effectively three basic kinds of workers:
- "toplevel" tools corresponding to the run modes, that are often all
that's used for local runs and directly started via the fat buttons
or e.g. entries in the analyze menu, with factories already previously
located in the plugin pimpls
- core "tool helpers", providing tool specific functionality typically
used in conjunction with a remote device specific run mechanism,
set up via RunControl::registerWorkerCreator
- target/device specific runhelper like port gatherers contructed e.g.
via *Device::workerCreator(Core::Id id)
Worse, these categories are partially overlapping, so it was not
clear how a "clean" setup would look like, instead some ad-hoc cobbling
"to make it work" happened.
In some cases, the runMode id was used throughout the whole ensemble
of run workers for a given run, and which worker exactly was created
depended on which of the mechanism above was used in which order.
With the new central setup, the top-level runmodes remain, but the
second kind gets new ids, so the implicit dependencies on order
of setup mechanism are avoided.
This also helps in the cases where there was previously unclarity of where
and how to set up worker factories: It's always and only the plugin
pimpl now.
Change-Id: Icd9a08e2d53e19abe8b21fe546f469fae353a69f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
... on a kit update.
Our default build directory template references the kit name, so changes
to the name should update the default value.
Fixes: QTCREATORBUG-19453
Change-Id: Iffbdd95043be5137696e5af021d4735f494d47d7
Reviewed-by: hjk <hjk@qt.io>
- Suppress reflections
- Keep selection when updating the model
Change-Id: I0e165f0019c8c24802193f3a59902876d4cb5060
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The wrong button function was called.
This does not fully fix the linked problem for the default session,
because there is the additional issue of TaskView::loadSettings() not
getting called at all.
Task-number: QTCREATORBUG-19388
Change-Id: I64dcec9c6d07c8ac614c9a2ecd783e7eaa1a204c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
And the default selected when configuring a project, since it was the
first.
Broke with 5dbfd46bcf which merged
"availableBuilds" and "availableSetups".
Change-Id: Ibc8c241595f3fee6f35e08fa83e499550eff869b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
QTC_ASSERT that the filter passed to Project::files is valid before
calling it.
Change-Id: I17776fa4ab3e2aa21ac34db015fdbbb382439669
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... on kit update. We don't know why the kit was originally selected,
and keeping track of this information would add unreasonable book-
keeping effort. Plus, the user probably does not expect the selection to
change anyway.
Change-Id: I341e1727a3f1fdd481c3a1670f821aee0e6b9cdd
Reviewed-by: hjk <hjk@qt.io>
This is what the consuming code expects in most cases.
Change-Id: I135592039e28b994996186f627215ab1d2f8d6dc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Cleanup ColorLogic (imports and source)
* Shifting a value from Constants.js to Values.qml
* Add a property alias on AbstractButton to allow changing the font
family
Change-Id: I51542f69f8f2190030a97164167d71d277147391
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Add AbstractButton wrapper to HelperWidgets this enables tooltips
on Buttons again.
Change-Id: If82bfcf3097f9e09d5cc19e4363b2428ad0ca872
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Explicitly remove any by default enabled checks (e.g. static analyzer)
otherwise we get more diagnostics than expected.
Change-Id: I53e63a10001be8027e880dac01000bdca4a8f920
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Looks like the information has been based derived from
buildDirectory() != target()->project()->projectDirectory()
for a while.
Change-Id: Ieb64e72d8fd1d4a6a339b695422fff6355cd3969
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Add true/false label to CheckBoxes
* Move and add missing tooltip
* Remove redundancy by wrapping ExpandingSpacer from StudioControls
Change-Id: I6ec5d534ea9d71bda54a9f16359479d02d057511
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This reverts commit 501df95d57.
Accidently moved to the wrong branch.
Change-Id: I845103df2e6fb00a2bc27923caffde2622464eba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
NameValueValidator use const reference save tooltip content which
created by temp variable tr() return.
Change-Id: Ie76b14108e02d74f5c1ca686b349ce948ef88c14
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
It was very confusing that we had two different functions that acted on
kit updates independently.
Change-Id: I4801b284c51cab1527324ac9a9f244d9fe9900c3
Reviewed-by: hjk <hjk@qt.io>
And provide an accessor for the framework's priority which
will be needed later on.
Change-Id: I5a2480699d9467ee50e2cc44b9d4ff58f9e8da88
Reviewed-by: David Schulz <david.schulz@qt.io>
It is almost never what you want (it is totally outdated), but it is
found in /usr/bin anyhow.
People who want GCC can still register it of course, and people who used
it before will keep having it as manually registered.
Change-Id: If5722f6e9521bb74160da064bb4dee8db28efdb9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We show all source files in the project tree, including those which are
listed in scopes that evaluate to false in the current configuration.
This is intended, as we want users to be able to navigate to all files,
not just the ones that are part of the build for the current target.
However, it'd be nice for users to be able to tell which files are
"active" and which ones are not. Therefore, we now mark the non-active
ones as "disabled" in the project tree, just like the QbsProjectManager
does.
Task-number: QTCREATORBUG-22855
Change-Id: Icfb48d4f6a247de76fc109acb84b34f03866e754
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Introduce the addvalue operation for the SDK tool.
The addvalue operation can be used to add new values
to an existing list in a config file without parsing
the output and then manually adding the new list back.
Change-Id: Iad6a0fb6178bff631424467850d73adc152ddbcf
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
