Commit Graph

61529 Commits

Author SHA1 Message Date
Denis Shienkov
37a6e6b58a BareMetal: Fix detection of C++ language option for IAR
... which is used at dumping of predefined macros
and a header paths.

Reason is that for the different architectures the IAR
use different C++ language options:

* for ARM: --c++
* for AVR or 8051: --ec++

Change-Id: I00ceadaf87348ee2250b9455ca04eed4bcb703a7
Reviewed-by: hjk <hjk@qt.io>
2019-07-24 13:25:24 +00:00
Robert Loehning
c1a83b2a88 Squish: Update lib creation
Fixes tst_APTW03

Change-Id: Ifa1bcf5334773b68b8b0027ca03a016d5ba92cb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-24 11:58:32 +00:00
Christian Stenger
b3d9647582 PE: Do not let user enable a kit that has errors
If a kit has errors it still could get enabled by using
its context menu on the Project view.
Avoid this and its side effects.

Change-Id: I2434cd3c540c1f3c287b84258391450693df986a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-24 11:57:07 +00:00
Christian Stenger
b0bee4b947 Fix compile on macOS
Amends 44acfc0702.

Change-Id: I1abfb757c88f60ed22a2c94f55dd0e418d2fb6a0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-24 11:56:50 +00:00
Nikolai Kosjar
0e49fc2d16 Clang: Remove unused function
Amends 9ded17fce086339aabe942585187c4157532fa89.

Change-Id: I96bc82c08d1e608cc743ee581111a4b3b71395a2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-24 10:03:49 +00:00
Christian Stenger
39aa325245 Fix compile after FileName drop
Amends 44acfc0702.

Change-Id: I1bddb0642e181b0a02d4ecba7ff1ae282218338f
Reviewed-by: hjk <hjk@qt.io>
2019-07-24 09:47:26 +00:00
Christian Stenger
e8e17f6c52 Unittest: Fix compile
Change-Id: I2ee07a67f042ac952d0301a0880f0674d21de714
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-07-24 09:42:32 +00:00
Nikolai Kosjar
1a4063ef8c Clang: Tests: Remove invalid tests
Also, some use cases are already covered in unittests.

Change-Id: I1b1351670509f1d004738a9c0dc8e858cfa6167b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-07-24 08:58:11 +00:00
Tobias Hunger
9519f125e9 CMake: Select better default target when a buildstep's target is no longer found
Select a better fallback target when a buildstep's target is no longer defined.

Change-Id: I7ef27361793125258cd2a73448d91d2561db5901
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-24 08:56:32 +00:00
Tobias Hunger
ce7407dc03 CMake: Update target list in build step list widget
Update the target list in the build step list widget for CMakeBuildSteps,
even when "current executable" meta-target is selected.

Change-Id: Ifc1d8dc67894202eb38fe6088552797b198c7463
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-24 08:56:24 +00:00
Tobias Hunger
8b9821440d CMake: Add helper method to find the default build target for a BuildStep
Add a helper method to find the default build target for a CMakeBuildStep
based on the BuildStepList the step is part of. Use all/install/clean
targets as appropriate.

Change-Id: Idc0c5fae7dfd255039b87ace77c02688cdd76e8f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-24 08:50:55 +00:00
Andre Hartmann
29df009cef GenericProposalModel: Remove unneeded condition
Change-Id: I60234bbf8291d950c475e45866018978d4c423a8
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-07-24 08:46:00 +00:00
hjk
44acfc0702 Utils: Drop transitional FileName alias for FilePath
Transition is over...

Change-Id: Iacaccead238130c8fdb347e172189ecc82b33401
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-24 07:31:50 +00:00
Leena Miettinen
a2a7dcd711 Doc: Update info about debugging Qt Quick projects
Update screenshots using the Design theme.

Change-Id: Idb8911329fb9bb05e34d647f4deb0ad9d47402e2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-07-24 07:21:11 +00:00
hjk
2c0b69cdc5 Core: Use more of Utils::FilePath in locator filters
Change-Id: Ie550691861317f2af6f38170b5dfc6413af5954f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-24 07:18:17 +00:00
hjk
4216702d95 BareMetal: Streamline GdbServerProvider code
Combine host and port values in a url object which is elsewhere
typically used, and move the member to the base class as
all current providers have something like that.

Base typeDisplayName on a datamember, and provide a reusable base
implementation of channelString()

Change-Id: Iedac09bb80d0bc1818cd88b0de99794e951999b8
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-07-24 06:56:09 +00:00
hjk
e23664cc42 TextEditor: Privatize BaseHoverHandler::decorateToolTip()
Never overridden, and does not look safe to invoke more than once.

Change-Id: If5f3830f3fbf26badb6335443defd628c05cf65a
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-07-24 06:50:34 +00:00
Nikolai Kosjar
e6145cdfb2 CppEditor: Tests: Remove a QEXPECT_FAIL
...since this passes by now:

XPASS  : CppEditor::Internal::CppEditorPlugin::test_useSelections(macro
use 2) '!hasTimedOut' returned TRUE unexpectedly. () Loc:
[cppuseselections_test.cpp(105)]

Change-Id: I1cf1416831d258319865c5a58a98bae5538ae245
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-24 06:47:54 +00:00
David Schulz
c52c857076 Utils: add missing function to consoleprocess on Windows
Change-Id: I3d8626e8562d742a02fde2f18267c4cd13dee849
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-24 05:55:50 +00:00
hjk
c36b1e40b0 Ssh: Use Utils::CommandLine in SshRemoteProcess
Change-Id: I074ca3e1e8ec8ce990d6b314a4a87de2f656566c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-23 16:03:18 +00:00
hjk
fa81f76237 Utils: Move meta char policy handling from FilePath to ConsoleProcess
Currently the only place that's using it and the scope is much smaller.

Change-Id: I1a43d14f0e2c69a16f76e6f83b82436bbeeac1c9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-23 16:03:02 +00:00
hjk
8b72e92167 Utils: Add CommandLine convenience constructors
... taking a QString for the executable.

This weakens the very explicit QString -> FileName conversion via the
named constructors for the special case of constructing a CommandLine.

I think that's worthwhile here, as it reduces the noise on the caller
site under circumstance where the nature of the thing is obvious.

Change-Id: I27b4a73639728893d053b2e7ba65cb745f0ffe83
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-23 15:51:45 +00:00
Christian Kandeler
80716610c5 ProjectExplorer: Add tool tip to ExecutableAspect
Because our project mode uses a fixed width for some reason, the file
path of an executable often does not fit on its label. Add a tool tip to
work around this.

Fixes: QTCREATORBUG-18991
Change-Id: I4ab7cd8812ae15bcef95c16a862361e24a28c259
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 15:26:48 +00:00
Christian Stenger
cb34f54aa0 Tests: Fix compile
Change-Id: Ie6e1230177cc11f4f3ab545f10c2c144ef316d3a
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 14:32:09 +00:00
hjk
b0e52f7ff6 Valgrind: Move to Utils::FilePath in some places
Change-Id: I54d03ccda62121055509fd24c5c98a13f7605964
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 14:25:37 +00:00
Robert Loehning
fd3363a2f8 Squish: Update tst_create_proj_wizard
Change-Id: I59b4829abd0d98cbf346e68e3d634da87b3a635e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 14:08:11 +00:00
hjk
5efa84b91f Replace remaining Utils::FileName occurrences by Utils::FilePath
Change-Id: Ic3120f18b4fbe90219de9128dba53d7453630b03
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 13:40:22 +00:00
Christian Stenger
e571b42622 Themes: Fix warning when loading flat-dark theme
Change-Id: Ifd228eb2164b83262b1281a18659cb1393032993
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-07-23 13:29:31 +00:00
Christian Stenger
24d9ad7c11 Dumper: Adapt QC internal dumper to renamed class
FileName is now FilePath. Follow the approach that is used
internal to display the summary of the file path as the
content of its URL if non-empty and the content of the file
otherwise.
Keep the old approach as well as it can still be used,
even in new code thanks to a using declaration and fallback
to the old approach if debugging old source.

Change-Id: I37c621e451fea92ca34db9a63b5ca26b3bdc201c
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 12:26:09 +00:00
Leena Miettinen
93c403e444 Doc: Separate C++ and QML info about evaluating expressions
Also move info about inspecting basic Qt objects to a separate
session.

Change-Id: I60b0da446ad23cb76549d9ccf56bd9313c9a7127
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 12:12:30 +00:00
hjk
251287f0d3 Avoid warning on empty expressions
For some reason, Q_UNUSED includes already a semicolon, adding one
on the user side creates an additional empty statement.

Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 11:55:59 +00:00
hjk
2b26eca80f SshDevice: Use qint64 for processId
De-facto standard and reduces numbers of warnings.

Change-Id: Ic7758ee30091aaa47650a9697145a302480b31de
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-23 11:52:56 +00:00
Tobias Hunger
09ae77d0a9 CMake: Update code to decide whether to run cmake in fileapi mode
Change-Id: Iea841bb49876a580abc80cc7ea21a88b153cc224
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-23 11:11:30 +00:00
Tobias Hunger
ea34cb2b4c CMake: Make "Run CMake" menu entry reliably run cmake
Task-number: QTCREATORBUG-19704
Change-Id: I575e530ad28641753fd57d371dbf081f4a13b337
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-23 11:11:12 +00:00
Christian Kandeler
9b1edfb371 ProjectExplorer: Do not hide empty qrc files
This broke with 92da9d1e67.

Fixes: QTCREATORBUG-22737
Change-Id: Ic4ec9f298e3e7c1b35b1c94096e5684555f48b2b
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 11:08:24 +00:00
Robert Loehning
f03989c09f Squish: Update tst_installed_languages
Change-Id: I5b9fb407f75792a771877bfc14e95ac897f58b31
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 10:59:05 +00:00
hjk
fa9141acdd Debugger: Make example setup code more complete
Change-Id: I2488a84077d7c88d3a14c43bc4f8a9159a866b1c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 10:22:32 +00:00
Andre Hartmann
b5a82a4d58 GenericProposalModel: Allow substring matches
So far, if we had these three functions:

  int getSomething() { return 44; }
  int get_something() { return 43; }
  int something() { return 42; }

then we did not get a completion for getSomething()
or get_something() if we just typed "some", as only
the prefix was taken into account.

This patch adds support for substring matches, and
adds these with lower priority to the proposal list.

Task-number: QTCREATORBUG-19170
Fixes: QTCREATORBUG-19918
Change-Id: Ifc5e2149e4b1fa995f1f8550efc84e7ff4fb1522
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-07-23 10:20:17 +00:00
Christian Kandeler
39ae3ca68f QbsProjectManager: Set qbs.architecture, not just qbs.architectures
If there's no multiplexing, then qbs.architectures will have no effect.

Task-number: QTCREATORBUG-22738
Change-Id: If485481bf0f683fc3c693216d13aee1ba87255fe
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 09:20:05 +00:00
hjk
eb67ab31e7 ExtensionSystem: Remove one deprecated use of QTime
Change-Id: I6bb4657127fdc1d79631059d26a1e35672af87e4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-23 09:04:39 +00:00
Tobias Hunger
20cccf53ae CMake: Make server-mode handle server restarts
Make ServerModeReader::parse handle the forceCMakeRun flag gracefully.

The problem there was two-fold:
1. The server would send a "isReadyNow" signal when its connection is
   estabilshed. This made the ServerModeReader trigger another parse run
   with the same parameters.

   That would in turn would force a new ServerMode process to be created.

2. The "configure" request that is sent races the new ServerMode
   process being connected.

Solve both issues by connecting a slot to the server-mode's
connected signal and have that do the right thing.

Change-Id: I26f9ac00d6ad6397a1fd1fab78610951f535ab53
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-07-23 08:50:20 +00:00
hjk
b2602b3555 Todo: Avoid some deprecation warnings
Change-Id: I3f17f9529d2d1aaf6d5b90e10585b45dc0f75d77
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 06:40:19 +00:00
hjk
2abdc54147 Debugger: Avoid infinite loop in dumper
Change-Id: I71e89574a9eecc079b4d8e91da352fd2b7b0d9ab
Done-by: Xander (@bugreports.qt.io)
Task-number: QTCREATORBUG-22637
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-23 06:27:49 +00:00
Christian Stenger
5f71a27f7b Python: Cleanup pdbbridge
Change-Id: I687f4dd777e7d3bdb4fd54e04b4c12cd66137bfb
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 05:35:40 +00:00
Christian Stenger
8f2397b100 Pdb: Improve python debugging experience
Rename internally used classes and suppress them
explicitly while debugging python code to not display
them on the Locals and Expressions.

Change-Id: Ia396243172b2d138c9f4c81b2f1ed0fec0dce3d3
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 05:35:27 +00:00
Christian Stenger
ea6592e9b4 Dumper: Fix handling of namespaced Qt
Change-Id: I5fae8dd0051596e3fb13cce32f282f3442adc8c0
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 05:35:02 +00:00
Christian Stenger
90392397cb Pdb: Fix missing marker for locations on Windows
When parsing the file path of location information the
GdbMi parser expects UNIX-style formatted paths.
When debugging with the pdb on Windows we reported
Windows-style paths which in turn made the parser fail
and the stack never contained a file name and the
current location also had never a marker displayed.

Change-Id: I5216bbaf39ceead63efe8426561f132de3cd04a2
Reviewed-by: hjk <hjk@qt.io>
2019-07-23 05:34:42 +00:00
Christian Kandeler
46ef3f3027 "New class" wizard: Respect the project's "no Qt keywords" setting
Fixes: QTCREATORBUG-6812
Change-Id: I3f51c61f7a1ed1e4626be6bc31fa2e3affed2084
Reviewed-by: hjk <hjk@qt.io>
2019-07-22 15:43:19 +00:00
Christian Kandeler
9aa67f225f ProjectExplorer: Fix erroneous selection of default kit
... in the target setup page. The default kit should only get selected
as a fallback. However, that code was called before checking the
imports, so it could happen that the default kit got selected in
addition to the kits for the imported builds.

Fixes: QTCREATORBUG-22499
Change-Id: I2a86f4de7e3d62f489ff5b5d56e4974b28f6d4f1
Reviewed-by: hjk <hjk@qt.io>
2019-07-22 14:50:28 +00:00
Christian Kandeler
5add218181 ProjectExplorer: Fix using clang on Windows
We need to derive some ABI-related data from the parent toolchain.
Otherwise, build systems that do not ignore the kit settings will not
work.

Task-number: QTCREATORBUG-22738
Change-Id: I4359143b4eade124b52af297d7509b682a5852b8
Reviewed-by: hjk <hjk@qt.io>
2019-07-22 14:49:47 +00:00