... by transforming the parameter to an r value and pass the argument by
std::move.
Change-Id: I6949ee6bbac7d8675fdbbcb62bb4f4c394bb395f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Plan is to only let the (base) factory create toolchains, having
the 'new' is a separate function complicates the process.
Change-Id: I1faff3e2ce4a19a2947ba4ac4e156ed56e5d18e5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Allow cancellation of cmake runs in tea-leaf and fileapi modes.
At least in those modes cmake can now get stopped when it goes into
an infinite loop.
Change-Id: I4e9bd769292325b9837904cd391ff61dbc477898
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Moved qmldesignerextension into component
Updated build systems
Change-Id: I8d2d0757a1639a472d426b66c0c8ae6fb84cc3d2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This was doing effectively the same as the base constructor with
all code paths overriding the values set here.
Change-Id: I41e29bc5ae5ef7d99ff4adc7beed738c49a3139f
Reviewed-by: David Schulz <david.schulz@qt.io>
This avoids conflicts with shortcuts.
Task-number: QDS-803
Change-Id: I9269729cf2cb4a6bba9493d768c595748af3392d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Revert the IDs back to what they were.
Amends 26463a2219
Fixes: QTCREATORBUG-22564
Change-Id: I220e362793d525ee8f01ff9649feb2cdfc37bba3
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
The context defined which branch to take, just inline the repective
branch, and use a new convenience method for the clear() case.
Change-Id: Ib5aef375e27d3600dea787c2f8fa4c0b788da194
Reviewed-by: David Schulz <david.schulz@qt.io>
The create() reimplementation is not needed anymore as the base
ToolChainFactory::create() had identical effect.
Change-Id: I94512937e2257da9affb522908c20d9250c34d3b
Reviewed-by: David Schulz <david.schulz@qt.io>
This sets the display name in the constructor now. In quite a few
places this will be directly overridden afterwards (either in
derived c'tor or in detectToolChains(), but this will help with
further changes:
The idea is to only leave { return new ... } in the create()
implementation such the method can be de-virtualized as the base
ToolChainFactory::create is enough.
Change-Id: I1b15c015b6f3e2bbff682bee3fac626ed1bde312
Reviewed-by: David Schulz <david.schulz@qt.io>
... because a topic was added to the Qt Design Studio Manual
Change-Id: Ib974724ff38248ad90aab72a34ee0c4a80d5ed4f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In iOS build configurations.
When setting the default value after creating the "BoolAspect", also the
value must be changed to that default.
The original code only used the default value when restoring the aspect
from settings.
Task-number: QTCREATORBUG-22529
Change-Id: Icee0887e02d2b6d83273492a45f20c0263bb68cc
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The default meta character mode needs to be "Abort" to retain previous
behavior.
Amends acfe45c434.
Change-Id: I1e0c752eddccb0d4821203573241308e56dfb2d3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
IOutputPane has an updateFilter method now, so rename the one in the
TODO output pane.
Change-Id: I0e6291372c83373b82d0d9911feffe032df8af5e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When using the 'windowsvista' style the folding markers are blue when
hovered. This color is almost invisible on the default folding range
background color. Use the tested folding markers of the fusion style,
because it is already used when device pixel ratio != 1.0
Change-Id: I23659cce71a2eb101692597a1d256d43f6426920
Fixes: QTCREATORBUG-21702
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
On Windows, compilers of type "Clang" display a QComboBox instead of a QLabel
Change-Id: I68537259d8d5b38b288308675139c92395f6df62
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
MSVC creates copy constructors and operators with a non copyable member.
Change-Id: I4cd9d05dc8d72e249d6c95a48da89c783c6550ca
Fixes: QTCREATORBUG-22578
Reviewed-by: David Schulz <david.schulz@qt.io>
Also add the import path to the example main.cpp file.
Task-number: QDS-805
Change-Id: I990e5dc364d610a4cef5697b3355147f9e5fcde1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Don't use two lookups for parent types and act on known null pointers.
While the machinery is robust enough to handle the result it's a
needless deviation in regular code path.
Change-Id: I6e50629cf554870a3ffb9f488f654e6ae557e5b3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If the format contains '/', that must be escaped to avoid the expander
to interpret that as regexp style replacement.
Task-number: QTCREATORBUG-22440
Change-Id: Iaa6c0ae0aa74a055a30b3c0413e325c497f9310f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
... from the special MsvcToolChain constructor.
There's a generic way to set that in the base already.
Change-Id: Idd9f44672fec16ff8e3b08ad0f9809b1e7e066f0
Reviewed-by: David Schulz <david.schulz@qt.io>
It was never actually updating when switching the editor.
An update was just accidentally triggered when the designer plugin
updated the editor XML when switching modes, which triggered
an intermediate document change signal.
Get rid of the separate code paths for setting the current editor
for "standalone" editor tool bars and the tool bars in editor views,
which implicitly corrects the update behavior in the former case.
Fixes: QTCREATORBUG-22553
Change-Id: Ieb9f4b53600e1e1b66695ec86164628025df73f8
Reviewed-by: David Schulz <david.schulz@qt.io>
It is now a standard part of Qt Creator and enabled by default.
Change-Id: Ifcd4a2138c4a96e73efe97e5075414875773add4
Reviewed-by: David Schulz <david.schulz@qt.io>
Neither tea-leaf nor fileapi provides progress information on cmake's
configure/generate runs. So fake it.
Change-Id: I0e336b4ba145793df6674f4847be1dddad7508cf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
