Kits are nowadays displayed if configured, but disabled
if they do not fit for the respective project.
Change-Id: If04a20afde2fc1ada643e45d5eea33e6ace7a4f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Clicking an object in the 3D object selection view, selects it in the
creator side. Multiselection (i.e. Ctrl+click) is not implemented yet.
Also selected object is not highlighted in the view yet.
Task-number: QDS-1124
Change-Id: I0b10162539ecedc40ed117896e385975c52b04a9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This method allows to modify properties in the data model from
the puppet. For performance reasons, properties should be modified
in bulks. Each bulk will be one step on the undo stack.
Change-Id: I7dbef02781706c8638981512ca0ec45d24c54545
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
It has been observed by users (though not reproduced here) that the
target setup page would apparently appear before the kit manager was
finished setting up the initial kits, leading to an empty kit list on
the target setup page even after the kits were finally loaded.
We now take this possibility into account.
Fixes: QTCREATORBUG-22353
Change-Id: I83cdc3da45785c3badfac484a54f34859191cc37
Reviewed-by: hjk <hjk@qt.io>
EditView3D.qml can contain errors, most likely because
of QtQuick3D updates.
Change-Id: I85879d9079ba8771a2af4478ba2e4e63a6aa9223
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Since we are currently not able to fix the build with all build system
and platform combinations
this partially reverts commit b128d498b2
and 6463a686f6
Change-Id: Icfb9ab6096ad1204e595522be12146b91d570f49
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
[ChangeLog] Updated Qbs to version 1.15.0.
Change-Id: I542fe7a7eb5e60fe6138213e04b69356c02d7a0c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Light component was split into three different light types in Quick3D.
Change-Id: I409dc4888b389bcb9b8e842f3a6bfeac34f3aaa0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The label needs to be created before the spinbox or the label will
block the spinbox mouse events, as the tail end of the labels overlaps
the non-checkbox control column to avoid unnecessary cutoff of the
labels that do not have any non-checkbox controls.
Change-Id: If7a7fd671b0dbb3f4c1ab5570217455e4978765e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Without the DesignerWindowManager QtQuick3D items will crash.
Change-Id: Ib4057d581143aed860fa120ab189e11076d1f531
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
With the option to not ask again.
It's too easy to create unwanted files when mistyping names in Locator.
Fixes: QTCREATORBUG-23078
Change-Id: I082d3e112db404813c7d8f46edb7a16836a98a92
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
If the inferior stops by itself and the debugger
tries to shutdown it had ended up waiting forever for
the additional workers (e.g. ports gatherer, channel
provider,...) to stop.
The debugger appeared as finished but the runworker was
still in a running state until the user would hit the stop
button of the application output pane.
Make the gdbserver essential to initiate a clean finish.
Change-Id: I16b2ebe5feadc88bb76ce34b49ac5d3456d0867c
Reviewed-by: hjk <hjk@qt.io>
When multiple test executables are defined inside a
single project file all or selected tests did just use
the first defined target which in turn led to execute
only the test cases of one of the executables or none
at all.
Take all targets into account and make Run All and
Run Selected work correctly for this scenario.
Fixes: QTCREATORBUG-23091
Change-Id: Idf0dd99f9a8782072cbc5792c937232673fee445
Reviewed-by: David Schulz <david.schulz@qt.io>
Move the non-OptionsPage code into a new file for comprehensibility.
Change-Id: I306ae669ec9fdd941f777426420859ee2eb89e95
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Instead of enumerating the directory, search directly for the executable
first, like it is done on UNIX.
Change-Id: I6465d85efa20d97622afc227eaadcbc14b3e22f5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This is a hack, not a proper solution. In theory, this here should
serve as a lock.
We currently get start - start - finish - finish sequences when
switching qmake targets quickly, keeping the run button disabled.
The whole setup here is unfortunate. Parsing inherently depend on
more than the project alone, it's roughly per-Target. So keeping
track of it in the Project complicates it.
Change-Id: I57d361ce21088d8e1ec53ce75f83ff3bd04851e1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Broken in b128d498b2
Tested with MinGW 8.1
Tested with VisualStudio 2017
Change-Id: I8f43efe43016ea95866ee018ac9a47373a37373b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We always set the target explicitly (in a certain way), so exclude the
target arguments coming from the build system and the (possibly manually
specified) platform codegen flags of the toolchain.
Change-Id: I74bbec67f5960f05b50cf9c5aa11875c71a5161f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Leave the function addExtraCodeModelFlags() around as it's used by
ClangPchManager::ProjectUpdater::toolChainArguments().
This allows us to filter out excess target arguments in a follow-up
change.
Change-Id: I742d713dd1ca6c391ba77c52555dcf4e94cc2ff9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
CMake gives the path to the cmake_pch.h[xx] file as relative path
to build directory. Making it absolute fixes the code model.
Fixes: QTCREATORBUG-22888
Change-Id: I2fdc080be779f22b737788be2074254290994aaa
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Introduced in 9c2568b8e8
Range-based for loops that modify the original container must
work on a copy.
Change-Id: Ib917014ab259c20b282cdc85e7ca6583f7844de5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
We already have valuesChanged() which notifies that a
property of the C++ QObject has changed.
This patch adds valuesModified() which notifies that values
in the data model should be changed.
While valuesChanged() only changes the so called instance value,
valuesModified() does change the internal data model and as
a result the QML code.
This is done in NodeInstanceView::valuesModified().
This enabled the qml2puppet to acutally change values,
like a property editor would.
Change-Id: I2493b9e626c4b194e332a7a096de3dbf2195514a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Column::COUNT should not show up as actual column, but the compiler
doesn't know.
Change-Id: I68eea5c73a95bd45378f88c505f0cefed62ce8ab
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We use Quick3DNodeInstance as a proxy class to wrap QQuick3DNode.
The access to private API like QQuick3DNodePrivate::setIsHiddenInEditor()
is restriced by such proxy classes.
Change-Id: If5191c3b730359000cf983c3af206dcffa07be74
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Pasi Keränen <pasi.keranen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This should not matter, but makes the add_qtc_executable targets
match up with the PCH, so that they should build a bit faster.
Change-Id: Ibecaaf7fd98d5b927d52e4956b1bea4a5775afba
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Using the spin box focus is not safe enough, but using
transactions on the dragging works nicely.
Change-Id: Iffc15b4ca44cb473b257f58e548ff86ebd56bbf2
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Since the camera is movable the light should follow the camera.
Change-Id: Ia9925f98288ff19a81086e52f3a31fe72b32ee99
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Some templates got an additional page for handling translations.
Change-Id: I420e4f1bd8be5a30056220abd73b3f9da44d5047
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
If we have a project with two enabled targets and we remove both of the
associated kits, one of the targets temporarily becomes the active one.
If the activeTargetChanged() signal gets queued, then the receiver will
be called with an invalid target pointer, as the target has been removed
in the meantime.
It is unclear why the signal was queued in the first place. Presumably
the original reasoning is no longer applicable after various
refactorings.
This amends (and effectively reverts) commit c13b20f160.
Task-number: QTCREATORBUG-23075
Change-Id: I3c63c763319734a4d52b3bb221919b20fd123dbe
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The build system of Qt for WebAssembly on Windows requires MinGW in the
path. If a MinGW toolchain is registeded (e.g. via Sdk installer),
append it to the path.
Change-Id: I5c33cb5c4df636be99f815e307806efc07e18a11
Reviewed-by: hjk <hjk@qt.io>
Add edit camera controls and grid helper to 3D edit view.
Task-number: QDS-1127
Change-Id: Ice5ea0fcca18d59dc8a2907710e16c6688b90628
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Removing the dummy OpenGL widget gets rid of flicker and scaling issues
when moving between monitors with different DPI.
Fixes: QTCREATORBUG-23064
Change-Id: I2373862244353b545e8756afe294f9beeefda422
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
