Commit Graph

6 Commits

Author SHA1 Message Date
Oswald Buddenhagen
20a3eae86f fix memory leak in AndroidSdkDownloader::extractSdk()
put the process on the stack, so we don't need (and fail) to free it.
while at it, remove the pointless close() call.

amends f46099d2.

Change-Id: I4025691bebf2899efe006ee83012aefbb8797a64
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-12-11 14:54:47 +00:00
Alessandro Portale
43c73b20e4 Android: Prevent multiple concurrent downloads of SDK tools
...by making the "Downloading SDK Tools package..." progress dialog
application modal.

Fixes: QTCREATORBUG-25013
Change-Id: I59979350d8f1ce5632ec520e1c661fff3399a283
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-11-30 15:01:11 +00:00
Assam Boudjelthia
41dd8dc8ef Android: read SDK configuration from user editable path
By default, copy the sdk_definitions.json to Qt Creator user resource
path. The user can use that to make any updates if desired.

Add SdkDownloader instance as a member of AndroidSettingsWidget.

Change-Id: Ieabc9c6ddecbe63586f750b26bcf4ca990caee26
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-03-18 10:53:15 +00:00
Assam Boudjelthia
ad927dac85 Android: call cancel() instead of hide() in sdk download progressdialog
The proper use is to call cancel(), the dialog will be hiden after that.
Otherwise, it will not be cancel  and can get visible again.

Change-Id: Ifb2a00721571ce2bc8ded7c96e6b69e587020b34
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-20 17:55:05 +00:00
Assam Boudjelthia
e50c744710 Android: use QDir::mkPath() instead of QDir::mkdir() in SdkDownloader
Allow creating nested dirs path.


Change-Id: I38106c148b177e5af06a59dd624ee74e2db1df40
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-11 14:30:35 +00:00
Assam Boudjelthia
f46099d21e Android: Automatically download SDK tools and essential packages
Automatically download Android SDK Tools to default path
used by Android Studio, then essential packages will be installed
using the sdkmanager tool. Automatic installation can also be
triggered by an added button in the settings page.

Essentials packages include NDK Bundle and other NDK versions
required by previous Qt versions.

An sdk_definitions.json file holds download paths for SDK Tools,
and other (Qt version <-> essential packages) combinations.

[ChangeLog][Android] Automatically download SDK Tools, NDKs and
all essential packages for Android builds.

Task-number: QTCREATORBUG-23285
Change-Id: I90e7aafecd017d2bdc959e403711d9d440a6bbb2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-07 18:21:30 +00:00