It can be happen that we get output before the process is assigned.
Change-Id: I4419b125fc9e7244142c188c8bdf0a030faf850a
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
It has no model attached so is doing nothing and called later again.
Change-Id: Ide36ba5640ff18e29d5be2ad5911ed448f37c92b
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
By adding a title, and a left border.
Change-Id: Id8a577c9011c7a7282f5b540e94e8f809481b6fa
Task-number: QTCREATORBUG-9104
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Opening a commit editor inside a submodule then executing
Local Repository Log opens the log for the supermodule.
Change-Id: I264925e0f23e2372a09a28e788174a747f5870a8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Broke with the removal of the QtProject subdir for plugins
Change-Id: Ic42d3e9b902f7ac228e62923093dfe6af01b2d19
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Since they are no longer modal, the "return to editor" shortcut was
executed for the escape key instead.
Change-Id: I4505f49105ad46f7c5f9e0257e77a8ca4652ef06
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Otherwise the options dialog might appear behind the current "dialog"
(for example the "new" wizards).
Also, take ICore::dialogParent as default.
Change-Id: I4578e269db5763842a942549a45ec8cdd6b28b5d
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Conditions:
1. Not empty. It erases the existing executable for no reason.
2. Not Windows -> Windows doesn't produce core dumps, so the path inside it is
unlikely to match anything on the host.
Change-Id: Ib3cd1ae278d8bc9f6ad326821319ca3deda44800
Reviewed-by: Thomas Otto <totto@zbh.uni-hamburg.de>
Reviewed-by: hjk <hjk121@nokiamail.com>
The resizing is not working any more.
This reverts commit afc498e24e.
Task-number: QTCREATORBUG-12653
Change-Id: Ie5b7ebd2f8810bbdc877b61e16591c5a2bbcf2d4
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Because the preposition is the last word in the function or title.
Change-Id: I3648f5723eaf63faef097ea80f30a4576136a4e8
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
The current code simply asserts when a new parse request comes in while
parsing. However, that condition is easily triggered, for instance if a
project file is saved to disk during a parse operation. Such updates
currently have no effect at all (other than triggering an error
message).
Instead, we now cancel the old parse job and start a new one.
Change-Id: If2eeb93b85b5163dcea99785a0fc89a254d082db
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
object() refers to the executable file (the build target), which
doesn't have to be inside the project's directory.
directory() refers to the directory of the frame's source file.
Change-Id: Icf9885d1346acbf42ea904e69d6c8eee4d6a40cb
Reviewed-by: hjk <hjk121@nokiamail.com>
...otherwise it might happen that no test functions will be executed,
which is highly confusing, especially since no error dialog will be
shown.
If there are errors, just print a warning and quit. If we do not quit,
the error dialog will be shown which might block build machines.
Change-Id: Ic347dfba8fefc0e0f375cf2363265008df56ee53
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Another follow up fix for 93304df038 .
Change-Id: I39c98ed2e769a048c00931bd3b850d4d50310d99
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
While it is true that additional information about target
artifacts can appear during a build, this data is already
present in the qbs::Project object and can simply be retrieved.
No reparsing is necessary.
The exception is when reparsing was requested while the build
was going on. In that case, we really need to do it after
the build has finished.
Change-Id: Ief3797782ad0ca5651974d4b5d3d64e1199ca9a5
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
You could enable the select-on-hover mode by clicking in an empty time
line, even though the buttons bar was disabled. You could also trigger
various bad behavior by clearing the view and restarting the profiler.
Properly initializing and clearing all members, and sending change
signals on clearing helps with that.
Change-Id: Ie7df80a52daaf166c3a4adb2eb1f28a59c21df57
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
If we use different x and width parameters in JavaScript and C++ we
introduce numerical instability which leads to visual glitches.
Change-Id: I352f3e8365ca52d135230343c2f034332ec71323
Task-number: QTCREATORBUG-12648
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
There is not even a guarantee that VERSION from os-release contains
"Linux" anywhere. Prepend "Linux" or "Unix" and add the version details
in parentheses instead.
Also remove unnecessary (and wrong) /etc/issues fallback.
Change-Id: I0457ad9e8cedeea35e0cad5ea8093652eb8428e1
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Fix expansion and updating.
Persistence and non-locals are still lacking.
Change-Id: I74e25199d50350516afc686a05836e239bfc8acb
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
The current code keeps an instance of QbsProject and of qbs::Project in
every project node, with them being null/invalid everywhere except for
the top-level node. Instead, introduce a dedicated class for the root
node and hold a QbsProject only there. The qbs::Project is held in
QbsProject now.
As a nice side effect, this also fixes QBS-644, presumably because the
dubious-looking use of projectNode() has been removed.
Task-number: QBS-644
Change-Id: I5d36806745b9d67879db6f48aa56bc97868e4f17
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
If the operation fails, people currently don't get any hint as to what
the reason could be. For lack of a better place, log the error message
to the General Messages pane.
Change-Id: I19c48bbee0e0030b2d542425d43c089a29600756
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Qbs is nowadays disabled with Qt4 anyhow, so we can use the less
hacky Qt 5 methods
Change-Id: I9ce9391238b3597cc4b31e9f9f6647cec1a2496e
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
This was necessary for supporting full screen on 10.7 even while
keeping compatibility with 10.6. Since we no longer support 10.6,
we can remove the workaround.
Change-Id: I03e23e9203836ab6fb5a836fc06a525e44516d34
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
