Jarek Kobus
e7b43b6b8b
SubmitEditorWidget: Avoid using sender()
...
Change-Id: I748dbf6232e89ffe0e412894bf708434be247e31
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2022-07-19 20:17:28 +00:00
Artem Sokolovskii
646254f460
VCSbase: Remove foreach / Q_FOREACH usage
...
Task-number: QTCREATORBUG-27464
Change-Id: I1088047513e7660907182e80303607d8c48919f5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
2022-05-23 08:49:43 +00:00
Andre Hartmann
c572ca0e87
VCS: Remove unused local variable
...
Why didn't this give a warning?
Change-Id: I866aa5ddf3107866bcf5da395f1312e50e75561c
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2021-09-13 13:08:07 +00:00
Andre Hartmann
4da225f7af
VCS: Fix commit message verification for empty subject
...
For commit messages with empty subject and
full body no warning was shown so far.
Example:
"
This is now considered as commit message with
a very short subject, but was valid before.
"
Change-Id: Iee24b022cd53dc9d2eb71f47571221e4dda9ba08
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2021-09-11 15:04:05 +00:00
Andre Hartmann
0e8756508c
VCS: Clear commit message hint when editor becomes disabled
...
The commit editor becomes disabled, when no more
changed files were available. In this case, the
commit message verification makes no sense and
should be removed.
Change-Id: Ic16cc4ade1ecd1b64faee52b21a10b9c882908d0
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2021-07-27 07:57:53 +00:00
Andre Hartmann
3d4b5c0269
VCS: Fix second line commit message verification
...
For commit messages consisting of only two lines, no
warning was shown when the second line was not empty.
Now a warning is print for:
First
Second
Third
as well as:
First
Second
Change-Id: Ibf19bc46465446f1634f9fdc783bd194b837d5ec
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2021-04-17 17:41:33 +00:00
Robert Löhning
cd0a140bde
Improve translatable strings
...
Change-Id: I0104209bb0f865a48f9ca2524f62457f7524bba9
Reviewed-by: André Hartmann <aha_1980@gmx.de >
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io >
2021-03-25 16:53:40 +00:00
Eike Ziller
e9bf841dc9
Fix lupdate issues
...
Some wrong tr calls / missing tr functions.
Some places where we need to bring lupdate to the right track with
regard to namespace resolution.
Change-Id: Idf552054a34e24d9671db68c816bf37f4d403dbc
Reviewed-by: hjk <hjk@qt.io >
2021-03-22 15:00:37 +00:00
Andre Hartmann
8c92f40db8
VCS: Add commit message verification
...
Help writing good commit messages by verifying
that the complete message is not too short,
that the first line (subject) is not too long
and that the subject is separated from the rest
of the commit by an empty line.
Change-Id: I296c036433767f2508630f409c0e4b4c241391d1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io >
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2020-12-23 15:26:55 +00:00
Andre Hartmann
41cb713370
SubmitEditorWidget: Inline two small functions
...
Change-Id: Ia9b2c451a587d418ccf39707c25d8aff062f6ed8
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2020-02-29 18:21:29 +00:00
hjk
ccc2a347a7
Vcs: Drop QActionSetTextSlotHelper
...
With the possibility to connect to any function that's not needed
anymore.
Change-Id: I307f706aa922a3b7d9f1cd7e2e88cece71090946
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2020-02-05 11:09:39 +00:00
Orgad Shaneh
96529a27c5
VCS: Add reason text when submit validation fails
...
Change-Id: If4c8d5d1d5dc5386e49b29be59786dc53cfaaaa3
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: André Hartmann <aha_1980@gmx.de >
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io >
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io >
2018-11-10 16:05:05 +00:00
Orgad Shaneh
8f65486dfc
VCSBase: Modernize
...
override, auto, nullptr, member initializers.
Change-Id: Ie21b8f4a4d6673947d82619bc3de677fcea63d7f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2018-09-20 07:02:17 +00:00
Orgad Shaneh
f1f506b479
VCS: Remove unused unregisterActions functions
...
Change-Id: I4c7a0dfc93f27f93cdbd84d7e027e63db05341e8
Reviewed-by: André Hartmann <aha_1980@gmx.de >
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io >
2018-08-28 07:26:02 +00:00
Orgad Shaneh
afb60d0434
VCS: Use namespace Utils
...
Change-Id: I41c818362398fd194995baf5b1adb16899e83217
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io >
2018-07-18 08:44:45 +00:00
Orgad Shaneh
6c70f22ada
VCS: Preserve selections in commit editor on refresh
...
Task-number: QTCREATORBUG-18483
Change-Id: I749f2d4d583f197e7b5b6f69116c3a196e85484b
Reviewed-by: André Hartmann <aha_1980@gmx.de >
2017-07-01 19:25:35 +00:00
Orgad Shaneh
b8d9a6d127
VCS: Fix wrapping when settings are changed while the editor is open
...
Change-Id: I41a138f1e0838be833edac1b63e64a1d86575db4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io >
2017-05-29 11:03:16 +00:00
Orgad Shaneh
9ee955acb7
VCS: Only accept commit on Ctrl+Enter when enabled
...
Task-number: QTCREATORBUG-16808
Change-Id: I08442b027a6af300b2786e4510177bc050887ada
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io >
2016-09-18 19:00:26 +00:00
Tobias Hunger
397e7f4843
Update License according to agreement with Free Qt Foundation
...
* Update files in src/plugins
Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com >
2016-01-19 15:57:01 +00:00
Tobias Hunger
b3e0adf476
VcsBase: Use Qt5-style connects
...
The bulk of the heavy lifting was done by clazy
Change-Id: I3d8904d3c5d22aecf5e5baefacc4dd9b77371417
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2015-11-20 07:45:59 +00:00
Orgad Shaneh
79d3d23488
Git: Use side-by-side layout for Fixup Previous Commit
...
Similar to simple commit layout.
Change-Id: If9470d47159cba21f11aefc8e2cc4895d10ff409
Reviewed-by: André Hartmann <aha_1980@gmx.de >
2015-05-10 20:10:44 +00:00
Tobias Hunger
fc2c615c6a
VcsBase: Convert submiteditorwidget to Qt5 style connects
...
Wrap lines that are too long while touching the file.
Change-Id: I209cf0f3c126748508d07ad1a5fdc7dea0d09c71
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2015-02-16 15:19:03 +00:00
Eike Ziller
9926fc2ab1
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
...
Conflicts:
src/libs/utils/tooltip/tipcontents.cpp
src/libs/utils/tooltip/tipcontents.h
src/plugins/android/androiddeployqtstep.cpp
src/plugins/baremetal/baremetalconstants.h
src/plugins/baremetal/baremetaldevice.cpp
src/plugins/baremetal/baremetaldevice.h
src/plugins/baremetal/baremetaldeviceconfigurationwidget.cpp
src/plugins/baremetal/baremetaldeviceconfigurationwidget.h
src/plugins/baremetal/baremetaldeviceconfigurationwizard.cpp
src/plugins/baremetal/baremetaldeviceconfigurationwizardpages.cpp
src/plugins/baremetal/baremetaldeviceconfigurationwizardpages.h
src/plugins/baremetal/baremetalplugin.cpp
src/plugins/baremetal/baremetalplugin.h
src/plugins/baremetal/baremetalruncontrolfactory.cpp
src/plugins/baremetal/baremetalruncontrolfactory.h
src/plugins/cppeditor/cppcodemodelinspectordialog.cpp
src/plugins/cppeditor/cppdoxygen_test.cpp
src/plugins/cppeditor/cppdoxygen_test.h
src/plugins/debugger/breakpointmarker.cpp
src/plugins/debugger/debuggeritemmodel.cpp
src/plugins/debugger/debuggeritemmodel.h
src/plugins/debugger/loadcoredialog.cpp
src/plugins/genericprojectmanager/cppmodelmanagerhelper.cpp
src/plugins/projectexplorer/addnewmodel.cpp
src/plugins/projectexplorer/addnewmodel.h
src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp
src/plugins/qmlprofiler/abstracttimelinemodel.cpp
src/plugins/qmlprofiler/abstracttimelinemodel.h
src/plugins/qmlprofiler/notesmodel.cpp
src/plugins/qmlprofiler/qml/CategoryLabel.qml
src/plugins/qmlprofiler/qml/MainView.qml
src/plugins/qmlprofiler/qml/Overview.js
src/plugins/qmlprofiler/qml/Overview.qml
src/plugins/qmlprofiler/qml/TimeDisplay.qml
src/plugins/qmlprofiler/qml/TimeMarks.qml
src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp
src/plugins/qmlprofiler/sortedtimelinemodel.cpp
src/plugins/qmlprofiler/sortedtimelinemodel.h
src/plugins/qmlprofiler/timelinemodelaggregator.cpp
src/plugins/qmlprofiler/timelinemodelaggregator.h
src/plugins/qmlprofiler/timelinerenderer.cpp
src/plugins/qmlprofiler/timelinerenderer.h
src/plugins/qmlprojectmanager/QmlProjectManager.json.in
src/plugins/texteditor/findinfiles.cpp
src/plugins/vcsbase/vcsconfigurationpage.cpp
src/shared/qbs
src/shared/scriptwrapper/interface_wrap_helpers.h
src/shared/scriptwrapper/wrap_helpers.h
tests/auto/qmlprofiler/abstracttimelinemodel/tst_abstracttimelinemodel.cpp
tests/system/suite_debugger/tst_debug_empty_main/test.py
tests/system/suite_debugger/tst_qml_js_console/test.py
tests/system/suite_debugger/tst_qml_locals/test.py
Change-Id: I67540b648f8b162496f4aa606b04d50c7c9125c6
2015-02-12 17:29:21 +01:00
Tobias Hunger
e29a49ca24
VcsBase: Sprinkle with auto
...
Change-Id: Icd1e1ec16b1ff918162d3c6f564348d47177ffc7
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2015-01-22 14:19:24 +01:00
Eike Ziller
3c85058694
Update License
...
Change-Id: I711d5fb475ef814a1dc9d2822740e827f3f67125
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com >
2015-01-16 12:37:56 +01:00
Eike Ziller
ea27143239
Merge remote-tracking branch 'origin/3.2'
...
Conflicts:
src/libs/utils/ipaddresslineedit.cpp
src/libs/utils/logging.h
src/plugins/analyzerbase/AnalyzerBase.pluginspec.in
src/plugins/android/Android.pluginspec.in
src/plugins/android/androiddeploystep.cpp
src/plugins/android/androiddeploystep.h
src/plugins/android/androiddeploystepfactory.cpp
src/plugins/android/androiddeploystepwidget.cpp
src/plugins/android/androidpackagecreationfactory.cpp
src/plugins/android/androidpackagecreationstep.cpp
src/plugins/android/androidpackagecreationstep.h
src/plugins/android/androidpackagecreationwidget.cpp
src/plugins/android/androidpackagecreationwidget.h
src/plugins/android/javafilewizard.cpp
src/plugins/autotoolsprojectmanager/AutotoolsProjectManager.pluginspec.in
src/plugins/baremetal/BareMetal.pluginspec.in
src/plugins/bazaar/Bazaar.pluginspec.in
src/plugins/beautifier/Beautifier.pluginspec.in
src/plugins/bineditor/BinEditor.pluginspec.in
src/plugins/bookmarks/Bookmarks.pluginspec.in
src/plugins/clangcodemodel/ClangCodeModel.pluginspec.in
src/plugins/clangcodemodel/clanghighlightingsupport.cpp
src/plugins/clangcodemodel/clangsymbolsearcher.cpp
src/plugins/classview/ClassView.pluginspec.in
src/plugins/clearcase/ClearCase.pluginspec.in
src/plugins/cmakeprojectmanager/CMakeProjectManager.pluginspec.in
src/plugins/cmakeprojectmanager/cmakeeditorfactory.cpp
src/plugins/cmakeprojectmanager/cmakehighlighter.cpp
src/plugins/coreplugin/Core.pluginspec.in
src/plugins/cpaster/CodePaster.pluginspec.in
src/plugins/cppeditor/CppEditor.pluginspec.in
src/plugins/cppeditor/cppfilewizard.cpp
src/plugins/cpptools/CppTools.pluginspec.in
src/plugins/cpptools/cpphighlightingsupportinternal.cpp
src/plugins/cpptools/cppmodelmanagerinterface.cpp
src/plugins/cpptools/cppmodelmanagerinterface.h
src/plugins/cvs/CVS.pluginspec.in
src/plugins/debugger/Debugger.pluginspec.in
src/plugins/designer/Designer.pluginspec.in
src/plugins/diffeditor/DiffEditor.pluginspec.in
src/plugins/emacskeys/EmacsKeys.pluginspec.in
src/plugins/fakevim/FakeVim.pluginspec.in
src/plugins/genericprojectmanager/GenericProjectManager.pluginspec.in
src/plugins/git/Git.pluginspec.in
src/plugins/git/gitorious/gitorious.cpp
src/plugins/git/gitorious/gitorious.h
src/plugins/git/gitorious/gitoriousclonewizard.cpp
src/plugins/git/gitorious/gitorioushostwidget.cpp
src/plugins/git/gitorious/gitorioushostwidget.h
src/plugins/git/gitorious/gitorioushostwizardpage.cpp
src/plugins/git/gitorious/gitoriousprojectwidget.cpp
src/plugins/git/gitorious/gitoriousprojectwidget.h
src/plugins/git/gitorious/gitoriousprojectwizardpage.cpp
src/plugins/git/gitorious/gitoriousprojectwizardpage.h
src/plugins/git/gitorious/gitoriousrepositorywizardpage.cpp
src/plugins/git/gitorious/gitoriousrepositorywizardpage.h
src/plugins/glsleditor/GLSLEditor.pluginspec.in
src/plugins/glsleditor/glsleditorfactory.cpp
src/plugins/glsleditor/glslfilewizard.cpp
src/plugins/helloworld/HelloWorld.pluginspec.in
src/plugins/help/Help.pluginspec.in
src/plugins/imageviewer/ImageViewer.pluginspec.in
src/plugins/ios/Ios.pluginspec.in
src/plugins/macros/Macros.pluginspec.in
src/plugins/mercurial/Mercurial.pluginspec.in
src/plugins/perforce/Perforce.pluginspec.in
src/plugins/projectexplorer/ProjectExplorer.pluginspec.in
src/plugins/pythoneditor/PythonEditor.pluginspec.in
src/plugins/pythoneditor/pythoneditorwidget.cpp
src/plugins/pythoneditor/wizard/pythonfilewizard.cpp
src/plugins/qbsprojectmanager/QbsProjectManager.pluginspec.in
src/plugins/qbsprojectmanager/defaultpropertyprovider.cpp
src/plugins/qmakeprojectmanager/QmakeProjectManager.pluginspec.in
src/plugins/qmakeprojectmanager/profileeditorfactory.cpp
src/plugins/qmldesigner/QmlDesigner.pluginspec.in
src/plugins/qmljseditor/QmlJSEditor.pluginspec.in
src/plugins/qmljseditor/qmljseditorfactory.cpp
src/plugins/qmljstools/QmlJSTools.pluginspec.in
src/plugins/qmlprofiler/QmlProfiler.pluginspec.in
src/plugins/qmlprojectmanager/QmlProjectManager.pluginspec.in
src/plugins/qnx/Qnx.pluginspec.in
src/plugins/qtsupport/QtSupport.pluginspec.in
src/plugins/remotelinux/RemoteLinux.pluginspec.in
src/plugins/resourceeditor/ResourceEditor.pluginspec.in
src/plugins/resourceeditor/resourcewizard.h
src/plugins/subversion/Subversion.pluginspec.in
src/plugins/tasklist/TaskList.pluginspec.in
src/plugins/texteditor/TextEditor.pluginspec.in
src/plugins/texteditor/basetexteditor_p.h
src/plugins/texteditor/basetextmark.cpp
src/plugins/texteditor/codeassist/basicproposalitemlistmodel.h
src/plugins/texteditor/codeassist/defaultassistinterface.h
src/plugins/texteditor/codeassist/iassistproposalitem.cpp
src/plugins/texteditor/itexteditor.cpp
src/plugins/texteditor/itexteditor.h
src/plugins/texteditor/itextmark.cpp
src/plugins/texteditor/plaintexteditor.cpp
src/plugins/texteditor/plaintexteditor.h
src/plugins/texteditor/texteditoractionhandler.cpp
src/plugins/todo/Todo.pluginspec.in
src/plugins/updateinfo/UpdateInfo.pluginspec.in
src/plugins/valgrind/Valgrind.pluginspec.in
src/plugins/vcsbase/VcsBase.pluginspec.in
src/plugins/welcome/Welcome.pluginspec.in
src/plugins/winrt/WinRt.pluginspec.in
tests/auto/debugger/temporarydir.h
Change-Id: I254af8be8119fe9855287909e17d4b8ca9d2fc2f
2014-10-14 15:36:16 +02:00
Eike Ziller
8295b503be
License update
...
Change-Id: I3c22ef2685d7aa589f5d0ab74d693653a4c32082
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com >
2014-10-09 11:41:44 +02:00
Orgad Shaneh
ece3f97f90
VCS: Fix word wrap mode for commit message
...
Change-Id: I99cee5236bc475aae949956ac7c1f05e8e3fd665
Reviewed-by: Eike Ziller <eike.ziller@digia.com >
2014-09-23 08:52:53 +02:00
Orgad Shaneh
41942ac088
VCS: Fix displaced comment
...
Change-Id: I71f0169951b5dfd9cedeff82006b757dd4df756e
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2014-09-16 16:16:56 +02:00
Orgad Shaneh
850276d9f9
VCS: Make text wrapping independent of actual editor
...
Narrowing the submit editor down corrupts the commit message
Also fixes the following cases:
# comment that is wrapped
to next line <-- this line currently appears
comment in the middle of
# wrapped line <-- this line currently disappears
Change-Id: I7a35058569f002479c646ef6cfd1fdb1ada401c9
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-09-16 16:12:45 +02:00
Orgad Shaneh
6158a4ca58
VCS: Avoid repetitive calls to cleanupDescription in submit editor
...
It is called twice on each change to the text, and called again on
commit.
Change-Id: I8bfa2b37247a270f8b92e0b8a4e581278acf4cea
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-09-16 16:12:14 +02:00
Orgad Shaneh
2a8fa5579a
VCS: Fix line wrapping for lines that end with a dash
...
Task-number: QTCREATORBUG-8528
Change-Id: I894e562c3c6568233a85689dc1a759644779adb5
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-09-16 16:12:10 +02:00
Christian Kandeler
847f10e9cc
Remove Qt version checks.
...
Qt 5.3 is the minimum requirement these days. Remove all fallback code
from sources and project files.
Change-Id: If6188a471197acadda4d6baee71804ba1a8026c6
Reviewed-by: Eike Ziller <eike.ziller@digia.com >
2014-09-08 10:33:25 +02:00
hjk
9c152fce7e
Vcs: Collapse VcsSubmitEditorFactory hierarchy
...
Same pattern as for VcsSubmitFactory.
Change-Id: I7adb8868a83842c1b6c642db372a3624dd2e879e
Reviewed-by: Christian Stenger <christian.stenger@digia.com >
2014-09-01 10:41:21 +02:00
Orgad Shaneh
ed02e7f3c5
Git: Fix crash when returning to commit editor from diff
...
The crash happens on Linux/Xming. 2 subsequents calls to
slotRefreshCommitData occur, m_commitDataFetcher is released when the
first one is handled, and the second call dereferences NULL.
Change-Id: Ibc06fe5dd89b790ac84544f6842cbf345d118703
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-08-04 15:27:00 +02:00
Daniel Teske
540f336920
SubmitEditorWidget: Check all -> Select all
...
Change-Id: I53b7c6c5fca1f0c988e0565b7ec196301ab88b7f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com >
2014-07-10 11:47:27 +02:00
Orgad Shaneh
f3106ebafe
Git: Use a separate thread for updating commit data
...
Task-number: QTCREATORBUG-12449
Change-Id: I3057ca458272daac72c54abce1d6f9acf6a5d4af
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-06-24 12:00:22 +02:00
Tobias Hunger
956744dff8
Vcs: Do not freeze when the user starts its commit message with <Tab>
...
Task-number: QTCREATORBUG-11614
Change-Id: Ide2fe81250f3c1331a7f54be827e7dd8f551fdc6
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-03-03 12:49:04 +01:00
Orgad Shaneh
7f21e8b29f
VCS: Do not wrap lines that start with tab in submit editor
...
This breaks "Conflicts" section in Git, and possibly others
Change-Id: I821fd147194af0ce3902cedad02f373d6892e665
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2014-01-29 11:07:11 +01:00
Robert Loehning
746c5d8863
Incremented year in copyright info
...
Change-Id: Ib5423fdd064e4546f848c0b640b0ed0514c26d3a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com >
Reviewed-by: Kai Koehne <kai.koehne@digia.com >
2014-01-08 08:29:47 +01:00
Andre Hartmann
9654df9f1f
Git: Allow direct push after commit
...
Git commit dialog: Added a drop-down menu to the commit button to
execute "git push" or open the "Push to Gerrit" dialog directly after
a commit or amend.
Task-number: QTCREATORBUG-8854
Change-Id: I00ff8f816d1768e0cdaf6929126b55826788e578
Reviewed-by: Petar Perisin <petar.perisin@gmail.com >
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2013-09-30 19:20:11 +02:00
Leena Miettinen
41411165ba
Doc: use standard wording in \brief commands
...
QDoc does some magic with the \class and \namespaces
and \brief commands, so the following wording must be used:
"The xxx class yyy ..."
Change-Id: Id231f30e8464898b776888d5423523de404aae34
Reviewed-by: Eike Ziller <eike.ziller@digia.com >
2013-06-20 11:22:47 +02:00
hjk
cfc8ce8c1b
Remove changeEvent(QEvent::LanguageChange) implementation
...
This was implemented only for a small set of widgets. It's unlikely that
we will ever have or even want a dynamic language selection, until then
this code is only dead freight.
Change-Id: I1bff4e1e89057786c0e5cb57225a508c5d390d9c
Reviewed-by: Eike Ziller <eike.ziller@digia.com >
2013-05-27 08:58:51 +02:00
Orgad Shaneh
8695fe6d7c
Git: Implement "Fixup previous commit"
...
Change-Id: Ia2584ff975ed0db614dc878a70ce4adbd5c3ba67
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2013-05-04 20:01:04 +02:00
Orgad Shaneh
cb055c1d0f
Git: Simplify editor code a bit
...
* Introduce a const submitEditorWidget() and use it
* Directly use layout from ui
Change-Id: Ib566bab464d4f1c08a3f2af0edb5e1fa989c3160
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2013-05-02 16:47:19 +02:00
Oswald Buddenhagen
1fda2111d4
Merge remote-tracking branch 'origin/2.6'
...
Conflicts:
src/plugins/autotoolsprojectmanager/AutotoolsProjectManager.pluginspec.in
src/plugins/debugger/qtmessageloghandler.cpp
src/plugins/debugger/qtmessagelogwindow.cpp
src/plugins/madde/maemodeployconfigurationwidget.cpp
src/plugins/qmldesigner/components/integration/designdocumentcontroller.cpp
src/plugins/qmldesigner/designercore/include/widgetqueryview.h
src/plugins/qmldesigner/designercore/metainfo/metainfoparser.cpp
src/plugins/qmldesigner/designercore/model/modelnodecontextmenu.cpp
src/plugins/qmldesigner/designercore/model/modelnodecontextmenu.h
src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp
src/plugins/qnx/bardescriptormagicmatcher.h
src/plugins/qt4projectmanager/profilekeywords.cpp
src/plugins/remotelinux/deployablefilesperprofile.cpp
src/plugins/remotelinux/deployablefilesperprofile.h
src/plugins/remotelinux/deploymentinfo.cpp
src/plugins/remotelinux/deploymentsettingsassistant.cpp
src/plugins/remotelinux/profilesupdatedialog.cpp
tests/auto/icheckbuild/ichecklib.cpp
tests/auto/icheckbuild/parsemanager.cpp
tests/auto/icheckbuild/parsemanager.h
Change-Id: Ie465a578446a089e1c502d1cb1096e84ca058104
2013-01-31 16:25:33 +01:00
Orgad Shaneh
76f6729892
Git: Pass rows instead of files for diffSelectedFiles
...
Useful when the same file can appear more than once
(e.g. staged + modified)
Task-number: QTCREATORBUG-5347
Change-Id: I3ce716c22840c149490e00e6948612607ae57159
Reviewed-by: Petar Perisin <petar.perisin@gmail.com >
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2013-01-11 13:13:39 +01:00
Orgad Shaneh
29a93998df
Remove braces for single lines of conditions
...
#!/usr/bin/env ruby
Dir.glob('**/*.cpp') { |file|
# skip ast (excluding paste, astpath, and canv'ast'imer)
next if file =~ /ast[^eip]|keywords\.|qualifiers|preprocessor|names.cpp/i
s = File.read(file)
next if s.include?('qlalr')
orig = s.dup
s.gsub!(/\n *if [^\n]*{\n[^\n]*\n\s+}(\s+else if [^\n]* {\n[^\n]*\n\s+})*(\s+else {\n[^\n]*\n\s+})?\n/m) { |m|
res = $&
if res =~ /^\s*(\/\/|[A-Z_]{3,})/ # C++ comment or macro (Q_UNUSED, SDEBUG), do not touch braces
res
else
res.gsub!('} else', 'else')
res.gsub!(/\n +} *\n/m, "\n")
res.gsub(/ *{$/, '')
end
}
s.gsub!(/ *$/, '')
File.open(file, 'wb').write(s) if s != orig
}
Change-Id: I3b30ee60df0986f66c02132c65fc38a3fbb6bbdc
Reviewed-by: hjk <qthjk@ovi.com >
2013-01-08 10:48:18 +01:00
Orgad Shaneh
01084aaa38
VCS: Use SubmitFileModel in SubmitEditorWidget
...
Much cleaner
Change-Id: I090e5d04e5afae1023fa58eca1ef416ddc069165
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com >
2013-01-07 14:11:10 +01:00
Orgad Shaneh
34db64c752
Move SubmitEditorWidget from Utils to VcsBase
...
It belongs there
Change-Id: I4b4cdacf32b0eab299d4b2d5258cd4d91a759907
Reviewed-by: hjk <qthjk@ovi.com >
2013-01-07 13:43:23 +01:00