Commit Graph

69993 Commits

Author SHA1 Message Date
Leena Miettinen
525219e848 Doc: Update contents of Motion Design chapter
Add information about new topics in the chapter.
Add animation.

Change-Id: Idce4c1cad796d8df011afc16413126dba6f2583c
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2021-06-30 06:43:50 +00:00
Leena Miettinen
2de96b84e1 Doc: Describe fine-tuning animation quality
Fixes: QDS-4500
Change-Id: Ibb3d203210898a5c0fbdee67e30f7e148a4b1e22
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2021-06-30 06:43:43 +00:00
Leena Miettinen
279bf1e1f3 Doc: Describe optimizing animations
Fixes: QDS-4502
Change-Id: I3b7c2a64384d00cd55a75a7c4df4e4c3e49471e9
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2021-06-30 06:43:36 +00:00
Leena Miettinen
e12783326b Doc: Update info about easing curves
The Easing Curve editor can be used to attach easing curves
to transitions and animation components, in addition to
keyframes in timeline animations.

Change-Id: I5b3ae0c1818516d02e6cfacf0c87e2e4f4926f08
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2021-06-30 06:43:25 +00:00
Christian Stenger
8e1032b83c Docker: Do not use hard-coded /tmp
Amends 8c7b6a7549.

Change-Id: Ie702c7ccc5ac897920f1b8eda00dd90378a2d80b
Reviewed-by: hjk <hjk@qt.io>
2021-06-30 04:55:15 +00:00
Henning Gruendl
459b67a77d QmlDesigner: UX improvement in property editor
Disable certain geometry property controls (x, y, width, height) in
the property editor when an item is controlled by a layout or anchors.

Task-number: QDS-3209
Change-Id: Ib8e5dba17c57d67464052321e0323c9fc21539a5
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-06-29 15:12:32 +00:00
Miikka Heikkinen
64d274454e QmlPuppet: Fix imported 3D asset library icon generation
Recent changes to custom geometry handling now require that the
zoom process in icon creation does each focus step asynchronously,
so that selection box geometry has a chance to update between frames.

Fixes: QDS-4652
Change-Id: If92bf580a556a68c10d3af1406c2eabef530254a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2021-06-29 14:28:24 +00:00
hjk
89ab11d539 ProjectExplorer: Short-circuit ProcessParameters::effectiveCommand
... in case of remote commands.

This is enough for docker related searches for now, on the other
hand, Environment::searchInPath is not yet generic enough to cope
with remote searches.

Add a FIXME so this is not forgotten.

Change-Id: I97f3c75069a17256c83dc9f8a73ae1c1c235465f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-06-29 14:12:57 +00:00
Leena Miettinen
a43c91b16d Doc: Document locator filters for version control systems
Only Git was mentioned this far. Only Git is supported by
QDS, so use conditional text.

Task-number: QTCREATORBUG-25642
Change-Id: If2c27bd5def8c4e4bee30558174127024458449a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-06-29 13:55:51 +00:00
hjk
eb7b5ea34e Docker: Improve logging a bit
Most logged items span more than one line, so be generous with extra
newlines.

Also, complain only about when host-local read access into the
docker device ist not possible, writing is generally done only
in the separately mounted places after re-mapping to host-local paths
in the host file system.

Change-Id: I5525749dfb880d4dc3547f86de43314567e92b4d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 13:48:13 +00:00
hjk
1afe21d41e Docker: Make mounted volumes user-configurable
Still use the so-far hardcoded "/opt" and "/data" as default, i.e.
not the intended final setup which should at least pick up
the source and build dirs automatically.

Change-Id: If632f3f5a6e824a952938c97336df8ff58b39d67
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 13:48:05 +00:00
Christian Kandeler
29704e60b0 Designer: Fix "Go to slot"
Amends 8dc4cb17c1, where we forgot to actually open the file in case the
slot already exists.

Fixes: QTCREATORBUG-25843
Change-Id: Idd9395f5bf72418043f917fd70bc3d6569b4f2fd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 13:43:17 +00:00
hjk
d8bd855c02 CMake: Use FilePath::dirEntries file api parser
Change-Id: Id83284518029414721cf1a44111d8f63cae9246f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 13:16:53 +00:00
hjk
b8e6d05ded Utils: Also pass Sort flag to FilePath::dirEntries
Change-Id: Ic21c2ba3ef59c6bb3e19552904187b3c6a096d80
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 13:16:46 +00:00
Leena Miettinen
bddcf63da9 Doc: Document Help > Contact command and dialog
- Move All Topics to the top of the page
- Create a list of ways to contact the team

Task-number: QTCREATORBUG-25642
Change-Id: Ie18cd3ba397f8cf1b3101692713f411d03b25098
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-06-29 12:53:40 +00:00
Christian Kandeler
4e777fcf90 Clangd: Make "Follow Symbol" more robust
The AST is only needed for virtual function disambiguation, while the
basic functionality works fine without it. So in case clangd fails to
retrieve the AST node for some reason, just use the original "go to
definition" result.
This also makes "Follow Symbol" work with clangd < 12.

Change-Id: I2c110e9a51b01dc912fcdf6f4ed45fce766df374
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-06-29 12:50:33 +00:00
hjk
d857e17b13 CMake: Use FilePath::ensureExistingFile in file API
Change-Id: I38c2e97711bbc1c72c51eeb59429572ea7931e4d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 12:35:02 +00:00
hjk
1e1c556bc8 Utils: Add a FilePath::ensureExistingFile
Essentially a kind of 'touch', to be used in the CMake file API.

Change-Id: Iaae62b441c0006b39d4bef5f06420e798c28c2a5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 12:34:43 +00:00
Miikka Heikkinen
b058b6e841 QmlPuppet: Add separate set of qml files for Qt6 for 3D editor
Import QtQuick3D 1.15 no longer works in Qt 6.2, so provide a separate
set of qml files for each major Qt version.

Fixes: QDS-4642
Change-Id: I3e17fb248f71f87fb9a40dcad3c03e037cafb0f4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-06-29 12:03:57 +00:00
Miikka Heikkinen
48348b8dc4 QmlPuppet: Change custom 3D geometries to use public API
Custom geometries often break and code becomes convoluted with
version ifdeffing, so refactor the custom geometries to use public
geometry api, which works both in Qt5 and Qt6.

Fixes: QDS-4611
Change-Id: I2d78776a14d5c8153b52806842254dbedb5de83d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2021-06-29 12:03:51 +00:00
Miikka Heikkinen
a86c480d50 QmlDesigner: Fix warnings about using anchors for layouted items
Using anchors for layouted items is undefined behavior, so fix those
instances in GradientPresetList. These also caused crash at design
mode open when building against Qt 6.2.

Fixes: QDS-4647
Change-Id: I801ce4c98c6cda74be522c73c4e1eb5bef7c7e1b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2021-06-29 12:03:45 +00:00
Cristian Adam
4c07f10d33 CMake: Fix compilation build with older CMake versions
Change-Id: I86dbff49cf5d00bf75d2e32154db2d3d254e2b17
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 11:17:49 +00:00
Andre Hartmann
a659f445c7 Debugger: Escape special chars in line annotation
By re-using the existing function quoteUnprintable()
and moving their code as escapeUnprintable() to
watchutils.

In contrast to the watches window, where the escaping
can be disabled by the context menu, the line annotations
are always escaped for simplicity.

Change-Id: I76adfd7cd70ec92ff0d7f7ea41fc30ae0057cad0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-06-29 11:09:04 +00:00
hjk
4271b3a299 Docker: Bark if there is no container before trying to run on it
Change-Id: I64bee9901a515d46aa18e35d5e4a26f9105519ea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 10:34:12 +00:00
Christian Stenger
75ffccad0b Docker: Make usage of UID and GID configurable
Make it optional to use UID and GID of the current user.

Change-Id: I1a7eeaba0cfae204b05f0ab4d409d965b8fc09ef
Reviewed-by: hjk <hjk@qt.io>
2021-06-29 10:21:36 +00:00
Miina Puuronen
d5182a890a QmlDesigner: Disable Asset Library context menu when not needed
Assets Library context menus options are now enabled only when needed
and disabled otherwise. Also some renaming etc.

Task-number: QDS-4628
Change-Id: I5b2c4209f8389e51cf3f5e470bc14e5f9ffc1f29
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2021-06-29 10:13:37 +00:00
hjk
13ad1351b0 Utils: Add QtcProcess::setStandardInputFile
Needed for SshProcess.

Change-Id: Id3c8ca0cc86d7a515371fb3651e2d186cbea4df6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-06-29 10:08:35 +00:00
hjk
5ead2afeeb Utils: Implement FilePath::removeRecursively
Sprinkle a few QTC_ASSERT to make sure we are in a known
context.

Cmake's FileApiReader uses this before moving directories
as QFile::rename does not do anything if the target exists.

Change-Id: I555f99e81a9fe7d93ae66145eeebfa9d5880bc51
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 09:34:28 +00:00
Mahmoud Badri
5470385085 QmlDesigner: clear assets selection on focus out
Fixes: QDS-4625
Change-Id: I4a9ab829522d66e3644bba7d43845bbe82d0773b
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2021-06-29 09:08:00 +00:00
hjk
24190d9c0b CMake: Use local paths with file system watcher
Change-Id: I6eb831255f90b56115a5c5d79175a8985052ff83
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-06-29 08:58:25 +00:00
Christian Kandeler
117fa35e00 Clangd: Ensure open document for "Send Goto Implementation" requests
Fixes: QTCREATORBUG-25861
Change-Id: Ied14b3ad129b205b05653a40c249a0a339ab686a
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-06-29 08:37:06 +00:00
hjk
b26fb834a8 Docker: Use categorized logging for DockerDeviceOperation
Change-Id: Ib9aa32c65bd38b4b72b356603182e84ce5672e91
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 08:35:32 +00:00
Henning Gruendl
3f5130ef2c QmlDesigner: Update SplitViewSpecifics
Change-Id: Ibb22bd5648b66c4fd12eb8a97f84d5eaa6a33670
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-06-29 08:29:57 +00:00
Henning Gruendl
3ac25411b4 QmlDesigner: Update layout specifics
* Update GridLayoutSpecifics
* Add missing Row-, Column- and StackLayoutSpecifics

Task-number: QDS-4648
Change-Id: I8d9c48ea7cfa4a33a84a9f2c039cca0c0b10f62b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-06-29 08:29:42 +00:00
Henning Gruendl
5f8e344a7d QmlDesigner: Update alias icon in navigator
* Replace the aliasOn/Off icon in the navigator with alias icon
* Change color for alias icon in Property Editor so it will match with
  the navigator

Task-number: QDS-4646
Change-Id: Idda5e62dac527c645c7c7b9de9c8b448087f31a7
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-06-29 08:29:21 +00:00
Alessandro Portale
eeccdd4839 Android: Remove size constraints of the "New AVD Dialog"
This removes minimal/maximal sizes of the dialog. Unjustified size
restrictions cause poor UX.

The initial dialog width is increased from 600 to 800 px.

Fixes: QTCREATORBUG-25846
Change-Id: I306fbacba2a833f0c9a3bd6a23c6ff9a1bba9c3b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2021-06-29 08:04:25 +00:00
Christian Stenger
acec1a3a03 Docker: Pass on working directory only if provided
Change-Id: I9ae62b441c0006b39d4bef5f06420e798c28c2a5
Reviewed-by: hjk <hjk@qt.io>
2021-06-29 07:34:48 +00:00
Christian Stenger
ca1ce3a1ba Docker: Silence assert
We query the device with executables that may or may not exist.
So, expect the call to fail if the image does not contain the
respective executable in PATH.

Change-Id: Iff43879c72155de8a8a9276e26085d03ead61f2f
Reviewed-by: hjk <hjk@qt.io>
2021-06-29 07:34:41 +00:00
Christian Stenger
8c7b6a7549 Docker: Use directory commonly existing
Trying to use /tmp on Windows ends up in a failing process call
as this directory usually does not exist.

Change-Id: I80a5e45c474d3fe6ff6f2ede67837722cb59078a
Reviewed-by: hjk <hjk@qt.io>
2021-06-29 07:34:33 +00:00
hjk
9f29b9e31b Docker: Use id of current user to run the container
This ensures typical files created in the build process are
accessible and removable(!) by the user outside.

Downside is that some commands (e.g. whoami) won't work well
within the container as that user typically is not listed in
/etc/passwd etc. inside the container. Buildsteps requiring
them won't work until the container image is (re-)created with
this data in place.

In general, there seems to be no silver bullet for this problem.
An extensive discussion of pros and cons can be found at
https://jtreminio.com/blog/running-docker-containers-as-current-host-user

Change-Id: I0421e031324ffe3d64b9aeede289a43357c46e3d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 07:30:09 +00:00
Christian Kandeler
6f5e20bf64 ClangTools: Fix applying check options
The algorithm we used to determine whether an option was applicable did
not take the wildcard syntax into account that is used when all sub-
checks of a group are enabled.

Fixes: QTCREATORBUG-25827
Change-Id: I1d385bcc90ea9bf0bfac5cffe8739a8148aa740f
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-06-29 06:59:21 +00:00
Christian Kandeler
74385cc10c ClangTools: Make sure URL for clang-tidy checks is always correct
Fixes: QTCREATORBUG-25902
Change-Id: Ifadb6c90cf9a86fc4efb734d6105217b70f9419d
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-06-29 06:58:58 +00:00
Alessandro Portale
bf6f446a35 Tracing: Fix build of tst_flamegraphview.cpp
Change faulty include from system to local

amends: 3ebe5dbb99

Change-Id: I466e683137b5e95f5b70fb2efa3dda1a77af8a04
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-06-29 05:51:29 +00:00
David Schulz
922f9b159d LanguageClient: fix diagnostic document revision check
We track the document revision in the client nowadays.

Change-Id: Ia55bc7cd5eaf100fb19953ca71e8de8f43ae3266
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-06-29 04:49:50 +00:00
David Schulz
44f0f9ae18 Clangd: use special value text for automatic worker count
Change-Id: Iddb75b6716724b5994d8093a8e389f5cb8e2d044
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-06-29 04:45:47 +00:00
Cristian Adam
2d08b296b7 CMakePM: Remove wishlist comment
The comment is no longer valid.

Change-Id: Ica19e26039e147ccdd77559cc85bfcb5e784b68c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-06-28 17:45:13 +00:00
Alessandro Portale
bb8aa12cbc PerfProfiler: Add qml, register types via qt_add_qml_module
Use the CMake-based qml API to create the "QtCreator.PerfProfiler"
module.
This uses qt_add_qml_module, which was introduced with Qt 6.2.

For Qt 6.1 and below, everything compiles and runs like before this
change.

Change-Id: I7e3a9e544e52592b5daf0117ce415583ab97dafe
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-06-28 15:06:50 +00:00
Alessandro Portale
9624d2cd69 QmlProfiler: Add qml, register types via qt_add_qml_module
Use the CMake-based qml API to create the "QtCreator.QmlProfiler"
module.
This uses qt_add_qml_module, which was introduced with Qt 6.2.

For Qt 6.1 and below, everything compiles and runs like before this
change.

Change-Id: If381059bbf2a0a2b92c7f62e6da3142036ac6bbc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2021-06-28 15:06:45 +00:00
Alessandro Portale
3ebe5dbb99 Tracing: Use qt_add_qml_module for tst_flamegraphview
Use the CMake-based qml API to create the
"QtCreator.TstTracingFlameGraphView" module.
This uses qt_add_qml_module, which was introduced with Qt 6.2.

For Qt 6.1 and below, everything compiles and runs like before this
change.

Change-Id: I7b1d7109c5fcff55c7be4b431f21281a63d13332
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-06-28 15:06:39 +00:00
Kama Wójcik
45b41a04c3 QmlDesigner: Fix layout and tooltip
* Fix layout for AnimatedImage
* Fix tooltip for Animation section

Change-Id: Ibdcc2e34317555396ad51fbf873dfcee1adbcf55
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-06-28 14:56:37 +00:00