This will allow us to just parse the postfix without fileName
extraction.
Change-Id: Ied6b80f25078473e2b91ced68913205a17f9068e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Hover was not working on LibraryHeader.qml. There seems to be some issues
between QQuickWidget and QML Item. Header width and height are now set with
m_headerWidget instead of root Item.
Fixes: QDS-4387
Change-Id: Ic587be319bb7aa6755fa26f6211ce11eb9795c67
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Qt nowadays supports ARM64 builds using MSVC. While running from Creator
is not possible, support of building projects can be done with this
patch.
Change-Id: I39eed497b222a05b01af7f251e933432afca0cef
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Check if asyncScanForFiles returns true, which means it added
a future, which then can be used for Core::ProgressManager::addTask
Task-number: QTCREATORBUG-24564
Change-Id: I347c027e676023a782e7d4822fe2d51385888a64
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Move it from EditorManagerPrivate::openEditor to the
EditorManager::openEditor overlaod that take a QString so no line or
column number should be passed via FilePath now.
Change-Id: Ia98058195045cbe555fb6a15c1010057746051d8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
We can do better than just "qmake" and instead take the path to
the qmake that the test was compiled with.
(Can still be overridden with environment variables.)
Change-Id: Icc045d4f96946aeb1f324e6f1334dc9747215f3f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This is something that requires a close look when we update the
meta system.
Task-number: QDS-4407
Change-Id: Ibb2bc79142bd4ae166c47ac261a3fe2aa5464a57
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Same layout, effectively the same purpose
Change-Id: I742d85ed06c07009ebb9696734f00894275859a3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It would only run exactly from the Qt Creator build directory.
Change-Id: Ifd105bdaab7405f93b6fb6084a85014fc4023b2f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The conan toolchain.file was not passed to the cmake process that
was setting up conan install, only inside for conan.
Task-number: QTCREATORBUG-21785
Change-Id: I5f315e7de823d4ef3237081da9b294b236fedebb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
QTCREATORBUG-25667 appeared a few Months back in corellation to a
seemingly unrelated change, and I was much later scratching my head a
day or two.
Therefore, it should be fine to have a test for the usage of
SynchronousProcess::runBlocking with interactive cli processes. Those
cli processes might output lines without terminating \n or \r and thus
hang until timeout.
We are IMHO lacking process IO tests, anyways.
Task-number: QTCREATORBUG-25667
Change-Id: I3b7ea471b2ac9fa4554f0ce51752ce54c4a7d304
Reviewed-by: hjk <hjk@qt.io>
Exit code handling can break during refactorings. This addition to
tst_QtcProcess tests negative, zero and positive exit codes of sub
prcesses that are launched asynchronously and synchronously.
Change-Id: Icbcc036d3fda7fa681958b57fd0a6f67d3a90352
Reviewed-by: hjk <hjk@qt.io>
extend_qtc_test should gracefully do nothing if the test was declared,
but disabled for any reason.
add_qtc_test failed to add the test to the list of declared tests, if
dependencies were missing, so extend_qtc_test was complaining that the
test didn't exist in that case.
add_qtc_test must always add the test to the list of declared tests, and
extend_qtc_test must only fail if the test was never declared, but do
nothing if the test target does not exist (because the test was disabled
for some reason).
Change-Id: I414a169e3e23c3c0e11c11e2ee86effa706b545c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Fix the location of the controls in Library.
Fixes: QDS-4379
Change-Id: I998950722d1068fd5eadc974664bf8f8d759f8f6
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
By using the "offscreen" platform plugin we can get away by not
having an X sesion for the default "xcb" plugin.
Change-Id: Ie274036f9f3efb2ec37a8dcbc0feb8a847788500
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Long term plan is to make that part of QtcProcess proper (removing
the QProcess base of QtcProcess, have a QtcProcess * in the private
data instead, and reap that e.g. on QtcProcess instance destruction.
Change-Id: Ic7e60fdd69f56e8e22bad3dfbc246e7de2fe9cd4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
They may differ in a containerized setup.
Change-Id: Ib7e60fdd69f56e8e22bad3dfbc246e7de2fe9cd4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Still some missing bits as some QString members had different meanings
depending on their context.
Change-Id: Ib48eab54498974a26bbd5123cbffeefee5f7e79c
Reviewed-by: hjk <hjk@qt.io>
For synchronous retrieval of the system environment of the device.
Change-Id: I057f9591866b72e37733d495a2a6b203fae91ac4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
After that, all Core::Reaper::reap are operating on QtcProcess
instances. That would allow for moving this into QtcProcess and
making some more widespread uses easier.
Change-Id: I7a8f3a0b63997ae4c883b723197d9f480a9506f8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If the view is not attached we should not access a nullptr.
Task-number: QDS-4382
Change-Id: I885f2b1b810d4ffd7b87749ca50e06cbdac3a7e2
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
If the view is not attached we should not access a nullptr.
Task-number: QDS-4382
Change-Id: I885f2b1b810d4ffd7b87749ca50e06cbdac3a7e2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... and add a QtcProcess::systemEnvironmentForBinary(filePath)
redirecting to IDevice::systemEnvironment() of the device implicitly
given by filePath. A device implied by e.g. a qmake binary or a compiler
binary is a common scenario.
Change-Id: Ieb2c724ae66f1a1752132e4e4648a604390ca369
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
QtQuick3D doesn't support both rotation and eulerRotation set on same
node, so we delete existing quaternion rotation if user sets an euler
rotation to the node. If node has quaternion rotation animation,
we block any change to eulerRotation in the node.
3D editor also disables the rotation gizmo for blocked nodes.
Task-number: QDS-4335
Change-Id: I4ce7b022c732a9547751f101548ecea948279db8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
It leads to unexpected results especially because any slash at the end
is removed, and also behaves differently to the other path methods in
ICore.
Amends 8e352af0ec
Change-Id: Iae3417d5a5e57bcef7ce4cdb368567ccd8fdc4c4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
It may happen that the old task was canceled and still running
while the new task was started. Later, when the d'tor is called
both old and new tasks may still be running. Before we waited only
for the new task to be finished in d'tor. Now we are waiting
for all tasks to be finished.
Amends: 7fb592fe0c
Task-number: QTCREATORBUG-25709
Change-Id: Id4b44cd36ee03aa45472b15d8fbb25a2cab77e92
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
There are no real reasons for doing this. In addition,
QmakeBuildSystem::destroyProFileReader() destroys it in
different thread that it was created in - for QObject
it could be a potential issue.
Change-Id: Ib958ea0f4ef3a9aeee92045eb430183207afe6c9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Starting creating custom qmakeRunEnvironment() with systemEnvironment
in derived classes without further context breaks down in cases of e.g.
containerized builds.
So instead create the base environment outside where the context is
clear (still wrong after this patch) and let the derived class only
apply the changes they need to an otherwise unspecified environment.
Change-Id: Ibb23844f490ce86d8a89f6ce728faff65865c09b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The default maximum size is 2MB which is quite small for bigger
transactions. Increasing it to 100MB will give sqlite enough memory
so it doesn't need to swap that often. This is not important for
reading because we use mmap.
Change-Id: I9a07bbd8f1ce594e66b46936480d69b0fb8c3d84
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
