Path macros were expanded when applying new paths in the
McuSupport options widget, but not when pushing the reset button.
This resulted in paths like {Env:PROGRAMFILES}/SEGGER/JLink,
which are displayed as an error in the UI. The reset-button is
now connected via a signal in McuPackage to the options widget,
since the macro expander is not accessible to the package object
directly.
Task-number: QTCREATORBUG-28500
Change-Id: I962c6eb83142be87e02debbf34f0602683fe6966
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Make it of std::optional<Utils::Link> type.
Use it for:
1. Removing duplicates
2. Showing link inside editor
Before, QVariant internalData was used in above cases.
Rationale:
1. Removing duplicates between results from different
ILocatorFilter makes only sense if accept() overload
for these filter types are the same (i.e. the implementation
is repeated). Otherwise, we are loosing some functionality
when some result is removed. Taking into account that
original intention was to eliminate duplicates for filters
where we do BaseFileFilter::openEditorAt() inside accept(),
we store linkForEditor in 3 cases (instead of storing
internalData):
- BaseFileFilter
- FileSystemFilter (only existing file case)
- OpenDocumentsFilter
We don't save a linkForEditor where we stored QString
inside internalData in the following cases:
- JavaScriptFilter
- FileSystemFilter (non existing file case)
Before, in above cases, we could have filtered out
some results unintentionally. This patch should fix it.
Now, we remove duplicates only for enties that have value
for linkForEditor.
2. Use directly linkForEditor, if exists, for opening editor.
This patch aims to decrease the number of different
responsibilities of internalData by 1.
Make 3rd arg of LocatorFilterEntry c'tor default.
Change-Id: I144c58661d7456bb5991f8077dc103272dfab194
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Do not stop at the first statement of the script
when performing "normal" debug, stop at the first
break point instead.
Preserve the original behavior when debugging by
triggering "Start and Break on Main".
Task-number: QTCREATORBUG-28732
Change-Id: I3022071f28c086a2d0787ca5873e611f77e28369
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Prepare toolchains for usage. Basically parameterize function
to be used with more than one version and make use of it.
Change-Id: I30ee198302de54d933fa7c436e701273d497cc07
Reviewed-by: David Schulz <david.schulz@qt.io>
This allows to hide setting categories by id.
For example:
HideOptionCategories=C++, Debug, Designer, Kits, BuildAndRun, CPaster, LanguageClient, Version Control
Change-Id: Ifeacbf7885fc2d51ef262fdb8bbbfc81f52bce53
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The focus grabber mouse area was interfering with mouse cursor on
controls under it. There is no need to have grabber cover the search
box, as clicking search box anyway moves focus.
Task-number: QDS-9163
Change-Id: Ie2487296914a893dfc658ff8178963233a50c467
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Ealier we state that nullptr should be used, and that is the current
policy.
Change-Id: Id462458f36893354a4f95e086d25a946f94b495e
Reviewed-by: hjk <hjk@qt.io>
The supported compiler are stated in the README, no sense in replicating
and maintaining that information here.
Back then it made sense to differentiate between "C++" and "advanced C+
+(11/14), but nowadays that separation is artificial, it all is "C++
features".
Change-Id: If67274566776ccd37bd20e925531405628edeb47
Reviewed-by: hjk <hjk@qt.io>
.clang-format contains some disallowed values for some fields. These
fields are corrected according to ClangFormatStyleOptions.
Change-Id: I32a40cdfeabee550ebf23f6c9cb3d1fafc3b764b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Previously the checks for the mode bits were incorrectly
using AND checks. As a fix the contents of "stat.h" was
copied and converted so it can be used directly and on
platforms that do not contain stat.h
Change-Id: If735dcffb8ffc490d297dae7f8c43ae01e79f460
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
The plugin is now enabled by default. Clang Format can be disabled
either globally or at project level without disabling the plugin.
Task-number: QTCREATORBUG-28721
Change-Id: Ifbc0418400ed8a7942d0dbceaa95b078ac897c49
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
- doesn't make sense to translate "%1"
- showPreprocessedFile: "reason" contains full stop, put at the end
- add missing closing >
- remove whitespace at the end of translated string
- added missing quotes and full stops
- Remove some control text from tr
Change-Id: I5537c3d12d038e25e2209af1198129fbf959b43c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Directly display the containing value without the need to expand the
variant. Additionally fix the dumper for Windows and add tests.
Change-Id: Iaae49470750fa3659339331e1518e13020df7938
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The path to the Qul SDK entered in the settings path persisted in
the UI when re-opening the settings page, even if it was not
applied. Kits and the settings file are not affected unless
pressing apply so this did not affect functionality. Un-applied
changes are discarded by re-reading the path from the settings
file in the constructor for the settings page.
Task-number: QTCREATORBUG-28568
Change-Id: Id03be22fba429e4764493cd3bedf45faa6908637
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
