Commit Graph

173 Commits

Author SHA1 Message Date
hjk
fd8bf48b2b debugger: start tightening the breakpoint state machinery 2010-11-16 17:09:55 +01:00
hjk
d7a75dff9e debugger: breakpoint code cosmetics 2010-11-16 12:43:17 +01:00
hjk
0a004097e1 debugger: remove intermediate BreakpointData stucture layer 2010-11-16 11:48:43 +01:00
hjk
694503cc76 debugger: looks like the BreakpointData layer is going to be unneeded. 2010-11-16 11:09:09 +01:00
hjk
3cf3f14d7f debugger: more breakpoint refactoring 2010-11-16 10:50:26 +01:00
hjk
62c7a110ab debugger: code cosmetics 2010-11-16 10:50:26 +01:00
hjk
76d2c58161 debugger: move marker filename and linenumber to BreakpointItem 2010-11-16 10:50:26 +01:00
Friedemann Kleint
29beabd5a4 Debugger: Handle throw/catch/main as BreakpointType enum values.
Remove BreakHandler::hasPendingBreakpoints, handle new types
in CDB and gdb. Start fixing Breakpoint-Dialog.
Add assignment of Breakpointresponse from BreakpointParameters.

Reviewed-by: hjk
2010-11-16 10:23:20 +01:00
hjk
146b2f0561 debugger: don't store watch points in session 2010-11-15 18:49:16 +01:00
hjk
f9cd211d29 debugger: fix setting of breakpoint types on session loading 2010-11-15 17:26:07 +01:00
Friedemann Kleint
9fc5970bdb Debugger: Introduce BreakpointParameters as base struct.
For Breakpoint data manipulation.

Reviewed-by: hjk
2010-11-15 17:04:29 +01:00
hjk
50dc4d8664 debugger: update display on engine exit 2010-11-15 16:58:23 +01:00
hjk
ef0073f17d debugger: BreakpointByFileAndLine is default when loading sessions. 2010-11-15 16:24:34 +01:00
hjk
0b32820a48 debugger: work on breakpoint enabling/disabling in gdb engine 2010-11-15 16:22:51 +01:00
hjk
a3923f8c24 debugger: re-enable "Delete all breakpoints" etc 2010-11-15 15:31:05 +01:00
Friedemann Kleint
30d6ae0e3d Debugger: Make CDB compile again. 2010-11-15 15:24:47 +01:00
hjk
4d1cd647b4 debugger: code cosmetics; fix toggling breakpoints using the editor context 2010-11-15 15:20:39 +01:00
hjk
7c337614a8 debugger: show disabled breakpoints again 2010-11-15 15:05:39 +01:00
hjk
a3b1ee1cb4 debugger: add some description to breakpoint states in tooltip.
FIXME: add translations once interface has stabilized.
2010-11-15 14:35:19 +01:00
hjk
482db08b00 debugger: move breakpoit tooltip from BreakpointData to BreakpointHandler
It also shows the response data.
2010-11-15 14:27:06 +01:00
hjk
956b54289e debugger: make BreakpointData and BreakpointResult proper value types 2010-11-15 14:12:34 +01:00
hjk
b02c71e926 debugger: collect breakpoint related data in a single hash 2010-11-15 13:12:37 +01:00
hjk
c6d3f08550 debugger: add forgotten ignoreCount accessor implementation 2010-11-15 12:32:51 +01:00
hjk
8ae541b36f debugger: Refactor breakpoint handling.
The breakpoints are now (fairly) tightly guarded by the BreakpointHandler.
Engines and Views are only supposed to refer to them by id. They also have
individual states now. The breakpoint data is split into a "user requested"
"fixed" part in BreakpointData and the engines' acknowledged data in a new
struct BreakpointResponse.

TODO: Move m_state and m_engine members to BreakpointResponse. Fix regressions
in the marker handling.
2010-11-15 12:09:25 +01:00
hjk
89eb27d231 debugger: remove some dead code 2010-11-10 14:36:53 +01:00
hjk
2161e0f6d9 debugger: refactoring of the plugin interface
There's  some 'external' and some 'internal' part now. Other plugins
are only supposed the external interface.
2010-11-10 12:08:23 +01:00
hjk
1afea78c7d debugger: convert register handler/window architecture 2010-11-05 13:51:02 +01:00
hjk
8e62715130 debugger: move logical ownership of breakhandler from engines to plugin 2010-11-04 09:55:05 +01:00
Friedemann Kleint
22f03cbde6 ProjectExplor/Debugger: Header cleanup 2010-11-02 16:14:00 +01:00
hjk
0afb34d5eb debugger: refactor breakpoint type, add function name to resolved jsbreakpoints 2010-10-29 14:31:16 +02:00
Arvid Ephraim Picciani
2a569ce073 Clean up BreakPoint
Reviewed-by: Friedemann Kleint
Reviewed-by: hjk
2010-10-29 11:29:37 +02:00
Friedemann Kleint
923c907d2e Debugger: Fix slashes in breakpoint display.
Reviewed-by: Arvid Ephraim Picciani <arvid.picciani@nokia.com>
2010-10-18 14:54:42 +02:00
Robert Loehning
d74c4f8aeb Fixed warning about unused parameter in BreakHandler
Reviewed-by: hjk
2010-10-15 15:33:34 +02:00
hjk
cc0e37cec5 debugger: replace n breakpoint lists of which n-1 are invalid by a single one 2010-10-13 17:44:23 +02:00
hjk
b0852c28db debugger: fix re-appearing zombie breakpoint markers
Reviewed-by: con
2010-10-13 17:44:23 +02:00
hjk
3cb91a1427 debugger: Fix state of breakpoint marker when disabling it using the breakpoint view
There was not updated cached state within the marker object.

Reviewed-by: Friedemann Kleint

Task: QTCREATORBUG-2544
2010-10-11 11:54:01 +02:00
hjk
6f35c937ca debugger: fix breakpoint marker drawing after session ends
This is a stop-gap measure to make breakpoints usable again.
Proper fix is still needed.

Reviewed-by: Friedemann Kleint
2010-10-06 15:00:47 +02:00
Friedemann Kleint
90872c632d Debugger[CDB]: Fix breakpoints.
Reviewed-by: hjk
Reviewed-by: aep <arvid.picciani@nokia.com>
Task-number: QTCREATORBUG-2612
2010-10-06 13:39:21 +02:00
hjk
7ad324feb3 debugger: more breakpoint fixes 2010-10-06 11:05:40 +02:00
Friedemann Kleint
ec6b90aac6 Debugger[CDB]: Make breakpoints work again.
Reviewed-by: hjk
2010-10-05 16:39:07 +02:00
hjk
d0848ee29a debugger: fix breakpoint cleanup to allow subsequent runs
Reviewed-by: Friedemann Kleint
2010-10-05 16:06:41 +02:00
Christiaan Janssen
24912c3f2e QmlObserver: breakpoint list is shared between engines
Reviewed by:  Kai Koehne, Andre Poenitz
2010-10-05 11:01:14 +02:00
Friedemann Kleint
d5596bf169 Debugger: Remove unused 'precise breakpoints' setting.
Remove break window menu action to toggle 'Full path'.
Remove gdb setting 'Use full path'.
Clean up break dialog:
- Set PathChooser::ExpectedKind before value (showed up in red).
- Use PathChooser::setPath()/path() instead of lineedit text
- Return thread spec
- Add validator for ignorecount as for breakcondition.ui
Remove unused fields from breakcondition.ui

Reviewed-by: hjk
Task-number: QTCREATORBUG-2593
2010-10-04 16:04:38 +02:00
hjk
b8d5f256a0 debugger: add missing 'Use full path' toggle in recently added 'Add Breakpoints' dialog
Reviewed-by: Friedemann Kleint
2010-09-28 13:15:36 +02:00
hjk
718433d27e debugger: add a somewhat more generic breakpoint creation dialog 2010-09-21 16:33:14 +02:00
Friedemann Kleint
332889aec2 Debugger: Sanitize Datatypes, part 1: Breakpoints.
Make address a quint64, linnumber and ignoreCounts int.

Reviewed-by: hjk
2010-09-21 14:26:45 +02:00
Friedemann Kleint
f7b19f8114 Debugger: Move DebuggerEngine/QmlEngine/QmlCppEngine into Debugger{}
namespace (from Debugger::Internal) as they are exported classes.
Introduce private classes to avoid exposing private JS debugger
headers.
2010-09-13 13:30:35 +02:00
hjk
7528b3b022 debugger: fix editing of breakpoint conditions 2010-09-08 12:18:04 +02:00
hjk
15fc9396b5 debugger: allow breakpoint removal also at the original position, not the "acknolegdged" one
Task-number: QTCREATORBUG-2264
2010-09-08 09:54:40 +02:00
hjk
18d14b5367 debugger: remove unused code. 2010-09-08 09:10:05 +02:00