Using more *::Constants::ICON_* where it makes sense and
wrapping the file names into QLatin1String where they were
missing.
The increased usage of the ICON constants needed a few more
cross plugin includes of *constants.h, here and there.
I think that it is OK, since the dependencies were alredy there
icon resource wise.
This fixes QTCREATORBUG-1434, but it's more of a workaround than a fix.
The problem was that the file was opened in the diff editor due to a
broken diff detection, and the diff editor in turn has a bug in that
it's kind of halfway read-only.
Reviewed-by: ossi
Task-number: QTCREATORBUG-1434
* Use id() for methods returning a string used to represent
some type of object.
* Use displayName() for strings that are meant to be user
visible.
* Quieten some warnings while touching the files anyway.
* Move Factories to their products in the plugins where that
was not done before.
Reviewed-by: dt
The actions are already lazily instantiated in
TextEditorActionHandler::setupActions(), so there should be no need to
call initializeActions() in all plugins on startup. Only the main text
editor plugin will still initialize its actions, to make sure the menu
items are there.
This stuff was all over the place, a relic from before the editor
settings were unified. Now the initialization is only done in
TextEditorSettings.
Fixes the .pro file editor and the generic project files editor, which
before only used the font settings.
Now reuses the colors set for Type and Keyword for the variables and
functions respectively. Having the categories Variable and Function in
the fonts and color settings was confusing.
