- Do not block starting the puppet processes while waiting for the reply
- Remove unnessecary connection.clear() from ConnectionManager::shutDown
since this was already done in closeSocketsAndKillProcesses
- Remove Timers from ConnectionManager::closeSocketsAndKillProcesses
since they leak memory and termination of the processes is done in
QProcessUniquePointerDeleter
- Remove second deleteLater from QProcessUniquePointerDeleter since this
is handled by the connection to the finished signal
Change-Id: If845ea44f483c5d3c646595ff9298bcdd3dfd59a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Moved beginResetModel/endResetModel calls out of
ItemLibrary::updateVisibility into the calling functions.
This way endResetModel is not called twice in ItemLibraryModel::update.
Change-Id: I9588ba97aeb9da7c5a629612c9b3dc6315859501
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This looks more in sync with other dialogs that we display.
Change-Id: I445da900982b7bdcc12d810e69170b0a7695b30c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Using nodeLength(node) is very slow, while searching for the next closing
bracket is nearly always sufficient.
Task-number: QDS-6110
Change-Id: I22f710f4cf90302192285a8cadd6ea6fc698b2a6
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The "Generate setup code" check box executes C++ code before
any of the QML tests are run.
Task-number: QTCREATORBUG-26741
Task-number: QTCREATORBUG-26610
Change-Id: Ica4d0391e3624196b3327267f5a3082ca57b58cd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Helps to detect clang on docker devices.
Change-Id: I9340900e205e767d8b058f6e69c61abf41c25726
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Update the text and screenshot.
Task-number: QTCREATORBUG-26610
Change-Id: Ie35f3b6885df49029ac0dbc54677e9e6f472d2c4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This increases the delay from 400ms to 800ms until
the model and GUI is synced with the QML code.
This means the user has to stop typing for 800ms
until the form editor and property editor are updated.
Change-Id: Ia250dec39cd8051d25619310024b718ad1cf9815
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The recently added "Select All" button needs to be included in the
width calculation.
If the find buttons switch to icon mode, "Select All" gets hidden.
Also, if the replace buttons are visible, they define whether all
buttons are shwon in full text or get hidden. No icon mode at all in
that case.
Change-Id: Ie85a68c7f7c3f1a6ca51ed3f91d64124eeb7aa1a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Pass the parent calling object to the addAction() functions and use a
queued connection. This prevents the following sequence of events:
1. The menu is dismissed when selecting a menu item.
2. The deletion gets queued via deleteLater().
2. The onTriggered action gets invoked and opens a dialog box.
3. The dialog box triggers the events to be processed.
4. The menu is deleted when processing the events, while still in the
event function to handle the dismissal.
This only affected the watch menu since the others were leaked. Added
cleanup handlers for the other debugger menus to avoid leaking them.
Task-number: QTCREATORBUG-26989
Change-Id: Ifa2c52d7bea884c55d43fa545e3e2870301e4052
Reviewed-by: hjk <hjk@qt.io>
On some systems IMPORTED_LOCATION isn't set, but configuration-specific
locations like IMPORTED_LOCATION_RELEASE are. In these cases, fall back to
the location of the release build if the default isn't found.
Fixes the build on Arch Linux.
Change-Id: Iff87a8356302a260b2ac5f959f835d1cdf8a5c65
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Use QmlProject::isQtDesignStudio() instead of checking various settings
sources in order to determine which product is currently running.
Change-Id: I3f08eb147e7dbbde3e2984d63c39d48c12530aaa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
If the user opens a .qmlproject in QDS mode we do not want to
enter the edit mode by default.
We check the startup project after opening and calling
openEditMode() will determine if we keep the default of opening
the edit mode or not.
Change-Id: Ic8a7fbefa007d487ec680099544c07fe007c0b29
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Sample output:
diff --git a/projects/cosign/build.sh b/projects/argo/build.sh
old mode 100755
new mode 100644
similarity index 88%
rename from projects/cosign/build.sh
rename to projects/argo/build.sh
index 87d865d2..14b8885c
--- a/projects/cosign/build.sh
+++ b/projects/argo/build.sh
@@ -13,7 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
################################################################################
+$SRC/cncf-fuzzing/projects/argo/build.sh
+
-compile_go_fuzzer github.com/sigstore/cosign/test FuzzGetPassword fuzz_getPassword gofuzz
Change-Id: Ifa66dfdb80b309d72f524f15c681823ab7e133ba
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
If a new processor is started while waiting for a result of a still
running procesor reset the flag whether content was received while
waiting.
Change-Id: I21a254681050d1db077deec88706f0010670e0ac
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Add a new node hint called "bindParentToProperty" which enables the
metainfo file to specify an automatic binding of a nodes parent id to an
arbitrary property.
Change-Id: Ib16955df608cdca5732882afc1f5ba0891283ca5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
- Initial variables are now listed in the Initial Configuration tab
and current ones in the Current Configuration tab.
- CMake builds can be stopped.
- Variables are no longer grouped according to their prefix.
- Kit Configuration button enables setting CMake options for the
current kit.
Fixes: QTCREATORBUG-26983
Change-Id: I0b8696adc9d442b4c33c6e3c34739e5583254cd9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* Add switch control
* Add additional color to all themes
Task-number: QDS-6146
Change-Id: I75c8aa2dc0dd75cf5b3ac1e025b05ad5110d5b9e
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Refresh is called twice - first time when the editor is just opened, on
this call the repository can be either empty, or the active project (even
if the current file is from another repository). After the editor is
initialized, setSource is called, and the state is recovered.
But between these 2 calls, m_repository is empty, and synchronous actions
are still executed (and fail).
Fixes: QTCREATORBUG-26952
Change-Id: I1767b35f0e9f24da2c447d0b565b410742c560d9
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Fixed issues seen running the tracepoint script in Arch Linux:
* Use /lib/ rather than /lib for the call to find to work with cases
where /lib is a symlink.
* When finding <name>_ret entries in match_tracepoints, search for
<name>_ret__return if the initial check failed. Newer versions of perf
seem to decorate the name with __return when the function name is
followed by %return.
* Handle arrays output from the call to awk in match_tracepoints. This
can happen when multiple functions are added with the tracepoint, and
breaks when checking for "bad" probes when a loop isn't used to add
individual checks for each entry.
Fixes: QTCREATORBUG-25651
Change-Id: Ie528b4d80f9ece8f23d27a84356c74577219ed45
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Now only the parts of the generator that have a value are displayed.
Previously the label had "<none>" for the missing values.
Change-Id: I666bd04c94c47410ee71912dc0cebbcc6c6c79d2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
When the user changes or adds new CMake Kit parameters, the changes
are reflected in the Initial Configuration.
Change-Id: Icca1c76749c772e946ff250f94b7965cf7cf9ee8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Previously all values coming from "Batch Edit..." would be considered
as user changed values and be displayed with bold font.
This means that if I had -DMY_VAR:BOOL=ON and do a Copy and paste
in "Batch Edit..." I would have it displayed as user changed and
it would be passed to CMake as changed value.
Also it should be possible to start with -DMY_VAR:BOOL=ON, click
the check box to make it OFF and then do a "Batch Edit..." with
-DMY_VAR:BOOL=ON to set the value back to original value.
Change-Id: I5f6cb915b32a3288c1339135dabfd182ca16feda
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
