Commit Graph

154 Commits

Author SHA1 Message Date
Henning Gruendl
f0983a08c9 QmlDesigner: Replace CSS color role
* Replace color role in CSS
* Add hover and focus state in CSS
* Fix hex color value in creator themes

Change-Id: I59626f369e2c02089f22bd51557d8226e2dc3631
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-16 17:18:31 +00:00
Henning Gruendl
db6ad528bb QmlDesigner: Implement new control design
* Update creator theme files and related enum
* Remove unused ActionIndicator functionality
* Update all controls (Colors, Positions, Sizes)
* Add global hover state and cleanup all other states
* Add global hover functionality to ButtonRow
* Add missing states
* Add new MenuItemWithIcon
* Add checkers.png for StateDelegate preview background
* Update copyright headers
* Replace AnchorButtons spacing
* Make ADS title bar buttons and tab bar buttons themeable
* Fix replace CSS colors to allow specifing alpha
* Fix replace CSS overwritting consecutive variables
* Make navigator icons and other elements themeable
* Make connection view themeable
* Make item library themeable
* Fix item library import path
* Update all HelperWidgets
* Fix GradientDialogPopup

Task-number: QDS-3768
Change-Id: I28a5fed178c95d098db052b8c2eabaa083d37b81
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-03-16 09:11:38 +00:00
Mahmoud Badri
58b3afa728 QmlDesigner: Clean up flow tags remainings
Remove the remaining unused code related to flow tags. Flow tags feature
was removed as part of the new item library ui commit:
151184a609

Change-Id: Ic2f518cb7d345d4f5a183194bebb29c76b227c15
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2021-02-23 14:01:47 +00:00
Alessandro Portale
19f2ed05d7 Dark Themes: Set the color for PaletteMid explicitly
Apparently, on macOS, the value of QPalette::Mid is set in a different
way than on the other OSes. Let's set it explicitly to ensure the same
painting of wigdets with dark themes.

The value PaletteMid=ffa0a0a0 was determined by manual trial and error,
to ensure that it does not change anything on non-macOS.

Fixes: QDS-3281
Change-Id: I7c044d3b41116e50b2c8a676f30a3b26019ad627
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-12-08 16:47:40 +00:00
Thomas Hartmann
43b5b6fe4b Define PaletteMid explicitly
Since QTCREATORBUG-23505 we use QPalette::Mid for CheckBox
and some other control. The value of QPalette::Mid depends
on the system.
On macOS this created issues with contrast see: QDS-3281

Task-number: QDS-3281
Change-Id: Ic6f83703d16778732992df6bbde50a235306d7c8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-12-08 15:49:59 +00:00
Miikka Heikkinen
6eee8aa99d QmlDesigner: Add 3d axis colors to theme
Task-number: QDS-2404
Change-Id: I16f9deb7ba6698adafdd1cc0c8bec868731e1aa8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-08-11 06:55:09 +00:00
Andre Hartmann
c9eedbe0f3 Git: Port colorful log to text colors
Fixes: QTCREATORBUG-24198
Change-Id: Icde06da5ac848fb0f7faf02a8e55fb26136f318c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-07-06 10:55:43 +00:00
Andre Hartmann
cbb70513bf Git: Allow colorful logs
Requires Git 2.3 or higher for RGB colors.

Can be enabled for the normal or graph log
with the "Color" tool button. For the diff
log, the old behavior is kept (highlighter
is used for the "normal" log, no colors at
all for the graph log)

Fixes: QTCREATORBUG-19624
Change-Id: I8a42a7ad0ebf99ceb459355310311d702dcf9977
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-05-13 14:03:46 +00:00
Alessandro Portale
5c71772fd0 Themes: Undo theme duplication. Just change the ThemeName
Until, we have a mechanism to define a default/fallback in a read-
only setting, it is better to stick to old file names rather than to
create redundant entries.

Change-Id: Ifbc78160e9c57025c66a266efab2b43646ee477a
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-07 09:36:57 +00:00
Brook Cronin
559df59907 Theme: add new dark and light design themes
Change-Id: Ibc65528694d5b8e55e17a80ecd82497c4ab98499
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-06 16:15:43 +00:00
Thomas Hartmann
3c0cd3baca Update designer theme to new color roles
Change-Id: I39ece78e3961d6c2705abcdefcffc4b9cdd8e704
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-06 15:59:18 +00:00
Brook Cronin
96cd1bffae Theme: add controls theme to creator themes and map to controls theme values
Change-Id: Iec6f217e8d3ae6e7f72fdf86c282e1b11b225626
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-04-30 15:43:45 +00:00
Christian Stenger
e571b42622 Themes: Fix warning when loading flat-dark theme
Change-Id: Ifd228eb2164b83262b1281a18659cb1393032993
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-07-23 13:29:31 +00:00
Alessandro Portale
1d2fa1d618 Classic theme: Add missing FancyTabBarSelectedBackgroundColor
In fact, that color is not used in the non-flat classic theme. But
without it, the theme reader complains:
  Theme "default.creatortheme" misses color setting for key
  "FancyTabBarSelectedBackgroundColor".

Change-Id: I81462510150c1dc4fbb3d0bf5d7a2d610abb1f10
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-04 06:56:32 +00:00
Thomas Hartmann
7249427749 QmlDesigner: Use QDS icon color for welcome mode
Change-Id: Icef4a2ba248b4205bedcf60f9c9de0d3cbdbfc75
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-04-01 10:19:43 +00:00
Thomas Hartmann
c0b3124146 QmlDesigner: Adjust selectedBackground in design theme
Task-number: QDS-523
Change-Id: Ib2906dd93448d58a3686545318258d424bfb1927
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-03-25 15:31:34 +00:00
Alessandro Portale
ec5c3b59ea Improve visual contrast for toolbar items in flat/flat-dark themes
Change-Id: I0b9c25100ae4818455b830d30feb1c61bebb1788
Reviewed-by: Aaron Barany <akb825@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-01-16 14:29:10 +00:00
Aaron Barany
9eb4df7a1f Editor: Improve icon/panel selection colors
Improve the visibility and clarity for the output panel and selected icons
for dark and creator themes. This should make it easier to tell what item
is selected across each of these themes.

Task-number: QTCREATORBUG-18888
Change-Id: I4cf4203a0d5b46978d32810cc81dfcdb5ac8b3ef
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-01-12 20:59:36 +00:00
Aaron Barany
328289484a Editor: Fix dark themes
Text selection now uses a subdued blue selection. Selections were
previously nearly impossible to see due to the colors being almost the
same
as unselected text.

Locator now uses the normal text color when highlighting what the user
typed. This fixes a dark text color being used with a dark background,
which was difficult to read. Also make the highlighting background a bit
lighter to improve contrast.

Task-number: QTCREATORBUG-18888
Change-Id: I2f48dc83844270cc832841b94ad5dea9cc6c6f00
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-12-13 06:49:51 +00:00
Orgad Shaneh
a23560582e Themes: Unify Message and NormalMessage colors in dark themes
They're (rightfully) identical in the light themes. Will remove Normal in
master.

Change-Id: I18c0d196ae98846ac46616c1b00545206ba935c5
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-11-21 03:44:25 +00:00
Alessandro Portale
0f4782fbca design.creatortheme: Set DarkUserInterface=true
It is a dark theme and should be marked accordingly.

Change-Id: I437a293162f5bff4ac549f08401ed9f7349213eb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-10-05 07:41:58 +00:00
Tim Jenssen
21fd164110 Theme: adjust to new theme color names
Change-Id: I6d99ff37ac419058729b248860a56eecc9fa0be3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-09-25 13:57:22 +00:00
Eike Ziller
ac9f1f798c Merge remote-tracking branch 'origin/4.7'
Change-Id: Ifb51ca9893549c478e99c9fc3ea6c32d5d5a28a2
2018-09-07 14:39:42 +02:00
Christian Kandeler
71e94e4e28 Theming: Fix value of TextColorDisabled for classic mode
TextColorDisabled has always been the same value as TextColorNormal
(which was presumably unintended), and nobody seems to have noticed for
a long time. However, as of commit f7a0a3cd26 we have been using
TextColorDisabled to display disabled project nodes, which means users
could not tell enabled and disabled parts of the project apart anymore
when using classic mode.
We now use the same value as in the other themes.

Change-Id: I1f616b6808d6c2012748af24b90953e4eb75df18
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-08-30 10:08:00 +00:00
Christian Stenger
8b397d6501 Theme: Fix typo
Amends c79f436e2a.

Change-Id: I211b667b50675b8fa48bdf231146ff7e406f592d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-08-27 09:14:45 +00:00
Morten Johan Sørvig
c79f436e2a Improve macOS dark mode support
The current theme support in Creator works well, also
in macOS dark mode. This change makes sure that the
native macOS appearance setting (for the Creator process)
and the creator theme setting are in sync.

This is required to avoid light/dark palette issues for
the light Creator themes when the desktop is configured
for dark appearance.

Add a “DarkUserInterface” flag to the creatortheme files.
This flag indicates if the theme is overall dark, with
light text on dark background.

Make setCreatorTheme() force the standard light aqua
appearance for light Creator themes.

Change-Id: I1a5c183230ab0e66641fd834df19d7e0ad1b6a53
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-08-24 07:50:25 +00:00
Thomas Hartmann
336ea19b17 QmlDesigner: Update icons of Qt Quick Designer
Change-Id: I970da740c15505cae525fc3514a27c1bc12fe40f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-08-22 09:50:01 +00:00
David Schulz
d4c7814e9e Utils: remove Clang from ClangCodeModel_*_TextMarkColor
They are also used by the qml code model, and may be used by additional
code models in the future.

Change-Id: If216cbeb7b77be0f3b6f31671c71d913206315cb
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-05-17 05:55:53 +00:00
Alessandro Portale
729fc96c48 dark theme: Define splitterColor
Color "SplitterColor" is neither a named color nor a valid color

Fix-up for: 98e26dc6fb

Change-Id: I2d3749a06850e4c630d6a0392e6a1c6e2a75258f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-04-27 13:52:35 +00:00
Thomas Hartmann
5c8c208f26 QmlDesigner: Add a couple of new theme colors
Change-Id: Iab39c0dae28d82f76a8d2ac8bc26562c89bf8e7c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-04-17 10:34:13 +00:00
Alessandro Portale
98e26dc6fb QmlDesigner: Remove programmatical derivation of theme colors
The Qt Quick Designer synthesized a few theme colors from existing theme
colors. That was in order to prevent the need for 6 theme colors being
defined in every theme. It turned out, however, that being able to
define these if favorable.

Todo in follow-up commit: remove QmlDesigner::Theme::qmlDesigner...()
functions, and fix up the qml, accordingly.

Change-Id: Ica85df5472cd7b9da8bf215eb6dbdcf608a4fb2d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-04-05 10:41:12 +00:00
Christian Stenger
f350018999 Welcome: Prohibit rename and delete of default session
Task-number: QTCREATORBUG-19642
Change-Id: I97d9fa84aad510fd8c2d95d3324f77fbcae4e9d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-20 19:39:06 +00:00
Eike Ziller
cff2cc90e2 Merge remote-tracking branch 'origin/4.5'
Conflicts:
	src/plugins/cpptools/clangcompileroptionsbuilder.cpp
	src/plugins/cpptools/clangcompileroptionsbuilder.h
	src/plugins/cpptools/compileroptionsbuilder.cpp
	src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp
	src/plugins/qmlprofiler/qmlprofilerclientmanager.h
	src/plugins/qmlprofiler/qmlprofilertraceclient.cpp
	src/plugins/qmlprofiler/qmlprofilertraceclient.h
	src/shared/qbs

Change-Id: I364ababc5d41046d17e999096c4a7187c4e4e010
2018-01-09 13:13:00 +01:00
Orgad Shaneh
91c50e797b Themes: Fix gradient color in Projects mode
Change-Id: Ic8187fa3a04e76111afa231f993b115933cd3ac5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-01-05 14:53:59 +00:00
Orgad Shaneh
add1bdf43f Theme: Fix parsing of colors without alpha
Use QColor(const QString &) ctor instead of manual parsing.

Uncovered by a19005fc38 which made the
locator highlighting black.

Change-Id: Ic11483613510e3cf97eede396e9b7d53bbc3ff61
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-01-05 09:03:10 +00:00
Orgad Shaneh
6797ca18f6 Dark Theme: Fix bad color value
Change-Id: Ie798db7cd887ff3933832e8589c908b115699529
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-05 07:35:25 +00:00
Orgad Shaneh
b2faf3b767 Dark theme: Make disabled buttons distinguishable from enabled
Follow suit with Flat Dark in 249bea0e44.

Change-Id: I6e279a3fca3fecadd15651373a37ab469d57defe
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-11-10 02:12:25 +00:00
Alessandro Portale
249bea0e44 Flat Dark theme: Make disabled buttons distinguishable from enabled
Task-number: QTCREATORBUG-19235
Change-Id: Ia7f0cc453ab38cb4d95b0f5de1a3261fd46aecdf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-11-09 08:49:28 +00:00
Mitch Curtis
d601c0177b Flat Dark theme: make property editor section title color more readable
This changes the color of PaletteBrightText from ffff0000 to ffff3333.
It is still quite bright (e.g. compared to the color in
b84aa8e837), as it's
supposed to be bright, and I don't know where else it may be used.

Change-Id: I7b125a8c80a4b79fa7106a9f7393081e8a11b22c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-07-17 12:11:22 +00:00
Eike Ziller
105b69836c Merge remote-tracking branch 'origin/4.3'
Conflicts:
	tests/auto/debugger/tst_dumpers.cpp

Change-Id: Id8b53b000f94a1b5ab923db79f67bad3276d09dc
2017-05-04 10:03:50 +02:00
Mitch Curtis
fcb504dede Flat Dark theme: make "changed variable" color in watch window readable
It was a dark red, which is really hard to read against a dark
background. This patch makes it a pastel red, as was done for the
Dark theme in bbb0de0553.

Change-Id: Ieb78522b1e5282e2c35b18ec65c31f4aeb246ad8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-05-03 14:10:49 +00:00
Serhii Moroz
6ecb1c4018 Locator: Add highlighting of the search text
Change-Id: Ia166e9667076e46770a754b626ceb28080139e79
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-03-21 12:31:46 +00:00
Ulf Hermann
a45b0d2c05 Make TODO plugin theme aware
Use the theme's colors by default and color the text rather than the
background of items.

Task-number: QTCREATORBUG-17532
Change-Id: I65a2d6da45ce7547b05463a2fb014f8230d0c336
Reviewed-by: Serhii Moroz <frost.asm@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-03-16 16:25:58 +00:00
Thomas Hartmann
423d360c23 QmlDesigner: Use colors from theme the for selection indicator
Change-Id: I3430e7c49678422811754f1c0400291cdf61c29b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-02-15 11:55:47 +00:00
Jan Kundrát
56e684fc37 Fix readability of TODO entries on dark themes
The TODO plugin provides default values for color-coding backgrounds
based on the severity of each item. These colors are rather light, and
there is just one default with no theme awareness.

It is a bug to use a theme-aware text color on a fixed-color background
-- just switch to a dark theme such as flat-dark and observe the
unreadability.

This patch simply ensures that the default settings have reasonable
readability. These defaults are still not theme-aware, but at least they
are consistent.

Change-Id: Ibf35a241c70e0f1ea001b55f84fd2e1dd1a0a2ea
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2016-11-14 14:00:49 +00:00
Orgad Shaneh
a6427453f4 Fix icons that moved from core to utils
Change-Id: Id3151b1cce2d97b2bfb6debaf3cebe53cd6d88ed
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2016-10-27 16:12:35 +00:00
Orgad Shaneh
0e134d260e Theme: Remove unused icon entries
Change-Id: I867aa0b8737b56fc3e8d357bb1559acad740ccf0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2016-10-27 09:39:42 +00:00
Alessandro Portale
84d298e085 TextEditor: Unify error/warning icon and textmark colors
In most themes, the color of the warning and error icons differ from the
color of the corresponding textmarks (on the scroll bars). This patch
makes sure that they are the same.

Also the progress bar error color is now the same.

Change-Id: Ibce536bed1a9f43d242c2eddf9f94cc6277b2f64
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2016-10-18 09:35:37 +00:00
Eike Ziller
c635c6b50a Merge remote-tracking branch 'origin/4.1'
Conflicts:
	share/qtcreator/qmldesigner/propertyEditorQmlSources/HelperWidgets/ExtendedFunctionButton.qml
	src/plugins/android/androidrunner.cpp
	src/plugins/debugger/debuggerruncontrol.cpp
	src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp
	src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.h
	tests/system/suite_WELP/tst_WELP03/test.py

Change-Id: Ibac4d71d4f4dbe1e4f05052d2f8a2dcfd82edd4c
2016-09-13 12:15:09 +02:00
Konstantin Shtepa
a3739fb14b Dark theme: fix selection color in help mode
Change selectedBackground color to color from flat-dark theme. Now
selected text in help mode is visible.

Task-number: QTCREATORBUG-16375
Change-Id: Ifed68617784f1303bc168e783e4a73bb9da55c8c
Reviewed-by: Konstantin Shtepa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2016-09-05 07:44:25 +00:00