Commit Graph

47434 Commits

Author SHA1 Message Date
Thomas Hartmann
80f6f22061 QmlDesigner: Do not define extra stream operators for QList
This is not required and creates issues with Qt 6.

Change-Id: I74e875fe785d5baa4d0688d0ef86a9151750e56c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-05-06 08:32:53 +00:00
Jarek Kobus
dc88306983 ClangModelManagerSupport: Add future synchronizer for started tasks
Task-number: QTCREATORBUG-25678
Change-Id: I0031f64b3d80cfcff6b9625bd2d57ea228382c80
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-06 08:22:22 +00:00
Thiago Macieira
f8d04c0732 Add missing #include
A local, unpushed change highlighted it.

qmldebugtranslationclient.cpp:47:42: error: use of deleted function ‘QYouForgotToDeclareStreamingOperators& operator<<(QDataStream&, T) [with T = QUrl]’

I really don't understand how this could compile even without my change.

Change-Id: I9f583ca106d24f048885fffd167c35c9e614c786
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-05-06 07:42:55 +00:00
Christian Stenger
80f61a5db9 AutoTest: Extract data gathering and parse result creation
Function processDocument() became to huge. Beside this it
might be needed to re-use functionality partially.

Change-Id: I4c31caa4458c165938c3d6f1170d8ac4806d2af1
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-06 07:19:42 +00:00
Eike Ziller
6689f0e5f4 Fix dropping files onto image viewer
Interactive QGraphicsViews eat all drag&drop events. Since we don't want
the view to be "interactive" anyhow, just set it to non-interactive.
Dragging the image around if it is larger than the view is not
implemented via drag&drop events, so it still works.

Fixes: QTCREATORBUG-25462
Change-Id: Iee403bab7ba83f897b4d2cca662c4e82ae4aa529
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-06 07:15:43 +00:00
Marco Bubke
81a36ac0ef Sqlite: Optimize the initialization
https: //www.sqlite.org/compile.html#omit_autoinit

Change-Id: Iaa91203be21f01a19235a9401cb4fa412eca8276
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-05-05 15:14:37 +00:00
hjk
43636e3cb3 Docker: Suppress a warning if logging is not enabled
Change-Id: Ifad1dd0b720d910cf0fc0c200517563f3ba0897c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-05 12:54:22 +00:00
Andre Hartmann
60055b6e4c FileProperties: Add line endings and indentation info
Open the file and try to guess the line endings and
indentation style.

Change-Id: I4e64b5ea7fc8429fe576d956fdff6b015f275003
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-05-05 12:49:11 +00:00
hjk
bedf8e65f4 Git: Use QtcProcess instead of SychronouceProcess helper functions
Change-Id: I76b21d046676b454f49970e8602f33b759f3c6c5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-05-05 12:29:29 +00:00
hjk
a570ab0e3c Perforce: Use QtcProcess instead of SynchronousProcess helpers
Change-Id: I1d6ef963a72a9ef3175c696bff9038faf5889311
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-05-05 12:28:45 +00:00
hjk
8b4cd1e0aa VcsBase: Use QtcProcess in VcsBaseSubmitEditor
Replaces uses of SynchronousProcess helper functions.

Change-Id: I015306a7265248253bc37b297600adf746be9f5d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-05-05 12:27:23 +00:00
hjk
c69eb63767 Utils: Remove SynchronousProcess::{setP,p}rocessEnvironment
Change-Id: I761c04a08bc7e52b2d57d90cb8aa93ec9f3db724
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-05-05 12:25:57 +00:00
hjk
793d673f39 Vcs/Utils: Use Utils::Environment for ShellCommand
Change-Id: Ica289ab2f83d52270923c4ff4983860cfbe0b494
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-05 12:21:29 +00:00
hjk
f5aa7bd9a1 QtSupport: Replace a use of SynchronousProcess
Change-Id: I986b2972aa4dbd3e4fe2ac0ba0893b358e2ac865
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-05 12:15:08 +00:00
hjk
5813c7e8c2 Utils: Make SynchronousProcess use Utils::Environment for environments
Makes the interface more similar to QtcProcess.

Change-Id: I58e57d9fdb7c37eb0d2a5c5eef8643d6be97c3cc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-05-05 12:14:31 +00:00
Christian Stenger
5b5a998a5c QmlDesigner: Fix invalid id detection
Do not expect an id having 2 or more characters.

Fixes: QTCREATORBUG-25474
Change-Id: I0b3878614ad41681036a98befd03661530a0625c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-05-05 11:43:43 +00:00
Jarek Kobus
0ca487b265 Fix a possible crash in ClangEditorDocumentProcessor
Use QFutureSynchronizer in order to ensure that all
threads have finished on shutdown.

Fixes: QTCREATORBUG-25673
Change-Id: I3a6a808ada389bc51a1f0149dfc112768929a20d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-05 11:13:49 +00:00
Tapani Mattila
d5cadcfa59 ProjectExplorer: Enable to easily check if a project has dirty files
Task-number: QDS-4241
Change-Id: I2fec5f411cdff9fabfa31bbd73971c0308df0783
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-05 11:07:40 +00:00
David Schulz
a86da031c7 TextEditor: Fix is visible check of function hint
Since the FunctionHintProposalWidget is just a proxy witget that uses a
FakeToolTip it is not shown directly so we cannot check the visibility
with isVisible.

Fixes: QTCREATORBUG-25664
Change-Id: I6888e373afcfc79565ce8e3dad1bb05501d58200
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-05 10:11:21 +00:00
Eike Ziller
b3a893e9b8 Merge remote-tracking branch 'origin/4.15'
Change-Id: I75ffc79eeb8d73296a2271a636fae48e35427947
2021-05-05 11:46:19 +02:00
Youri Westerman
103aa8be7c Add more information to appdata xml
- Add oars content rating to appdata xml
- Add screenshots to appdata xml
- Add release info

Change-Id: I61bf023814149983f7a64e03f49eb8d998dac85b
Reviewed-by: Youri Westerman <tetracon@gmail.com>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-05-05 07:57:01 +00:00
Aleksei German
b92acd3e8e QmlDesigner: Report Bug link for QDS
Task: QDS-1272

Change-Id: I1d369d2a53d6829651a8c70be77ef4e5855d775c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-05-05 07:38:10 +00:00
hjk
077c149667 Debugger: Don't pass comments as custom commands to backends
GDB creates disturbing replies for them.

Fixes: QTCREATORBUG-25666
Change-Id: If6223d1065cb96301e3e25aec15e653702e78d08
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-05 06:37:26 +00:00
Christian Kandeler
97744a071a ProjectExplorer: Fix project mode layout issue
Window state save/restore was undermined by code that added and removed
the central widget, leading to inconsistent data.
Fix this by making sure that we (de-)serialize if and only if a central
widget is present.
Also remove the hacky workaround that was supposed to fix this, but
didn't.

Fixes: QTCREATORBUG-25551
Change-Id: I6e7f2aff7455db476f870ead64b09a9716f3558b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-05-04 14:46:06 +00:00
Christian Kandeler
23fb4449f1 ClangTools: Let users disable checks from text marks
Fixes: QTCREATORBUG-25622
Change-Id: Ied5ca0fca65cd12a2df7744ffc2043dc9686c973
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-04 12:45:30 +00:00
David Schulz
ffd9b7415d TextEditor: Fix snippet variable index overflow
Change-Id: Ifd224c33d5ffe56e22b85d8c1959448154d550b1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-05-04 11:21:50 +00:00
Christian Stenger
1e019b1c1e TextEditor: Fix compile with Qt6
toStdList() has been removed in Qt6.
Amends a2dadb3d0b.

Change-Id: Id2032d7e0a0c3345614bc56d98152c41f199af07
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-05-04 11:21:44 +00:00
hjk
4c375e31a3 Python: Replace a use of SynchronousProcess
Change-Id: I93ce9a3224c88c69c3b0ef46f1416645ffca1e1e
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-04 09:55:47 +00:00
Christian Kandeler
90ff9be54a Find: Stop at the root item when updating the "checked" status
... of search result items.
Otherwise we're breaking assumptions elsewhere.

Fixes: QTCREATORBUG-25662
Change-Id: I9dce79bd58ada02988741741c09e4ce42cc7af03
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-04 07:30:10 +00:00
Christian Kandeler
6fbe88b215 TextEditor: Queue call to ICore::showOptionsDialog()
... from text marks.
Direct calls appear to be unsafe, possibly because text marks are
transient.

Fixes: QTCREATORBUG-25623
Change-Id: I929ff6310c9d93b677f66acc8869e7aeceb5564b
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-04 07:27:59 +00:00
hjk
dec9169efe Utils: Move SynchronousProcess::normalizeNewlines to QtcProcess
Change-Id: I5ba8ba1061b04b032aafd08382d34ccb62272829
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-04 07:19:55 +00:00
hjk
196b7b0f24 ClangTools: Use Utils::CommandLine for a command line
Change-Id: I489e5538fe97e7d565eed22af8d285d89b870ca3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-04 04:38:17 +00:00
hjk
dbf80d5fe2 ProjectExplorer: Whitelist DockerDevice for DesktopRunConfigurations
The idea is that "everything" that can run on the real local host also
can run in a docker container mimicking the same kind of environment.
I.e. all run configurations suitable for current "Desktop" would/should
also be runnable in a docker container, ideally without noticing.

_Desktop_RunConfiguration would then be a bit of a misnomer, it's more
"things that act like 'desktop'", but that can easily be changed later.

Change-Id: I0b284135202e64b54ee86a3815efa95d75a5e29f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-03 15:13:43 +00:00
hjk
a13eeae6f3 ProjectExplorer: Code cosmetics in desktoprunconfiguration.cpp
Change-Id: If5ccd9369817a2f87c7ad3b87b88e8705e110d25
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-03 13:56:19 +00:00
hjk
ebd8d520fc ProjectExplorer: Make AbstractProcessStep::doRun() tests work remotely
By funneling file system accesses through Utils::FilePath.

Change-Id: I13a3aac23bd5fc301edf5e5c52e0c7ebd1e6ca6c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-03 13:38:05 +00:00
hjk
6182f39b06 ProjectExplorer: Avoid one use of SynchronousProcess for ps output
Change-Id: I9b78810899f6d2c608092295ceef570bc136816d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-03 13:37:52 +00:00
hjk
779e572ea3 QmlDesigner: Replace SynchronousProcess use in BuildableHelperLibrary
Change-Id: I064d0c53116b1f657c1b1d301b4de3e337ba9eaa
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-03 13:33:49 +00:00
hjk
84fbb9f605 ClangTools: Remove some use of SynchronousProcess
Change-Id: Ifaf8979f5e3d2799002322580c8cb6982c099921
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 12:32:07 +00:00
hjk
a9da8723fb Perforce: Avoid one use of SynchronousProcess
Change-Id: Iafa9fcbcd8e902b4fb28834f19bf0c31e3bb9149
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 11:48:41 +00:00
Eike Ziller
f3e4c7112b Add output panes to Projects mode
No real reason not to do it, and build systems print output there.

Change-Id: Ie0f08e3e88e585098b097e7c983d54e2fea8c6f2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-05-03 11:47:24 +00:00
hjk
2f593d9db9 LanguageServer: Use Utils::CommandLine in StdIOClientInterface
Change-Id: Ic2516387d7308bfad05cef54467c417cc47a7655
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 11:31:17 +00:00
hjk
e5312362c8 LanguageClient: Avoid one use of SynchronousProcess
Change-Id: I39329a68691ad084128056c34cc41554776fd18b
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 11:27:31 +00:00
hjk
ada1e68e35 Qnx: Avoid some use of SynchronousProcess
Change-Id: I4ae66efc9e09196e0ce0c08c939f1d7f1386f071
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-03 11:26:40 +00:00
David Schulz
a2dadb3d0b TextEditor: Snippet ranges refactoring
Parsed snippets are now reported in chunks of texts and variables. A
variable has a index that can be used to identify matching variables and
maybe a mangler that can be used to modify the variable when applying
the snippet.

This effictively moves the variable matching logic from the overlay to
the parser of the snippet, which is needed to implement the LSP snippet
parser.

Task-number: QTCREATORBUG-22406
Change-Id: I6999554c6c6d0f1887c98bf732473f01aa1f230c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-03 11:12:34 +00:00
Christian Kandeler
4890902abf LanguageClient: Allow for custom symbol search result handling
Change-Id: If19ce24b39820afbfd48c48493e07709f4b3633e
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 11:07:08 +00:00
hjk
2014bf472d Qnx: Some style fixes
Change-Id: I90e9bbd0bfb92f9804c38bb143b8d0690ddb8991
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-05-03 10:56:16 +00:00
hjk
c75c6f342e Debugger: Make findQtInstallPath remote-aware
Change-Id: I3df662a182c079725e616776befead30265f22b3
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 10:49:01 +00:00
hjk
03b2920d31 Debugger: Use QtcProcess instead of SynchronousProcess::stopProcess()
Change-Id: I6206e64e098d3490738a9c2a76ff433c990aab17
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 10:22:09 +00:00
hjk
96569f9c63 Debugger: Fix watch time column display logic
Amends 93a580395.

Change-Id: I84b5e826ab5f9202d661e9b2736a874c767faa54
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 09:19:44 +00:00
Christian Kandeler
b4e8d32189 LanguageClient: Allow to look up the document for a given file path
Change-Id: I565ce07b28008edbc9d40178069b078ff3530744
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-05-03 07:37:41 +00:00