Commit Graph

47434 Commits

Author SHA1 Message Date
Miikka Heikkinen
b0984dada3 QmlDesigner: Show preview for more image and picture types
BorderImage, SafeRendererImage, and SafeRendererPicture items now show
their images in navigator preview image tooltip.

Change-Id: I52c2f2ab87b3489fdfbbabe52737c5b97b0cf3fe
Fixes: QDS-2921
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-02 12:55:22 +00:00
Miikka Heikkinen
798e0e623f QmlDesigner: Fix navigator preview tooltip issues
Immediately hide preview tooltip when hovered row changes.
Tooltip follows the cursor as it hovers over the same item.
Fixed the preview image label size.

Change-Id: I16aec577bd68735873517d04eb51d21b7975f2c6
Fixes: QDS-2908
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-02 12:55:07 +00:00
Miikka Heikkinen
95c27ea4c8 QmlDesigner: Remove "locked" auxiliary data instead of setting it false
Since absence of locked property implies it is not locked, simplify
the auxiliary data by just removing the locked property instead of
setting it to false.

Also remove unused private method ModelNode::removeLocked().

Task-number: QDS-2915
Change-Id: I27904514f168c28138b6311278f60565fc810f00
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-02 12:54:39 +00:00
Christian Stenger
873566d743 PerfProfiler: Fix test generated data
Amends 67c800af6e.

Change-Id: I8e8bda0373ec70bda94f2fef74710d6125dfcace
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-11-02 10:11:13 +00:00
Alessandro Portale
dca5cb4f14 Don't animate TreeView expansions
Some styles set a QStyle::SH_Widget_Animation_Duration. An animation
does not go well with just-in-time population of the expanded content.
This change avoids that for all TreeViews.

Fixes: QTCREATORBUG-24834
Change-Id: I16ca4c61733d8875e713d7349ed6b99ba37ecf74
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-02 09:28:49 +00:00
Christian Kandeler
76ae5780c4 CppTools: Fix function decl/def look-up
... in the presence of macros.
For instance, renaming a parameter of a function preceded by some sort
of DLL_EXPORT macro would not offer to apply the change to the definition,
because the macro gets expanded and the respective tokens have bogus
offsets derived from the place where the macro is defined.
Luckily, such tokens are marked as "generated" and we can skip them for
the purposes of retrieving the actual location of the function.

Fixes: QTCREATORBUG-24739
Change-Id: If5db355b1c301060a17a687c2b5582fa1ef17d3f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-02 09:08:21 +00:00
Lukas Holecek
4e28aed405 FakeVim: Fix deleting selection on search command-line
Change-Id: Ie01dd84cf87db2d999c10352285c0ee8366aadc1
Reviewed-by: hjk <hjk@qt.io>
2020-11-02 07:56:56 +00:00
Eike Ziller
1cd87a05b5 Fix build with newest Qt6
Task-number: QTCREATORBUG-24098
Change-Id: I8ced79ecd590dbeeb3038054e75ee0632ca37462
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-30 15:17:15 +00:00
Christian Kandeler
659771f09b Debugger: Provide keyboard shortcuts for "next" and "previous"
... to applicable analyzers.
Rather than inventing separate shortcut categories for all the
analyzers, we make use of the fact that only one analyzer view is active
at any given time, and make them use the same shortcuts for consistency.

Fixes: QTCREATORBUG-20659
Change-Id: Ifa60080def0e6b32395854cff588ab3af9ea33b9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-30 12:20:58 +00:00
Christiaan Janssen
9cd5fb927d McuSupport: generate kits automatically on plugin initialization
Fixes: QTCREATORBUG-24354
Change-Id: I26587102bd24d1678707ca1d9160c84149e77c8e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-30 11:07:27 +00:00
Orgad Shaneh
b7c72f8621 Debugger: Do not discard macros when clicking on source mapping
Fixes: QTCREATORBUG-24816
Change-Id: I7e541d3edb7601cf91064ba30059e4a8f0aa6064
Reviewed-by: hjk <hjk@qt.io>
2020-10-30 10:15:23 +00:00
David Schulz
43b25e6d99 Debugger: Fix breakpoint enabling
Change-Id: I496d0b90dd572d4f4949c98d5abe035edfba8d19
Reviewed-by: hjk <hjk@qt.io>
2020-10-30 09:51:12 +00:00
Christian Kandeler
247a432f74 ProjectExplorer: Fix project window layout restore behavior
Steps to trigger the problem:
1) Start Creator with some fresh settings path.
2) Open an unconfigured project.
3) Observe a normal-looking target setup page.
4) Configure the project.
5) Close the project.
6) Remove the .user file.
7) Re-open the project.
8) Observe a target setup page whose left part takes up almost all the
   space, leaving the main project widget practically invisible.

Conclusion: The configure page does something to the widget state that
breaks the restored layout. I don't know what it is exactly.

Fix: Slightly delay restoring the widget layout.

Change-Id: Id88ea12267a7dd0fe54749c18b0761d0e873d646
Reviewed-by: hjk <hjk@qt.io>
2020-10-30 09:11:31 +00:00
Christian Kandeler
ee96c2d9fc ProjectExplorer: Fix assert in MakeStep
... when it's part of a deploy configuration.

Change-Id: I56340ea5553a267daa04b5fd89aff382ec1d27cd
Reviewed-by: hjk <hjk@qt.io>
2020-10-29 17:02:55 +00:00
David Schulz
f44c447874 ClangTools: enable goto actions for a single diagnostic
Usable nowadays since the action also opens the diagnostic location.

Change-Id: I24a0df606fec5d7e84a2f3450317864f62a4e118
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-29 11:44:53 +00:00
Eike Ziller
724fd58a3b Merge remote-tracking branch 'origin/4.14' into master
Conflicts:
	src/plugins/cppeditor/cppquickfix_test.cpp

Change-Id: I470ee35f54f883244d819531131c172bd25c0e3f
2020-10-29 09:18:31 +01:00
Henning Gruendl
c019860809 QmlDesigner: Update the Stack (z) context menu
* Rename arrange menu and items
* Remove the "Reset z property" item
* Add reverse item and functionality
* Fix some related typos and formatting

Task-number: QDS-2938
Change-Id: I0e706aefdaed99b28faae4b307146847a54a24ed
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 16:43:30 +00:00
Christian Kandeler
b30b2f481c ClangTools: Make "go to next/previous diagnostic" open an editor
It's very likely that the user will want to have the respective location
displayed in the editor.

Fixes: QTCREATORBUG-20658
Change-Id: I34128c6444208571df566725e2ad1675d4456853
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 14:28:24 +00:00
Eike Ziller
ee1e6ca508 EditorManager: Avoid changing the editor in between when closing editors
Do not call setCurrentEditor(nullptr) since this sends a
currentEditorChanged signal which claims that no editor is active, which
can lead to unnecessary updates.
In the specific case, the git branch view was updating with the project
directory as a new repository, and then, after the actual new current
editor was set updated again with the repository of the editor.
This can be needlessly expensive if the previous and new editor are in
the same repository, but the project repository is something else, like
when having the Qt Creator super-repository open, or when editing files
unrelated to the project.

Change-Id: I515c3c40a86bfa2713ff13460ddfda974bc08c59
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 14:02:27 +00:00
David Schulz
bf2276ebde LanguageClient: do not generate diagnostics twice
Change-Id: Ib15f67fb362440fa901ae4118cb176b2bf073fdc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 13:29:51 +00:00
Knud Dollereder
8ca3b557da Update locking state from external views and cleanup
Improve treeview styling related to locking/pinning
    Use font icons.
    Show implicitly locked nodes by darkening text and icon.
    Show implicitly locked curves by darkening the text.
    Show unlocked/unpined icons only when hovering the mouse above the item.
It is now possible to lock/pin multiple curves by locking/pinning the node items.
Load unselected curves into the graphicsview when pinning them.
Rename namespace DesignTools to QmlDesigner.
Remove unused function from the timeline module.
Get rid of a memory leak.

Change-Id: I2c9c0a9e1ffe79520c4869178a11cc5825d04bbe
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 13:13:56 +00:00
Christian Stenger
050f6b083c Qbs: Fix linking tests when building release with tests
Change-Id: I5df34f06b5ca107b5e85cf6319d6d08aba244e5b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-28 13:12:54 +00:00
Vikas Pachdha
ce413d81d0 AssetExport: Export line height value in pixels
Task-number: QDS-2597
Change-Id: I96db25b08db55c3107931ab31e4b9342be92e644
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 13:05:24 +00:00
Henning Gruendl
7f44ef76f1 QmlDesigner: Fix view menu constants and comments
Change-Id: If48b80fc2d928d177d59693371ba9d8f9d66bfca
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 13:00:50 +00:00
Henning Gruendl
2c91080502 QmlDesigner: Fix navigator root icons clickable
* Fix root item icon columns clickable
* Hide tooltip for root item icons

Task-number: QDS-3006
Change-Id: Icd6177bfce30724bb4806aeec4768232760b35e9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 12:49:57 +00:00
Christian Kandeler
7b6ab79f3e ClangTools: Do not include our wrapped Qt headers
These are only necessary for the code model and can prevent clazy from
finding certain issues.

Fixes: QTCREATORBUG-24845
Change-Id: I04ba6703812918c39ebbde1dbac5af85fe18622d
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 12:44:34 +00:00
Christian Kandeler
d2ebc16b92 CppEditor: Fix "move definition" quickfix for template member functions
There are a lot more problems in this area (e.g. with nested classes),
but let's tackle them one by one.

Fixes: QTCREATORBUG-24801
Change-Id: I4b3805ea6f8b28373925693650150bbd89508096
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 12:41:26 +00:00
Alessandro Portale
b5e9dd006a Marketplace: Implement a little optimization
Should have been done in a previous commit.

Amends: b77318cb74

Change-Id: Ic3800ca6b6a4e799a5545aa9c68d9f7f7ccfcb20
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-28 12:39:56 +00:00
Alexis Jeandet
cfcfb304fa Meson: Replace most std::for_each by range based for
Change-Id: I18aa38bb84264e0f6a99f431c1caaded9bbbe248
Reviewed-by: hjk <hjk@qt.io>
2020-10-28 09:16:27 +00:00
Eike Ziller
4c7fd32fa0 cmake build: Add support for setting user file extension
Via QtCreatorIDEBranding.cmake

Task-number: QTCREATORBUG-22488
Change-Id: I42699732640b67672b87b2de06f10b9da57bee7e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-28 08:53:09 +00:00
Marco Bubke
6ba5054c10 QmlDesigner: Simplify threading in image cache generator
Change-Id: Ib969e6dae268c4564239d11c761873092e2dbb17
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-10-27 17:21:24 +00:00
Alessandro Portale
b77318cb74 WelcomeScreen: Don't rely on image format auto-detection
The examples and marketplace pages show images that are decoded from
data buffers. This happened without specifying the encoding format,
which triggers image auto-detection.

The negligible overhead of the auto-detection is usually not a problem,
but the probing of image QImageIOHandlers that goes along with auto-
detection can emit warnings. A concrete example is a warning in the TGA
plugin which was added in Qt 5.15.1.

Task-number: QTCREATORBUG-24853
Change-Id: I596604bde7621acf92e825f45e0c23ac4e90b78d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 16:15:10 +00:00
Orgad Shaneh
f487e471aa BareMetal: Remove qualifiers from setting keys
They're pure noise, since there should be no conflicts between base and
derived classes, and there can't be multiple classes for the same provider.

This maintains compatibility when upgrading from earlier versions, but not
for downgrades.

Change-Id: I02655410172ff170fca4893f7b37c2fb1f316aff
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-10-27 16:02:13 +00:00
Orgad Shaneh
0a4a1693ec Revert "BareMetal: Get rid of DefaultGdbServerProvider"
And rename it "Generic".

It *is* useful for pre-configuring a device with address, then simply
debugging with F5 instead of going through the Attach to Running Debug
Server dialog and manually choosing the address, port and ELF file.

This reverts commit 46afac5687.

Change-Id: If1e2115e38f38431d70dc8745ffe11ac1a13a7fa
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-10-27 16:02:03 +00:00
Lukasz Ornatek
6f489a10c1 Fix predefined annotations
Task-number: QDS-3002
Change-Id: I1ccc586e19d3059a419431188bab58c84441c08c
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 15:09:00 +00:00
Miikka Heikkinen
091fb1fc7d QmlDesigner: Fix stall at asset import icon creation
ProcessFinished signaling has changed so that sender() returns nullptr,
so changed the processFinished handling to simply remove all finished
processes.

Change-Id: I6c1d37737cf7fd15840daa1c7d73f2620fab1102
Fixes: QDS-3004
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 15:07:56 +00:00
Leena Miettinen
9da8a3f540 Welcome: Link to Qt Design Studio QuickTip: Interactive 3D
Change-Id: I4fd574060f9d753b1fc1279e4387cf721668431c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 14:53:39 +00:00
Andre Hartmann
2bc736a4f7 Git: Do not refresh branch view when hidden
Change-Id: Ia2e327b6396657255f9b40b792d794a647fc5745
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-10-27 13:56:14 +00:00
Eike Ziller
7ae976a8b9 cmake build: Use qtc_add_resources for StudioWelcome
Avoids creating resource file if plugin is disabled.

Change-Id: Ia3e1a127c49cae4b03547367a78ca7dd8c3689f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 12:53:54 +00:00
Alexis Jeandet
36632330ca Meson: Only trigger meson introspection files parsesing on file change
FileSystemWatcher was triggered before meson-info.json was written which most of the
time did just ignore last changes. When meson plugin is parsing the project, it discardes
all new parsing requests.

Change-Id: I20c8e95e5ed330628614a9fe1485394fd6b9fde8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-27 12:51:20 +00:00
Alexis Jeandet
8b23b6efbe Meson: List files from extra_files target field in project tree
Fixes: QTCREATORBUG-24824
Change-Id: Id37bdaea08fb527398195ac16f99fe3c00d36566
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-27 12:51:14 +00:00
Christian Kandeler
0ebb004d85 CppEditor: Make "Complete Switch" quickfix work with enum classes
Fixes: QTCREATORBUG-20475
Change-Id: Id21a007ab4b652dcfe49d97bfa4c9fa77bacf8c4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 11:40:37 +00:00
Assam Boudjelthia
9d3c156fd3 Android: fix parsing Andorid Abis for Qt 6
Amends 4946677df4, to allow
parsing the correct supported Abis from qmake.

Fixes: QTCREATORBUG-24828
Change-Id: I20f8cbf5c0f1bcdf3debb0d9b5c47fa77de163ab
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-27 09:16:06 +00:00
David Schulz
061a56143c ClangTools: show all checks in clazy settings
Show all checks if no filter is selected, otherwise checks with no
categories will never be visible (qt-keywords).

Change-Id: I2809afc050c7da6386a3e01d90c8ea6bcb7cab68
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 08:50:20 +00:00
David Schulz
d7ab6210af ClangTools: Do not show text marks for suppressed diagnostics
Do not generate marks for automatic runs
and hide them for the explicitly invoked analyzes.

Change-Id: Ic48e7b13c424c51e7e1759c588c94bbd45e6d1bb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 08:50:09 +00:00
Eike Ziller
43facbe090 Revert "cmake build: Disable clangpchmanagerbackend and refactoringbackend"
The change breaks the dev package:

The imported target "QtCreator::clangrefactoringbackend_lib" references
the file
"/home/qt/work/build/qtc_build/lib/qtcreator/libclangrefactoringbackend_lib.a"
but this file does not exist.

This reverts commit 20a6207459.

Change-Id: I68f3b6948bde611b9e5b841d1fde2b136877cbfc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-27 08:37:26 +00:00
Marco Bubke
0f02fd7c87 QmlDesigner: Check if index is positive
Task-number: QDS-2999
Change-Id: I61f4aba59124e6b0eeb0089da31631e7f4e59cbf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-27 08:26:51 +00:00
David Schulz
6e846b6606 TextEditor: skip painting annotations for disabled text marks
Change-Id: Id05bfe5bd120b2bbb2e2b70fb29a99b8c430e459
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 07:38:30 +00:00
hjk
045881089f QmakeProject: Don't crash on project import
Amends fc1fc6a07a.

Fixes: QTCREATORBUG-24802
Change-Id: I62e7e0bab82ae1b025c053785b77586aa78bcd1f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-26 16:30:11 +00:00
Eike Ziller
20a6207459 cmake build: Disable clangpchmanagerbackend and refactoringbackend
By default. Previously only the corresponding plugins were disabled, but
not even building the backends makes more sense.

Change-Id: I36d61869a3050f37da1f480dea89e7539dda599a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-10-26 15:34:22 +00:00