Seem like it get a nullptr project at shutdown.
Change-Id: I76d9f4b2b90b0641d645cb413f9ebfe678bb1c9f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This will make it easier to implement custom puppets. The new connection
manager will restucture the code and it add a mechanism to capture data
too.
Task-number: QDS-2529
Change-Id: I5d15c3303ef1c9a3e25ba197d350e0d561ce813a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... if the first argument is a call to a function returning a pointer to
QObject.
Fixes: QTCREATORBUG-13265
Change-Id: I12c2d07331a0c6dca56ad55c518240fd74be3dca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... when rewriting an argument of a refactored function.
Fixes: QTCREATORBUG-13698
Change-Id: Ifb569a290d3c46944d17a73a19400833e5ba7fe9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Especially on Windows systems, paths can be long.
To avoid resizing the dialog on each open, just
make it larger by default.
Change-Id: I3803ee6f930e0c27f3d8841fff025d1641bb216e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
There was a type, so it crashed. The code is now under tests so we cannot
break it anymore.
Task-number: QDS-2563
Change-Id: I81426a9f8a568b217b7bf9c8c261b24be14ff61a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The preferred interface are step ids, #include'ing other modules
*constants.h header is considered ok for siblings in the core
distribution and does not create run time dependencies between plugins.
Change-Id: I0421936068b459c1aea61e23310f860d8ed1f0d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Using the full path for the file nodes may be quite long
depending on the location of the project.
Display its name relative to the project directory or the
parent group node instead.
Fixes: QTCREATORBUG-24374
Change-Id: I4ce57a0940008d99c51e63c2265a371a0ffe20ef
Reviewed-by: David Schulz <david.schulz@qt.io>
... in the Push to Gerrit dialog.
Fixes: QTCREATORBUG-24436
Change-Id: I2f1ab49d9fbeb09ffb66de23d34a2facd53cb725
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Do not access list items if there are none.
Amends 502ad9badb.
Fixes: QTCREATORBUG-24421
Change-Id: I2982f675bba36eac98cb116acf64472a9f415977
Reviewed-by: hjk <hjk@qt.io>
Simplify interfaces. Also persist all command line settings,
make overriding default arguments explicit.
Change-Id: Ifb7e791dfc07ae9a88cfd769b9d21c5ee242e31d
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
QT_USE_FAST_CONCATENATION doesn't do anything nowadays.
Using QT_USE_QSTRINGBUILDER is the same as QT_USE_FAST_OPERATOR_PLUS
for QStrings and enables more QStringBuilder use for QByteArrays.
Change-Id: Ibd297817c50d86661d47822799f989447249af1b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
As for the other aspects.
KitManager::kitRemoved() triggers several actions in a fragile (wrong?)
order: BuildSettingsWidget::updateBuildSettings() after
Target::handleKitRemoval() already destroyed the target with all
configurations and steps.
Having a null there is fine.
Change-Id: I2e10826c12971a25ee4cbab24ef5327fa6e47499
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
And show a tool tip also there.
Noticeable e.g. in the "Incredibuild for Windows" buildstep checkboxes.
Change-Id: Iebabda6fb025596aa9dbc7c917c4bdbeb25a1a8d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use case-sensitive sorting in the side bar outline, just like in
the editor outline.
Fixes: QTCREATORBUG-12714
Change-Id: I9d8243c61fcceb6e3d7b55e3b27fa5d20accccea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Covering the remaining bits in the buildsteps.
Change-Id: Ia1c51eb14c92bd377b7b5d6ddbd4658e9adc1b89
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The most common case is when building triggers a new configuration process
which changes introspection data.
Change-Id: I7b23df4089898bb66a634b29809775d26011b315
Reviewed-by: hjk <hjk@qt.io>
- partially move towards using ProjectConfigurationAspect infrastructure
- fix display of default make arguments
- code cosmetics
Change-Id: I5ce3eb531c65b53d66411e959bcf79408418d5a1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and use it in the DebuggerRunConfigurationAspect.
Change-Id: I1079f1a307d5e4b286d32570c48299d296fa3061
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We accessed a reference after removing the value from the container.
Change-Id: Idfb97093b7a23ba04e5cb0582c81031f431dce88
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Give it enough space for subject-based branch names.
Change-Id: If6ace5434903553330e802ff41f92083b0aee874
Reviewed-by: André Hartmann <aha_1980@gmx.de>
... when the checked out commit is not a remote branch.
Fixes: QTCREATORBUG-24006
Change-Id: I175a3aedba88bd9e3b5cf298c5c161c56e9d0acd
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This also unites this with the nearly same string in
simulatoruvscserverprovider.cpp
Change-Id: I48930456f038577869ffade787e549fc396c365e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Fix the change type dialog to also include checking for signals
* Add check for same type
* Add dynamic properties and signals
Task-number: QDS-2562
Change-Id: I34652e702d9051fb5a237afae584e345c731622f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Add the on state to the tab close QIcon to have a different color in
focused tabs
* Make the tab close icon checkable if FocusHighlighting is enabled to
exploit the QIcon state for the color change
* Adapt the focused font color in the dockwidget stylesheet
Task-number: QDS-2558
Change-Id: I9fdfb93f0677f724336da8efdb2fb219af9c9e87
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Add mode disabled to the zoom all button in FormEditor widget
Task-number: QDS-2558
Change-Id: Ie0da97cca5ea4c2411e21fc3cbea202397e02097
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fix duplicate items in the auto completion result by trimming the
strings. Otherwise items like "Item " and "Item" will both show up in
the result.
Task-number: QDS-2561
Change-Id: I0244fed19cf358d5c72ee169cd8ffa13672edce2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Sort incompatible properties before showing them in the dialog.
Task-number: QDS-2560
Change-Id: I9871bc8ea488be04fcfac7b9c0f1a7cbf185072a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
