Commit Graph

47434 Commits

Author SHA1 Message Date
Orgad Shaneh
a48cde86f3 Git: Show full description on tooltip in commit chooser dialogs
Like Push to Gerrit, Rebase, Reset, Fixup Commit.

Fixes: QTCREATORBUG-24366
Change-Id: I0f596f84661a1a4f37fe971683cc0d985a6c9b1f
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-08-02 05:00:50 +00:00
hjk
78406916a3 Debugger: Avoid use of QHash::values(...) in QmlEngine
This will be gone in Qt6 and seems unnecessary here as insertion
into the hash explicitly checks containment first, so this was
effectively not used as QMultiHash anyway.

Change-Id: I3f6ef9473930f72ee9b5f81f3623829d63619cc0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-31 13:16:40 +00:00
Christian Kandeler
4bbf76a344 ProjectExplorer: Allow to add custom output parsers programatically
This enables plugins to add custom parsers to the global pool.

Fixes: QTCREATORBUG-24403
Change-Id: Id600c12fc66876879a5a2975139d72f87c4f2e30
Reviewed-by: hjk <hjk@qt.io>
2020-07-31 12:19:34 +00:00
hjk
996f490e97 Meson: Do not use QFuture implicit conversion
QFuture::operator T() will be removed with Qt 6

Task-number: QTCREATORBUG-24098
Change-Id: Iec7d8d95ab965867e8fa5ddaac496a4129ed08a9
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-31 11:19:15 +00:00
Christian Kandeler
3f9427200b CppTools: Fix formatting for lambdas with trailing return type
After the arrow, the state is still the same, as now a type is expected.
Only after the opening brace does the actual function start.

Fixes: QTCREATORBUG-18497
Change-Id: I7bf18fbd6907d36f8869af3a78ad617cf0ee9dbb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-31 08:15:18 +00:00
Christian Kandeler
21fbf36a5d Cmake: Fix compile output glitch
Using a dedicated OutputLineParser ensures that we only ever see
complete lines and thus prevents "partially red" lines in the compile
output pane.

Fixes: QTCREATORBUG-24209
Change-Id: I12b3de70b81789afe727b66e366facdcc81f8ab8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-07-31 08:12:54 +00:00
Christian Kandeler
537e2e23ff CppEditor: Work around cmake bug
If you mention "Q_OBJECT" in a raw string literal, the cmake build
fails...

Change-Id: I9004184b48dea9a77b9303c3fd871cef747ade4c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-30 13:30:18 +00:00
hjk
efc39f971e Qt6: Workaround for ListModel iterators
Change-Id: I622b42b8aea4f06b62e8739f7e8abb234ed7d3b4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-30 07:04:03 +00:00
hjk
5363256acd Qt6: Port some uses of QApplication::desktop()->availableGeometry()
Task-number: QTCREATORBUG-24098
Change-Id: I3bf911402084fb26110a89992cb5f1d61c2f46e9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-30 05:56:00 +00:00
Christian Stenger
0950940c35 LanguageClient: Improve outline
For non-hierarchical symbols probably no difference,
but language servers providing hierarchical document
symbols will benefit.

Change-Id: Icab7ac74a7780ee72c556955867a0ad7da3d8a02
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-07-30 04:56:20 +00:00
hjk
6c590531b0 Small Qt 6 migration stuff
- qsizetype vs int
- QJsonValue vs QJsonValueRef
- #include for metatype system

Task-number: QTCREATORBUG-24098
Change-Id: I066d9e3d5c35766b8aa3adc1c5835b23feb20b37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 14:03:19 +00:00
Christian Kandeler
77d13f08ba CppEditor: Let users create implementations for all member functions
... in one go.

Fixes: QTCREATORBUG-12164
Change-Id: Ifc81c8b1caf4319ce57882375f513d72e4c0ea52
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 11:56:07 +00:00
hjk
120540f1db ProjectExplorer: Add BaseIntegerAspect::setToolTip()
Change-Id: I7a9fe0695b30c926d6b3e11302a4a8eaadfa2b16
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-29 11:18:16 +00:00
Christian Kandeler
4e9951af3a CppEditor: Consider operators
... when looking for reimplemented member functions in the "Insert
virtual functions of base class" quickfix.

Fixes: QTCREATORBUG-12218
Change-Id: I6e37e28ab747a76dcc97df242bd6c6199fbc7e2e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 10:29:45 +00:00
Alessandro Portale
6c45c3fb1c CppTools: Bump TIDY_DOCUMENTATION_URL_TEMPLATE from 8.0.1 to 10.0.0
Change-Id: I198f805768984eb060b2a72f705e618e6a7a53ff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-07-28 19:37:51 +00:00
hjk
c467ae6114 Android: Drop special AndroidPackageInstallationStepWidget
A base BuildStepConfigWidget with a summary updater are good enough
nowadays.

Change-Id: Ic8df7662cc28969786fd93171c53ec428a09db58
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-28 19:08:30 +00:00
Robert Loehning
0c26c3602d ProjectExplorer: Fix indentation
Change-Id: Ia38b19eb50f46917713766d3d1aa9308dcbe5a7c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 18:27:57 +00:00
Robert Loehning
fb17795a9f Android: Add missing full stop and fix message
sdk_definitions.json does not have to contain 'lldb;x.y' anymore
as this is part of the base installation nowadays.

Change-Id: I39bc988674a8e60b22cd852b890224ac1c87e8c8
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-28 17:46:17 +00:00
Christian Stenger
002b3907f6 QmlJSTools: Fix plugin unit test
Amends 58ea14aea7.

Change-Id: I27d68572cffd9d2e37b3dbf8c47c75633db5d806
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 14:43:29 +00:00
hjk
412ffe55bb ProjectExplorer: Move MakeStepConfigWidget::updateDetails()
... to MakeStep. Next step towards full aspectification.

Change-Id: I64763a96e549a557015ed42c82d7599604788c4f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 14:18:01 +00:00
Leander Schulten
755659e663 CppTools: Prevent SegFault in the ClangFormatIndenter
If you create a ClangFormatIndenter but do not set the
fileName, the indenter will SegFault while indenting.

Change-Id: I93a56d7916bc1a02da9ee21a116bd48b4405edb1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 14:17:54 +00:00
hjk
200d81d38c Nim: Aspectify NimbleBuildStep
Change-Id: I0f166e68590901568edfd590606df57e25111b9a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 13:38:54 +00:00
Christian Kandeler
dfe5eb3b11 GCC parser: Recognize messages referring to scope
... such as "foo.cpp: In member function 'bar': ...".
These weren't caught at all, because the file name has no line number.
They did show up in the issues pane, because the ld parser accidentally
caught them, but they were not properly merged with their context.

Change-Id: I29a757879c21a051cb31c65497b3ad2bfff2315e
Reviewed-by: hjk <hjk@qt.io>
2020-07-28 13:31:08 +00:00
hjk
0e5cc282e6 ProjectExplorer: Small code cosmetics
Unused declaration, const, ..

Change-Id: I0de544ba9be36a291fec5d1ab187e038a4fcc464
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 11:59:22 +00:00
David Schulz
91e78936fe LSP: prevent nullptr access
Found by coverity scan

Change-Id: Ibc243abbb40cde8c670084c9486fdd2f47b137de
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-28 11:35:17 +00:00
Robert Loehning
cf183a898d Android: Clarify error message
Change-Id: Id85c6a96ec2ffcb3bfd027ffdcc99ff97e1dd8ac
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-28 10:40:58 +00:00
Leander Schulten
fdd70d898d CppEditor: Don't create 'namespace xyz{}' if there is 'using namespace xyz'
Change-Id: Idc08de5f44ccac0de8490158199c4e44f7efe79e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 09:53:48 +00:00
Assam Boudjelthia
88be337b0d Android: change openssl error dialog Ok to Cancel
Change-Id: Ib2be438e330c969a2ddb46db35c8f11e5cf94e9e
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-28 09:43:55 +00:00
Christian Kandeler
8469886ab8 Valgrind: Fix test failures
Change-Id: I4b8b69ecdf537f38d062dc62cf6c91ce92edcd8a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 14:26:01 +00:00
Christian Kandeler
a54d24d497 VCS: Fix unit tests
... when building with cmake or qbs.

Change-Id: Ib3a04da6e145a21e60488dab80c5fde86eaaa06b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:56:14 +00:00
hjk
fca6eee65c ProjectExplorer: Make ArgumentsAspect resettable
Useful for NimbleBuildStep and similar to what WorkingDirectoryAspect
has.

Change-Id: Ibd88f84b5d150af7cbf74bda89a45494a4521998
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-27 12:18:15 +00:00
Robert Loehning
dcbf15cf2e Core::OutputWindow: Use proper numerus form
Change-Id: I0c8da8a49a436ff9f8bcdcb02756be1734406df2
Reviewed-by: hjk <hjk@qt.io>
2020-07-27 08:03:41 +00:00
Alessandro Portale
7b6d44a90a Android: Introduce constants for Android ABIs
Avoiding string duplication prevents typo-related runtime errors and
allows an IDE to use find symbol rather than plain text search.

Change-Id: I7fba7c7c5cf90c0b371efce3b575537b2708dd0f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-26 05:49:49 +00:00
Andre Hartmann
e903f9e350 Git: Fix quoting of repository name
... in the "Uncommited Changes Found" dialog.

Change-Id: I7f987786f4aada47983b849419e2443311dec75f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-07-24 14:04:15 +00:00
Christian Kandeler
bed084bd74 qbs build: Fix meson autotests
Change-Id: If2f57ac6fd622dae69a736a89d90f76c7653eee0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-24 12:15:38 +00:00
Tim Jenssen
49bce1d9e6 qmlpreview: fix compile
Change-Id: I7c9b82637217e45c6d239413df07cc9d62440603
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-23 17:05:29 +00:00
Robert Loehning
7ce989a306 VcsManager: Tell user which file is going to be deleted
Change-Id: I72a853cf65d0bd697379c1738657f098243b814d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-23 15:48:13 +00:00
Robert Loehning
5c0b3196ef ProjectExplorer: Fix iterating through files to remove
Change-Id: I680f8e40248dbbf4f4ee76765fad7a99944b0a5f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-23 15:47:39 +00:00
Robert Loehning
1203be0bc3 ProjectExplorer: Don't prompt user whether 0 files should be deleted
Change-Id: I893c8af5e2c0f0172dd397732275bdec9918bc44
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-23 15:47:10 +00:00
Assam Boudjelthia
7775334998 Android: regression fix for warning missing ANDROID_ABIS
Ammends 27514fa94d.

Task-number: QTCREATORBUG-23291
Change-Id: Iadf33f9c60a738c9ee4c810bb065667cab29aa92
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-23 15:16:03 +00:00
Christian Kandeler
73f3056c3e CppEditor: Add class member from member initialization
That is, if a class member being initialized is not yet declared, offer
to add the declaration.

Fixes: QTCREATORBUG-11842
Change-Id: I1d2a56ab99543e996e220aa26b7923023dd163f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-23 12:57:29 +00:00
Christian Stenger
86eadb4d1b CPaster: Inform about a permanent redirect
Helps to keep track of the current workaround and replace
it again with using the updated URL on a permanent move.

Change-Id: I913dbd7be18d77c9a8d52f1dd931cc5b30320fa2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-23 12:42:52 +00:00
Assam Boudjelthia
27514fa94d Android: Warn if the selected device main ABI is not selected
Task-number: QTCREATORBUG-23291
Change-Id: I2ae13edaee30c6548a37e077c18f508a42b42d25
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-23 11:48:51 +00:00
Tim Jenssen
955f124ffd fix build on older compilers
Change-Id: Id5ccad524c7609eb789d7fa805ace0719a807e65
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-23 11:43:43 +00:00
Alessandro Portale
e0915b7eff Android: Fix rendering of settings background in dark mode
This amends faad83d5a3 by undoing the
insertion of a QScrollArea + QWidget under the whole form. The reason
for adding this was to be able to scroll down to the license agreements.

Since Core::SettingsDialog already puts the settings widget into a
QScrollArea, we have two of those and one is superfluous. When using a
dark theme (e.g. flat-dark), this extra QScrollArea introduces wrong
background color. Also, it complicates the already quite blown
androidsettingswidget.ui

This change removes the QSrollArea + QWidget while keeping the feature
of scrolling to the license text. This is achieved by searching through
the parent chain for a QScrollArea and using the first found one for
scrolling.

Task-number: QTCREATORBUG-24379
Change-Id: I2bdae9367eb06b68fa47badf2556eb1ec7ebcafb
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-23 10:28:48 +00:00
Tim Jenssen
1f702edfd3 qmlpreview: add debugtranslation ui
action in the menu will only be shown if a QtStudio Qt is found
qtversion.xml
   <value type="QString" key="overrideFeatures">QtStudio</value>

 - still have some issues with multiple file test runs
   so disable it for now
 - elideWarning is not tested

Change-Id: I68c9f774a980b84cd4eea1595775fd01afa6f3cf
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-07-23 09:42:46 +00:00
Tim Jenssen
bde420f7b7 qmlproject: rename lastUsedLanguage -> currentLocale
removed the connection from plugin to
QmlMultiLanguageAspect::setCurrentLocale
but calling it directly in QmlPreviewPlugin::setLocale

Does not matter which method is called it will change the right
thing only once because it is checking if it already have the
set locale.

Change-Id: I6cb4b115788adc103481dcda45e3214a0cd73401
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-07-23 09:14:31 +00:00
Alessandro Portale
8a8453e55d Android: Set more columns in AVD table to ResizeToContents
Give the columns with potentailly more content some space.

Change-Id: I4c213f97df077801e3b11ef09519973a61c58c4f
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-23 09:04:27 +00:00
Assam Boudjelthia
ee1b8c2f16 Android: move tooltip from ui to widget class and shorten long phrases
Change-Id: I15bd9f54e7d4dbc3fae62b331172d6bc8e74e7ad
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-23 09:00:54 +00:00
Christian Kandeler
e4100c31fc CppEditor: Fix trailing whitespace after extracting a function
... from a block of code.
We must not insert an empty line into the newly created function,
because it gets indented in the first indent operation, resulting in
trailing characters after the actual code has been inserted later.

Fixes: QTCREATORBUG-12118
Change-Id: If438d4de379cae90baa846c112866f2777b44fce
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-23 09:00:44 +00:00