... when constructing a run configuration display name.
The target name is not typically a file name and might legitimately
contain a dot.
Fixes: QTCREATORBUG-25480
Change-Id: I7954763661d36ae20b931d6d05ef3e29b36a9fc9
Reviewed-by: hjk <hjk@qt.io>
This follows suit which what is currently happening in other plugins.
Change-Id: I5fb75e23d7d6add632cd07c732131b4f9793d345
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
A 'true || ...' was used while testing aa69415ac7 and was accidentally
committed.
Change-Id: I07d56035e93944e20cf1d2f5808ce3cbff1c5d5e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Splashscreen shows some information text
if that define is set.
Change-Id: I272eb470b8c2493577a50451a3c11832254b16b8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The existing logic (in qmljsinterpreter.cpp) for updating used imports doesn't work correctly. It takes into consideration items that are not
part of the currently open document. Fixed by checking current model
items in the document and updating used imports based on it.
Fixes: QDS-3785
Change-Id: Ia50c3c7e7ca41b9bca0d69e7c2e253f29892933e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Amends b569258748. The change dropped the special setup of
m_warnAgainstUnalignedBuildDir and fumbled when flipping the
the internal value for m_ignoreSystemFunction/m_runSystemFunction.
Almost back to the first patch: Keep the value under the name (and meaning)
"RunSystemFunction", but flip it for internal storage and user display.
Change-Id: I4e8cf430fd9ad922357b581b862b7e491c035977
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
They were quite similar, largest difference was the ownership of
subaspects, which is now handled by a bool property.
Change-Id: Ib3f2f20b9a84ef40ea8a9eb59da9c89c9a281750
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This only handles the storage side, all gui/layouting is left for
follow-up changes.
Change-Id: I0f2b6dc82e5d4374528c8a72610a5afe264a72b1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
On Windows, we would start with a clean environment just with the emsdk
environment added in order to run "em++.bat -dumpversion".
That fails for some emsdk versions for reasons unknown. Let's reduce OS-
specific special casing and instead use the system environment as basis
everywhere.
Change-Id: I143fe6193528390e17ee0a62936ad03d2c5a109e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
- use newer approach to settings page layout building
- no SHOUTING enums
- namespaces
- proper dialog parent for message
Change-Id: I7adfb7487d502b8fd706c4a0c5645f4d2153e39c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
coreplugin/CMakeLists.txt uses BUILD_WITH_CRASHPAD and not
the old not existing variables
Change-Id: I5ad9ebb3cf0ac1ee06d53a1e276d70a194b0ace4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The multi configuration generators (Visual Studio, Xcode) had an
empty "Build type" which caused failures to parse the CMake file-api
information.
Change-Id: I70ee4978cee4d43e980edf4cd512d1ca95275638
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The new default "true" for "Ignore qmake's system() function when
parsing a project" broke initial parsing of an opened qmake project.
Task-number: QTCREATORBUG-25536
Change-Id: Ia155e27051a030b5fbf34ab3b94d7be2b952eb9b
Reviewed-by: hjk <hjk@qt.io>
Check if a project does actually exist.
Task-number: QDS-3309
Change-Id: I59beff2637bbe80175dd223d6f574ea3886d95c5
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Warn, instead of crash in case the aspect implementation changes.
Change-Id: If74cb91395e317765d493a97dcd1cdecc6f94296
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It move the magic number of column results to the sql statement
and improves the mock a little bit.
Change-Id: I101067444cf27ec5dea0c72de7fd484a7e8710f0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The display name is continuously read and written from/to settings.
Let's not add markup each occurrence, it accumulates.
BuildStep::summaryText has the logic to add the markup for the UI.
Change-Id: Ifbb74ccb8d2f0adcebbd69cc012a5b1376154934
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
... in connection with CMakeBuildConfiguration initialization.
Having an Android device type does not necessarily mean an Android Qt
version is selected in an incomplete kit.
Change-Id: Ib157166c45b7d2ac20eafd6437054b9232595c1e
(cherry picked from commit fdd69e27b3)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The removed margin around the subform at the bottom is intentional.
Change-Id: Ia598a6189111346b0f23f7aa4801ad0db1725fb9
Reviewed-by: David Schulz <david.schulz@qt.io>
AdbCommandWidget is cumbersome to use and has issues regarding updating
the enabled state of the buttons and the dragging and dropping of items.
Cut the maintenance and replace AdbCommandWidget with a StringAspect,
where one line means one entry, just like several other places in Qt
Creator do.
Some residue remains though: in order to keep project settings
compatibility, we need to convert from QStringList (settings) to QString
(StringAspect) and back.
Change-Id: I3ebfff882358ba2e8c0ac6d5b309e89a84f0554c
Reviewed-by: hjk <hjk@qt.io>
... in connection with CMakeBuildConfiguration initialization.
Having an Android device type does not necessarily mean an Android Qt
version is selected in an incomplete kit.
Change-Id: Ib157166c45b7d2ac20eafd6437054b9232595c1e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
"Add Prefix" adds prefix /new/prefix%1 which should be updated by user most
likely.
Change-Id: I0978574b38eb74b39c1cc8377ef1ab9008a4d88e
Reviewed-by: hjk <hjk@qt.io>
