Commit Graph

68568 Commits

Author SHA1 Message Date
Thomas Hartmann
a1ce4c9bc7 QmlDesigner: Fix crash
Change-Id: Ia96a163efb6a612861d5cc90e37a121fcb3db646
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-30 09:54:04 +00:00
Leena Miettinen
8d00e04f24 Doc: Update info about Flow View and related items
Task-number: QDS-3824
Change-Id: Id036f5643fd30204c212944d26ac05b8f3a0b692
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <kama.wojcik@qt.io>
2021-03-30 09:25:39 +00:00
hjk
341132dd0a CMake: Code cosmetics
- use newer approach to settings page layout building
- no SHOUTING enums
- namespaces
- proper dialog parent for message

Change-Id: I7adfb7487d502b8fd706c4a0c5645f4d2153e39c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-03-30 08:57:31 +00:00
Marco Bubke
710b96cc89 Sqlite: Value can now handle blob too
This can be quite handy if we want to handle images in the database
dynamically.

Change-Id: I76b87d6b59e999b043bb2335192c90a371187431
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-30 07:30:08 +00:00
Marco Bubke
393c65e34e Sqlite: Use std::byte
Change-Id: Ie5bdbae67f7d0f9e533ad20ddb66d03057df2028
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-30 07:30:02 +00:00
Marco Bubke
f57694948e Sqlite: Cleanup sqlite statement
Change-Id: I727a95491a45fe01bf59821d4f451f25483745ed
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-30 07:29:55 +00:00
Tim Jenssen
22099bd71a crashpad: fix execute permission
Change-Id: I44f5412b3903349f8cfbe12307fdf3bc2b24a6c8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-03-29 17:22:50 +00:00
Aleksei German
0768ec8687 QmlDesigner: Fix for color roles
Change-Id: I6336130d7db684a13081e5a128753816bf5bbcc5
Fixes: QDS-4038
Fixes: QDS-4039
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-29 14:18:42 +00:00
Leena Miettinen
de597ce821 Doc: Update the QDS workflow image in Getting Started
Task-number: QDS-3985
Change-Id: I470ba3c453fbb4fd1863d87073bb5cb6201ca55b
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-29 14:13:40 +00:00
hjk
09f632d4c7 Utils: Delete aspect subwidgets one by one
Items deleted in finish() trigger via the connect in registerAspect their
own removal from m_subWidgets, invalidating container iterators used
by deleteAll().

The re-ordering to back-to front does not make a difference, I'd
still to destroy things in reverse construction order.

Change-Id: Ibb17da7cdc67013d744b159aa33fd1d119080e3b
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-29 12:38:25 +00:00
Tim Jenssen
dc2710cd00 crashpad: fix windows builds + show settings checkbox
coreplugin/CMakeLists.txt uses BUILD_WITH_CRASHPAD and not
the old not existing variables

Change-Id: I5ad9ebb3cf0ac1ee06d53a1e276d70a194b0ace4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-03-29 12:25:41 +00:00
Johanna Vanhatapio
efc6d08915 Doc: Remove the extra qdoc command
Change-Id: Ica5fe790156f2e1ffffd5f343c4fd60434dfc69a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
qds/v2.1-beta2
2021-03-29 09:13:19 +00:00
Johanna Vanhatapio
0da8cbaf8e Doc: Update info about applying 3D materials
Fixes: QDS-4032
Change-Id: Idbaea9f0d47ef4be894f68e884722c8dcab734d1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2021-03-29 08:06:34 +00:00
Leena Miettinen
30c5fd6599 Doc: Update info about building with CMake
Reorganize tool-specific information into separate topics.
The other build systems will be added in follow-up commits.

Fixes: QTCREATORBUG-25460
Change-Id: I324f66a464d7ab799e351e77ebe20f29fb091622
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-03-29 06:59:16 +00:00
Allan Sandfeld Jensen
9a5d04f4fa Fix qmake build
Change-Id: I5730de131f90c198bdf14b6983a4dbc0efbdcea5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-03-29 06:32:20 +00:00
hjk
6a6e7c90df Utils: Add a StringAspect::valueChanged signal
Similar to what BoolAspect already has. Will help with the NimSettings
page.

Change-Id: Id373cd21769c129fb8329d9102ccfd97675e8d24
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-29 05:28:25 +00:00
hjk
bff4022e98 CodePaster: Some more settings page cleanup
Change-Id: Ieac61eda5081025a3fe3cbbfffbd46d5433d0ebc
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-29 05:25:38 +00:00
Cristian Adam
a862c7b354 CMakePM: Fix "Build type" for multi configuration generators
The multi configuration generators (Visual Studio, Xcode) had an
empty "Build type" which caused failures to parse the CMake file-api
information.

Change-Id: I70ee4978cee4d43e980edf4cd512d1ca95275638
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-03-26 19:36:19 +00:00
Alessandro Portale
4465e60afd QMakeProjectManager: Restore original settings defaults
The new default "true" for "Ignore qmake's system() function when
parsing a project" broke initial parsing of an opened qmake project.

Task-number: QTCREATORBUG-25536
Change-Id: Ia155e27051a030b5fbf34ab3b94d7be2b952eb9b
Reviewed-by: hjk <hjk@qt.io>
2021-03-26 19:08:29 +00:00
Thomas Hartmann
254365b7d6 StudioWelcome: Set correct file for Digital Cluster
Change-Id: Idf8513a7db3c7e096c814395ffa701689e1cc0cf
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-26 17:15:05 +00:00
Thomas Hartmann
ee281240eb StudioWelcome: Fix crash
Check if a project does actually exist.

Task-number: QDS-3309
Change-Id: I59beff2637bbe80175dd223d6f574ea3886d95c5
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-26 17:14:56 +00:00
Thomas Hartmann
981e3e734f StudioWelcome: Add effect demo ad download
Change-Id: I95346189de1a6915f8b971cd2c9f69a027f63f6a
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-03-26 17:14:45 +00:00
Cristian Adam
a96a94ac79 GitHub Actions: Build without PCH
ccache is not working very well when pch is enabled.

Change-Id: I2922d2261bf4040ccd2837b2cc5c505ec2881207
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-03-26 17:11:16 +00:00
Alessandro Portale
07f1aa7ed1 CMakeProjectManager: Remove left-over qDebug()
...from CMakeBuildSystem::updateQmlJSCodeModel

Change-Id: I2f0db764266d5580c47fb99bc6637bcd0ba508ca
Reviewed-by: hjk <hjk@qt.io>
2021-03-26 15:19:25 +00:00
Michael Winkelmann
5fa2911c63 Editor Proxy: Fix warnings and code style
Change-Id: I978aef31f7c09da33509dddd2a13ae138551c914
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-03-26 14:58:12 +00:00
hjk
5a9b715fed Android: Robustify aspect access by id
Warn, instead of crash in case the aspect implementation changes.

Change-Id: If74cb91395e317765d493a97dcd1cdecc6f94296
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-03-26 13:45:02 +00:00
hjk
beda749326 CMake: Aspectify CMakeSpecificSettings
Change-Id: I2e094c5a392964fdaf49ac30c2e0ae0f57a3b11d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-03-26 12:40:08 +00:00
Marco Bubke
7785a3a651 Sqlite: Move result count to class declaration
It move the magic number of column results to the sql statement
and improves the mock a little bit.

Change-Id: I101067444cf27ec5dea0c72de7fd484a7e8710f0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-26 12:24:37 +00:00
Alessandro Portale
a25ea9febe Android/iOS: Don't add markup to display names of build steps
The display name is continuously read and written from/to settings.
Let's not add markup each occurrence, it accumulates.

BuildStep::summaryText has the logic to add the markup for the UI.

Change-Id: Ifbb74ccb8d2f0adcebbd69cc012a5b1376154934
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2021-03-26 11:21:36 +00:00
Eike Ziller
eb516063d3 Fix build with Qt 6
Change-Id: I546dd9457e68b9ff59b0fe50248553736d18729b
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-26 10:48:11 +00:00
Leena Miettinen
c79df73bde Doc: Add info on exporting nested Figma component instances
Fixes: QDS-4049
Change-Id: Ia5f370bab2d44fc90ded48ddc8b089bc9975d921
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2021-03-26 10:44:45 +00:00
hjk
daf19fec84 Core: IOptionsPage code cosmetics
Header sorting, common pattern for namespaces.

Change-Id: I22b37faad459083ee87acb83ece80c7ac9f404e9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-03-26 10:43:45 +00:00
Jarek Kobus
d3faab0e72 StringTable: Use QElapsedTimer instead of QTime
Change-Id: I75065cbe32dcd4405360b90f3f51387f286d6186
Reviewed-by: hjk <hjk@qt.io>
2021-03-26 10:31:28 +00:00
Eike Ziller
daf23d29a1 Update perfparser to head of 4.15 branch
Fixes build with Qt 6.

Change-Id: I449f8ee0e507fbd9e4d1fe69aeaf38fa4da65cc4
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2021-03-26 09:32:39 +00:00
David Schulz
bd47caa348 LSP: Prevent soft asserts in LanguageClientArray::toList
Change-Id: Icb935137d389c223ac1360b4a7e0af5c303b793c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-03-26 08:43:54 +00:00
Eike Ziller
a0d3d89e3f Bump version to 5.0 beta1
Since we almost always do incremental changes instead of major overhauls
in one go, it doesn't make sense to couple changes in the major release
number to major feature overhauls (which is why we've stayed at "4"
since a few years now).

Switch to a version scheme more like semantic versioning. So next
feature release is 5.0, and the following feature-release after 5.0 will
be 6.0, and so on. After all we do break public API in these releases.

Fixes: QTCREATORBUG-25486
Change-Id: Id8510dd75077386e59c537a0c9768f27120a998a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2021-03-26 08:20:28 +00:00
Tasuku Suzuki
2ea13a359a QbsProjectManager: Fix context menu grouping warning
3bd490acdb introduced a warning
Can't find group "ProjectExplorer.Group.Build" in container
"Project.Menu.Project"

Change-Id: I1a382f7e807b79a938ec70fd3b1b0a27d54c29f9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-03-26 07:53:11 +00:00
Leena Miettinen
9d0c3dc3d6 Doc: Describe new Language Client options
Fixes: QTCREATORBUG-25530
Change-Id: Ia59e476cdd6a1d655f269293c8e6ef97c5b084b5
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-26 07:53:07 +00:00
hjk
23f6aea6d3 Android: Prevent crash in AndroidManager::applicationAbis
... in connection with CMakeBuildConfiguration initialization.

Having an Android device type does not necessarily mean an Android Qt
version is selected in an incomplete kit.

Change-Id: Ib157166c45b7d2ac20eafd6437054b9232595c1e
(cherry picked from commit fdd69e27b3)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-03-26 07:52:40 +00:00
Vikas Pachdha
28de5ec4fd AssetExporter: Export type Label as text
Task-number: QDS-3979
Change-Id: I0920d242a480da9a27f26d39b44ab1d3714917e4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-26 07:31:46 +00:00
hjk
c38739df57 Debugger: Use new IOptionsPage apply convenience
Change-Id: I2954bec762fb3f5d3426663108ff493f140f1b5e
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-26 07:20:31 +00:00
hjk
1dba079cbd Python: Use LayoutBuilder in settings widgets
The removed margin around the subform at the bottom is intentional.

Change-Id: Ia598a6189111346b0f23f7aa4801ad0db1725fb9
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-26 07:09:26 +00:00
hjk
7651601f19 Utils: Introduce a standard way to have a Reset button for StringAspects
Resets line edit contents to defaultValue(), disabled if current
contents is the default.

Usable later for BuildPropertySettings

Change-Id: I1fcbcfb8664eb7f66de62a6606d8d7556026f468
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-03-26 07:06:09 +00:00
Alessandro Portale
bc7d0561c3 Android: Simplify pre-/post-run adb command input
AdbCommandWidget is cumbersome to use and has issues regarding updating
the enabled state of the buttons and the dragging and dropping of items.

Cut the maintenance and replace AdbCommandWidget with a StringAspect,
where one line means one entry, just like several other places in Qt
Creator do.

Some residue remains though: in order to keep project settings
compatibility, we need to convert from QStringList (settings) to QString
(StringAspect) and back.

Change-Id: I3ebfff882358ba2e8c0ac6d5b309e89a84f0554c
Reviewed-by: hjk <hjk@qt.io>
2021-03-26 07:02:31 +00:00
hjk
fdd69e27b3 Android: Prevent crash in AndroidManager::applicationAbis
... in connection with CMakeBuildConfiguration initialization.

Having an Android device type does not necessarily mean an Android Qt
version is selected in an incomplete kit.

Change-Id: Ib157166c45b7d2ac20eafd6437054b9232595c1e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-03-26 06:58:36 +00:00
Tasuku Suzuki
c4b730b002 ResourceEditor: Set focus to the prefix line edit after creating new one
"Add Prefix" adds prefix /new/prefix%1 which should be updated by user most
likely.

Change-Id: I0978574b38eb74b39c1cc8377ef1ab9008a4d88e
Reviewed-by: hjk <hjk@qt.io>
2021-03-26 05:59:31 +00:00
Andre Hartmann
60a275ce62 CompileOutputWindow: Fix creation of task positions
When jumping from the issues pane to the compile output,
the selected text was always starting and ending one line
earlier than expected.

Probably broken by 1c6e4fbd3.

Fixes: QTCREATORBUG-25497
Change-Id: Ia5b796f27faa91e45b10b945dbf6261f1dbce036
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-03-25 19:38:00 +00:00
Mahmoud Badri
1dd52d39af QmlDesigner: Fix dropping files to assets view when in list mode
Fixes: QDS-3996
Change-Id: I1ef38fc784d2cf97a370caa39e42d6d7bf6bc6ea
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-25 18:11:27 +00:00
Eike Ziller
44d31cb687 cmake build: Disable PCH for CMake < 3.18 with GCC
https://gitlab.kitware.com/cmake/cmake/-/issues/20119 was fixed in
CMake 3.18.

Change-Id: Iad335e8c7a70069404f5c80bb3b65c0d52f82393
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-03-25 17:44:15 +00:00
Robert Löhning
cd0a140bde Improve translatable strings
Change-Id: I0104209bb0f865a48f9ca2524f62457f7524bba9
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2021-03-25 16:53:40 +00:00