Commit Graph

115 Commits

Author SHA1 Message Date
hjk
ef0a19d926 analyzer: less global symbols
Change-Id: I2f771c7dc2a709611c68b97a5287804d4b8590fd
Reviewed-on: http://codereview.qt.nokia.com/2632
Reviewed-by: hjk <qthjk@ovi.com>
2011-08-04 15:42:44 +02:00
Kai Koehne
1757228278 New QTC_CHECK warning replacing QTC_ASSERT(x, /**/)
Warn if the condition fails, but otherwise don't change the execution
flow.

Change-Id: Id7b14c745109b66960add967b2a4ef8d31e1a546
Reviewed-on: http://codereview.qt.nokia.com/2389
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
2011-07-29 12:19:11 +02:00
hjk
019c5ce6ef analyzer: potential fix for not-up-to-date actions
I cannot reproduce the issue locally. This removes a test whether
something has changed before updating the actions.

Change-Id: If32a7911a6b7ebde65d6dcd45d1eaae6a09933fa
Reviewed-by: con
Task-number: QTCREATORBUG-5405
Task-number: QTCREATORBUG-5357
Reviewed-on: http://codereview.qt.nokia.com/1526
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
2011-07-13 15:36:26 +02:00
Eike Ziller
d7c2c23da8 Fix initial layout in analyze mode.
Task-number: QTCREATORBUG-5414

Change-Id: I4ac8d150f20e35a769e6f7f13db420d81e93e7e2
Reviewed-on: http://codereview.qt.nokia.com/1552
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-13 09:29:34 +02:00
hjk
c96668fe06 analyzer: add 'Locked' and 'Reset to default' actions to Views menu
Change-Id: Ia5677b250fefe8fcfe731a06aabb6d2f2988a03d
Reviewed-on: http://codereview.qt.nokia.com/1491
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
2011-07-13 08:48:10 +02:00
hjk
be8337f69f analyzer: remove unneeded AnalyzerPluginPrivate class
Change-Id: I2fac5e0e8c796d6009ba30da82a5a7a67672851d
Reviewed-on: http://codereview.qt.nokia.com/1517
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-12 12:51:07 +02:00
hjk
868613b5ed analyzer: merge dockwidget and toolbar creation.
Now that dock and control widgets are always created as late as
possible and both are needed immediately afterward it makes sense
to merge there construction. This also reduces the chance to create
a partial tool gui in an inconsitent state.

Change-Id: Ic7f405d65b2b8f0b4ee3ff0ef991d6e4746bac0a
Reviewed-on: http://codereview.qt.nokia.com/1249
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-07 10:37:04 +02:00
hjk
4823487b59 analyzer: fix control/dockwidget construction order
Change-Id: Id39c55617c6441b221fc321d71e73168f2b3e4bd
Reviewed-on: http://codereview.qt.nokia.com/1245
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-07-07 10:36:44 +02:00
hjk
38c7f981cc analyzer: postpone selecting saved tool
... until the analyze mode is actually selected

Change-Id: I7d03c48a4b4260d54bf3218b3a493ceacd2d2967
Reviewed-on: http://codereview.qt.nokia.com/1243
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-07 10:33:17 +02:00
hjk
8d8d9d4645 analyzer: directly start tools from menu
Change-Id: I385abbd906e975b75b1c01e597b6e366c5c57126
Reviewed-on: http://codereview.qt.nokia.com/1180
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
2011-07-06 12:41:44 +02:00
Christiaan Janssen
45212d3c1a QmlProfiler: handling start/stop actions
Change-Id: I940025ba1f35f6136b4a12936b9e508ccb9d0d1f
Reviewed-on: http://codereview.qt.nokia.com/1160
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-05 13:13:00 +02:00
hjk
a89158b887 analyzer: handle all possibilities to start qml profiler in QmlProfilerTool
Change-Id: I286bdc4dc3fbab2e784e72f47ff02644cc2899e5
Reviewed-on: http://codereview.qt.nokia.com/1096
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-05 12:12:21 +02:00
hjk
be452fcaff Revert "analyzer: move convenience factory back to base plugin"
This reverts commit 06a41da04e.

Change-Id: I06a41da04e726ffd35da18d99cd2f46cb99467bf
Reviewed-on: http://codereview.qt.nokia.com/1094
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-05 12:09:25 +02:00
hjk
06a41da04e analyzer: move convenience factory back to base plugin
Change-Id: Ife82b74ce4b457dd9e6a6cc3749cb629aeeacf58
Reviewed-on: http://codereview.qt.nokia.com/1086
Reviewed-by: hjk <qthjk@ovi.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
2011-07-04 16:23:38 +02:00
hjk
36a3028b9d analyzer: refactor progress
Change-Id: If74c8035bc83a8113c2a15dcacefa38afbbbb4d8
Reviewed-on: http://codereview.qt.nokia.com/1056
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:02:36 +02:00
hjk
2086d94866 analyzer: finish split of tools into "tools-with-modes"
Change-Id: I82b61c07172a33b861a7d6db903ac2516019498b
Reviewed-on: http://codereview.qt.nokia.com/1054
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:02:13 +02:00
hjk
d6bf0c3732 analyzer: remove dummy control widgets
Change-Id: I9c15e557699f2f321619fb07feea8d4489006c83
Reviewed-on: http://codereview.qt.nokia.com/1053
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:02:01 +02:00
hjk
fd370662ba analyzer: cleanup mode construction
Change-Id: Icdb89bb581a234820e0c6318f20f8e033ed7b3f0
Reviewed-on: http://codereview.qt.nokia.com/1052
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:01:35 +02:00
hjk
f0a0e5b1ea analyzer: move responsibility for run modes to individual tools
Change-Id: Iaf2fa9d4c087470649336a453c6a9a7db12d220f
Reviewed-on: http://codereview.qt.nokia.com/1051
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:01:25 +02:00
hjk
daefb0c83a qmlprofiler: simplify plugin construction
Change-Id: I26fe148669656637a82a30012e8632b105d4f073
Reviewed-on: http://codereview.qt.nokia.com/1050
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:01:13 +02:00
hjk
99d9f065b3 analyzer: refactoring of analyzer manager
Change-Id: I60268b8bc86e439beb3fca8f4b6a87ea03925bad
Reviewed-on: http://codereview.qt.nokia.com/1049
Reviewed-by: hjk <qthjk@ovi.com>
2011-07-04 12:01:00 +02:00
hjk
bbe427ac1f analyzer: reorganize local/remote starts
Change-Id: I6273ea7ea50fd2bddad3a627e4616fe93e8398b9
Reviewed-on: http://codereview.qt.nokia.com/921
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-06-29 18:44:46 +02:00
hjk
5ab3d58cce analyzer: remove unused DockWidgetEventFilter
Change-Id: I0ddcd555efc900905703669040f792fb7c4d95c9
Reviewed-on: http://codereview.qt.nokia.com/909
Reviewed-by: hjk <qthjk@ovi.com>
2011-06-29 16:27:52 +02:00
hjk
b6c0f3d8a6 analyzer: refactor AnalyzerManager
Change-Id: Id925bb638b2757ef079c21192d4e2a8cc8f08694
Reviewed-on: http://codereview.qt.nokia.com/908
Reviewed-by: hjk <qthjk@ovi.com>
2011-06-29 16:27:39 +02:00
hjk
4ead16afcd analyzer: dissolve "Start" menu button
Icon missing.

Change-Id: I85f9f6361a336260e731f71aab037ac60c4a1aac
Reviewed-on: http://codereview.qt.nokia.com/894
Reviewed-by: hjk <qthjk@ovi.com>
2011-06-29 13:19:37 +02:00
hjk
c43f3c848f analyze: create a top level menu entry
Change-Id: I17c4d17583d401fb537d5956f5b07a1dc12906e1
Reviewed-on: http://codereview.qt.nokia.com/893
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-06-29 13:19:24 +02:00
hjk
a9f53ec9c5 analyzer: remove output pane
It's all dockwidgets now.

Change-Id: Ia47ca9331fdfbe12ca11f77c26afc35e73a2fae3
Reviewed-on: http://codereview.qt.nokia.com/776
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
2011-06-27 16:17:11 +02:00
Friedemann Kleint
a56162ec6e tr()-Fixes for 2.3: No contractions, spelling.
Change-Id: I08babdb15bcf7f7ac086e9e12955b780b7591391
Reviewed-on: http://codereview.qt.nokia.com/480
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-06-14 17:18:48 +02:00
dt_
42e5e5f00a Show tooltip on disabled run actions
Change-Id: I9b5eaa49e14b71b9d1f8ac84aa7cb7bb4d014cac
Reviewed-on: http://codereview.qt.nokia.com/192
Reviewed-by: hjk <qthjk@ovi.com>
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
2011-05-27 16:58:05 +02:00
hjk
10317564f1 analyzer: simplify dockwidget setup
Change-Id: Id450ee1d6ad24707536f9b35e7868e5f8ce9dab2
Reviewed-on: http://codereview.qt.nokia.com/59
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk
2011-05-23 14:57:53 +02:00
hjk
251bff8a9c analyze: rework 'addDock'
Change-Id: I3ce22c3f75d5cc631ab22e02f8a52af00452c0c3
Reviewed-on: http://codereview.qt.nokia.com/57
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk
2011-05-23 14:57:40 +02:00
dt
e5a42e2dc0 Remove unecessary include
Change-Id: I25171ca3f2d1e69be289ea6c40f5a063b3244868
Reviewed-on: http://codereview.qt.nokia.com/61
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
2011-05-23 11:56:56 +02:00
hjk
c31bc05e2e analyzer: make output pane not pop up automatically in all cases
Change-Id: Ief96ab7093d78915087a273f3eff0b4489c3b370
Reviewed-on: http://codereview.qt.nokia.com/30
Reviewed-by: hjk
2011-05-20 11:00:28 +02:00
hjk
705d450910 analyzer: fix quotes in messages
Change-Id: I611898d9c253cffaa09fa181a99feaf093ccdbe0
Reviewed-on: http://codereview.qt.nokia.com/29
Reviewed-by: hjk
2011-05-20 11:00:14 +02:00
hjk
9d72a6e7c8 analyzer: style
And test for *rr*.

Change-Id: I7905e5df8f981b683d9552fb7cc15f9b8f16624e
Reviewed-on: http://codereview.qt.nokia.com/15
Reviewed-by: hjk
2011-05-19 13:58:49 +02:00
hjk
df91b0bbfb analyzer: cleanup 2011-05-18 16:37:19 +02:00
Kevin Funk
bf1f5c2b02 Fixes for valgrind-callgrind feedback by Nokia
Most changes include style fixes and UI changes for better usability.

Merge-request: 324
Reviewed-by: hjk <qtc-committer@nokia.com>
2011-05-11 16:26:34 +02:00
Friedemann Kleint
4d113c9b4b Analyzer: Introduce delayed initialization of docks.
Introduce AnalzyerTool::initializeDockWidgets to do that.
Work around exit crash in callgrind.
2011-05-06 17:26:01 +02:00
Tobias Hunger
aa2acec14c Fix/add copyright headers
Change-Id: I8b73d583be1ee7183f4074bce49d5390e38631a2
2011-05-06 15:17:05 +02:00
Friedemann Kleint
74d65c7e18 Analyzer: Do not make each tool current on startup.
Avoid adding all dock widgets of all tools to the mainwindow
to save the default settings during initialization.
2011-05-06 14:37:26 +02:00
Friedemann Kleint
be3768328e Analyzer: Store FancyMainWindow defaults without QSettings.
Store hash directly, do not keep QSettings objects around.
2011-04-26 13:43:08 +02:00
Oswald Buddenhagen
dc3c156cac Merge branch '2.2'
Conflicts:
	src/plugins/debugger/gdb/pythongdbengine.cpp
	src/plugins/qt4projectmanager/qt-desktop/qt4desktoptargetfactory.cpp
	src/plugins/qt4projectmanager/qt-desktop/qt4desktoptargetfactory.h
	src/plugins/qt4projectmanager/qt-desktop/qt4simulatortargetfactory.cpp
	src/plugins/qt4projectmanager/qt-desktop/qt4simulatortargetfactory.h
	src/plugins/qt4projectmanager/qt-maemo/maemodeploystep.cpp
	src/plugins/qt4projectmanager/qt-maemo/maemodeviceconfigurations.cpp
	src/plugins/qt4projectmanager/qt-maemo/maemoglobal.cpp
	src/plugins/qt4projectmanager/qt-maemo/qt4maemotargetfactory.cpp
	src/plugins/qt4projectmanager/qt-s60/qt4symbiantargetfactory.cpp
	src/plugins/qt4projectmanager/qt-s60/s60deploystep.cpp
	src/plugins/qt4projectmanager/qt4target.cpp
	src/plugins/qt4projectmanager/qt4target.h
	src/plugins/qt4projectmanager/qtoptionspage.h
	src/plugins/qt4projectmanager/qtversionmanager.cpp
	src/plugins/welcome/welcomemode.cpp
2011-04-14 12:39:31 +02:00
hjk
be9455bc50 mode: make displayname, icon, priority, id, type data members 2011-04-14 11:15:08 +02:00
hjk
70d392d235 core: make context and widget IContext data members 2011-04-14 11:15:07 +02:00
Christiaan Janssen
cbfaea1ed3 QmlProfiler: qmlproject support
Reviewed-by: Kai Koehne
2011-04-14 09:57:08 +02:00
hjk
8397663964 Update license. 2011-04-13 11:49:28 +02:00
Kai Koehne
64fee9c5cb QmlProfiler: Enable attach action only if profiler is current tool 2011-04-04 15:59:31 +02:00
Kai Koehne
02ea914426 AnalyzerManager: Export switching to analyzer mode 2011-04-04 15:59:31 +02:00
Kai Koehne
e5679e8a95 AnalyzerManager: Make menu extendible
Use Commands everywhere, so that other plugins can extend it.
2011-04-04 15:59:27 +02:00
Mike McQuaid
678d1cc9c9 Add analyzer multiple tools, mode & remote support
Merge-request: 284
Reviewed-by: hjk <qtc-committer@nokia.com>
2011-04-04 14:39:28 +02:00