Commit Graph

72473 Commits

Author SHA1 Message Date
Eike Ziller
9091761996 Fix issues with Meson tests
- set temporary directory for launcher
- check for finding meson tool instead of crashing
- use GUILESS_MAIN since it doesn't use gui

Change-Id: I3f8de658d9ccbec3efb260cf2d58e27720e78d47
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-01-12 11:47:02 +00:00
Tapani Mattila
637d1c167b CMake generator: Use qt_add_executable instead of add_executable
Task-number: QDS-5267
Change-Id: I83d82089f1f10ec0a30e7f2c2ed776c31fdcd8b5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-01-12 10:32:13 +00:00
Tapani Mattila
85dab69262 CMake generator: Integrate warnings in confirmation dialog
Task-number: QDS-5856
Change-Id: If95515ee0921598623a024fd7bd8fe8ef3482aa9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-12 10:32:00 +00:00
Tapani Mattila
72c3d675a0 CMake generator: Make file picker a treeview
Task-number: QDS-5836
Change-Id: Ib261ac8750baae7ce55d9c990b5dadb26fc6ac03
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-01-12 10:31:45 +00:00
Thomas Hartmann
b9798f35e6 StudioWelcome: Do not show errors/warnings of welcome page
Change-Id: Id089f86f5bec4d5af3eef0e0200f6e8f2a586303
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-01-12 09:54:00 +00:00
hjk
d4b2f18c5e Docker: Split tryCreateLocalFileAccess() function
... into a parts updating the container access (i.e. shell process)
and the potential local file system access on Linux.

Change-Id: I0d3e7d9e859f15f9e22182fbe7ae1188b0c9ff57
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-01-12 06:51:54 +00:00
Christian Stenger
f6265d706a QmlDesigner: Fix missing dependency
Change-Id: Ie12969d59bd63925f88c973f52de283d410b8c13
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2022-01-12 05:32:10 +00:00
hjk
3342d4477c Docker: Switch Linux file handling to docker --exec by default
Also on Linux, where there's actually a choice.

It's slower, but less fragile when it comes to user ids
and/or file system permissions.

Change-Id: I811612fcff65fad50be18bed21150f6ca7fae93c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-01-11 15:00:08 +00:00
Jarek Kobus
79ce29b5a1 Simplify RemoteLinuxCheckForFreeDiskSpaceService
Use FilePath::bytesAvailable() on remote device instead.

Change-Id: I2431641ea2f4c090439e0380a378e39aa617540a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-01-11 10:15:36 +00:00
David Schulz
28e0a957c5 Editor: avoid duplicated line endings inbetween multiple cursors
Change-Id: Ia1721837efef47d570faa4e393b6b0b372944735
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-01-11 09:16:24 +00:00
Jarek Kobus
eabfc443a7 Use Reader mode for clangbackend
It doesn't look as there would be any write to this process
from Creator side.

Change-Id: I2c16a8ba28d8724d434d3c0f95c7b52616121b4b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-01-11 08:07:31 +00:00
Leena Miettinen
51209b991a Doc: Update Beautifier options screenshot to show correct exe
The current image shows the path to clangbackend.exe instead of
the path to clang-format.exe.

Fixes: QTCREATORBUG-26820
Change-Id: If445f0917ca1bde329e2a5c5410f0e071df566cf
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-01-10 16:47:00 +00:00
Eike Ziller
b028af43ef ToolTip: Guard against nullptr access
screenAt(pos) can be nullptr if pos is outside the current screen
configuration. Seems to be possible when screen configurations change.

Fixes: QTCREATORBUG-26019
Change-Id: I5def200b14247e7fbcf62ad68cda991e8c10c9d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-01-10 15:18:10 +00:00
Jarek Kobus
403ed474e2 Fix ClientServerOutsideProcessSlowTest
Currently the RestartProcessAfterAliveTimeout test is creating
two instances of echoserver, which is not desired. This
patch fixes it by creating just one instance.

Disconnect from disconnected signal before disconnecting
from server in order to not to receive additional
request for restart.

Amends 4007828820

Change-Id: Iaf4994a9373b39bf0b065484e61627704a37672f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-01-10 15:12:01 +00:00
Jarek Kobus
71626a7d16 Make DeviceManager::deviceForPath() thread safe
This method is used from multiple thread inside
most of methods in DeviceFileHooks.

Change-Id: I152fa983c48cb72f8ed2f99da0e7f73b1b8b9a5e
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-01-10 14:35:45 +00:00
Jarek Kobus
e2f7a2a898 Provide a default implementation for doDeviceSetup / stopDeviceSetup
Change-Id: I9f4e15f98039315ddcdd4f40fb6d0802b94da87a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2022-01-10 14:35:11 +00:00
Eike Ziller
6a5fccd676 CMake: Show more variables in config widget
By reducing the height of the editors for the items. At least shows 10
instead of 9 items in the same space on macOS now, and looks less
wasteful.

Change-Id: I422a772cad52a2fcc8223d188b32d8d8adf9bf95
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-01-10 14:26:40 +00:00
Eike Ziller
bc6b05497d Build.py/macOS: Add a signed bundle
If a signing identity is given, create a signed install, and zip it up
(if zip files are wanted).
Can be used to directly add a signed app to an installer.

Change-Id: Ib575d7c907eea74c247407107884f29a526d5d1c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-01-10 13:44:40 +00:00
Eike Ziller
6893721471 ActionManager: Update proxy action more directly
The proxy action was updating from the actual action delayed by a
QueuedConnection. This was introduced in
c3772bfd4c to avoid disconnecting and
reconnecting to QAction::changed while handling that same
QAction::changed.

This introduces a delay between the actual action's change and when it
is reflected in the proxy action.

ProxyAction::update only needs to disconnect signals that would trigger
because of the changes done to the ProxyAction. So it doesn't need to
disconnect/connect from the actual Action's changed signal. Only
disconnect/connect the signals that we really need, and get rid of the
QueuedConnection again.

Fixes: QTCREATORBUG-26363
Change-Id: I2b851af35fcb4a3931b645896dd77477cee79812
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-01-10 12:58:31 +00:00
Eike Ziller
695f254fac Fix filtering in target setup page
- fix "continue" button state (was always disabled after filtering)
- do not loose focus on every key press in filter input

Fixes: QTCREATORBUG-26779
Change-Id: I16960e65b32b5ddfa0e4e5b1acd160492b1c995d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-01-10 11:18:10 +00:00
Eike Ziller
998abe9b7a macOS/deployHelper: Accept if clazy-standalone already has right rpath
Adding an already existing rpath is an error for install_name_tool.
Not completely failing in that case makes local testing easier.

Change-Id: I22d94225af2375af4e397212b2a7500315f25882
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-01-10 10:57:54 +00:00
Eike Ziller
80e0cb56ec Fix build with macOS deployment target < 10.14
As is used for the Qt 5 based prebuilt binaries.
std::optional is only fully supported out of the box since
10.14.

Change-Id: Ide8bd9ac8b66b05e1bb6e9b350edf3e7ffdaf97e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-01-10 10:28:11 +00:00
Antti Määttä
3c2c8b97a1 Use Repeater3D instead of Object3D in component complete check
Do not use QQuick3DObject when disallowing recursive component complete
check so that the animations get added to the instance server.

Fixes: QDS-5731
Change-Id: Iff8e39f74d68b312b66d68adaf6ab79d625f88f8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-10 09:03:53 +00:00
Christian Stenger
e182c3de49 QmlDesigner: Fix qbs build
Change-Id: I714a096d2db88f875e9adbfea8ca8b9535bfcb6e
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-01-10 09:00:54 +00:00
Eike Ziller
501b6eff9c Merge remote-tracking branch 'origin/6.0'
Change-Id: Id84183d2ba73dbe98700af43074cc2d05b26f06d
2022-01-10 09:47:11 +01:00
Mats Honkamaa
a3d5e27edc Doc: Add documentation for multi language function
Added description of the functionality in the Translation view as well
as a tutorial.

Task-number: QDS-5639
Change-Id: I839739058ce899c86080cf3dce7c26dc6fb83d64
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-10 08:33:15 +00:00
Thomas Hartmann
cc56a48bbb StudioWelcome: Support for description and tags
Change-Id: I329cc135452a5048e4a0ef756c041a50a5f75119
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-07 21:48:16 +00:00
Eike Ziller
b068cede11 Fix processlauncher for tests
The socket/name for QLocalServer must be a path that is short enough for
unix sockets (<= 104 chars).

QLocalServer already ensures that the "name" is an absolute path, by
prepending QDir::tempPath() if it isn't. For Qt Creator that worked, but
the temporary directory set up for the unittests resulted in a too long
combined path.

Also, we should avoid directly using QDir::tempPath() and use
Utils::TemporaryDirectory to keep all our temporary files at one place.

So, make the "name" explicitly an absolute path in our specific
temporary directory, and make the name shorter for the test.

See 6feed6e656 for a similar issue.

Change-Id: I07dc4233db1c9d353cd6977da43850256057ba55
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-01-07 13:35:11 +00:00
Thomas Hartmann
4e80d94c37 StudioPlugin: Enable loading of new WelcomePage from share
Change-Id: If7f16909569d555fd814b35e099b4b22c771df7d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-01-07 12:47:42 +00:00
Cristian Adam
dfacdbefa8 CMakePM: Add ability to stop CMake run in Settings
Previously the only way to stop the CMake run was to click on "x"
button of the "Configure" progress bar.

Now you can click in Settings on "Stop CMake".

Change-Id: I167b86ba62679f197c194148b122ff0c87e87162
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-01-07 11:13:54 +00:00
Cristian Adam
94dc8dfac2 CMake: Fix include CheckCXXSourceCompiles file casing name
This will break on Windows systems that have file casing enabled.

Change-Id: I769d27b434e4433ed4e251d6f23efee8698ab0ae
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-01-07 11:08:11 +00:00
Thomas Hartmann
d985c538ba StudioWelcome: Use preview thumbnail
Change-Id: Ifd7ebc6f83ceecf7241379e4ce44d022b4a7310e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-07 10:39:58 +00:00
Marco Bubke
3cf01fbf07 QmlDesigner: AsynchronousImageFactory generates if the image is null
If the image is update but null we still generate a new image. This
is a ugly workaround for the flaky generation process. Hopefully
we can fix it after all hidden dependencies are removed.

Change-Id: I0e344002a1952fb849393d3e245e31612c69d7bd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-06 22:09:39 +00:00
Thomas Hartmann
d987d305ef Theming: Extend theme with color roles for WelcomePage
Change-Id: I1eb8b6231a15cdc427d6d2a08d657bd697379229
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-01-06 22:08:00 +00:00
Cristian Adam
9976f7a57d GitHub Actions: Disable running of tests
Currently the macOS job runner is failing sporadically and since the
tests are only 99% passing and they are only informative only if the
developer actively checks a test in the output log.

Change-Id: Id75d8d05c5fd45f2cc15e08b20973646a06ff6bd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-01-06 19:04:27 +00:00
Alessandro Portale
d17d8ab50f Docs: Convert QDS UI icon pngs in the docs to grey-on-transparent
Use the new tool from the prior commit to recolor the icons from black-
on-white or black-on-transparent to grey-on-transparent in order to
ensure a proper visible contrast against dark and bright background of
the online docs.

Fixes: QDS-5693
Change-Id: Ia6cf378501f3ea526d1c35c089817cd34fa2c62f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-01-06 19:01:38 +00:00
Alessandro Portale
60d7056d6c Docs: Add a python script to recolor UI icons to grey on transparent
There are black-on-white and black-on-transparent icon images in the
documentation. With the new dark theme for the online documentation, the
former variant looks odd, and the latter one is not visible.

The docs team chose to use switch to grey-on-transparent icons, so that
they have enough visible contrast against bright and dark backgrounds.

This change adds a python based tool that converts the existing icons to
grey-on-transparent via ImageMagick, and then optimizes the pngs via
optipng.

Task-number: QTCREATORBUG-26644
Change-Id: Ib14c5a68235b6b906600dcaa1c5094c9cc6ab9b7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-01-06 19:01:21 +00:00
hjk
dc585d37b9 QmlDesigner: Fix compilation
Amends 13789ce2f9.

Drop superfluous toStdString() conversions when operating on
QByteArrays.

Change-Id: I90d9a3617036063dc1276a130dd4a5056e12eb28
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-06 16:07:49 +00:00
Marco Bubke
b2e1bcc4e5 QmlDesigner: Add fetchHasImage to ImageCacheStorage
Change-Id: Ieb148abb02527bb84eda4f00af85a66d98731f03
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-06 14:36:19 +00:00
Marco Bubke
6d7578a75b QmlDesigner: Improve target support
In the long run we have to use a value class of the target pointer which
will be simply copied to the thread and cannot get dangling.

Change-Id: Ib99a69aa9697038887a24300eb234c3baf4eb1b2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-01-06 14:36:15 +00:00
Eike Ziller
bcee5c5dc4 ClangCodeModel: Fix performance regression of code completion
Broke when converting the code to QtcProcess.

Amends 8724a4efbb

Fixes: QTCREATORBUG-26829
Change-Id: I14b4bd9ddc035c1c837231cb6436d9e8e203d5cd
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-01-06 14:34:55 +00:00
Eike Ziller
1df8dd3c93 Revert "Revert "Use QtcProcess for clangbackend""
This reverts commit d65e47b5c6.
Reverts the quickfix for the performance regression of code completion.
Followed by a minimal fix.

Task-number: QTCREATORBUG-26829
Change-Id: I1afe71c24ee94caadd4fa849c29f6fc030fb1a8b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-01-06 14:34:35 +00:00
Cristian Adam
1b8e59729b QmlDesigner: Build fix for MinGW 8.1.0
The headers were not actually used, and by removing them the
MinGW 8.1.0 build is back to green.

Change-Id: I38572696a3c1abc15ec79c1cfd0f7c68ba1fc6b0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-06 14:12:18 +00:00
The Qt Project
0866b26308 Merge "Merge remote-tracking branch 'origin/6.0'" 2022-01-06 12:14:28 +00:00
Eike Ziller
65e8c864af Merge remote-tracking branch 'origin/6.0'
Change-Id: I405e3f95b0cdcd7b2686f31baae16c03c787f007
2022-01-06 11:55:39 +01:00
David Schulz
bab969aa73 RemoteLinux: Fix qbs build without tests
Change-Id: I9a30d434822526a5555c70ffa362a8104e81b230
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-01-06 10:32:17 +00:00
Alessandro Portale
78e229716d Docs: Convert UI icon pngs in the docs to grey-on-transparent
Use the new tool from the prior commit to recolor the icons from black-
on-white or black-on-transparent to grey-on-transparent in order to
ensure a proper visible contrast against dark and bright background of
the online docs.

Fixes: QTCREATORBUG-26644
Change-Id: Ie48b9da269426e3a98a9d70bdf9950cdd924b64d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2022-01-06 09:56:54 +00:00
Leena Miettinen
243521380b Doc: Update CMakeLists.txt files of tutorial example apps
To match the files generated by the application wizards.

Change-Id: If749a6dcc25eacb9daef451fec6abbc879bbc8a8
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-01-06 09:45:03 +00:00
Thomas Hartmann
06137eb789 StudioWelcome: Read mainFile from .qmlproject file
Change-Id: I0fd413cb8334fc3a60b313cee425966745f8a9fe
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-01-06 09:43:13 +00:00
Henning Gruendl
117a8c65b9 QmlDesigner: Replace filewatcher in resource model
Replace the Utils::FileWatcher with a connection to the ProjectExplorer
fileListChanged signal.

Change-Id: Ia2d3a6d239451ed979bbfb654fe5258aadd3c686
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-01-06 08:48:07 +00:00