According to Ossi the only safe characters in a path for qmake are
alphanumerical, underscore, dot and dash.
Task-number: QTCREATORBUG-10980
Change-Id: Ibacbfeb7f04f1f0524093f1d8fce637ea4ae6fd6
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This allows plugins (e.g Andoird, BlackBerry...) to better control
the kits that are auto generated from their SDK/Target sources.
Change-Id: I250451a21364780d083ef99af232ae914f8756f4
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Do not trust kits with an invalid id, as there is no way those
could have ended up being saved out by creator. Safe all other kits
that were constructed using Kit(const QVariantMap &).
This new constructor uses the code that used to be in fromMap(...),
with some simplifications.
Remove fromMap(...) method from kit as it is no longer used.
Change-Id: Iac28ea9b85670e03088a4b7c5283af6b4b70c0fc
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This avoids useless validation runs during construction.
Also reorder member variables to save a couple of bytes
in the structure.
Change-Id: Ibc33b89f12c306852af02d387ee2d177f732bb83
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Stay below the radar during construction/fromMap. This avoids some
signals from the KitManager about unmanaged kits having been updated.
This signal is used in three places only and always connected only
after the the construction happend. So this should be safe.
Change-Id: If6cc29b6bb98fa161776a9a79f48f88173db04b8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
While those do not hurt they are just unnecessary.
Change-Id: Ic2a971637fe6b0441c6fffa0d3c5161aea36e924
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Mutable KitInformation are those that are supposed to be editable in more
user-accessible places (e.g. like the Mini Target Selector or similar)
than the normal kit options page.
The functionality to display these settings is not part of this patch.
Change-Id: I13446c49abf89eaf739a60dbcd01c97e2144de45
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
It's rare that users will want older toolchains.
In updateAutomaticKits distinguish between a Kit being removed since
the toolchain doesn't exist anymore. Which happens on e.g. changing
the ndk path. If the toolchain still exists, then it isn't the
newest anymore, so demote the Kit to a manual kit thus enabling the
user to remove it if he no longer needs it.
Change-Id: I59203abc9bed5f2c46a002cea68fd72a84283840
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
The only os specific issue handled at this time is windows not wanting
to overwrite binaries that are still running. Make that message trigger
a build issue and provide a hint how to handle it.
Task-number: QTCREATORBUG-9100
Change-Id: Id0b270202b67b0b7d555392cb35b0e2ebcbc8fad
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Display warning and error icons in the kit options page. This is more
consistent with what we do elsewhere.
Change-Id: I31786054da3ad8c55931156f0124740eea2d68d3
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Distinguish from const char * one.
QString ctor is yet to be removed
Change-Id: I2da231036c6417353b0566d39666d918ad141c6d
Reviewed-by: hjk <qthjk@ovi.com>
Which asks each KitInformation for their parser, thus currently creating
a toolchain + qt chain if that is applicable. Remove all code that does
that by hand from various buildsteps/buildconfigurations.
Change-Id: I79a07ffd1dbe9a43bdbc838bc0098071aa412009
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This reduces the amount of validation that is happening a lot.
Change-Id: I9a854afc462109845febbb09da1b27930a23cb95
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
* Do actually print severity of an issue in the tool tip
Change-Id: I266bc6efbeb2175d9ca001147a5c732f29b2485c
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Make sure validate will not modify kits, add a fix method to do that
when kits are loaded/added.
Change-Id: Ib378af0f3470b2caf64177b35fca061089ac4523
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
