Commit Graph

63610 Commits

Author SHA1 Message Date
David Schulz
45381e9d04 LanguageClient: Only send contentsChanged notification to reachable clients
Change-Id: Id35b94d3c6f9b3b08b1e66b992ca5fe86cdab6d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-25 13:17:05 +00:00
David Schulz
83eab470c1 LanguageClient: Only send position changed signals to reachable clients
Change-Id: I0d387ea10aeba8f5f1be3d0ddb6a6ccb82e04e64
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-25 13:16:58 +00:00
hjk
bb783eb819 Help: Drop use of nullptr for default QFlag
Last one.

Change-Id: Iaef520ad4a0050544fc46ec3cde10c42675448e4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-25 13:15:46 +00:00
Orgad Shaneh
dd0efea95d Misc: Fix MSVC warnings
C4573: the usage of 'QObject::connect' requires the compiler to capture 'this' but the current default capture mode does not allow it

and implicit conversions from size_t to int

Change-Id: If9b4ba3103cadd5b2a38ba7072d05aa1488a87bb
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
2020-02-25 12:19:53 +00:00
Miikka Heikkinen
9b5e642400 QmlDesigner: Fix crash building against Qt 5.15
QGradient construction has changed in 5.15 so that it will no longer
allow creating a gradient for the final enum that indicates the number
of presets rather than actual preset.

Change-Id: I5304b924890f8ae4530834a2b34062e789147c5d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-25 11:55:48 +00:00
hjk
e5d1e9d274 Work around QHash::unite deprecation
Change-Id: Ibf199b5e3f2ca99b7e0cafe20893a509d9eab906
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-25 10:43:10 +00:00
David Schulz
63e9c4c31a Editor: Prevent setting negative position in block selection
Fixes: QTCREATORBUG-23622
Change-Id: I0f041a772869695e7d460effd4b0d58f94ce55ec
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-25 09:49:06 +00:00
hjk
aeef7137a2 CppTools: Work around a endl warning
And drop some foreach use.

Change-Id: I2ba4762cf6c5c8de7262a47044f65624d585e21a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-25 09:27:56 +00:00
hjk
7dbf2c01c7 iOS: Some IosDeployStep cosmetics
Change-Id: If9834af39b9c06373da472b3e0624051730f785a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-25 09:10:54 +00:00
Christian Stenger
be250deeed QmlDesigner: Fix building tests on Windows
Change-Id: I7b55b2b222821ef5f8980ad67552a7b31b49ac2b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-25 08:16:37 +00:00
Andre Hartmann
73fd611988 ExternalTool: Add timestamps to message output
Change-Id: I14048833c1e16812defe0e5f70379f18480c8633
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-02-25 08:16:19 +00:00
Alessandro Portale
3a29497717 CMake build: Add a qtc_glob_resources function
This is the CMake equivalent of "RESOURCES = $$files()" from qmake.

Use it in StudioWelcome for the Qml resources.

Change-Id: I2f495e2c4bad9f0bb488dee7e8966e31acb51b5a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-02-24 16:37:27 +00:00
hjk
ca2dd71d77 QmlDesigner: Avoid warnings about unused parameters
Change-Id: I37ca27bc1e808454be11c856429efe87428700e4
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-02-24 15:52:11 +00:00
Thomas Hartmann
0a4471dbbb QmlDesigner: Rename 'Imports' to 'QML Imports'
Change-Id: Ice57052273ac2e7eef555c9a26a9032098541d8e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-24 15:42:53 +00:00
hjk
b0847af740 Fix some translation contexts
Change-Id: I5471cca06970bc01a77cd1e2fd00890d3f22349f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 14:46:17 +00:00
hjk
87e4704356 Debugger: De-virtualize and de-slot DebuggerEngine::show*Message
Apparently not used virtually/weakly anymore, so make it easier
to reason about used code paths.

Last users apparently were QmlCppEngine and TrkAdapter. Both gone.

Change-Id: I5ab7d261362bede9a4cf622f4c124726deca83e8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 14:37:48 +00:00
Christian Stenger
5d3e56b3b4 QmlDesigner: Fix compile with Qt5.11 and building tests
Change-Id: I96dea7de0d185c67ea3a26a42de0805bd60dc1d1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-02-24 13:40:07 +00:00
hjk
989b44d911 VcsBase: Don't use QObject inheritance in VcsEditorFactory
The only remaining use is a setProperty that's never read back
anymore after 9c96a1c4d.

Change-Id: I2c49b044bb97a123e72070df5e83909c53e40881
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-02-24 12:57:14 +00:00
hjk
0e48783c03 CMake: Use buildConfiguration() instead of target()->activeBc
In case it does the same, it is faster now.
In case it does't do the same, it was something  wrong.

Change-Id: Ic3c237a9349d490bcadb10a5e9f700d68a178dae
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-02-24 12:57:03 +00:00
hjk
5c9141241b Android: Inline AndroidManager::intentName into only user
Using Target is actually not optimal as handle to access that
information (BuildSystem + BuildKey or sth to that effect would
be better), so reduce the visibility of this kind of interface.

Change-Id: I138f156b51795d51d2af49c5119d160663dfc20d
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-24 12:56:41 +00:00
Miikka Heikkinen
4908055937 Integrate Edit3D view into Creator
Edit3D view is now a tab alongside Form Editor.
Buttons were moved to a Creator side task bar on Edit 3D view.

Change-Id: Ia06107e4f855ba512ffea3e628a61558894e800e
Fixes: QDS-1570
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 12:18:53 +00:00
Tobias Hunger
564c0c1b94 QmlDesigner: Fix annotationeditor
You need a QPointer here to avoid potential double-free. A normal
pointer is not reset to nullptr when the widget gets cleaned via
the widget tree, so if (widget) widget->deleteLater() does not
work with a normal pointer.

Change-Id: Icd352b8767b91c4ea0ad045a56857fa651f200f0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 11:13:11 +00:00
Tobias Hunger
d22815f208 QmlDesigner: Avoid potential double-free in FormEditorAnnotationIcon
You need a QPointer here to avoid potential double-free. A normal
pointer is not reset to nullptr when the widget gets cleaned via
the widget tree, so if (widget) widget->deleteLater() does not
work with a normal pointer.

Change-Id: I18460c44414ff2ee90d8afe3a857d5902d69f911
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 11:12:55 +00:00
Tobias Hunger
836bf1f379 QmlDesigner: Fix initialization of SelectionIndicator
Change-Id: Ic13236a93e78b29a73bd86590c800edb20c0cffd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 11:12:43 +00:00
Robert Loehning
7eda08f600 Squish: Directly click mode selector
The tooltip doesn't show up on Windows anymore unless
you manually move the mouse.

The positioning has proven to be stable, so we don't
need to double-check using the tooltip anymore.

Change-Id: I92400d1fa273d4fb6a011cdf00c3b127c06764d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 10:50:34 +00:00
Tobias Hunger
144ee4103f android: Do not crash when node is nullptr in CreateAndroidManifectWizard
Change-Id: I1988fa72be535210e50d9ed18ef9d081e6ae39ed
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2020-02-24 10:47:43 +00:00
Tobias Hunger
2e59ef8c1c Android: Consistently allow Qt version to be nullptr
Do not crash when Qt version is nullptr. This was checked for in
some places, but not in others. Not sure whether or not it is safe
to assume that Qt version is never a nullptr here, so I went for
the better-safe-than-sorry option.

Change-Id: Ief9a479ee5719204582902bfa72412145658f0c2
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2020-02-24 10:47:28 +00:00
Tobias Hunger
f8e6638069 CMakeBuildStep: Adapt variable name after moving functionality
Adapt the variable name after moving the functionality from the
BuildConfiguration to the BuildSystem.

Change-Id: I16006066841222ddd3607198413e2b55e6270c89
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:47:02 +00:00
Tobias Hunger
0dcd380865 CMakeBuildStep: Remove dead code
Change-Id: I3ba8d5ece263f19c0b129e9de81888c9016583a5
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:46:51 +00:00
Tobias Hunger
64c9c9e184 CMakeBuildStep: Document that the buildconfiguration will be non-null
Change-Id: I27be487f2a662df8cf41152d6c7ffd0f40151061
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:46:42 +00:00
Tobias Hunger
e525dea898 CMakeBuildStep: Fix message
Change-Id: I6c373639273bdce17531e3e7fe5ec0f38e62b8b3
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:44:39 +00:00
Knud Dollereder
06d5817076 Add the ability to modify the animation range from the curve editor
Fix a synchronization issue between timeline and curve editor when
the animation contains pinned curves

Change-Id: I89dda234063259f41d662749d696f5fc8a04f9e8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 10:11:24 +00:00
Orgad Shaneh
de5f4d1160 VCS: Fix broken annotation changes detection
isValid() is true for empty regexp...

Change-Id: I0af92574181736d5dde2ca48d3a8ab75ff6f14dc
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-24 08:32:03 +00:00
hjk
92a1d1a9ba WinRT: De-Q_OBJECT-ify deploy steps
Change-Id: Ie0ad653d7611a2db8421baed68a7dbb9d89e06a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 08:10:28 +00:00
David Schulz
e17c96cf11 Dumper: move global enums and functions to utils
Change-Id: I11f5f0d970cd23a5fd907d33daa3cb8a441d0c58
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 07:47:40 +00:00
Christian Kandeler
daa58e899d Qmake: Do not repeat build directory in warning message
The build directory line edit is right above the label containing the
message, so repeating the build dir value just widens the label
unnesessarily.

Change-Id: I650a4ce76a82582b2710a4673c134dbb4faf306e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 07:17:45 +00:00
Orgad Shaneh
b2ceb7db79 Git: Open log for ranges in output window
Show doesn't make much sense.

Change-Id: I945910749fa99245469164c1a411ce39b9f4f3d4
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-24 07:13:25 +00:00
Jochen Becher
87d2df9d7b modeleditor: Improve intersection of line with polygon
Change-Id: Ie546801fadedffaef24c53ce83ce0a039e77a04a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-23 15:54:52 +00:00
Jochen Becher
db90ce21c9 modeleditor: Fix intersection of relation with component
Change-Id: Ib0a999e56f98bc2a4483583a322e107560c17dc0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-23 15:54:24 +00:00
Jochen Becher
c37ecdeaf1 modeleditor: Keep some border around the diagram scene
Change-Id: I09aeaffa0a36048c8a6c8e7787750b08e07f08d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-23 15:54:00 +00:00
Andre Hartmann
710836f222 Debugger: Fix std::optional dumper
Tested under Ubuntu Linux 18.04.1
with gcc 7.4.0 and gdb 8.1.

Started-by: Tobias B. on Jira
Fixes: QTCREATORBUG-22436
Change-Id: Id75c817f26bf16e4d93332ab24068cacbe5d9d8e
Reviewed-by: Marcel Petrick <mail@marcelpetrick.it>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-02-23 14:33:45 +00:00
Alessandro Portale
6e88cc33de StudioWelcome: Add the qml files to the CMake build system
Add a missing delimiter for the debug build. For the release build, we
need a .qrc file which captures the whole qml/ subtree.

Change-Id: I07fa916f6074870278c2aa90a8e4a599bf784a3d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-02-23 11:05:03 +00:00
hjk
d45e123b8e ProjectExplorer: Remove pure ProjectConfiguration::isActive function
It's never used polymorphically, and only caused an unused
implementation in BuildStep.

Change-Id: I5fbd34925788ca22960a2f522eef75be3137c67b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-02-21 17:30:15 +00:00
Cristian Adam
63b0c79a46 GitHub Actions: Add OpenSSL to resulted test artifacts
Change-Id: Ieec647abc87f87de79ef07c12378a2a32e783d8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 16:08:42 +00:00
Denis Shienkov
b858e58d3f Debugger: Allow to specify 'init' and 'reset' GDB commands
... in case the attaching to the remote running GDB server.

We need in this option for the bare-metal programming, because the
'Attach to Running Debug Server' option should cover functionality
of the removed 'Default' GDB server provider.

Without of this option the debugging is non-functional in a most
cases.

Change-Id: I77a37552b2c7c2e76d70dbecfe9e21f316c02534
Reviewed-by: hjk <hjk@qt.io>
2020-02-21 16:07:40 +00:00
Thomas Hartmann
af9f703dc3 QmlDesigner: Remove project explorer from navigator
This was a 'hack' to make the project explorer more accessible
and with dock widgets this is not required anymore.

Change-Id: I92b0a168a41eade2718698b9602e33550286e96f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 14:44:18 +00:00
hjk
be899de35c CMake: Move CMakeBuildStepConfigWidget definition to .cpp
Slimmer interface.

Change-Id: I34b8c172864456f67216efce7a09967c0ffec8be
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-21 14:10:15 +00:00
Thomas Hartmann
c74a3042d4 QmlProject: Add qtForMCU flag
Change-Id: Ia473fd257414f5edddc0ffcce8c913897d75f351
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 14:02:23 +00:00
Christian Kandeler
21ab7e59d7 AdvandedDockingSystem: Fix deprecation warnings
Change-Id: I21193c2b275f9c11d25eef11bdbe2931ad2ea4ff
Reviewed-by: hjk <hjk@qt.io>
2020-02-21 13:47:44 +00:00
Christian Stenger
8d71943cfa Mercurial: Fix compile for Qt5.11
Change-Id: I2ae766a76d34f0ca6e43ba6059fda82edaf0358d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-02-21 13:30:19 +00:00