Commit Graph

75236 Commits

Author SHA1 Message Date
The Qt Project
3a59331232 Merge "Merge remote-tracking branch 'origin/8.0'" 2022-08-04 06:48:30 +00:00
hjk
2f37566f33 Tracing: Avoid copying unneeded parts of a Icon
Change-Id: I975fea87ce94661cbc61caa08d3da5bb6596cf26
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-04 06:44:31 +00:00
Christian Stenger
5b67f03416 Dumper: Fix bitfield handling on macOS
Amends f14634a651.

Change-Id: Iae1c7ad9c78786c9178a07a493abb76db3b4c4aa
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 06:33:47 +00:00
Christian Stenger
d24dd97717 CPaster: Replace deprecated code
Change-Id: I2c9ee3df6c4a8e91d5f3701655e10dc106697593
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 05:54:07 +00:00
Christian Stenger
9a0cadd06a Tests: Fix dumper expectation
Amends c1d75d8df7.

Change-Id: Ib69c095a9f94fa618f5c9791d4c908fbefa5ecb3
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 05:53:41 +00:00
hjk
ecb658e7fc ClangCodeModel: Avoid FilePath->QString->FilePath roundtrip
Change-Id: Ieb74aee5a6e8bfe8bdfe954d958e38da646fcb4d
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-04 05:11:01 +00:00
hjk
8ae55344de ClangCodemodel: Avoid repeated construction of category prefixes
Change-Id: I0166010a17f1f37855862f28cc9e2472b638c9de
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 05:06:34 +00:00
Alexander Akulich
057bb3095b CMakeSettingsPage: Reload item data on CMake executable path changed
This fixes missing/outdated 'Version' information and maybe useful
for more data later.

Change-Id: Ibf302a424d8a3c289d37fc0fabc00ab22e4bde97
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-08-03 21:02:20 +00:00
hjk
7950a038b4 Merge remote-tracking branch 'origin/8.0'
Change-Id: I1dc664137eeecb7dd69f29af7a08164683d51077
2022-08-03 17:51:42 +02:00
Jarek Kobus
a714ddf59f VcsCommand: Create ProgressTimer manually
The QFutureInterface<void>::get() method was introduced
in 6.3, so we can't use it yet. Create ProgressTimer
manually in the caller thread for the future passed to
ProgressManager::addTask().

Amends a5683616b9

Change-Id: I1f96c433e759d66eaaa1a32489e9db4facecf46a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 14:06:05 +00:00
Orgad Shaneh
55722ac5a4 BinEditor: Use inline member initialization
Change-Id: If70532c94b5a446dbb6595d635f4c03b69a5d65c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 12:30:35 +00:00
Orgad Shaneh
eb33d26090 TextEditor: Factor out codec chooser
Change-Id: I664f7ba484f379b8d2b8254d4f880c0d37d70ff8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-03 12:30:16 +00:00
Jarek Kobus
4edb238073 VcsOutputWindow: Use FilePath for repository
Change-Id: Ie6669c94a1fa29e48524b9338e74413bb0830229
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 12:23:52 +00:00
Orgad Shaneh
f8c3d860fc Gerrit: Do not pass username to curl for REST requests
It is set in .netrc anyway, and there is a regression in curl that causes
it to fail when passing the user name.

See https://github.com/curl/curl/issues/8653

Change-Id: Ic7aa2d874884db71f71d162486acf4e054eab7e9
Reviewed-by: hjk <hjk@qt.io>
2022-08-03 12:23:09 +00:00
Christian Stenger
175867e54e Tests: Fix define for Qbs build
Avoid the need to always specify this value by an
environment variable.

Change-Id: I2f08b5f15c9dc818826305fbd1d96e52ebdc89bf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 12:18:56 +00:00
Jarek Kobus
1192441a31 Scxml Magnifier: Don't install event filter on qApp
After 1ba6faeea0, where
activating the magnifier with Alt key was disabled,
the fix in 158fd92558
isn't needed anymore.

Amends 158fd92558
Amends 1ba6faeea0

Change-Id: Ibeb90fa246d576f8d7fe2cf2a64fa7a9cc6d30f2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-03 11:50:19 +00:00
Jarek Kobus
7bd33bc247 VcsCommand: Remove defaultWorkingRepository() getter
It wasn't really broadly used.

Change-Id: If2e185a7d8d0f920f3ec7f507bf96dd81f4559b0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 11:30:36 +00:00
Jarek Kobus
a5683616b9 VcsCommand: Fix timed task's future interface
Pass the future interface of the running task into
ProgressManager::addTimedTask() instead of not
related future. In this way canceling the timed task
(after pressing the small x button) makes the
future interface canceled in the worker thread.

Change-Id: I4596823d40bd079841e59c9bdba025d30cb33711
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 11:30:31 +00:00
David Schulz
0a2510edcb Python: skip root on venv detection
Virtual environments on the root level are uncommon and can cause issues
on some linux distros.

Fixes: QTCREATORBUG-27976
Change-Id: I266f1b321c1c2d2b4b416acf3f34ce8c1d686219
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 10:55:30 +00:00
Orgad Shaneh
195fc29ef5 Gerrit: Show command and failures in testConnection
Can be useful when authentication fails.

Change-Id: Ibd3700c4ce9cc76b0d9c4cde32730a4e1906ccd6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-08-03 10:17:49 +00:00
Orgad Shaneh
b3b36f7d2a Gerrit: Refresh server details also when authenticated is changed
For example, if the server was not authenticated, and .netrc was edited
outside Qt Creator.

Change-Id: Ib28b6e924e3fab958410da49ceb45ed4269e195b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-03 10:17:34 +00:00
David Schulz
5aa987b6a5 LanguageClient: fix outline focus
Setting a focus proxy to the outline widget makes sure the tree view
gets the focus whenever the oultine widget gets focus, so after opening
the outline the user can directly use navigation keys to move the
selection in the outline.

Fixes: QTCREATORBUG-27595
Change-Id: I0771c99ccf5aa334f45065d58366b53f53bf75a5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 09:54:27 +00:00
hjk
dac9dff459 Gerrit: inline authenticationdialog.ui
Also, replace /#/settings/http-password by /#/settings/#HTTPCredentials

There should probably be some stretch between the form and
the buttonbox, but it wasn't there in the .ui so I left it
out for now.

Change-Id: Ie07a3283261a1070a489e454f9fb86c0c6dc2ca8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-03 09:44:08 +00:00
Samuel Ghinet
86f93b8949 Sync color between environment map and 3D Editor background
Task-number: QDS-7097
Change-Id: I5f2c83bc43bd589d0d1f32e01e7512ab20a03bcf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-08-03 09:35:11 +00:00
Cristian Adam
de08f08a21 clangd: use QTC_CLANGD_COMPLETION_RESULTS as default value
If the user set the QTC_CLANGD_COMPLETION_RESULTS environment variable,
use that value as the default value for the settings page widget value.

Change-Id: I525e8bb4a5631b7d8461f18d1fc5c6972bd758cb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-03 09:15:56 +00:00
hjk
8a44294821 Merge remote-tracking branch 'origin/8.0'
Change-Id: Iea4fd2949f5d5345802e2e7d9283d72c6c55f69f
2022-08-03 10:52:13 +02:00
Christian Kandeler
c6399adf48 CppEditor: Remove some virtual functions from ModelManagerSupport
These were never called via the base pointer.

Change-Id: Ib233d9e93d80b1fbcc09a5b7b07d9fa3b8615f66
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 08:27:58 +00:00
hjk
c1d75d8df7 Debugger: Add simple dumper for QKeySequence
Change-Id: I097336fb77ff34e94c9096b51a511b3a0f2c86d1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 08:18:53 +00:00
hjk
f14634a651 Debugger: Fix bitfield dumping with Python 3
Change-Id: I2959a2e14c6f25e29460de74ea95a16a5226d48e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 08:18:39 +00:00
Marcus Tillmanns
c0b3cc1bbc FilePath: Fix setFromString root for partial path
Change-Id: I3a9352a364c71a8463736b25086a0493ae5c5d31
Reviewed-by: hjk <hjk@qt.io>
2022-08-03 07:09:55 +00:00
Jarek Kobus
8e48dd5c92 VcsCommand: Remove unused field
Change-Id: I14ce1c616bb98bef127aec666ca9241e63584e40
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 06:12:01 +00:00
Jarek Kobus
191fc196d5 VcsCommand: Remove one addJob overload
Remove defaultTimeoutS field, as it wasn't broadly used.

Change-Id: I0056788b066eb6d682d5ba7acdb01d5dd3568967
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 06:09:44 +00:00
Jarek Kobus
d2a1198a7b ClearCase: Remove unused includes
Add some forward declarations.

Change-Id: If7b55d57484f9ab7b03e3919a7ba52f243fc5de0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-03 06:09:39 +00:00
Jarek Kobus
6129157f57 ClearCase: Simplify isConfigured()
Make executable check inside ClearCaseSync::run()
consistent with isConfigured().

Change-Id: Idc08dcdf87005937b1299a0d033c4cf2503f63a4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 05:20:11 +00:00
David Schulz
a35d56ca2e Core: remove suspended entry from file path cache
... when cleaning up suspended documents on session switch.

Fixes: QTCREATORBUG-28021
Change-Id: I6ef9fda96162d56758f176381b1eabe47eb8770f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-03 04:51:26 +00:00
Jarek Kobus
b84c22b2fd ClearCaseSettings: Use FilePath for ccBinaryPath
Change-Id: I0de348d0b99a1f81d75418a7927c989283c4137a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-02 17:34:40 +00:00
Jarek Kobus
278d297397 VcsCommand: Simplify public runCommand()
Get rid of unused workingDirectory (default working
directory will be used) and exitCodeInterpreter.
Simplify internals a bit.

Change-Id: I2a7547e5a594dd7a21f390daeb06778656e9e971
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-02 17:34:31 +00:00
Marcus Tillmanns
b2f0f78bdc filepath: Fix windows driver letter handling in fromString()
Change-Id: Ic66e468ed2161bc10136ab31dc29a7358e6d7397
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-08-02 13:59:29 +00:00
Christian Kandeler
98a39401db CompilationDatabaseProjectManager: Be more careful with filtering
Do not blindly remove all flags that contain the file's base name.

Fixes: QTCREATORBUG-27990
Change-Id: Ib51b65a8694e82ec22af859176b0db0e5d86b5f0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-02 13:50:14 +00:00
Christian Stenger
1c34105dfc Squish: Register result item type
Needed to be used in queued connections.

Change-Id: I2911a5ff73d2be0b406fcfa9f073764b3edfbe9d
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-02 12:40:28 +00:00
Christian Kandeler
2b8ac45071 ClangCodeModel: Move "find references" into its own class
Change-Id: If4dc9f7cb56b7f2e03e3d4622e616fb8486ddc92
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-02 11:48:22 +00:00
Knud Dollereder
b52177119f Fix wrong optimization in the timeline settings dialog
The timeline settings dialog used a static QString to cache the
last inserted expression binding value.
This caching fails when the user modifies the expression in the
text editor since the cached string is not updated in that case.
This patch removes the caching since this optimization is negligible.

Fixes: QDS-7162
Change-Id: I0122b29180afbfe5b867063139c924efa6e17ea3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-08-02 11:32:34 +00:00
Christian Kandeler
2f169bdfcb ClangCodeModel: Make some ClangModelManagerSupport methods static
Change-Id: Ie34a89ae01783631c6482cff8d4866595e757be5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-02 11:21:16 +00:00
hjk
df4155f617 App: Use more local methods to trigger memory trim timer
The global event filter function is executed often, for events
originating deep in the widget hierarchy even multiple times.

Triggering the timer only by mouse and key presses on the main
application and on texteditor is less intrusive and still happens
often enough (TM).

Change-Id: I848d55a347bd62d12e8523965d1750c59da33116
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-02 11:18:12 +00:00
Jarek Kobus
9177649cab QMakeStep: Use Utils::Guard
Change-Id: I1fbc830620cb2db42ac71e3c02e1d3993197a727
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-02 10:10:55 +00:00
Jarek Kobus
5434ea417f ProjectConfigurationModel: Avoid using sender()
Change-Id: I65a2da1f2e8a5d3bb98bda752942d83e4074df9d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-02 10:10:41 +00:00
Christian Kandeler
240105f55f CppEditor: Clean up ModelManagerSupport creation
No need for "providers" etc.

Change-Id: I4ae9e8ecd6b3554711e002f233c13fd7758f01e4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-02 09:15:55 +00:00
Christian Kandeler
dd37abed6b CppEditor: Remove unused code
Change-Id: Ife0f6609a55de903f5f90af0dc6b72209e02f5af
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-02 09:15:32 +00:00
Christian Kandeler
a82406eb27 Utils: Add shortcut for buttons in environment dialog
Task-number: QTCREATORBUG-27887
Change-Id: Ifb52d24354b1042cdb1ccb4ca898a251cbac1039
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-02 09:13:46 +00:00
Christian Kandeler
5f9c30cacf ClangCodeModel: Do not make clangd open all ui headers
This amends 01ceb3a3cb, where we failed to
consider the case of projects with lots of UI headers, which cause
excessive memory use by clangd with our current simplistic approach.
Instead, we now only open ui headers that are used by currently open
documents.
Note that this approach will fail for indirect includes via header files,
but people who do that do not deserve happiness.

Change-Id: I1ef2add701e0f13dc0da79267d3c1367c1b496cc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-02 09:13:25 +00:00