Commit Graph

29 Commits

Author SHA1 Message Date
Orgad Shaneh
4b6a6acc4e Core: De-pure IOutputPane::visibilityChanged()
Most implementations are empty.

Change-Id: I811cacfc2918c8b2803798c4f5d3dabc7d60ccd1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
2020-10-09 05:23:17 +00:00
hjk
430a33dcd9 Core/Utils: Migrate further to Utils::Id
The coreplugin/id.h header is kept for downstream for now.

Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-06 06:07:13 +00:00
Christian Kandeler
6a07e2c341 Output panes: Do not allocate extra standard formatters
The OutputWindow base class has a functioning default formatter these
days.

Change-Id: I0a75d0a081cdd2cfdd913388419483df836a53e9
Reviewed-by: hjk <hjk@qt.io>
2020-03-20 14:49:49 +00:00
Christian Kandeler
04a99c1de1 Remove the limitation that output formatters have to be exclusive
Introduce an aggregating output formatter that forwards its input to a
sub-formatter that feels responsible for it, or otherwise lets the base
class handle it.
Our output panes now use such an aggregating formatter.
In particular, this means that in the future, we won't have to stuff all
run control output formatting into the Qt output formatter anymore.

Change-Id: I5498f200a61db10ccff3ec8974c6825da7f7072d
Reviewed-by: hjk <hjk@qt.io>
2020-03-20 13:48:15 +00:00
hjk
a44bfdd779 Provide an empty default IPlugin::extensionsInitialized()
And remove all empy re-implementations.

Change-Id: I19f0b4e55c042c96693ecb89766f97f0a97b54ae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-07 10:21:34 +00:00
Alessandro Portale
2234c517c0 Utils: Add a non-toolbar variant of the "RELOAD" icon
New icon is: Utils::Icons::RELOAD. And the toolbar variant is now
Utils::Icons::RELOAD_TOOLBAR.

Change-Id: I811d83c7340a717968430ac1ce4a5c708c8ddcf9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-07 09:22:07 +00:00
Orgad Shaneh
586c6dd92f Deduplicate calls for obtaining model index
Change-Id: I799742a06ce592ab935ee0609d5930a7d26a44e1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-01-03 04:32:07 +00:00
Andre Hartmann
295fb99cc6 SerialTerminal: Some style fixes
Change-Id: I7415b613493540b250e1e5fba792a76c8e2d6b30
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-09-11 20:12:03 +00:00
Andre Hartmann
8deb1f3b4f SerialTerminal: Fix sign conversion warning
Change-Id: I503f9e9d556aa58807b552d0696fcd311ec5cf79
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-09-11 20:10:24 +00:00
Sona Kurazyan
8e31932c29 Remove usages of deprecated APIs of QLayout
Replaced:
  QLayout::setMargin() -> QLayout::setContentsMargins()
  QLayout::margin() -> QLayout::getContentsMargins()

Task-number: QTBUG-76491
Change-Id: If28ef6910b3afe5d04e4746b74f9362a3e3b3c8e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-02 13:01:07 +00:00
Cristian Adam
d855b84c5d Qt Creator CMake port
Based on Tobias Hunger's work from a few months ago.

The CMake configuration needs libclang and Qt paths specified as
CMAKE_PREFIX_PATH.

Auto tests are run with "ctest". At the moment the pass rate is 87%.

Change-Id: Iba98e39bf22077d52706dce6c85986be67a6eab0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-05-17 13:33:28 +00:00
Alessandro Portale
e9cf8a4e3e Remove a couple of "setAutoRaise(true)" for toolbar buttons
Most of the QToolButtons in the toolbars don't set autoRaise, and they
are fine. I assume that those who do set it, just do it for because that
line was copy/pasted so often.

Change-Id: I71341ddbd26a586d34713661ec538b37033685e5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-04-29 10:35:33 +00:00
Andre Hartmann
48073b2990 IOutputPane: Refactor zoom function into base class
Try to make zoom and font handling in the panes more
similar and put common stuff into IOutputPane.

Change-Id: I59c38c5eecbf67b7ca6c9d84a6f61b1292a787df
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-04-16 14:20:22 +00:00
hjk
6f37348b4c Replace static_casts by QOverload where possible
Mainly to get rid of the QProcess::finished deprecation warning.

Also adjust coding style in the surrounding connects when needed.

Change-Id: I12f9b248c7974b892c4a069356e578e80f8c59e9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-02-26 15:18:14 +00:00
Alessandro Portale
bbac294682 SerialTerminal: Modernize
modernize-*

Change-Id: If7b19d7c560ecda5f6e519d88b7eab46d4eabccf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-25 20:20:13 +00:00
Eike Ziller
3d1d9aae2e Merge remote-tracking branch 'origin/4.8'
Conflicts:
	src/plugins/winrt/winrtdevicefactory.cpp

Change-Id: I33b8697e2ebf2bea051d7f1144449e0743ee16a5
2018-11-19 10:00:18 +01:00
Orgad Shaneh
ad7c42c9b3 SerialTerminal: Use monospace font
Change-Id: Iea42d55c348959adf57936fe0141c5bd5673efbd
Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-16 08:45:07 +00:00
Orgad Shaneh
08b38cff4c SerialTerminal: Save and restore selected port name
+ Populate serial ports on startup.

Change-Id: Ie7216bb09ba1ffbb0036019cb4974a14119fc55f
Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-16 08:26:48 +00:00
Benjamin Balga
b5a76be357 SerialTerminal: Apply line ending to current pane
Change-Id: Ib9365ace637d7e7c44347c7319315717a5f8b9b6
Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-16 08:20:46 +00:00
Orgad Shaneh
e0a1b171f1 SerialTerminal: Show error string on connection failure
Change-Id: Ie951d9598358ef87ea50d6b748b1a88d3ba5431d
Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-12 09:48:03 +00:00
Orgad Shaneh
9c7ac5e26a SerialTerminal: Select text in input line after each command
Makes it easier to type a different command.

Change-Id: Ica152575f2f5130a8f2da75379403841aba89176
Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-12 09:37:22 +00:00
Christian Stenger
2cf2cebfc9 Avoid enabling all message types by default
Passing no QtMsgType parameter ends up in enabling all
message types by default.
Follow the common pattern of only enabling the warnings
by default.

Change-Id: Ic7ec0420089c95f716a86feb9791d9cb13f4dd90
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-06 09:40:05 +00:00
Alessandro Portale
b16ba2ba59 Remove a few redundant occurrences of 'virtual' and 'override'
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]

warning: 'override' is redundant since the function is already declared
'final' [modernize-use-override]

Change-Id: I9036a0dc88ed70c4f6e37b916bb24ff65074863d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-06-18 08:41:37 +00:00
Alessandro Portale
1dbdd259be Remove some obsolete code inside QT_VERSION_CHECK sections
With Qt 5.9 as minimal build version, we don't need to handle 5.7 or 5.8

Change-Id: Ie1eed95ab46364452b0633f78bebc565a4a63f4a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-04-27 07:43:49 +00:00
Orgad Shaneh
7d3a79c696 Utils: Purge asConst
Replace by qAsConst.

Change-Id: I3301366f73c066c86f08df7188d70dc3b613c55c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-04-09 09:04:00 +00:00
Christian Stenger
e42ff6399e Fix build with namespaced Qt
Change-Id: If5675920a5e4020a8a21e103eed6613475f709b5
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2018-03-14 12:49:03 +00:00
Christian Kandeler
6b29198874 SerialTerminal: Add qbs project file
Change-Id: Ic9b65d09424f0f28f58181d3da526127800c4d45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-31 14:57:36 +00:00
Christian Stenger
b0b2859fe8 SerialTerminal: Fix compile for Qt less than 5.8
Change-Id: Icaa48d92d75bdd669bc6e4184568bfcf92cc768c
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-01-31 06:33:04 +00:00
Benjamin Balga
b386eae888 Plugins: new serial terminal plugin
Plugin adding serial terminals in the output pane.

Change-Id: I75d0f69f8d90268ff774e4eae30e36eda022d3aa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-01-30 13:35:19 +00:00