Don't compare int with QString - which even compiles with Qt 5 (but
luckily doesn't with Qt 6).
Amends 123133841e
Change-Id: I347568c89658896a2e094610dbf1700ff84d81c5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
It seems there is no need to update it and it is an expensive
operation.
Task-number: QDS-4008
Change-Id: I5dd8427f73a6ce755b017f6d284b72acb31ed7d5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fixes "Jump to File" from the context menu and the ctrl+click navigation
for files that contain special characters.
Fixes: QTCREATORBUG-25572
Change-Id: I7c26c6d517ced26f803c2224f0c09397f373b3b5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
When building debug with tests this surprisingly failed
due to missing include.
Change-Id: I238dc1d1e4aca790c07a37f0d65973da693bed99
Reviewed-by: hjk <hjk@qt.io>
A convenience method to tie the enabled state of an aspect to some
other bool aspect, to be used e.g. when settings item availability
depends on some check box.
Makes it harder to miss one of the three necessary steps.
Change-Id: I8c120bb6846aea2a503614f7c73fa57a149cab41
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The "Docker Container" runconfig executes 'docker run <image>' without
further attributes, and "works" with docker's hello-world example image.
Change-Id: Ib9417d238ac0757db16be1fc21af40c81db02f05
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Docker allows to run a container "by itself", not needing an explicit
command line.
Change-Id: I4f3992410f7f7bbcce1897a7400628ef9354043d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Structurally more similar to what the other plugins do.
Change-Id: Ic664277b089ebf60241fc8627353721e0e2f3002
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
... while a parse is going on.
Fixes: QTCREATORBUG-25137
Change-Id: I02a914332ef120caee044139581e1901b4537bff
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
To override RunConfiguration::runnable() behavior without the
need for subclassing. Will be useful for the docker plugin.
Change-Id: I9e8511faa95355038b08c3e3be24429d66a5253f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Only four simple values.
Adapting qmlprofilerconfigwidget_test did not seem desirable,
as in the aspectified state this is hidden in the base aspects
implementations.
Change-Id: I933a8ca065169c61b7f25f109e0b7a0e6d21cb33
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Apparently, we can prevent clang-format from removing line breaks by
adding an empty comment at the end of the line.
Change-Id: Ia78ecb9e7351d059c544cbda11d33af5734e2218
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Move the information about these views to separate topics and
describe the differences between using them in Design mode or
in the sidebar.
Change-Id: Ie71edb7d270bf5c4e020f2818f9f8e0e9e505094
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Makes TestTreeItem programming language agnostic.
By moving the "query" methods to CppTools, the cohesion within these
methods is improved, i.e. information crosses the AutoTest <-> CppTools
border fewer times. Furthermore, it allows the CppTools plugin to see
how its data is being used, allowing it to optimize its queries
behind the scenes.
Change-Id: I0a60140abaca1193d500605dfa2812b4d937d94c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Some examples can now be downloaded, while others are still
delivered with QDS.
Task-number: QDS-3407
Change-Id: Ib74dce703d5e824bfbf129951c3fd624ada601b9
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The value.isNull() was misleading. It should only check if a value is
invalid. The null sematics in Qt are special anyway because it they can be
misleading. Most values have no special "null" value like pointers or NaN
with floating point values. QString is for example exposes it's
implementation with a pointer. Sometimes zero is reportet as null but this
not what we wanted to know. So just treat null strings as empty strings.
Change-Id: I6599f6c97f22aff83779a0b32415bf52fd64d82f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... by using QAbstractSlider::actionTriggered() instead of the mouse-
centric signals.
Fixes: QTCREATORBUG-25557
Change-Id: I0092fbfcb8fefb3a234bfb1592a2483bdc9e68d3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Creating QIcons elsewhere is not safe because of image reader plugin
loading and the pixmap cache.
Fixes: QTCREATORBUG-25301
Change-Id: Ia22a0cd571f808d7f5c639353fdf2e548743f8ca
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
The issue is that when a GC() function is being executed
in a separate thread, the main thread may delete
the StringTable (on shutdown) in the same time. The destructor of
StringTable didn't check in any way that the other
thread is still executing GC() method.
In order to fix it we employ runAsync method, returning
the handle to the running task. We store the handle
in futureSynchronizer, and in destructor of StringTablePrivate
we safely wait for all futures to be finished.
Fixes: QTCREATORBUG-25417
Change-Id: I0039d6041276c521c221e8dfc3894e84e47b82a2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Changed FormEditorFlowDecisionItem's default text location
from TopRightCorner to TopLeftCorner
Task-number: QDS-2508
Change-Id: I6c95ab859e7d82d94399d5249c027f5e772eb9d7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... whose type is a template.
Fixes: QTCREATORBUG-25560
Change-Id: I1d626f9376e8802a87ca1a28099932ccbf744d47
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Only row span used currently in some base aspects, can be
extended once needed.
Used in the Perf config widget to correct recent change.
Change-Id: I37fae178cbfb8d493e0232e53e877d0e317ec9f2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
As for the build config, we provide a global variant for use by external
tools, and one for use in the respective run configuration itself.
Also hide the deprecated "CurrentRun" variant, which was forgotten in
b55825a420.
Fixes: QTCREATORBUG-25561
Change-Id: I51aaff10301f7ff1256abf1c09ac9f5be136ab00
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It's unlikely that the user wants to change files that are not part of
the currently loaded projects, so opt-in is the right approach for
those.
Fixes: QTCREATORBUG-8561
Change-Id: I1812a3e64de66828ac07dea7bbb63acdb4dd40d8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
