... to simplify the user code.
Some, but not all, potential beneficiaries are adapted.
Change-Id: Ia7d514a0114a4f99f8ee745523435f5b990bd095
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Where they were missing. The text is shown as a paragraph in the
extension manager.
Change-Id: I6e15c89fe4023b222e9c476f4312e13fcb0905c0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Its unnecessary to register the object in the plugin system.
Change-Id: I0a356b9a040879503e38090939008277e4eea4f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Edited the short descriptions to answer the question
"What can I do with this extension" to help users decide
whether they need it.
In long descriptions, tell users what else they need to
be able to use the plugin.
Change-Id: Iefce7505b61fc77cf38cc915f1f7dbd25c9cb570
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Avoid the redirect that is inevitable nowerdays.
Also, change necessitas.kde.org to www.qt.io, since the orgininal page
is offline.
Change-Id: Ib1823f0df97d2df87822fd2bb7552e2f2c7e971e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Some (Fedora) OS/Distros set a default value for TERM such as "dumb", which then breaks
command line tools such as "clear" which try to figure out what terminal they are
running in. Therefore we have to force-set our own TERM value.
Fixes: QTCREATORBUG-30737
Change-Id: I50ac86f17c92dc7bc477cc59ed43ec22025593fb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add missing full stops, remove space at beginning and end, remove end
lines at end
Change-Id: I4ce28f578e13e100dcfbd8ef70630462faf407fc
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
ConPTY on windows will send "clear line" characters in response
to resizing the PTY.
During re-showing the terminal pane the widget receives a "height=0"
resize event. We have to ignore this otherwise the conpty might try to
clear the screen.
Another issue was that we are calling resize on the pty even thought the
process has ended and won't be able to respond to the clear attempty by
the pty anymore.
Fixes: QTCREATORBUG-30523
Change-Id: I24caeaffb31d255a0640952e2d35bda23fd16280
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Rename process.h back to qtcprocess.h
MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.
There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have
Simply use a name that doesn't conflict.
Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
When the active project is on a remote device the working directory
is set to its root directory. In this case we need to find the right shell
binary from the remote device.
Change-Id: I6b541273d23a8de5442ac041b28d81984ed5ef65
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
For the users that have a space in their user name, the location of the
shellintegration.ps1 is a path with a space in it.
This patchset fixes the escaping of that space.
Change-Id: Iae84b2e8a8f1b4e2b7e523e28417caaeb77bc5cd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Previously a "1" was printed every time a powershell terminal
was started.
Change-Id: Ibd6f9dc9de8ba11ede98e13ca2f65ba5a99536fb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The shellintegration script escape the current working dir.
We were missing the code to unescape the paths.
This was particularly visible on Windows powershell
where backslash was escaped by "\x5c".
Change-Id: If697722986c72ebbc19d5ec8e3930321f3af7b6a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.
Replace QWeakPointer with std::weak_ptr.
Replace QEnableSharedFromThis with std::enable_shared_from_this.
Use std::static_pointer_cast and std::dynamic_pointer_cast
for casts used with QSharedPointer before.
Change-Id: If255a100c790860934f36d52906b93f33c31cfe8
Reviewed-by: hjk <hjk@qt.io>
It was not readily clear that Environment::appendOrSet/prependOrSet
needed a value for "sep", otherwise it would just concat the values without separator. This got apparent when looking at usages of
appendOrSet.
Instead there are now three options, "Auto", "Colon" or "Semicolon"
with the default being "Auto", which determines the separator based on
the Environment::OsType.
Usages of appendOrSet and prependOrSet are also fixed with this commit.
Change-Id: I868e14ce38f50be9cd07292fe3f22663a62d116d
Reviewed-by: hjk <hjk@qt.io>
Allows the user to Ctrl(Cmd)+Click "version like" text (e.g. text that
only contains 0-9 and a-f) and starts a "vcsDescribe" if a version control
can be found for the current directory.
Fixes: QTCREATORBUG-29213
Change-Id: I462092b58bf595a6968f4765f83a207506f0cf87
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Ctrl+K is a useful shortcut for some users, so we have to block the locator if the keyboard is locked.
Fixes: QTCREATORBUG-30032
Change-Id: I211e0bc449d3981513cc77bd14baf70a9acc3ae1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Create a qt_attributions.json and generate a documentation file from it
automatically when building documentation. The result is included as a
table in the acknowledgments page in the documentation.
Some attributions cannot (yet) move to qt_attributions.json, because
that requires the sources to be available in the project's source tree,
which is not the case for LLVM, Clazy, etc.
Remove the attributions from the README and instead point to the
documentation from there, so we get rid of that duplication.
Change-Id: I22623fe7495593ffce2e2c6c26255c27c5a8cb71
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Speculative fix for sometimes slow load times of the Terminal
plugin on Windows
Task-number: QTCREATORBUG-29840
Change-Id: I6782db075bfaa25fbabe2bac2a8f0f3b4af4f833
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
Change actions to use ActionBuilder and
use ToggleAspects for tool buttons.
Change-Id: I0f4a58c3a98cb2804e3d387ea02cac043bd71ae7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
FilePath::toUrl does not pass queries correctly to QUrl.
So we use QUrl::fromUserInput directly.
Fixes: QTCREATORBUG-29850
Change-Id: If0706b3b37d03eeea87247b44f07f8a0f8915a95
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
