Commit Graph

62024 Commits

Author SHA1 Message Date
hjk
1bc385bd66 Debugger: Compile fix
Change-Id: If2b2286d9c5d444022b748f6c32319fb60d1c1aa
Reviewed-by: hjk <hjk@qt.io>
2024-07-15 10:30:49 +00:00
hjk
d8d36286b4 Debugger: Simplify DebuggerToolTipContext constructor
Change-Id: I3407a3f6e7d2ca7cdcd16256bc069933a42bfa8b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-15 09:51:18 +00:00
hjk
4367737012 Debugger: Remove dead code that persisted tooltips at some time
This was not in use since 2fe69b60 in  2015 without anyone complaining.

Change-Id: Iccc4a230a008b8dff5b08faa5cb1ae513c4c0360
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-15 09:51:10 +00:00
Christian Kandeler
1c272072e5 ClangCodeModel: Fix displaying ifdef'ed regions
... that are started by an indented preprocessor directive.
clangd potentially sends regions not starting at line boundaries (in
this case erroneously, but potentially also on purpose), which
TextDocument::setIfdefedOutBlocks() does not expect.

Fixes: QTCREATORBUG-31204
Change-Id: I9126263b9501edbbab1fbc22cc59c5ee1ae814c2
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 09:26:51 +00:00
hjk
5cc47bc232 BinEditor: Move most data related operation from widget to document
Task-number: QTCREATORBUG-13209
Change-Id: I235cd0226689b242511b18bd7e70314a74307a96
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 08:41:55 +00:00
hjk
5d9b689e29 BinEditor: Clean up a bit
Change-Id: I95b8ff3dece3107831390d668cadc4aa17e3b618
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 08:41:35 +00:00
hjk
096215a970 BinEditor: Move factory service out of BinEditorWidget
This was conceptually the wrong place.

Change-Id: I4d591a41ae51ce82fd020d5ded49a4313cdc9182
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 08:09:28 +00:00
Marcus Tillmanns
a28f5916b1 Core: Add option to exclude binary files from search
Fixes: QTCREATORBUG-1756
Change-Id: I4675981f21b65c638ad64ac36668e5474337e283
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-15 07:50:08 +00:00
hjk
bc5f956d78 BinEditor: Move address widget to BinEditorWidget
The obvious location.

Change-Id: I12348034fdc82c16819f978c9889c8fc018399c3
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 07:06:42 +00:00
hjk
1d834b9a12 BinEditor: Split doc and widget initialization a bit
Change-Id: I236b0151c245c7da4cd692d175940fa62220bebb
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 07:06:28 +00:00
hjk
0469dd5602 BinEditor: Split out BinEditorDocument class definition
Still preparing data holder re-organization.

Change-Id: I29473fed8320b3812288b72d0d5fc943aa67a2cf
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 07:06:08 +00:00
Marcus Tillmanns
5cd6f6086a LanguageClient: Rename jsonEditor()
Also adds QObject *parent argument for ease of use.

Change-Id: I25d23186d398d35ebc8519b5964da637bf4d028d
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-15 05:56:29 +00:00
David Schulz
cee9270699 TextEditor: Add action to clear a selection
Change-Id: I5467a5ef30413418d65a9ac22f1c22d58ee0ee60
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-15 04:20:36 +00:00
Christian Kandeler
ba8fe5601f QmlJSEditor: Fix warning
Amends a8a3d79592.

Change-Id: Ifbab600c148d71cf1763f1c23290a98a3066c359
Reviewed-by: hjk <hjk@qt.io>
2024-07-12 12:47:41 +00:00
Christian Kandeler
ec5e055a90 ProjectExplorer: Add function for retrieving toolchain factory by type
Change-Id: I0968738c50e7fce56a016c4801054131a1ea33c9
Reviewed-by: hjk <hjk@qt.io>
2024-07-12 12:47:22 +00:00
hjk
a67d95d138 Docker: Avoid a warning for an unused #include
... by adding three others elsewhere.

Change-Id: Ib9fde247ec3d5f9e19a9d5f175373e4b237c8a6b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-12 12:20:41 +00:00
Christian Kandeler
fec896e712 Utils: Add convenience function for generating a unique Id
Change-Id: I74516ef5077009ebcf1d47c724ca63e502729ede
Reviewed-by: hjk <hjk@qt.io>
2024-07-12 11:47:05 +00:00
Semih Yavuz
491c0ab7a6 Restart qmlls when project info changes
When the project info changes, we should update the qmlls version
which the current opened document is using.

Fixes: QTCREATORBUG-31208
Change-Id: Ief338efd863ea7472a4e5b68a5b6e7d601fd0f80
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-12 11:43:22 +00:00
Cristian Adam
751cfa7bc3 CMakePM: Do not allow staging dir setting for clean build step
CMake will fail with an error for the "--target clean install"
combination.

Change-Id: I6de31539a3ead57bbcde5ce9905a22c9aeb3fd12
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-12 10:52:11 +00:00
Marcus Tillmanns
6d4e901e5e LanguageClient: Add "Send message" to inspector
Change-Id: Iad7940cdd461e9302fbe88147e7a74122b24704b
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-12 10:23:48 +00:00
Cristian Adam
6c5717844d CMakePM: Disable CMake actions after clearing CMake configuration
This way the user will not have actions that will result in the
following error: "Error: could not load cache".

Change-Id: I4b4f2015e1215d4c12c6aefc03f4ee5b419016c3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-12 10:07:59 +00:00
Marcus Tillmanns
9be409de16 LanguageClient: Add clientsByName()
Change-Id: Id66a94cd2cf1d19f7f4770457f069a2db5e18c4f
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-12 10:02:38 +00:00
David Schulz
bfdda368a9 TextEditor: optimize folding highlight
only try to get the cursorForPosition if the mouse cursor is above the
folding region.

Change-Id: I81efdcfc84dc4d1bab696c57de8732e819ea4b72
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-12 09:34:18 +00:00
Thomas Hartmann
073f8772c9 QmlDesigner: Do not show MCU support related wizards
If detailsPageQmlPath is empty it is not one of our wizards.

Task-number: QDS-13210
Change-Id: I9c00e92e176eb8a26acd3cc1ed36d94d913cc7bb
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-07-12 08:32:11 +00:00
hjk
496cd41d24 BinEditor: De-pimpl BinEditorWidget
Change-Id: If9760aa6e800c8878d7bd267ba18f1c95cae090c
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-12 08:00:16 +00:00
hjk
04109bf05d BinEditor: Re-organize plugin setup
Adapt to recent development.

Change-Id: I9c121e5b793469e5dae319ea50d74c59f6ee68b9
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-12 08:00:08 +00:00
hjk
a4c177491a BinEditor: Merge widget and plugin files
First step for re-organization to move data handling from widget
to document.

Task-number: QTCREATORBUG-13209
Change-Id: Ida7c5d7d57523b51e7ee271af3b5b7835d9e14f9
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-12 07:59:56 +00:00
hjk
58f3e06e98 Core: Avoid a temporary MultiTextCursor
Change-Id: Ibe588ab34e754c9f2c6b483ab642c818b19edef7
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-12 07:59:42 +00:00
Jarek Kobus
ad7de40a9d IosToolTaskAdapter: Don't leak the IosToolHandler on destruction
The TaskAdapter may be destructed at any point in time,
even when the task is still running (i.e. when the task tree
was canceled). Make sure the internal IosToolHandler gets
deleted in this case.

Amends 150441bf88

Change-Id: I1ae4d324390c38d4faf9ec32f83c66295ed18532
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-12 07:53:49 +00:00
Christian Stenger
6afc9b5b51 Lua: Add lua files to project files
Amends 8a9c2a1e73.

Change-Id: I196fd8dfdbf172b2cf0c967b3f0e64b2965024e8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-12 07:42:54 +00:00
hjk
cba64c460b Use the new BaseAspect::addOnChanged in a few places
... and in some cases move it closer to the aspect setup. I kept
the original location in cases where the order possibly matters.

Change-Id: I4774ea355d0d1e3cf890676a84121195fca6d406
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-12 07:40:10 +00:00
Marcus Tillmanns
8a9c2a1e73 AiAssistant: Cleanup
Change-Id: Ic418523a9a514128adf11ec3a97ffb6d8d70c8a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-12 06:43:51 +00:00
Christian Stenger
62d698c39c Lua: Fix build on Windows for older Qt
Qt6.4 ends on Windows with an ambiguous overload for the
operator otherwise.
Amends d298244c10.

Change-Id: Ie6813cffb22925b71ee55219ade1c3234f6aed8f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-12 06:16:27 +00:00
Lukasz Papierkowski
d298244c10 Lua: Add TextDocument bindings
Change-Id: Ib713993a548f76f50c4b29fb11c445d2e38b16b3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-11 21:36:26 +00:00
hjk
822e5a30bc Welcome: Re-organize welcomeplugin.cpp
Introduce a (local) WelcomeModeWidget class, and arrange the
code in 'building up' fashion.

Change-Id: I841a38a292fbcb2aaaa1ee33cda90f4c5f817de2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-11 14:13:10 +00:00
Christian Kandeler
2bfa16daa1 CppEditor: Fix code folding in the presence of ifdef-ed out blocks
The intention was to not track brace depth and folding indent inside
ifdefed-out code. However, the information about which blocks are
ifdefed out come from the semantic highlighter, and the logic was in the
syntax highlighter, which runs before the semantic highlighter and thus
does not know which blocks are currently inactive.
Therefore, we move the logic to the place where we receive the
information from the semantic highlighter.

Fixes: QTCREATORBUG-21064
Change-Id: I144f4d636b9b9a993763b45a2b6c6c96195a2f77
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-07-11 14:10:41 +00:00
Christian Stenger
fe4f47c235 Wizards: Suppress warning for non-projects
The warning is explicitly for sub projects.
Kind of amends e30dd3c5ee.

Change-Id: Ic54e5ca8c3505cf113a178b8b4be6da4a4e64ac0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-11 13:57:04 +00:00
Thomas Hartmann
3e01f4289e QmlDesigner: Use the provided arguments as intended
Change-Id: Ie69f88b05c01efbe46acfc399b3ebc05056003e0
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-07-11 13:54:58 +00:00
Thomas Hartmann
cc32336129 QmlDesigner: Use IFeatureProvider to hide wizards
Instead of filtering manualy we can simply defien a feature only
in the full QDS.

Change-Id: Ibeb2faca85cba77aacd1a99d5f405b21fcf3530b
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-07-11 13:54:47 +00:00
David Schulz
6988462cd5 TextEditor: fix highlighting whole words matches
... at line start and end.

Fixes: QTCREATORBUG-31020
Change-Id: I3b26089ef72a34dedfe8846119f672e75bf03215
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-11 12:42:38 +00:00
Semih Yavuz
60b0d88df9 Fix warning message due to incorrect qmlls path
Don't try to start qmlls if the found path doesn't exist.
When there is no Qt version found in the project (this happens
when you open a qml file without providing its build folder, or
open it without the project info so no linked Qt version is found)
we might end up with incorrect path where no actual qml executable
exist for that path. Check the existence of the binary before assigning
it as the path for qmlls.

Fixes: QTCREATORBUG-31207
Change-Id: I626ace796401e72462eb850d4bd88c1ef51cf53a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
2024-07-11 11:50:24 +00:00
Jarek Kobus
7f79bec02c Android: Make m_androidABIs field local in AndroidDeployQtStep
Change-Id: I7107470ddd8b8cd2e6039e8d230b516f8eb3004e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-11 11:40:57 +00:00
Jarek Kobus
1c409022b4 Android: Drop m_manifestName field inside AndroidDeployQtStep
Change-Id: I14a3b92928ceabf2d634d9bf2bc6e7b81402b4d0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-11 11:40:49 +00:00
Jarek Kobus
abdce9e73a Android: Refactor filesToPull
Replace QMap with a list of FileToPull struct.
Rename gatherFilesToPull into filesToPull and make it a static
getter.
Simplify for loops.

Change-Id: I74208a60efb8f00676c1b72c807ba9c7bd6ef587
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-11 11:40:40 +00:00
Eike Ziller
42a8b5b432 Merge remote-tracking branch 'origin/14.0'
Change-Id: Id00d72a8707d122b72d89ed0ecf03ad5ed8230d2
2024-07-11 12:10:59 +02:00
Eike Ziller
a13635ca6b Application Output: Fix name of output file
If a tab is re-used for a different application, the output file name
must change too.

Fixes: QTCREATORBUG-31099
Change-Id: I3413fca3a99757777db8cb771f0947f655d20ea4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-11 09:37:35 +00:00
hjk
c0d86751dd Welcome: Use ActionBuilder to set up the UI Tour action
Change-Id: I6b7590d7923da7dc5cd92c59a678fe031f6752c6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-11 08:55:46 +00:00
hjk
0ca17351d4 AutoTest: Use new SelectionAspect::setUseDataAsSavedValue()
Change-Id: If5ec39b5d2488994e678d2fe76cd9ad3232442ac
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-11 08:51:01 +00:00
Christian Stenger
04bb6b95fe QmlJSEditor: Fix order of initialization
Enabler need to get set after reading the settings.
Silences soft asserts.

Change-Id: I7e70279537a87462e607e51a40d9fef565b46fa8
Reviewed-by: hjk <hjk@qt.io>
2024-07-11 08:36:00 +00:00
Thomas Hartmann
07d8a8109f QmlDesigner: Add and check feature for 3D wizards
In QML Lite Designer mode we do not show 3D wizards.
For this we introduce a feature ("QDS.3D") and check for it.

Change-Id: Ifca2cea5373181434bee6cb7813ebc64c8df6983
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-07-11 08:02:41 +00:00