"Use Scene Environment" is not default option for 3D view background.
Fixes: QDS-12414
Change-Id: I5981b5d77a044c5f2d250c5c1ccdf307a7764108
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Clicked signal was directly connected to handleObjectClicked function,
but it had different number of parameters, leading to multiselection
parameter to always being undefined.
Fixes: QDS-8137
Change-Id: If065531878df9ad7e6584c89dce19b6b7d71a676
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Converting file:// urls to relative paths assumed that the file://
url would always point to a file that is in same or child folder of
the qml document, which broke for urls that pointed under generated
components folder.
Fixes: QDS-12029
Change-Id: I352ba01650ebf6c1c5fedef9323bf27b44491736
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Mouse wheel no longer zooms 3D view when done in fly mode. Instead,
it adjusts the camera speed value.
Fixes: QDS-12291
Change-Id: I0bb5960d67cb25d545d3ac2ce2567c75f057ea72
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
While in fly mode, Shift will speed up the WASD/QE movement by 100% and
Alt will slow it down 50%.
Also changed how shortcuts are disabled in fly mode. ShortcutOverride
events are now used to suppress conflicting shortcuts, which has the
advantage over old method as it will also suppress application global
shortcuts (such as Alt key moving focus to application menu).
Task-number: QDS-12291
Change-Id: I5c97d10b6f8955f3b3214e8e254a80cae7357ce5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Adding new nodes to the scene for some reason doesn't include them
to the full window render done for picking purposes. Changed the render
to be done via grabItem() on the target View3D instead, which seems to
work more reliably.
Fixes: QDS-12577
Change-Id: Ia5f01b9521fd898f8cf073f96d32fc31bf936a37
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
When in fly mode in 3D view, crosshairs are shown in the middle
of the active split. Pressing space in fly mode when there is
a model at the crosshairs will move the camera close to the
model.
Fixes: QDS-12292
Change-Id: Id15c13458af3763f4e0712614cf9cf3ed695fb5d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Changing dynamic properties on a CustomMaterial root object didn't
trigger rendering. Also there were duplicate of the property generated
when it was changed, which made quick3d side ignore the property change.
Fixes: QDS-12469
Change-Id: Ia83eaa76fd4f43428a01baea9a3491a8917aa30d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Resetting the zoom after aligning edit camera to scene camera avoids
confusing behavior in some cases, primarily when the alignment is
triggered from outside 3D view.
Fixes: QDS-12348
Fixes: QDS-12350
Change-Id: Ic0c076ea3dff3f1be5f57e20c0dbbe6069867b51
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
When moving the edit camera with keyboard, zoom level no longer is
used as multiplier for the movement.
Fixes: QDS-12274
Change-Id: I59c903b73fef095e619cccc36868605b47f9ec83
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
When getting the bounding rect for an effect we actually have
to find the item with the effect first.
Change-Id: I4e20f77c6b8dca9d58ccffb42d8b803f57317cb9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
The property name changed and we adda bit more padding.
Change-Id: I9432f3d5a053d38feb32649be52a99696a9f3b6c
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
- Replace hasNext()/next() with a `bool advance()` method
- Replace QAFE::FileTime with QFile::FileTime, they are identical
- QAFE methods now return std::unique_ptr, which matches reality as call
sites stored the pointers in a std::unique_ptr anyway
FileIteratorWrapper:
State::BaseIteratorEnd is only needed when using hasNext()/next(),
hasNext() changes m_status to State::BaseIteratorEnd, then next() checks
that and changes m_status to State::Ended; this isn't needed with
advance() since it's only one method.
Change-Id: I4414f334715237a2fc13ace6f4733d975e2cfaa3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit ba3f0bc841)
* Effects are items and we have to use __effect/source and allEffects
to idenfify them and get the correct bounding rectangle.
* For now we use a custom parser to work around issues when editig the model
Change-Id: I78690498c44f8285d3bb6ce78eafcafb9c26b2f1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Replaced old hardcoding of 40px margin for effects with actual
sourceRect of the layer. Also check for effect first before clip, as
that clip doesn't actually affect the clipped item itself,
it only affects the children of the clipped item.
Fixes: QDS-12303
Change-Id: Ia962c74cdefb16ed17bea34f0fc50649256d78fe
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
User feedback was gathered and in part implemented in form of a design
update. Smaller fonts, icons and gaps in the projects/sessions screen
and in the examples tiles.
Change-Id: I69d0d9ae21ba855feceeb77d620aa5b556377808
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This forks code from Qt to fix an issue with JSValue.
We must skip QJSValues when iterating properties
since copying or constructing the QVariant crashes.
Task-number: QDS-12263
Change-Id: I8db701cee94dccd7fe254c9473dc25b87f8a04f8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
- Replace hasNext()/next() with a `bool advance()` method
- Replace QAFE::FileTime with QFile::FileTime, they are identical
- QAFE methods now return std::unique_ptr, which matches reality as call
sites stored the pointers in a std::unique_ptr anyway
FileIteratorWrapper:
State::BaseIteratorEnd is only needed when using hasNext()/next(),
hasNext() changes m_status to State::BaseIteratorEnd, then next() checks
that and changes m_status to State::Ended; this isn't needed with
advance() since it's only one method.
Change-Id: I4414f334715237a2fc13ace6f4733d975e2cfaa3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Edit camera speed configuration consists of a slider and a multiplier,
which combine into the total camera speed.
Speed and multiplier are stored per scene.
Fixes: QDS-12187
Change-Id: I587c04cf80d1ca95b5a38c406158e46cdb91d06f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Also if the click was over a visible model in View3D, that model will
be selected. 3D view edit camera will be aligned to the scene camera
currently in use.
Fixes: QDS-12188
Change-Id: I25823dbbcf9d1706b2cdefb8c34aa78ecd93e407
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
You can now activate fly mode in 3D view by pressing right mouse
button. In fly mode, cursor is hidden and mouse controls edit camera
rotation directly, and WASDQE can be used to move the camera around.
Fixes: QDS-12030
Change-Id: I52550502632af19de36a1557d9aac84ff3cb18cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
To build a correct puppet with the correct version
number do:
cmake -DBUILD_DESIGNSTUDIO=ON
no branding argument necessary anymore
Change-Id: I74b25e3da296fe77d83892d0596f5da3c38ed6cf
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Use Dto::IssueKindMeta::enumToStr() to convert it to string.
Rename icons accordingly.
Change-Id: I8a955f2f0075793eea761cd4a41374a65d2aaea2
Reviewed-by: hjk <hjk@qt.io>
The box is visualized with wireframe box, just like setting debug view
property on reflection probe itself would do, only in 3D view the box
is shown when the probe is selected.
For simplicity, the box visualization is only done for single selected
reflection probes.
Task-number: QDS-11964
Change-Id: I1ad645517fa32785e4a5952b13cb3e10eb5f89b9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
These are tools of the 3D view and shouldn't be reflected on reflection
probes added to the scene.
Fixes: QDS-11963
Change-Id: I6d32ed737e3801fbab81a746306de571a25ff363
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Some effect related objects such as QQuickShaderEffectSource can be
silently removed alongside another object, so use QPointer to ensure
all objects are still valid before readding them.
Fixes: QDS-11973
Change-Id: I75ee2dc81e27774f8be87b031e149b135ec84023
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Now effects made with effect composer can be hidden/shown using
visible property.
Fixes: QDS-11786
Change-Id: I44782246adfa3ba3cd0a8203fa67b3f5412535f7
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
