Commit Graph

72811 Commits

Author SHA1 Message Date
Marco Bubke
e41fe49f29 QmlDesigner: Fix unused variable
menu is not used

Change-Id: I5ee685b89160fd50537c7b993f05c56ada6d0e9b
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-06-11 12:15:47 +00:00
Mahmoud Badri
de5a3b696d QmlDesigner: Refactor out ContentLibraryMaterial from user bundle
Some tweaks and refactoring to get rid of ContentLibraryMaterial in the
user section of the content library. The end goal is to unify the code
for handling all Qml components in the user section (materials, 3d
components, effects, 2D components. etc).

Change-Id: I99d4fb64dae0b52265994ce478525e574e4bc658
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-06-11 12:14:14 +00:00
Eike Ziller
cf64d46bbe Markdown: Implement navigation history
The text editor widget now tells us when it thinks a new navigation
point should be added, so do it.

Change-Id: I20e65134420cb1d94d7bc5310791d07ff951647c
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-11 11:49:22 +00:00
hjk
a8ea6c1eac Debugger: Fix action handling of QML Console filter buttons
Amends 93a5803956.

Fixes: QTCREATORBUG-30788
Change-Id: I3699e07e67821098500b5b4f85a15d8b19f57ec5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-06-11 11:34:12 +00:00
Jarek Kobus
faf6ae04c2 TaskTree: Qt-ify the code (part 3)
11. Replace local lambda with static method, otherwise getting:
    "qarraydatapointer.h:110:17: error: pointer may be used after
     ‘void free(void*)’" on rhel-9.2-gcc12.
12. Use std::optional::reset() instead of "= {}", otherwise getting:
    "error: use of overloaded operator '=' is ambiguous
     (with operand types 'std::optional' and 'void')" on vxworks-imx6.

Amends 88ee3aa908
Amends 6621c68ca9

Change-Id: Ie1631e119cb89d23a6acb3b4c39199e6ebaf1ea1
Reviewed-by: hjk <hjk@qt.io>
2024-06-11 11:11:31 +00:00
Christian Stenger
dbe2e422f7 Axivion: Link from dashboard overview to table
Make issue counts clickable and directly jump to
the respective issue kind.
This approach mimics original dashboard view more
closer and avoids confusion on the user side when
trying to find the issue table.

Change-Id: Ic23368ea6d881b46950ef41c28d4cbf737163cf2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-06-11 11:07:26 +00:00
Cristian Adam
b66a800045 Revert "CMakePM: Set platform codegen and linker flags for GCC compilers"
This reverts commit 831b93905b.

Reason for revert: breaks Android and it looks like magic. For CMake one
should use a toolchain file. But this revert keeps the CMAKE_C|
XX_FLAGS_INIT parameters update / merging.

Change-Id: I1c3c61e4a9345a29e72db7f5f5a2d6e3fdba52f1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-06-11 09:52:22 +00:00
Miikka Heikkinen
35efae7bb6 QmlDesigner: Improve code model update at bundle component import
When the bundle folder is completely missing, we can use importScan
to update code model, but if the folder already exists, then full
code model reset is required. Since there is no proper notification
for reset finishing, we listen to library info updates and after
those no longer come for a brief period, we consider reset done.

Task-number: QDS-11496
Change-Id: I472f6fdb47ccb7b8131783f86025f3d3538a946d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
2024-06-11 09:47:22 +00:00
Christian Kandeler
2d35dd1532 ClangTools: Fix behavior of expand/collapse button
It's a check button, so it should behave like one, i.e. its current
state should be considered when adding new diagnostics, and it should be
enabled regardless of whether any diagnostics are currently visible.

Change-Id: I0e21ad5fdc5cd6a20fda7b40ea7eecd454d1e11f
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-11 09:15:10 +00:00
hjk
4e2d8d0226 Fix more metatype related deprecation warnings
Change-Id: If206b70d263bcdb6d617827fb9cb8fe3214564a1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-06-11 08:51:23 +00:00
David Schulz
64f9ff8963 Rust: use cached release information
Change-Id: Ibc9b0921e02f4c190986bcf69f75a3347369c68d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-11 08:24:37 +00:00
Henning Gruendl
994f3827b3 QmlDesigner: Make form editor color permanent
Make the form editor color permanent via AuxiliaryDataType::Document
instead of AuxiliaryDataType::Temporary. Also put it into the globally
available AuxiliaryDataProperties.

Task-number: QDS-12245
Change-Id: Ib9191f168bdbfdb09367afaeb8052d6fdbf7dad9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-06-11 06:55:43 +00:00
Thomas Hartmann
4e988d48d0 QmlDesigner: Make smooth rendering the default
Task-number: QDS-12958
Change-Id: Ica43e8887f43211e306381ac7d89da932f64e07b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2024-06-11 06:48:21 +00:00
Thomas Hartmann
8f58dc6de9 QmlDesigner: Adjust regular expression
This is a heuristic to detect expressions and we should
require at least a single "." to distinguish true/false and simple
string literals.
The implcit binding detection is not ideal, because there are still false
positives.

Task-number: QDS-12888
Change-Id: I23b5dd44ff3150f6d5a4ec94bd7a19b5e2117f5b
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-06-11 06:39:58 +00:00
Marcus Tillmanns
bb5b8b40ff LanguageClient: Don't store client settings multiple times
Change-Id: Iff6dcfef4d8f1e5cc01b48f2a4cf12f4c5927581
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-11 06:31:06 +00:00
Thomas Hartmann
f6988e8319 QmlDesigner: Qualify properties of the root item when sending to puppet
In the qml2puppet bindings to properties have to be fully qualified.
This is good practice i nany case, but customers reported broken files.
Therefore we fully qualify property bindings, if they exist in the root item,
but not in the item referenced from.

Task-number: QDS-9340
Change-Id: I11aaa4ce1ed6ddefcac7e7873fdfd931ee2d978f
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2024-06-11 06:26:37 +00:00
Leena Miettinen
3cf9f64791 Doc: Update info about connecting Linux-based devices
- The device wizard instructions should not mention USB, as
  USB connections are detected automatically
- The descriptions in the Extension Manager should use
  "network" when both wired and wireless connections are
  supported

Change-Id: I29a7279c413b335280fc5f2fa254e8922ecac5a9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-06-11 06:06:52 +00:00
Christian Stenger
732b503aa2 Lua: Add wizards to qbs build
Amends cb1f1bdd61.

Change-Id: I56a20324a089abc360c94d6eb7d2c2522622a094
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-11 06:00:35 +00:00
hjk
8a6e1d6c06 TextEditor: Avoid some deprecation warnings
Change-Id: I05ceed344086f1cf75926f132422a1e0ae30cf08
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-11 05:47:42 +00:00
Mahmoud Badri
9b21b643ca QmlDesigner: Remove AbstractView::emitCustomNotification() overloads
Use default params instead

Change-Id: I5e8f7bc2bf29e266768fdabb6d000d058499733e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2024-06-10 15:33:57 +00:00
Thomas Hartmann
71241c4abb QmlDesigner: Fix bindings in states
If a state is binding, we have to use the instance value.
qmlObjectNode.hasBindingProperty() does check if the state has a binding.
Before, we only checked the base state.

Task-number: QDS-11994
Change-Id: I70109bb359f458b3e281b0f0abff11b0e688d1df
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-06-10 15:24:54 +00:00
Mahmoud Badri
b7131bbd30 QmlDesigner: Add support for importing materials to content lib
Fixes: QDS-12965
Change-Id: I422a45f305593eb4b58cd59b807e3bdefd9d056f
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-06-10 15:00:24 +00:00
Mahmoud Badri
ed263f5ee5 QmlDesigner: Add 'import' action to material browser context menu
Change-Id: I68577899841d8884d96446c762e7d228a1b03dc5
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-06-10 14:51:39 +00:00
Christian Kandeler
f65c54fa3e Wizards: Remove remaining uses of classToHeaderGuard()
Amends 335c552bda.

Change-Id: I4f43e74f74cd42c4139e91b80abe89bf371411ef
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-10 14:08:15 +00:00
Thomas Hartmann
66048e2a44 QmlDesigner: Fix hardcoded Qt 5 import
Change-Id: I5395d3a8c9af7354a41442a8dddfe0cf0a56c402
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-06-10 14:06:02 +00:00
David Schulz
0cd5230f6a VCS: Improve performance of isVcsFileOrDirectory implementations
FilePath operations are relative expensive on Windows compared to the
cost of a string comparison, so always first check the file name before
checking any file meta data.

Change-Id: Ibb4c13d7e11e0c01bdf3706a62362f4c0a27d284
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-06-10 13:58:45 +00:00
hjk
acd3d60fb2 Debugger: Add debugger name to progress bar
... when there is more than one engine.

Mildly-related-to: QTCREATORBUG-30355
Change-Id: Idaf41b97f51c384ccf6a437d9c9c8dec922affc6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2024-06-10 13:34:30 +00:00
Christian Kandeler
6040fef260 RemoteLinux: Do not try to start a process via a shared connection
... on a disconnected device.

Change-Id: Ide89f38783b96d41c50b7f53d649f213522e8857
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-10 13:26:31 +00:00
Marco Bubke
361caf938f Utils: Fix small string
Change-Id: I94b9cd4c282bf57254b52172658135237d4073bd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-06-10 13:23:30 +00:00
Marco Bubke
3f53749998 QmlDesigner: Move includes to string layout
To fix build on MacOS.

Change-Id: Ie697ee7c5d0f57f0ba9735b36c704196ef7e5a4f
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2024-06-10 13:23:23 +00:00
Christian Kandeler
37f5501a1f RemoteLinux: Do not try to fetch environment of a disconnected device
Change-Id: Ibe1ca43fa3d9d0ade2fa3db1808c1a5fd2cb7232
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-10 13:20:36 +00:00
Christian Kandeler
6e4fbed511 RemoteLinux: Serialize the "disconnected" state
Otherwise permanently unreachable devices will keep causing annoying
delays after every restart.

Change-Id: I85c6fd0a6964c7f25e4b61b8eb092fc606b146ad
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-10 13:20:16 +00:00
Shrief Gabr
e00d00c069 QmlDesigner: Add indicator/warning if accessibility is disabled on macOS
Task-number: QDS-12889
Change-Id: I286628492e1ef195eafd529bf090c027d3bdde8b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
2024-06-10 12:39:41 +00:00
Christian Kandeler
6141aa3f61 Update qbs submodule to HEAD of 2.4 branch
Change-Id: I3c87ea95da4f91f194467249fa8fe55b04d573da
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-06-10 11:10:58 +00:00
Aleksei German
68123d07df QmlDesigner: Disable GroupItem in Context Menu
Task-number: QDS-11988
Change-Id: Ifd547e12b165c7fe76c5818f8b7f4bde93ab1340
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2024-06-10 10:05:54 +00:00
Marco Bubke
a7309597fa Utils: Optimize smallstring a little more
For string with a larger area we use spend a little bit memory on less
execution time.

Change-Id: I261ada4120de974ce40daaa7f0922af4dd115996
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-06-10 09:18:34 +00:00
Mahmoud Badri
c463807dda QmlDesigner: Avoid UniqueName::generateId() crash when id is empty
Change-Id: I07099c143db2317a0275b56a8300bdccf959b6c0
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2024-06-10 08:31:41 +00:00
Mahmoud Badri
9b7007637b QmlDesigner: Fix crash on bundle export
- Make sure tem dir stays around until icon is generated.
- Handle the case of empty id.
- Few more smaller tweaks.

Change-Id: I807b1258cf2cb5c4a6714454f840d50d14bde17c
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-06-10 08:30:53 +00:00
Jarek Kobus
29121865a8 Session: Add missing include
Otherwise Q_DECLARE_TR_FUNCTIONS is not known.

Change-Id: I685ccedb7c94847b065ca9919368c74ecc5d2376
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-06-10 08:22:43 +00:00
Artem Sokolovskii
3241818a6a AppStatisticMonitor: Add Windows support
Change-Id: Ib5b53d7802f54d2a8845ddfc7ba86c977d1db4be
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-10 08:05:25 +00:00
Marcus Tillmanns
cb1f1bdd61 Lua: Wizards
Adds a simple lua file wizard, and a lua plugin wizard.

Change-Id: I0ea08cdc5eabe7396cb49abd265fce16f5960416
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-10 07:38:23 +00:00
hjk
d308b86847 Utils: Centralize aspect macro expansion setup and handling
Let each aspect have a macro expander, and let aspect-owned lineedits
use this for expansion.

Change-Id: Ifa6f5a678cf81c169643e4145f41e69eafedeb93
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-10 06:31:20 +00:00
Marcus Tillmanns
685694c7a9 Copilot: Remove agent.js from the translation
agent.js was renamed to language-server.js. This patch changes the installation note
but requires a change to the translation files.

Change-Id: I02f825260c5a7a3c53fa938c2e074216210493eb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-06-10 06:08:54 +00:00
Marcus Tillmanns
13c892f9d3 LuaLSC: Fix crash on exit
Since the client lives longer than the lua context, its destruction would
also cleanup the custom handlers which had captured the lua function.

Calling anything as well as the destructor of a sol object after the lua
context is gone results in a crash, so make sure that we don't keep it
around any longer.

A better solution in the long term would be to allow custom handlers to
be unregistered in the Language Client.

Change-Id: I59ac39d9279dc5faf24d3fd3b29e8c7c00e2b48e
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-06-10 05:58:14 +00:00
David Schulz
421210e609 Debugger: avoid 32 bit cdb detection
Change-Id: I75c8dd4e764b3d16387fb49271bf0b973e0f45b7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-06-10 04:54:20 +00:00
hjk
cbd596f608 ProjectExplorer: Add macro expansion for CopyStep
Fixes: QTCREATORBUG-30821
Change-Id: I8cde8d93ca41fa320113d95c25d42f0f277025eb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-07 12:05:29 +00:00
Mahmoud Badri
273ca4b5a9 QmlDesigner: Give a default name if node id is empty
...when exporting a component as bundle

Change-Id: If51cf35df63abddf93db52fa580fdf624e26fda4
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
2024-06-07 11:55:21 +00:00
hjk
80f46e055c Use non-null valies for LB connection guards
Task-number: QTCREATORBUG-31024
Change-Id: I532d2daade968ff4aa2f3dc1ba89d2a3a4e9c2eb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-06-07 10:58:42 +00:00
Mahmoud Badri
2f418813b8 QmlDesigner: Confirm overwrite when importing a bundle
Change-Id: Ifdafb7d607d1ce5c4d2f0eac401588b691e25410
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
2024-06-07 10:57:48 +00:00
Christian Kandeler
73191bce0c Utils: Allow FilePaths to be compared case-sensitively
... and make use of that when renaming.

Fixes: QTCREATORBUG-30846
Change-Id: Id06a6df5db13325d17dcd69270604e754d7dee2a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-06-07 10:20:06 +00:00