This allows using the scanner on remote paths and avoids some unneeded
FilePath::fromString and FilePath::toString calls.
Change-Id: I4871613a9d36daf78607b196f4dfb6e165be8305
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Rename DeployErrorCode into DeployErrorFlag and make
it a flag type.
Change-Id: I459a72a3a0a1dcddc275cd649a7f55c15369359d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Fix tr() messages so that they don't contain newlines.
Change-Id: I705e56796393501da1a2917adb6673a24c1cbcf6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Hide waitForBooted() in cpp.
Move avdManagerCommand() into avddialog.cpp, as it's the only
one usage of this method.
Change-Id: Id88ecbb5532a7d2594c65dddc8245573efd41018
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Qt Creator opens by default the offline documentation of CMake.
But the user can click on the "Globe" to go to the online version
of the documentation.
Change-Id: I0b3a6bceb13784b232b539f1c04bd09aa3a11034
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Qt and std container like different size types
creator/src/libs/3rdparty/sol2/include/sol/sol.hpp:13844:15: warning: comparison of integers of different signs: 'std::size_t' (aka 'unsigned long') and 'qsizetype' (aka 'long long') [-Wsign-compare]
13844 | return idx >= cont.max_size();
| ~~~ ^ ~~~~~~~~~~~~~~~
creator/src/libs/3rdparty/sol2/include/sol/sol.hpp:13902:9: note: in instantiation of member function 'sol::stack::unqualified_getter<sol::as_table_t<QList<int>>>::max_size_check' requested here
13902 | if (max_size_check(meta::has_max_size<Tu>(), cont, idx)) {
| ^
creator/src/libs/3rdparty/sol2/include/sol/sol.hpp:14140:15: note: in instantiation of function template specialization 'sol::stack::unqualified_getter<sol::as_table_t<QList<int>>>::get<sol::nested<int>>' requested here
14140 | return g.get(types<nested<V>>(), L, index, tracking);
| ^
creator/src/libs/3rdparty/sol2/include/sol/sol.hpp:11719:15: note: in instantiation of member function 'sol::stack::unqualified_getter<sol::nested<QList<int>>>::get' requested here
11719 | return g.get(L, index, tracking);
| ^
creator/src/plugins/lua/bindings/settings.cpp:269:55: note: in instantiation of function template specialization 'Lua::Internal::typedAspectCreate<Utils::IntegersAspect>' requested here
269 | return createAspectFromTable<T>(options, &typedAspectCreate<T>);
| ^
creator/src/plugins/lua/bindings/settings.cpp:314:9: note: in instantiation of function template specialization 'Lua::Internal::addTypedAspect<Utils::IntegersAspect>' requested here
314 | addTypedAspect<IntegersAspect>(settings, "IntegersAspect");
| ^
Change-Id: If67ca19aa995622ef476386544b02a77b5af5916
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Do not update states label with empty strings while
debugging as this overrides real state information
when performing additional actions like fetching
variables, stack, and so on inside the debugger.
Change-Id: Ic026644931c845b6f3fb5bb422acc6e36e4a4142
Reviewed-by: hjk <hjk@qt.io>
3D import preview can now be rotated using left mouse button and
dragging the preview image. This causes camera to orbit around the
previewed model, similar to rotation to 3D edit view orbit camera.
Close/Cancel button logic was also improved.
Fixes: QDS-12795
Change-Id: I0c7d1ad28f8fe779b9bedc4bf76be704078d91a6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
We do not use "Label: [ ]", we use normal checkboxes of the form
"[ ] Label"
Amends 2166647682
Change-Id: If77b44fe4d27f9bec749f47b6675189d8e8a070f
Reviewed-by: hjk <hjk@qt.io>
Puppet used to return just string for enumeration types.
Now it will use Enumeration type properly.
Change-Id: I602891e34c03cb659ee0a8e4571b39b6e24f9e1c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
In `IDevice: Replace QSharedPointer with std::shared_ptr' (#536681), the
type of IDeviceConstPtr has changed to use std::shared_ptr, but the code
in RunControl was not updated, leading to compilation error:
error: no member named 'isNull' in 'IDeviceConstPtr'
421 | if (!device.isNull() && device->type() == ...
| ~~~~~~ ^
1 error generated.
Change-Id: I812034f37b14c9c62040f09e039a68eb4edfd4d6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Don't run blocking processes in a separate thread.
Run them asynchronously from the main thread.
Change-Id: I5343f05d992d974720e786e2814cba2d6b295cd4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Allows the user to directly start typing in additional information for a
bookmark after triggering the shortcut. This seemed to have happened
automatically before, but since this is desired behavior anyhow it's
okay to call it explicitly.
Fixes: QTCREATORBUG-30829
Change-Id: I77eef2092052e61397f3a73f15c32e909eda01a0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add them to the global future synchronizer, so they are canceled and
waited for before deleting any plugin instances.
Change-Id: Iec78b7566905815c4d2b4cc7410d10b2da16c7b7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
The variable name "version" had changed to "pluginVersion".
Change-Id: I8299593a4888191e931fed74dc9a4052503fe682
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Also change the class to namespace, rename "get" to "generate"
and add unit tests.
Change-Id: Ib52bf7e3e0110e33acb40ca6e3d9bfc61cefdca0
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Use the global synchronizer from Utils::futureSynchronizer() directly
Change-Id: Ic8843bc1ff7951c041529a258f36117f08ec4b35
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
... and make use of it in ClangdClient.
When a file gets saved, clangd checks all open documents for whether they
are affected by that. While the answer is usually "no", there is still
one thread per document being started to find that out, which triggers
users who keep a close watch on CPU usage. To alleviate this, we now
send the didSave message only for header files.
Fixes: QTCREATORBUG-28580
Change-Id: Id761cec8b04e95a795c8bd8754466bf03b6f2c28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Move the global FutureSynchronizer to Utils and use it
by default for AsyncTask (if that is in the main thread).
This way setting a synchronizer is less prone to be forgotten.
Individual uses can still override this.
Change-Id: I1a12bf4d7f4cb5be99668bf0a4797108c2fe6448
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Show preview of 3D import in item library import dialog
when importing a single 3D asset.
Fixes: QDS-11111
Change-Id: I13135be1e931cbee034ca8a89654c0827b937bdf
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Actions were deleted after being inserted into actionsToRemove,
which caused them to get deleted again, leading to crash.
Change-Id: If6597f117859ca92cfc5af67c730e2f84e5c0639
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
