Commit Graph

72811 Commits

Author SHA1 Message Date
Christian Kandeler
68dab97bc5 CppEditor: Fix running tests with clangd
Try harder to find a suitable kit:
  - Pick one without warnings.
  - Pick one with a Qt, as otherwise configureAsExampleProject()
    will fail.

Change-Id: I5a38e86bd81840c6794de365980618c904936d3a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-28 13:44:14 +00:00
Jarek Kobus
f3a53dfd8c Axivion: Use more dashboard url instead of server url
Change-Id: I1fbc1dad779e9198206cb8ef4a4029a99af6861f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-28 13:39:24 +00:00
Jarek Kobus
bcdcaab7b7 Axivion: Make initial dashboard fetch a part of authorization
Ensure that after authorization we have fetched the initial
dashboard info. If the fetch fails, we remove the stored
ApiToken from the key chain.

Change-Id: I894b9d8bc8ade8ec6fa29391fafa67ad5b4fabba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-28 13:38:44 +00:00
Cristian Adam
64a77d8c83 TextEditor: Set the special weight of Source Code Pro font family
The text editor font is used also for output panes, make sure that on
macOS we use QFont::Medium so that the font is not too skinny.

Amends 13dc66a08d

Change-Id: Idad26738d42452c8d683df7a40a4a2fe44e9793e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-02-28 12:54:50 +00:00
Artem Sokolovskii
95a5f01096 TextEditor: Fix folding for async syntax highlighter
- Made restoreState, ensureBlockIsUnfolded, fold, unfold and unfoldAll
functions to be called only after highlighting is done
- Improved management of foldValidator in async case
- Removed optimizations in cpphighlighter and glshighlighter.
The highlighters are async now and optimization is not necessary.
In these optimizations in the function highlightBlock the highlighting
changes not only for currentBlock but and for several next. Which is
contradict with the function name.

Change-Id: Ib413e6b982eb39d52f36c3066ff0fa8c28fbe231
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-28 11:53:02 +00:00
Alessandro Portale
3f78592831 Utils: Remove soft assert for reading theme flags
An included theme file will usually not define all flags.

Change-Id: I733d8558009ba1b660f66b92c7c2d044035bb0ae
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-02-28 11:43:25 +00:00
Vikas Pachdha
d9759ffb72 Fix invalid node offset
Node offsets were not calculated and thus the aux data was incorrectly written

Task-number: QDS-11920
Change-Id: I8d7aab754cf37740369db00fce78ebb2d3531b70
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-02-28 10:26:19 +00:00
Eike Ziller
5af531cd39 Utils: Fix build with MSVC with C++20
Rename process.h back to qtcprocess.h

MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.

There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have

Simply use a name that doesn't conflict.

Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-02-28 08:09:05 +00:00
Marcus Tillmanns
95743d5c9f RemoteLinux: Don't show self in "Access via"
Task-number: QTCREATORBUG-30008
Change-Id: I90ee2df7243a2b07b494b1d1911930b7ae242669
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-02-28 07:53:17 +00:00
Ali Kianian
bf78e16641 QmlDesigner: Delay loading model source until types are loaded
Change-Id: If4eda07b2c5d9b916d8b2b1a2f94e68d576eedbd
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-02-28 07:02:42 +00:00
Christian Stenger
2b525b4246 AutoTest: Suppress progress bar more aggressively
Task-number: QTCREATORBUG-30447
Change-Id: I4386d522819b9f361f179ccda6a0fd3c759c389d
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-28 05:47:48 +00:00
Christian Stenger
dc21bd6af2 AutoTest: Delay reparsing of postponed files
Task-number: QTCREATORBUG-30447
Change-Id: Ica1dba358e05edfe2ad7ed6fd92fc8afde291718
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-28 05:47:40 +00:00
Christian Kandeler
6e5c72824a QmakeProjectManager: Fix Makefile compatibility check
E.g. qmake "binaries" for Android are actually shell scripts that call a
Desktop qmake in a different location, which lead Qt Creator to conclude
that the directory contains an incompatible build.
Fix this by checking that the -qtconf argument passed to qmake points
into the real qmake's parent directory, as is the case in the
abovementioned scenario.

Fixes: QTCREATORBUG-30354
Change-Id: Id6e878fab3379a3a8893389447514a1b7226784c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-02-27 17:13:15 +00:00
Alessandro Portale
903d01b934 Welcome: Implement new design
2024 redesign

Change-Id: I6629849921272d856f201693973a8e29c6465e94
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-02-27 16:42:10 +00:00
Jarek Kobus
e2a0dd2cef Axivion: Fix the condition inside onUnauthorizedGroupSetup
We should execute this branch just once, when the server access is
unknown.

Introduce isServerAccessEstablished() helper.

Change-Id: I28953f468be39ca49f088032aebb3fa81b814f3f
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 16:32:36 +00:00
Jarek Kobus
97077f4d26 Axivion: Raise the size of issues packet
Change-Id: I4a60649982b1ffa50c2c85f4db3d57f88186a211
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
2024-02-27 16:32:27 +00:00
Leena Miettinen
fdb1fa2a3b Python: Fix capitalization of Python in UI text
Change-Id: I55beeb658eb583a74c4d79f3dc2f121010080101
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-02-27 16:00:48 +00:00
hjk
af712dc0e7 Axivion: Fix clazy warning about mixing const and mutable iterators
Change-Id: Ief898ff2febb958f3f68a64ddcb614479854600f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
2024-02-27 14:47:42 +00:00
Jarek Kobus
e8b3887dbf Axivion: Make use of Dto::IssueKind enum
Use Dto::IssueKindMeta::enumToStr() to convert it to string.
Rename icons accordingly.

Change-Id: I8a955f2f0075793eea761cd4a41374a65d2aaea2
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 14:17:56 +00:00
Alessandro Portale
c536712707 Android: Remove command line and version numbers from translations
Change-Id: Ib4fcd6cbf0a023e074aaad4b265c0ab60edac01a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-02-27 12:49:36 +00:00
Christian Kandeler
226806e0fb RemoteLinux: Make deployment downgrade warning less spammy
Keep the message, but make it a warning only for the "generic copy"
case, which almost no one ever wants.
Otherwise, it will annoy Windows users, who typically have no rsync
installed.

Change-Id: I2044b9ea2b199e03dc4e9421d05a2698d92ad76a
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 12:47:46 +00:00
Miikka Heikkinen
4db744cbf7 QmlDesigner: Add ReflectionProbe box visualization to 3D view
The box is visualized with wireframe box, just like setting debug view
property on reflection probe itself would do, only in 3D view the box
is shown when the probe is selected.

For simplicity, the box visualization is only done for single selected
reflection probes.

Task-number: QDS-11964
Change-Id: I1ad645517fa32785e4a5952b13cb3e10eb5f89b9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-27 11:36:10 +00:00
David Schulz
a57a925b76 Debugger: defer type look up
Change-Id: I425c2bfc3c88ebf46af161c5434c0c05a3bb9c97
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-27 11:32:53 +00:00
Jarek Kobus
5152a35048 Axivion: Change the credential key
Make it user @ server.

Change-Id: I62e2c88ade5cc984ba11f718c3db292e4075e5e4
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 11:17:57 +00:00
David Schulz
82399ac9c5 ClangFormat: Fix compile against latest llvm main branch
Change-Id: I6fe414721103d00eb3212040c1aafa2ef123b9d1
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-27 11:11:52 +00:00
Ali Kianian
d473f9aabb QmlDesigner: Prompt to consider first row as header for CSV files
* Also, a bug is fixed for reading the quoted texts within CSV rows

Fixes: QDS-11667
Fixes: QDS-11834
Change-Id: I74242148e38c8e71edeb45f3543308259358ee1a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-27 10:45:48 +00:00
Christian Stenger
4dcba2ad25 Core: Correct log view thread handling
Fixes a crash when log messages are received from
multiple threads.

Fixes: QTCREATORBUG-30444
Change-Id: I51c78656da1dd30bcb51a801083d1714e474d8e5
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-02-27 10:01:42 +00:00
Jarek Kobus
e95ad3778f AndroidRunnerWorker: Avoid deleting process directly from its handler
Task-number: QTCREATORBUG-29928
Change-Id: If25c742e57ddaa90ed3342d09dafe626288f0783
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 09:49:14 +00:00
Jarek Kobus
0114933deb AndroidRunWorker: Remove redundant variables
Change-Id: I6677ce5d4640fdd68d3571d833f9c3651068facc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-27 09:38:59 +00:00
Jarek Kobus
7c98f2aa9e Axivion: Unuglify issues view frame
BaseTreeView's c'tor calls setFrameStyle(QFrame::NoFrame), that's
why the frame was lacking. Bring back the Qt defaults explicitly.

Change-Id: If48c97cc0b0afa3fdb71b5ba30284371da35192f
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 09:33:27 +00:00
Marcus Tillmanns
536bb51c5a Android: Validate selected Java version
Change-Id: If77e5b524fdfea7d87ff4f221ef81d2f723f2f82
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 08:42:49 +00:00
Eike Ziller
a8414effd8 Merge remote-tracking branch 'origin/13.0'
Change-Id: If752e3383b35873b696e8beca27d8838a4096c8a
2024-02-27 09:04:51 +01:00
Eike Ziller
fdabbfcbcf Diff: Fix that dialog for "Revert Chunk" closes right away
On macOS.

Change-Id: Ifbe402c44779e4062a5dfb5d7c09da7ac845acce
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2024-02-27 08:00:21 +00:00
Leena Miettinen
3d8592edd1 Project Explorer: Fix quotes
Use double quotes for emphasis in UI text.

Change-Id: Idb34140816c8dfffaa87837055a1b76ceda09ef0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-27 08:00:04 +00:00
Leena Miettinen
795d144227 Translation Wizard: Be less polite
Do not use "please" in UI text.

Change-Id: I5332579ab297ae35a18fed88097313c8a50a1f6d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-27 07:59:34 +00:00
Marcus Tillmanns
290232bfd3 Android: Warn if parsing packages failed
Change-Id: I61f249e1b45f1b9322b189b2781dc2375e9d13ca
Reviewed-by: hjk <hjk@qt.io>
2024-02-27 07:38:20 +00:00
Mahmoud Badri
fd2ec14a2d QmlDesigner: Collection editor new collection dialog improvements
- Show a unique name when the dialog appears
- Unify and simplify the unique name generation methods
- Fix name field left border cut
- Remove warning on dialog open
- Clear lot of clutter

Change-Id: Ie5b9711c704e68bb41c4f7c3ff63091d9bd11175
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
2024-02-26 15:19:15 +00:00
Jarek Kobus
69a0f16547 TextEditor: Hide FormatTask in cpp file
Unexport it.

Change-Id: Ib2e73486e31d115a3e960c7bb4420014172313a7
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-26 15:19:08 +00:00
Jarek Kobus
fc59b375ff TextEditor: Move editor field outside of FormatTask struct
It doesn't take part in format() processing function, so move this
field outside. The format() may be called in separate thread, so,
just for safety, don't keep this field there so that nobody accesses
it from non-main thread.

Remove the c'tor of FormatTask and use list-initialization instead.

Change-Id: I54daf1461243a46bbd7f58c91ba051909b6cf280
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-26 15:19:01 +00:00
Jarek Kobus
5df9dee69a Axivion: Remove assert for empty relative doc path
Change-Id: I4364e691c78eb52a2c880e416521458b66931f47
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-26 15:00:53 +00:00
Christian Kandeler
0d7abc019f ClangTools: Remove support for reading settings from ancient versions
Change-Id: I643c553686ec72556fbae62fe1b8c9c9fe327787
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-26 14:54:51 +00:00
Christian Kandeler
e43fde322e CppEditor: Fix indentation of function call arguments
... following an argument with an array subscript operator.

Fixes: QTCREATORBUG-29225
Change-Id: Iba38043d94be718efee30ce50f5b55aac4ba6ecd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-26 14:53:24 +00:00
Christian Kandeler
3f692e2f17 CppEditor: Refactor CppCodeModelSettings
Preparation for per-project settings.

Change-Id: I78ecf0cde6150e40353c4aea6a98717d119f05c7
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-26 14:49:59 +00:00
Miikka Heikkinen
595ba9e68c QmlDesigner: Suppress reflections from helper grid and selection box
These are tools of the 3D view and shouldn't be reflected on reflection
probes added to the scene.

Fixes: QDS-11963
Change-Id: I6d32ed737e3801fbab81a746306de571a25ff363
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-26 14:14:02 +00:00
Miikka Heikkinen
0a97233326 QmlDesigner: Fix metainfo type detection for QML basic types
Qml basic types seem to have "QML." prefixed to the type sometimes,
so check for those as well when determining the metainfo type.

Fixes: QDS-12030
Change-Id: I944f9a247927b952bb76aaa9f5eaa31334cc10c8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-02-26 13:31:02 +00:00
Christian Stenger
dafb8f2231 Axivion: Fix toggling sort
If the horizontal scroll bar is not at position 0 we got the
wrong offset for the position of the column.

Change-Id: Id333584f9d509b67eeef39bc7966f095b577e0fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-02-26 13:22:21 +00:00
Eike Ziller
e8bc1fa78e Squish: Avoid yes/no questions, actions are clearer
Change-Id: Ia0e23a08f074d61db8ead4566753fb27e4a97a71
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2024-02-26 13:10:46 +00:00
Leena Miettinen
0bcc5378e5 CMake: Fix setting label and tooltip
Change-Id: Ia5ca9472054ec366110086bf79f630c5716b83fb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-02-26 12:49:43 +00:00
Jarek Kobus
97ec97ff27 ClangModelManagerSupport: Skip explicit call to waitForFinished()
This is done by the FutureSynchronizer d'tor, so no need to call
it explicitly. Move the FutureSynchronizer as the last field of
ClangModelManagerSupport so that its d'tor is executed first.

Change-Id: Id38b8ec08579be8e4ade99ecadb511850ff37f8c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-26 12:30:56 +00:00
hjk
b5e03b8fe2 QtSupport: Reduce ExtraCompiler life time to plugin life time again
Amends 6467797af2.

The created extra compilers were parented to their factories, who gained
a life time extension from 'end of plugin live' to static destruction
when the factories were made static. However, this that time the likewise
static QObjectCache in GeneratedCodeModelSupport::update might be
destroyed already, leading to a potential crash in m_cache.remove(dead).

This change here re-establishes the original timing by using the
plugin itself as parent for the extra compilers.

Change-Id: Id868b7b87f00440c67af551b71359c47a5c29cba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-26 11:57:23 +00:00