Try harder to find a suitable kit:
- Pick one without warnings.
- Pick one with a Qt, as otherwise configureAsExampleProject()
will fail.
Change-Id: I5a38e86bd81840c6794de365980618c904936d3a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Ensure that after authorization we have fetched the initial
dashboard info. If the fetch fails, we remove the stored
ApiToken from the key chain.
Change-Id: I894b9d8bc8ade8ec6fa29391fafa67ad5b4fabba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The text editor font is used also for output panes, make sure that on
macOS we use QFont::Medium so that the font is not too skinny.
Amends 13dc66a08d
Change-Id: Idad26738d42452c8d683df7a40a4a2fe44e9793e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
- Made restoreState, ensureBlockIsUnfolded, fold, unfold and unfoldAll
functions to be called only after highlighting is done
- Improved management of foldValidator in async case
- Removed optimizations in cpphighlighter and glshighlighter.
The highlighters are async now and optimization is not necessary.
In these optimizations in the function highlightBlock the highlighting
changes not only for currentBlock but and for several next. Which is
contradict with the function name.
Change-Id: Ib413e6b982eb39d52f36c3066ff0fa8c28fbe231
Reviewed-by: David Schulz <david.schulz@qt.io>
An included theme file will usually not define all flags.
Change-Id: I733d8558009ba1b660f66b92c7c2d044035bb0ae
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Node offsets were not calculated and thus the aux data was incorrectly written
Task-number: QDS-11920
Change-Id: I8d7aab754cf37740369db00fce78ebb2d3531b70
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Rename process.h back to qtcprocess.h
MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.
There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have
Simply use a name that doesn't conflict.
Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
E.g. qmake "binaries" for Android are actually shell scripts that call a
Desktop qmake in a different location, which lead Qt Creator to conclude
that the directory contains an incompatible build.
Fix this by checking that the -qtconf argument passed to qmake points
into the real qmake's parent directory, as is the case in the
abovementioned scenario.
Fixes: QTCREATORBUG-30354
Change-Id: Id6e878fab3379a3a8893389447514a1b7226784c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
We should execute this branch just once, when the server access is
unknown.
Introduce isServerAccessEstablished() helper.
Change-Id: I28953f468be39ca49f088032aebb3fa81b814f3f
Reviewed-by: hjk <hjk@qt.io>
Use Dto::IssueKindMeta::enumToStr() to convert it to string.
Rename icons accordingly.
Change-Id: I8a955f2f0075793eea761cd4a41374a65d2aaea2
Reviewed-by: hjk <hjk@qt.io>
Keep the message, but make it a warning only for the "generic copy"
case, which almost no one ever wants.
Otherwise, it will annoy Windows users, who typically have no rsync
installed.
Change-Id: I2044b9ea2b199e03dc4e9421d05a2698d92ad76a
Reviewed-by: hjk <hjk@qt.io>
The box is visualized with wireframe box, just like setting debug view
property on reflection probe itself would do, only in 3D view the box
is shown when the probe is selected.
For simplicity, the box visualization is only done for single selected
reflection probes.
Task-number: QDS-11964
Change-Id: I1ad645517fa32785e4a5952b13cb3e10eb5f89b9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Make it user @ server.
Change-Id: I62e2c88ade5cc984ba11f718c3db292e4075e5e4
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
* Also, a bug is fixed for reading the quoted texts within CSV rows
Fixes: QDS-11667
Fixes: QDS-11834
Change-Id: I74242148e38c8e71edeb45f3543308259358ee1a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Fixes a crash when log messages are received from
multiple threads.
Fixes: QTCREATORBUG-30444
Change-Id: I51c78656da1dd30bcb51a801083d1714e474d8e5
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
- Show a unique name when the dialog appears
- Unify and simplify the unique name generation methods
- Fix name field left border cut
- Remove warning on dialog open
- Clear lot of clutter
Change-Id: Ie5b9711c704e68bb41c4f7c3ff63091d9bd11175
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
It doesn't take part in format() processing function, so move this
field outside. The format() may be called in separate thread, so,
just for safety, don't keep this field there so that nobody accesses
it from non-main thread.
Remove the c'tor of FormatTask and use list-initialization instead.
Change-Id: I54daf1461243a46bbd7f58c91ba051909b6cf280
Reviewed-by: David Schulz <david.schulz@qt.io>
... following an argument with an array subscript operator.
Fixes: QTCREATORBUG-29225
Change-Id: Iba38043d94be718efee30ce50f5b55aac4ba6ecd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
These are tools of the 3D view and shouldn't be reflected on reflection
probes added to the scene.
Fixes: QDS-11963
Change-Id: I6d32ed737e3801fbab81a746306de571a25ff363
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Qml basic types seem to have "QML." prefixed to the type sometimes,
so check for those as well when determining the metainfo type.
Fixes: QDS-12030
Change-Id: I944f9a247927b952bb76aaa9f5eaa31334cc10c8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
If the horizontal scroll bar is not at position 0 we got the
wrong offset for the position of the column.
Change-Id: Id333584f9d509b67eeef39bc7966f095b577e0fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This is done by the FutureSynchronizer d'tor, so no need to call
it explicitly. Move the FutureSynchronizer as the last field of
ClangModelManagerSupport so that its d'tor is executed first.
Change-Id: Id38b8ec08579be8e4ade99ecadb511850ff37f8c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Amends 6467797af2.
The created extra compilers were parented to their factories, who gained
a life time extension from 'end of plugin live' to static destruction
when the factories were made static. However, this that time the likewise
static QObjectCache in GeneratedCodeModelSupport::update might be
destroyed already, leading to a potential crash in m_cache.remove(dead).
This change here re-establishes the original timing by using the
plugin itself as parent for the extra compilers.
Change-Id: Id868b7b87f00440c67af551b71359c47a5c29cba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>