Commit Graph

72811 Commits

Author SHA1 Message Date
Christian Kandeler
e2c1d12a05 CppEditor: Fix "SelectBlockUp" for string literals
Literal::size() is the number of chars used internally, not necessarily
the number of logical characters.

Fixes: QTCREATORBUG-29844
Change-Id: I74431a2f3f533482567c3774f09deb44dc83d9f0
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-24 12:57:28 +00:00
Christian Kandeler
78329318f3 Update qbs submodule to HEAD of 2.2 branch
Change-Id: I9a816a352917fd411b0fc07d4090be195790b06f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-24 12:25:06 +00:00
Christian Kandeler
462079f806 CppEditor: Fix renaming virtual functions
Before renaming, we first follow the symbol to see whether it originates
from a generated files. We must not try to list the overrides for virtual
member functions in that context.
Amends 06390f5b53.

Change-Id: Ic17e865a03b884d63875622f54448fef63c24b7e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-24 12:24:28 +00:00
Miikka Heikkinen
ac3a4b71e6 EffectMaker: Bake preview shaders using correct version of qsb tool
If the target kit Qt version differs from Qt version that QDS was built
with, there is a chance that shaders baked for the target kit don't
work for rendering preview on QDS side, if QShader version has changed
between the two Qt versions. This means we must bake separate shaders
for the preview and the project to use, each using the correct version
of qsb tool.

Task-number: QDS-11361
Change-Id: I44df2aeb3f4d6aa4b80e3be052d46735d96c53ef
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-11-24 11:47:29 +00:00
Eike Ziller
b2def1b949 QmlDesigner: Hot fix for settings crash
Change-Id: I05d27fb2dee65c50191e7dcd7c7bf8f195bb46e5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-11-24 11:06:16 +00:00
Eike Ziller
2a331567f6 ExtensionSystem: Check for duplicate plugins
If there are multiple plugins with the same name, do not load any of
them, mark them with error.

Fixes: QTCREATORBUG-26221
Change-Id: Id433a66203294b8302294eb09665043452e45ded
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-24 10:54:12 +00:00
hjk
9b2cbe9b71 Android: New setup for AndroidDeviceManager
Also remove the now-unneeded plugin pimpl.

Change-Id: I37eaa91a2756e823d07323b54695e19860cb16ab
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-24 10:26:01 +00:00
hjk
353c3cc930 Android: Use new setup for more plugin items
Change-Id: Id5ff09813ab7b4be425d007abd4cc04d9c9472c1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-24 10:25:51 +00:00
hjk
497b9b3c2c Android: Use new setup for a few factories
Change-Id: I4538a2839b995f7bc245ae1a91f1979cc8c0dfdc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-24 10:20:42 +00:00
Jarek Kobus
0d12bbf432 ProjectExplorer: Remove unused member
Change-Id: Ie7096da33d211f55d3ba37a5b685f5fb8ba89f23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-24 09:28:02 +00:00
Eike Ziller
9698ae50c5 Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/valgrind/xmlprotocol/parser.cpp

Change-Id: I905a5c4f7334f733e99359fbfccd1572b4007696
2023-11-24 10:07:10 +01:00
hjk
b01b44a6b2 ProjectExplorer: Use new setup pattern for msvc based toolchains
ClangCL and MSVC itself.

Change-Id: I500ffdcdb2ef71d14b112466613cdd9cb57dc89c
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-24 08:25:11 +00:00
Eike Ziller
18c2346305 ExtensionSystem: Add plugin details dialog to error dialog
When a plugin fails to load, we show an error dialog with each of the
failed plugins and their error message. Add a button that opens the
plugin details dialog, and also show that on double click on a plugin in
the list.

Refactors opening a modal dialog with the details into its own function.

Change-Id: Id55d0add3682860470ede63b141fbce2e8dab75f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-24 08:15:25 +00:00
Christian Stenger
5841e95123 Valgrind: Fix accessing empty optional
Change-Id: I3d4d8ed9b919a6c0eb8d5530c9d8e2723a8cc1ae
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-24 07:50:28 +00:00
David Schulz
dca3d516b9 ProjectExplorer: expand BuildInfo
Allow defining whether a widget in target setuppage has a build dir
pathchooser and whether it is enabled by default.

Change-Id: I85e9c602b1475c93d39472f2e68a0e4d5ac6e882
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-24 05:35:50 +00:00
Jarek Kobus
712fd89bb9 TaskTree: Fix testInThread(Parallel) test on macOS (second try)
The test was failing on macOS on github.

Change-Id: Ie5fb6aca78b2eac10dc4de988f312065f8ea4a8d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-23 19:08:16 +00:00
Alessandro Portale
d41a99520e Core: Add parameter defaults to constructors
Make Welcome* widgets more standard conformant.

Change-Id: Id098067138e434f99a71add528601c250f78a33d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-23 12:43:54 +00:00
Alessandro Portale
3e2ced7adb Core: Move ResizeSignallingWidget to WelcomePageHelpers
This makes it available to ExtensionManager.

Change-Id: I343c51286215556880838677a87f4df8c65d2308
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-23 12:43:48 +00:00
Aleksei German
71394691b5 QmlDesigner: Fix for MCUs styles combobox
Task-number: QDS-11258
Change-Id: Ib1399e111daf14856e3e679619978180ba7da088
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-23 11:05:51 +00:00
Mahmoud Badri
c14dc9d2ba EffectMaker: Focus view upon open, and correctly open new effects
Also don't open old effect maker when creating a new effect

Fixes: QDS-11359
Fixes: QDS-11364
Change-Id: Ie9659af991f10cafac29dc53cbe7163eb8995b2a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-23 10:36:17 +00:00
Eike Ziller
c77128e698 Merge remote-tracking branch 'origin/12.0'
Change-Id: I7971dd83798e975d4e10b77a352c9d7ef7b14ec0
2023-11-23 10:43:00 +01:00
Orgad Shaneh
0da6fe6890 CppEditor: Pass function by reference
Coverity-Id: 1572606
Change-Id: Ia25fe956ebace7e77412971d7834ce63f236f729
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-23 09:29:40 +00:00
David Schulz
4cc2e60c38 ProjectExplorer: add function to setup a single BuildInfo
Change-Id: I418c7bae6a1519126b75b6ce535379facc332062
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-23 09:19:25 +00:00
hjk
459cdf5f32 Squish: Delay-create SquishTestTreeModel
... by a few lines.

Change-Id: Ida09bd25cee700ab167c6546f9cd6a39b863b592
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-23 06:45:25 +00:00
Christian Stenger
d6de193e5e AutoTest: Remove unused variables
Removes after refactorings now unused local or member.

Change-Id: I56f16cb2058c6d15c3906550480ddcb32ef600c8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-23 05:49:47 +00:00
hjk
6191e24935 Beautifier: Dissolve plugin pimpl
Change-Id: I00a5b92578e57c64da535af908bb661cdd901e8c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 17:04:40 +00:00
hjk
8ceaa67ea8 Beautifier: New setup also for ClangFormat and Uncrustify
Change-Id: I338e8947c09219f6a35d1361f2e10f8264b37ad3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 17:04:33 +00:00
hjk
27d265137f Beautifier: Move ArtisticStyle to new setup scheme
Change-Id: I186fcbff69976f980c43d8bc887b5f76fb7f4916
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 17:04:24 +00:00
Jarek Kobus
229c23ce39 TaskTree: Add docs for Storage element
Change-Id: I4faa691a8f6ad7f358a508ba25b60d1ea7476afd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-11-22 16:27:01 +00:00
hjk
ef717b9f22 Squish: Use ActionBuilder
Change-Id: Ie193b82cffa1e7bd0ddb45d11885212e1f119f65
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-22 15:37:38 +00:00
hjk
5733014ceb Squish: Re-organize wizard page setup
Move things to new setup, inline stuff, code cosmetics.

Change-Id: Ib521d93983d1cce3d8f52d49f1cd4e0fa64a622b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-22 15:37:20 +00:00
Cristian Adam
554bb75ad9 Debugger: Fix assert when starting local debug
When starting a local debugging session and the terminal is not used, no
reason to assert that the remote pid is not valid etc.

Change-Id: I1b62a98721425784ca80ce9261b07475c19f3ba1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-22 14:57:55 +00:00
Christian Kandeler
240748c106 TextEditor: Get rid of extra indent ranges in RefactoringFile
Having extra indent regions complicates the interface, the
implementation and the calling code.
Instead, derive the indent regions from the change set and let callers
opt out for the relatively few cases where indentation is not desired.

Change-Id: I49d2854830a51778534ef260fb5c9f2c7685554a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-22 13:47:16 +00:00
David Schulz
2bd02671d8 ProjectExplorer: allow defining additional data in BuildTargetInfo
Change-Id: I14987e4d56424628828feeeeadfac2c4b28468c8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-22 13:44:14 +00:00
hjk
d597189902 Revert "PerfProfiler: Use new setup for PerfRunConfigurationAspect"
This reverts commit b49f847576.

The class access is used in perfprofilerruncontrol.cpp.

Change-Id: I1c0d9d1230224f04d39e71706064fd09b4071954
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 13:29:34 +00:00
Jarek Kobus
a56ed10c53 TaskTree: Add docs for List element
Change-Id: Iba859b1a1ff424f55d3fe0c7785de61c36d1418f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-11-22 13:27:52 +00:00
hjk
bf373f7e41 ProjectExplorer: Use new setup pattern for gcc related toolchains
Change-Id: I8b00f126a0824e5ec3b2ef3e63fdef41cd8917a1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-22 13:26:32 +00:00
Jarek Kobus
8f0dc9d531 TaskTree: Update docs for Storage renamings
This addresses the 20th point in the master task below.

Task-number: QTCREATORBUG-28741
Change-Id: I7c6d1d6069b10a2afbfc6569f27b48929a417fb1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-11-22 13:06:50 +00:00
Christian Stenger
8a2ea1f63b PE: Fix determining whether to use file missing overlay
Amends d92043e69c.

Change-Id: I2d71c06fcce1b469b5dedd799a50c4dde19ab341
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-22 12:29:55 +00:00
hjk
b49f847576 PerfProfiler: Use new setup for PerfRunConfigurationAspect
Change-Id: Ib249fecdaeeec8c6fa3c24ae02563023ab7c749b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 12:29:32 +00:00
hjk
c11e1002b9 PerfProfiler: Use new setup for PerfProfilerTool and the plugin itself
Change-Id: I6f732c631b7ad5edeb34961ff90d9db40fbd49c4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 12:29:18 +00:00
hjk
209c386e60 QmlProfiler: Dissolve plugin pimpl
... by using the new setup for QmlProfilerTool.

Also, move the class definition to the .cpp.

Change-Id: I3bc93f4960823914da9820fb2cb18de44f1c60c2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 11:27:00 +00:00
Christian Kandeler
db71c461de TextEditor: Remove unneeded RefactoringFile::setFilePath()
Change-Id: Ia44642191259b83539c093d04921317b6155fdee
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-22 09:39:04 +00:00
hjk
27084b1884 ScxmlEditor: Rename scxmleditorfactory.h and scxmleditordata.cpp
... to scxmleditor.h and scxmleditor.cpp so it looks like a normal
file pair again.

Change-Id: I5be9d78cf39cba2a04525aca79e36b8283f08870
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 08:25:58 +00:00
hjk
69b96ff7d2 ScxmlEditor: Merge editor factory and data files
Currently scxmleditordata.cpp and scxmleditorfactory.h are used to
keep the diff small, these will be renamed immediately.

Change-Id: I4d4878b7eb2f52fb5f326bde33badd7e31305336
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 08:25:48 +00:00
hjk
db301c1bce ScxmlEditor: Use new setup for ScxmlEditorFactory
Change-Id: Iabb25fb8b6cf774631eb5b910532b892321e3cea
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-22 08:25:34 +00:00
Eike Ziller
36d00b8a55 FakeVim: Test build without tests
Undefined symbols: FakeVim::Internal::createFakeVimTester

Change-Id: I2acaeaeb6a3be84ecc95415cd6f20296c4913786
Reviewed-by: hjk <hjk@qt.io>
2023-11-22 07:43:23 +00:00
hjk
eb08ae9145 GenericProject: Dissolve plugin pimpl
Not needed anymore.

Change-Id: Ic14c4f2d5c8d34919665631272a4efd281899fc9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-22 07:27:42 +00:00
hjk
70d3c5b20b RemoteLinux: Move plugin class definition to .cpp
Change-Id: Iab0b0fc2d4d649486a3aa93594236e91d8144bb3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-22 07:21:48 +00:00
hjk
a3525a3d67 RemoteLinux: Move some deploment related stuff into extra file pair
Not necessary, but more uniform now.

Change-Id: I11d13958c554d2d647c0910a6c6dbd4cca781bf2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-22 07:21:38 +00:00