Literal::size() is the number of chars used internally, not necessarily
the number of logical characters.
Fixes: QTCREATORBUG-29844
Change-Id: I74431a2f3f533482567c3774f09deb44dc83d9f0
Reviewed-by: David Schulz <david.schulz@qt.io>
Before renaming, we first follow the symbol to see whether it originates
from a generated files. We must not try to list the overrides for virtual
member functions in that context.
Amends 06390f5b53.
Change-Id: Ic17e865a03b884d63875622f54448fef63c24b7e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If the target kit Qt version differs from Qt version that QDS was built
with, there is a chance that shaders baked for the target kit don't
work for rendering preview on QDS side, if QShader version has changed
between the two Qt versions. This means we must bake separate shaders
for the preview and the project to use, each using the correct version
of qsb tool.
Task-number: QDS-11361
Change-Id: I44df2aeb3f4d6aa4b80e3be052d46735d96c53ef
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
When a plugin fails to load, we show an error dialog with each of the
failed plugins and their error message. Add a button that opens the
plugin details dialog, and also show that on double click on a plugin in
the list.
Refactors opening a modal dialog with the details into its own function.
Change-Id: Id55d0add3682860470ede63b141fbce2e8dab75f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Allow defining whether a widget in target setuppage has a build dir
pathchooser and whether it is enabled by default.
Change-Id: I85e9c602b1475c93d39472f2e68a0e4d5ac6e882
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Also don't open old effect maker when creating a new effect
Fixes: QDS-11359
Fixes: QDS-11364
Change-Id: Ie9659af991f10cafac29dc53cbe7163eb8995b2a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Removes after refactorings now unused local or member.
Change-Id: I56f16cb2058c6d15c3906550480ddcb32ef600c8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Move things to new setup, inline stuff, code cosmetics.
Change-Id: Ib521d93983d1cce3d8f52d49f1cd4e0fa64a622b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
When starting a local debugging session and the terminal is not used, no
reason to assert that the remote pid is not valid etc.
Change-Id: I1b62a98721425784ca80ce9261b07475c19f3ba1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Having extra indent regions complicates the interface, the
implementation and the calling code.
Instead, derive the indent regions from the change set and let callers
opt out for the relatively few cases where indentation is not desired.
Change-Id: I49d2854830a51778534ef260fb5c9f2c7685554a
Reviewed-by: David Schulz <david.schulz@qt.io>
This reverts commit b49f847576.
The class access is used in perfprofilerruncontrol.cpp.
Change-Id: I1c0d9d1230224f04d39e71706064fd09b4071954
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This addresses the 20th point in the master task below.
Task-number: QTCREATORBUG-28741
Change-Id: I7c6d1d6069b10a2afbfc6569f27b48929a417fb1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
... by using the new setup for QmlProfilerTool.
Also, move the class definition to the .cpp.
Change-Id: I3bc93f4960823914da9820fb2cb18de44f1c60c2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Currently scxmleditordata.cpp and scxmleditorfactory.h are used to
keep the diff small, these will be renamed immediately.
Change-Id: I4d4878b7eb2f52fb5f326bde33badd7e31305336
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>