Commit Graph

72811 Commits

Author SHA1 Message Date
Alessandro Portale
fd1956a91c QmakeProjectManager: Remove unused functions
These project wizard related functions are unused remnants from when a
couple of wizards were still implemented in C++. The wizards have since
been reimplemented as .json wizards.

Change-Id: I4cef7ef26cb66e86ef968645c68f3234d4dc15b6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 10:04:11 +00:00
Amr Essam
0cbda147a8 QmlDesigner: Export effect maker composition qep project into assets
Meanwhile, composition resources are not yet exported

Task-number: QDS-10500
Change-Id: I3687d1d62a64472c7ec84716c584dced5fbb6a85
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-09 10:02:19 +00:00
The Qt Project
841d9d739e Merge "Merge remote-tracking branch 'origin/12.0' into qds/dev" into qds/dev 2023-11-09 09:24:26 +00:00
Thomas Hartmann
070022e9e2 TextEditor: Allow to programmatically highlight a block by cursor
This can be used in QmlDesigner to highlight the currently selected
QML object.

Change-Id: I9907d54f767c7d034739d4111a46cd994c961426
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-09 08:53:25 +00:00
Tim Jenßen
058fd820e5 Merge remote-tracking branch 'origin/12.0' into qds/dev
Change-Id: I1e38a9dc4402a4cf836c32a6b0e5f49a836574b7
2023-11-09 08:46:51 +00:00
Thomas Hartmann
ad49605ea9 QmlDesigner: Highlight selected node in code editor
We also highlight the drag target when using drag and drop.

Task-number: QDS-10869
Change-Id: Ic396848f93deaa3cce899c2cf431d5a7f5a940f5
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-11-09 08:46:33 +00:00
hjk
792d88aa05 Core: Introduce Menu and Action classes
Idea is to have a bit more "object { propertySetter }" kind of pattern
for common cases and to couple actions and menus only via Ids, not
real objects.

In a LayoutBuilder context this might later look like

    Menu {
        id(BOOKMARKS_MENU),
        title(Tr::tr("&Bookmarks")),
        container(Core::Constants::M_TOOLS)
    }

in the end.

Overall line count increases but I claim it reduces complexity on the
user code side.

Change-Id: I166e0c8c6b3036430dc464fd652fb37ded21c09a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-09 08:00:37 +00:00
Christian Stenger
e5c4d20e2b LanguageClient: Reset maximum restart tries on explicit restart
If the user forces the language client to restart for whatever reason
the client may end up in not starting anymore depending on the
number of restarts that had been done already.
So, explicitly reset the counter in case the user triggers the
restart.

Change-Id: Ie5f33c8dc3d565b6126badc9708906fc14f4e743
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-09 07:58:13 +00:00
hjk
05e7308c08 ProjectExplorer: Use more Ids instead of Kit in KitModel
The idea is to slowly move towards a uniform approach to handle the
Kits/Qt Version/Debugger/Toolchain/... managers/settings.

Change-Id: I6ddba968a51d9468bb0dfec74b2fb8b902d11294
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-09 07:55:28 +00:00
Eike Ziller
7bd99104e0 Merge remote-tracking branch 'origin/12.0'
Change-Id: I2594f193260a103e1c4484fcab974213c881353d
2023-11-09 08:22:27 +01:00
Christian Stenger
4436e96f91 Debugger: Fix compile with Qt6.2
Amends 43f99cb53b.

Change-Id: Ia28b129f761e8cfe6dd3a908ccfcf50d043d1639
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-09 07:16:08 +00:00
Marcus Tillmanns
6e1d7fc961 CompilerExplorer: Fix crash on undo
We need to store the source text document so that when the editor
is remove and the user triggers undo/read, the pointer is still valid.

Change-Id: I571906db1c4424455172a42d72351cd9ba1e7c03
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-09 05:55:08 +00:00
Marcus Tillmanns
e4805b88c9 CMakePM: Use FilePath::fromUserInput
Change-Id: I748fc41ed380c907b6edcca3a1802a47f9f74436
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-09 05:53:36 +00:00
Jarek Kobus
9a8531c22f DockFocusController: Avoid using sender() in onFocusedDockAreaViewToggled
Since m_focusedArea is always a sender of the signal connected to the
onFocusedDockAreaViewToggled() slot, reuse it in place of sender().

Change-Id: I17b817132c8b74e825f0accb9c1d467bfdf24ac3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-08 17:03:41 +00:00
Jarek Kobus
611bef47ce DockFocusController: Avoid using sender() for visibilityChanged()
Use Qt::SingleShotConnection connection instead and remove
disconnect.

Change-Id: If3ec082bb2341277bfeb781b13986492a88172e6
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-08 17:03:30 +00:00
Jarek Kobus
b75df9eb83 AdvancedDockingSystem: Avoid using sender()
Change-Id: Iabc97c99046e1ebabddf988c675a51a93875ddf5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-11-08 17:03:22 +00:00
Thomas Hartmann
036963de02 QmlDesigner: Add signals of dynamic properties
We have to take into account that signal themselves
are considered dynamic properties, but do not require
the changed suffix.

Task-number: QDS-10977
Change-Id: I6af83586eee1b8f37e0510839baecee42972494c
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-08 15:44:40 +00:00
Mahmoud Badri
d9ab8e8bef QmlDesigner: Update light baking and effect maker pause icons
Also hide the code icon from effect maker

Change-Id: I1045a0718b5b86ef13164e215e5f0f1420487497
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
2023-11-08 14:53:15 +00:00
Alessandro Portale
76dbc9e42b Utils: Remove handling of macOS < 10.14 in theme_mac.mm
Qt Creator should only be built and be running on macOS 10.14 or later.

This cleanup is in preparation for other following changes.

Task-number: QTCREATORBUG-29783
Change-Id: Idd549051b899726f2db8fed320a2ef15e948d2d7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-08 14:44:56 +00:00
Mahmoud Badri
514b070a4c QmlDesigner: Update icon font
Added icons:
addGroup_medium.svg
assignTo.svg
bakeLights_medium.svg
listView_medium.svg
pause_medium.svg
tableView_medium.svg
warning_medium.svg

Change-Id: I17c39fdd771e3391ae6a37f171223fdea0e773fe
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-08 13:48:40 +00:00
Jarek Kobus
79421fd597 TaskTree: Rename StopOnFinished into StopOnSuccessOrError
In order to conform to CallDoneIf::SuccessOrError.

Amends 2c0a59384c

Change-Id: I2704667ca8d005c63c13b62786010ce430f0b550
Reviewed-by: hjk <hjk@qt.io>
2023-11-08 13:04:36 +00:00
Knud Dollereder
578b66727a QmlProject: Add QML_IMPORT_PATH to the main cmakegen template
Change-Id: Idd55f372701c76f43869abfc3b493247e06ce8f5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-08 12:53:16 +00:00
Thomas Hartmann
1b27dd383f QmlDesigner: Allow dropping components and assets to text editor
Task-number: QDS-10868
Change-Id: I8037fd0fdd6060bbf84f0b24a52f18304380dcd2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-08 12:48:03 +00:00
hjk
16233c51cd ProjectExplorer: Don't internally chain KitManager signal emission
Rather, emit directly in sequence. Saves a few cycles in the
signal/slot machinery simplifies reasoning on the user side
which signals to expect.

Change-Id: Ib75f47a73e9731b506b9df3c713684a9cf59aa67
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-08 12:42:17 +00:00
Christian Kandeler
e48d365b19 ProjectExplorer: Normalize separators on HeaderPath construction
Fixes a Windows test failure in CompilationDatabaseProjectManager.

Change-Id: Ic373b7a50b1374be4cf028fc304442c3cf077735
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-08 12:27:57 +00:00
hjk
e2cc01d213 ProjectExplorer: Remove unused code from KitAreaWidget
Change-Id: Ic90d820f51a785967ba2d7a176ec14430119285b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-08 12:10:46 +00:00
Eike Ziller
ae2d429edb ClangTools: Use "Diagnostics" as view title
The tool is already shown in the perspective selector, and the view
shows the found diagnostics.

Change-Id: I0c9f7e1aa21801c176623ecb751412637ff6c025
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-08 11:49:18 +00:00
hjk
b8c7186a36 Core: Simplify system env setup code a bit
Change-Id: Ic25c4b1e9371f9c46a2d95a243964f0a3ef1f878
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-08 11:32:36 +00:00
Semih Yavuz
ffcbbecf27 reformatter: Do not remove type annotations
Type annotations were being removed by the reformat action. Write out
the relavant annotations in ast to fix it.

Add exclusion mechanism in tst_qml_reformatter test since it performs
line by line comparison which doesn't fit all reformatting cases.
Introduce char-by-char data tests.

Fixes: QTCREATORBUG-29061
Change-Id: Ia52b51e6d7d938bdec325c4f426b11c722f85f8e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-11-08 11:09:02 +00:00
hjk
6685f0255d Utils/all: Move mime constants into a central place
They are reasonably standardized, and generally usable cross-plugin,
so this can help to avoid a few cross-plugin compiletime dependencies.

Change-Id: Icb2b010c3e12dee69df54ab16f6f8e90d9cffba6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-08 09:59:26 +00:00
Christian Kandeler
df360704f0 ClangTools: Suppress bogus clazy warning about #pragma once
We don't pass the correct value "c++header" to the -x option, because to
clang that implies building a precompiled header, which apparently
switches on some different mode that breaks clang-tidy and clazy.
On the other hand, with "-x c++" clazy now thinks that this is a source
file and frowns at "#pragma once". Suppress this warning for header files.
Amends 60fca0596a.
We might run into similar "header vs source" problems in the future. I
don't see anything better than suppressing them one by one.

Fixes: QTCREATORBUG-29781
Change-Id: Ia15ac5b278777e2b2e089e9d58bb7537c38955ce
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-08 09:52:29 +00:00
hjk
fc7c11fb65 ProjectExplorer: Consolidate creation of KitAspect's "Manage..."
Change-Id: I001a21f41bcd5ff0614bdf98893b56137c06546f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-08 09:52:26 +00:00
Christian Stenger
210907529f QtSupport: Fix order of setEnabler / readSettings
Silences a soft assert.

Change-Id: Ibd32f2efe75f610bf7e8f6a33a7a84a8da9f7019
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-08 09:13:15 +00:00
Thomas Hartmann
aab09423e4 QmlDesigner: Add more properties for ordering in code
Change-Id: Ie7d65520e273c02b331531c64d666e95bedaa9bd
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2023-11-08 09:12:41 +00:00
Samuli Piippo
2eb73350ab boot2qt: always use GenericUpload
GenericUpload knows if sftp or rsync can be used.

Change-Id: I6f6d478f2da9659777cc5046b4425ae025fdca0a
Reviewed-by: hjk <hjk@qt.io>
2023-11-08 09:08:51 +00:00
The Qt Project
04eea22c5f Merge "Merge remote-tracking branch 'origin/12.0'" 2023-11-08 09:08:31 +00:00
Eike Ziller
363d2d161c Merge remote-tracking branch 'origin/12.0'
Change-Id: I35cb28b759fb200c45a1496299584132336fcd1c
2023-11-08 10:07:29 +01:00
Jarek Kobus
c25a7a0381 TaskTree: Address some code style issues
Amends af63dcaf96

Change-Id: I9c727751afe306be5da36e772201eff1f36ac18a
Reviewed-by: hjk <hjk@qt.io>
2023-11-08 08:30:31 +00:00
Jarek Kobus
1f660c9afd TaskTree: Add more description for the ProcessReaper
Amends 65341d7e5f

Change-Id: Ia74a77a21080d55688ff0fed5a4ea8b02b963bf7
Reviewed-by: hjk <hjk@qt.io>
2023-11-08 08:30:23 +00:00
Eike Ziller
05ef0d9cb9 Fix crash in QmlOutline related to QmlDesigner
This is a workaround for the ugly hack that QmlDesigner forces the
EditorManager to send a currentEditorChanged signal with QmlDesigner's
custom, internal IEditor.

The currentEditorChanged signal triggered an update/re-creation of the
outline widget *for that editor*. Which is not the intended result in
the first place, but even aggrevated by the fact that QmlDesigner never
calls currentEditorChanged with the actual
EditorManager::currentEditor() again.

Work around that by only ever using the EditorManager::currentEditor()
for the outline widget.

Fixes: QTCREATORBUG-29653
Fixes: QTCREATORBUG-29702
Change-Id: I39c5bee94141a0d86c0e92879eb8b1c2b7ba64b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-08 08:03:10 +00:00
hjk
baaf00d43f Core: Re-order EditorView functions a bit
More canonical.

Also remove two unused slots markers plus a bit code cosmetics.

Change-Id: I4015ffecc5cb2f7d0bb7d8e35c4a59c425a42a6d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-08 07:12:40 +00:00
Cristian Adam
79f07f9d4c VcsBase: Add Qt Jira and Gerrit URLs support
This way one can simply click on the url in git log.

Change-Id: I91abda71a48f079e554a48a70a0f05e8417731ed
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-11-07 20:56:06 +00:00
hjk
bad0601166 ProjectExplorer: De-Q_OBJECT-ify DeviceManagerModel
The provided features are not used (anymore?).

Change-Id: I79a170082bdfce9290a623fd26573a600a3f2c22
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-07 16:27:17 +00:00
hjk
64b6f0f02b ProjectExplorer: Hide GccToolChain::WarningFlagAdder declaration
It's only used in the .cpp.

Change-Id: Ib9ce5ca49dfe2440d553c98cf688dcd6d31ac084
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-07 16:22:20 +00:00
David Schulz
4a081cb386 TextEditor: remove texteditor_p.h
There is no need to have an extra file for one struct that is only used
inside texteditor.cpp

Change-Id: Iee8f7ce5e0d19da7b444660d81c350eb10b501ef
Reviewed-by: hjk <hjk@qt.io>
2023-11-07 15:24:57 +00:00
Daniel Trevitz
c83a0be72d Only download from remote when we absolutely have to
If the kit includes a correctly configured sysroot gdbserver will tell
us our hostPath. Respect that hostPath if it exists, otherwise fall back
to remote debug.

Also, populate the hostPath with the symbol file from the run
parameters.

Task-number: QTCREATORBUG-29614
Change-Id: I3838cd44aa96d7dfcd4ded660b8102a1532c5362
Reviewed-by: hjk <hjk@qt.io>
2023-11-07 15:23:06 +00:00
Marcus Tillmanns
772546453a Utils: Warn if enabler is set before readSettings
Change-Id: If3dd3fc5adbcd73a87f8e57482c7497c3cd11da2
Reviewed-by: hjk <hjk@qt.io>
2023-11-07 14:35:26 +00:00
Artem Sokolovskii
72fb52f767 DAP: Move acceptsBreakpoint to mime type
Change-Id: I3234e7981202c7d668b8c3c86c818ca47f7be589
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-07 14:35:05 +00:00
Artem Sokolovskii
3bf61cc36c DAP: Move to a unified way to handle breakpoints
Rely on SetBreakpoints response instead of breakpoint event.

Change-Id: Iff052a13c442fb1fcd945cf1a80f1354c43c15c5
Reviewed-by: hjk <hjk@qt.io>
2023-11-07 14:34:56 +00:00
Artem Sokolovskii
55227ba829 DAP: Make dap engine less noisy
Change-Id: I97d804511b07640e87045f2007575fb6543bb5be
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-11-07 14:32:43 +00:00