... without a space before the identifier.
Change-Id: I977ffae82eb86f5ae6ea594cba17cc486e63bf6c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Saving the source context id as part of the source id simplyfies file
path handling. It is now very easy to see if a two source ids have the
same source context id.
Change-Id: I6c86942d9f026fc047c49bbde3fffd6af14d81de
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
It also can be overwritten by option:
IS_SUPPORTED_PROJECTSTORAGE_QT
or environment variable:
QTC_IS_SUPPORTED_PROJECTSTORAGE_QT
Change-Id: Iabc7d59ff100017811167a6ec4e7447ccc3e55ee
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Project type traits are increasing the code complexity in the updater by
quite lot. The discover can be done in an other way too.
Change-Id: Ied9b7df445e854c76243ece6666690ea10b8d33d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
It makes it easier to add new arguments without breaking the tests.
Change-Id: Id03053ac17e4da26a2abf2a23e6cc20848ed9af5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
A file component is always of the reference kind. Sets the file
component trait too.
Task-number: QDS-12665
Change-Id: I800b32a4d204fb016c1274d05c08695b01581ae4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Setup code should not be in the act region. It makes it not only harder
to read what is tested, but debugging too.
Change-Id: Id93300e7b9ab3ee63a1fcf10c0d462b0c4ff7b47
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If `minQtVersion` exists for a material in material_bundle.json file,
and kit version is less than `minQtVersion`, the material should be
skipped.
Version class has improved and moved to QmlDesignerUtils.
Task-number: QDS-13274
Change-Id: I726c1765c69e5b080650099d0b811a90cfc3ccf5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
It has some platform specific warts, filepath.h is somewhat
cheaper and less ugly overall.
Partially clean up surroundings
Change-Id: Ida1fd470ec020f69c446109427f92a08e879789f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
See the CMake documentation https://cmake.org/cmake/help/latest/
prop_tgt/FOLDER.html
This allows placement of targets in the project view in specific folders
like e.g. "tests"
Qt Creator (ab)uses the FOLDER property for the "qtc_runnable" feature,
see https://doc.qt.io/qtcreator/creator-run-settings.html
which would not allow to have both.
The "qtc_runnable" should be fixed by having a property "QTC_RUNNABLE"
for a target and have Qt Creator parse the code.
Fixes: QTCREATORBUG-28873
Change-Id: I73433de78b9a86f631ee9d7903db535b69b734f6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
1. Instead of a single action, a menu is shown. This menu contains all
of the materials of the selected node.
2. If multiple nodes are selected, the intersection of the materials is
shown.
3. Having several identical materials in a nodes are supported.
4. For each material, there are two options
* Remove (Removes the material from the selected nodes)
* Edit (Opens the material editor for the selected material)
Task-number: QDS-12375
Change-Id: Icc19a4127dc490490e4464ce840e89e5379c5e8c
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
To decouple the string implementation from the internal string. It
should lead to much less allocations too after the rest of the code is
converted too.
Change-Id: Ifb49f57b9e5ac5af4963e1257c535ddef6044d93
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
On Linux, Creator only considers files with the exact extension ".qml"
QML files and places them under a "QML" node in the project tree. On
Mac and Windows, Creator also places files with extension ".QML" there.
Change-Id: Id81989e867fa946081ea7a350b208ddfe09e5460
Reviewed-by: Jukka Nokso <jukka.nokso@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
When qmake is not present in PATH or not usable, Creator does not add
a Qt version and does not write qtversion.xml. Expect this behavior
in the test.
Change-Id: I0890b9a22bdec47c0ac7206ba0a83d1e3ded2bb3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...so we don't accidentally use a wrong one.
Change-Id: I4c08e11aab34b8649f40ba14385492b17e656385
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The switch to cmake broke this test completely as qmake handles
changes to ui files differently.
Changing a ui file needs re-execution of moc which is not done
automatically for cmake except when building.
Beside this the cmake project manager seems to inform the code
model about respective changes significantly later, if at all.
So, we explicitly trigger a build now after changing the ui file
and explicitly ensure the code model treats the file correctly
by closing and re-opening it.
Change-Id: Icb9cfb572c1442eff1bebc9c29fdee55155ca287
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
The old MinGW can't compile the used project anymore.
Even configuring already fails. Testing compatibility
with old Qt versions and compilers isn't the purpose
of this test, so it can simply move to newer ones.
Change-Id: Ie21a5a726c33b4073f2aa4d955e2e5ea943bf9bc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Alias properties are quite often broken. So we have to handle that
broken aliases.
Task-number: QDS-12761
Change-Id: Id9b53b98080733e5939de6b3761c923fa35e1dcf
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Ensure the For loop iterates even when the loop's body is empty.
Simplify internals a bit.
Change-Id: I4a269d61fa324a9c36109e95e74a992e915a72b0
Reviewed-by: hjk <hjk@qt.io>
Improve code readability by requiring iteratable Group
to be named For.
The For's c'tor requires an iterator element as a first arg.
The For's c'tor allows for passing exactly one iterator element.
It's not possible to place iterators inside Group element anymore.
Change-Id: I9dfe2c0da058abac161f66c4e336da2417c383f1
Reviewed-by: hjk <hjk@qt.io>
We can polish it later. But so far the architecture works and the
problematics cases of missing types is handled.
Task-number: QDS-12761
Change-Id: Ifb55a5772fddfa7719a4d690b24b0539679f79ec
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
References into vectors are instable because the vector can be
reallocated. std::list \provides stable references to entries. In the
future std::inline_vector is maybe a better option.
Change-Id: I76ac3005259ef9d09f3b8c226dbfd48433aa48b9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Clean it up before more files are added to it.
Change-Id: I58c531a80718d99d05dc444974e1a4236da8c6cb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
They are useful in conditional statements to influence
the workflow of a group.
Add tests for nullItem, successItem and errorItem.
Fix some comments in tests.
Change-Id: If0faa579e256d5a943d22cf66fe5208d60a63e0d
Reviewed-by: hjk <hjk@qt.io>
