Since we now use PropertyNameView, we can remove this workaround.
Change-Id: Id7c46857ee60579f8b27e8e4cbc4d189dc928bd0
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
They were internally stored as QWidget anyway and only used as
IOptionsPageWidget after qobject_cast, with a sane default
implementation if they are not.
Change-Id: I98c73fb1221ba6f05e52d9f79ccd0f4c2fc7fa69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
QPrinter does not do anything strange in the destructor,
so the change in lifetime is harmless.
Change-Id: Iaa255c8809e977dc480b3e23810f3c11b99fad28
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It's now all in the .cpp.
Also, make all the global statics members of MimeSettings, which is
a singleton anyway, and de-indirect the models which have identical
lifetime.
Change-Id: I0e9b485804e569b95526d1610821cd9c12dd1322
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The initialization/setup/... methods are typically called 'setupX...'
nowadays.
Change-Id: Iecdca160a54f60fbeb3dbffcc6d7aca20bc68682
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It has some platform specific warts, filepath.h is somewhat
cheaper and less ugly overall.
Partially clean up surroundings
Change-Id: Ida1fd470ec020f69c446109427f92a08e879789f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Since this means that StringBuilder expressions are not usable
as arguments anymore, use .withSuffix() more extensively.
This makes this "unusual" construction also a bit better findable.
No measurable performance gain or loss in either direction.
Change-Id: I04508e77764455bd9d3a21eda63bc6de01508e4b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Do not show the "commit message is short" text while
the user is still typing the first words.
Therefore, make the initial timeout larger and restart
the timer whenever the submit message changes.
After the minimal subject length or a newline is entered,
switch to faster evaluation.
Change-Id: I41034ed2c8e71e81dae42685bc9ff310edca2543
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If there is just a spelling error in the source text that can be fixed
without changing the text's semantics, we can do that after string
freeze without interfering with the work of translators that might
already have run lupdate and started translating, by adding an english
translation file.
This should never be used to fix the meaning of the string in any way,
and should be dissolved into the tr() calls (+ fixing source tags in
translations) before the next string freeze.
Change-Id: If72505b0ca22c35ef41c0cfabed669a800315f20
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Use the QFontMetricsF constructor instead.
(Which I hope this change does as requested by the warning)
Change-Id: I89992715f5cc0a2e1b5e98498c2cc36bb705b187
Reviewed-by: hjk <hjk@qt.io>
See the CMake documentation https://cmake.org/cmake/help/latest/
prop_tgt/FOLDER.html
This allows placement of targets in the project view in specific folders
like e.g. "tests"
Qt Creator (ab)uses the FOLDER property for the "qtc_runnable" feature,
see https://doc.qt.io/qtcreator/creator-run-settings.html
which would not allow to have both.
The "qtc_runnable" should be fixed by having a property "QTC_RUNNABLE"
for a target and have Qt Creator parse the code.
Fixes: QTCREATORBUG-28873
Change-Id: I73433de78b9a86f631ee9d7903db535b69b734f6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
