feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
37,770 Commits 108 Branches 368 Tags
b01a6a4663489bf7f4fe0842a492e452204de564
Commit Graph

15 Commits

Author SHA1 Message Date
hjk
a59fdc8096 TextEditor: Fix crash due to setting up fall back editor twice 
Change-Id: Id1287a1b1b33924c490b664d81c661b1481a3e4f
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
 2014-09-01 11:33:34 +02:00
hjk
ec5ea375e0 TextEditor: Use more direct approach for fallback IEditor construction 
There are still a few places where the EditorWidget is the primary
object, or several of them per "visible" IEditor (e.g. Diff).
Provide a means to streamline setup there, too.

Change-Id: I14cfbd68e555ebc539e707032a0e5bef563e0a36
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
 2014-08-29 15:51:09 +02:00
hjk
761f8de751 TextEditor: Fix regression introduced by recent c094592f8a 
Change-Id: I9fe2bc726454c8c44f59bf4c720a11765d1bb744
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
 2014-08-28 17:36:25 +02:00
hjk
c5fae0e8da TextEditor: Further *Editor/*EditorWidget disentangling 
In most cases, the *Editor constructor does not need to
access the *EditorWidget.

Change-Id: I1f5c076a0f723d5d82b398e8c250c7bd1d47eb17
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
 2014-08-19 10:32:12 +02:00
Eike Ziller
d9d0aba1c4 Merge remote-tracking branch 'origin/3.2' 
Conflicts:
	qtcreator.pri
	qtcreator.qbs
	src/plugins/coreplugin/editormanager/editormanager.cpp
	src/plugins/projectexplorer/editorconfiguration.cpp
	src/plugins/projectexplorer/projectfilewizardextension.cpp
	src/plugins/qmakeandroidsupport/createandroidmanifestwizard.cpp

Change-Id: I8de0f6fcdd8d214fbc14e79f74cb0206e6e2c6c1
 2014-08-15 16:14:34 +02:00
jkobus
45dc2e2a73 Show the chunk context info in unified diff 
Task-number: QTCREATORBUG-12394
Change-Id: I827fb894fd373b34cbae19f686b15acb697489c3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2014-08-14 20:10:47 +02:00
jkobus
87b5db5562 Save / restore state in diff editor when reloading 
Task-number: QTCREATORBUG-12650
Change-Id: I0bb25ed39f8a15dd5da798ebf0ce72898a2e3b3d
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
 2014-08-13 15:44:36 +02:00
hjk
d7c2b0b681 TextEditor: Consolidate document access functions. 
There was document(), textDocument() and baseTextDocument().
Two should be enough...

Change-Id: Id9e41c8d857c5cb3269a9fce5ab594d34448c982
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
 2014-08-04 10:43:56 +02:00
jkobus
c9c4f05fee Fix newline handling in diff editor 
Task-number: QTCREATORBUG-12618
Change-Id: If2a30ff4efdc106f43e2ea77d2783ea797e92722
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2014-07-09 16:19:51 +02:00
jkobus
f07cb7ae3a Fix double click on removed lines in unifieddiffeditor 
Task-number: QTCREATORBUG-12493
Change-Id: I31c63cfb5f05e73595fc42eef258998e2783697a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2014-07-04 14:16:21 +02:00
Erik Verbruggen
87fa7b77dd Remove unused variables. 
These produce warnings with -Wunused-const-variable.

Change-Id: I897446cfd019c5328e3b1962f16a2190af37959d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>
 2014-06-27 11:25:19 +02:00
hjk
62a870a14f TextEditor: Simplify HighlighterFactory hierarchy 
Change-Id: I555639a9137dcb8ccb471e1615823870c8158b3c
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
 2014-06-26 15:54:12 +02:00
Orgad Shaneh
6c921090bf DiffEditor: Avoid "jump to file" for directories and nonexistent files 
Submodule diff sample (sub is the submodule's root directory):

diff --git a/sub b/sub
index 6ae5025..4b26500 160000
--- a/sub
+++ b/sub
@@ -1 +1 @@
-Subproject commit 6ae5025c9a66767e90cd320f9661e7694f7ea8b5
+Subproject commit 4b2650066d4143e8b7a9f4b19e46b96996a1dd90

Change-Id: I388de5bc50ceb1fcfc31a3a70ce8328c83fafa71
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>
 2014-06-23 16:35:41 +02:00
jkobus
dcedc45474 Compile fix 
Change-Id: I0b586bd1b024c3d1f0eaebfc057e85fbedfe72cd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
 2014-06-06 14:43:58 +02:00
jkobus
8cad94534f Implement unified diff editor 
Change-Id: I93e0bfd71a8a650afbe2ca9e0f1f3dbfc9d57db0
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>
 2014-06-06 12:33:59 +02:00