Use the new page in favor of the CheckoutProgressWizardPage.
Change-Id: I7801c146fa67d6fcf550616f3798a7a919aafb96
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
On MSYS2, if QtCreator is launched from one of the msys2 shells
then the MSYSTEM env. var is set and our Pythons set os.sep and
os.path.sep to '/' so that it aligns with the default separator
of those shells.
fromNativePath(str) then fails to convert '\' seprators embedded
in binaries since str.replace('/', '/') is a noop. The operation
we want here is to convert all '\' to '/' anyway so this is more
explicit regardless of any opinions on our choice to dynamically
vary os.sep and os.path.sep
Change-Id: I76c05b188abca41c6a1b516c68b584e0c06e7235
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
If the user uses a name with a . in front, those files need to read
too.
Change-Id: I5d8a762afa5dc4cff646f2a5cf2e4eabf6f9bc99
Task-number: QTCREATORBUG-13127
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Do this in a separate step to keep the next patch more readable.
Change-Id: I37cfd5481dcbfda52135eccec30852aefde1b950
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
when there are removed files in navigation history. Steps to reproduce:
Open file in editor. Remove it outside the qtc. Activate qtc. "File Was
Removed" prompted - agree to remove it. Navigate back(alt left two
times). Qtc goes crazy with endless Error messages like a "Cannot open /
path/to/that/dead.file for reading: No such file or directory"
Change-Id: I10a4c178ba83a8dc769895830b6f76da2e676556
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
That was used during the times where OS X still had alternating row
colors in item views.
Change-Id: I6622604502a768c4abeb42f25bcfea5c65f66395
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
It is more reasonable to elide filenames at left and messages at right
Change-Id: I980026eb558c6528da85a5ddb1a7125bb3d7fdce
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
The default in QMacStyle, to use FieldsStayAtSizeHint, just almost
always is the wrong thing to do. Additionally this goes undetected for a
while most of the time, because most people do not run their code on OS
X. Override it globally to AllNonFixedFieldsGrow like in other shipped
styles.
Task-number: QTCREATORBUG-14337
Change-Id: I3b0719c0201871fbf0163b54b1a54823bf5d14f3
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
The view is also used for the regular expressions for FakeVim's
ex command mapping, so we should not do special filtering for
keyboard shortcuts on OS X
Change-Id: I437b45a53beb93caeaec43af2f898c55b2a1601f
Reviewed-by: hjk <hjk@theqtcompany.com>
Incorrect conversion from the Variant to the String is fixed.
Change-Id: I082cdbeee1568d0b6b567232b50419d76572a197
Task-number: QTCREATORBUG-14404
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Rename the signals used to report stdout/stderr to make it clearer
what they actually do. Remove some unimplemented private member
functions while at it.
Change-Id: I7e856f906ccb45964f3b1b64336d4d8ebca7b9ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The IOptionsPage parts in it were trivial, and we need more flexibility
for the shortcut settings options pages.
Change-Id: I93ddaf060ac88ef339da9f542719f2d695660ac0
Reviewed-by: hjk <hjk@theqtcompany.com>
For example when developing on Windows, cross compiling to Linux, the
result is not executable from the Windows perspective.
Reverts f2cfd3c01a which changed the code
to use ExistingCommand to get the automatic expansion of app bundles on
OS X, and do automatic expansion of app bundles also when using path
chooser of type File. Choosing an app bundle in a path chooser of type
File would previously lead to an invalid entry in the path chooser
anyhow, because the app bundle itself is not a file.
Change-Id: Ie710c47918d2b8735009e290301ed2683e354f2c
Task-number: QTCREATORBUG-14412
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
The window was cleared even if the option to clear it wasn't
selected. Moving the cursor to the end, has the side effect of
clearing the selection, so do that always.
Change-Id: I6b61981f46394c61e61066aa8033c7e3391e6c07
Task-number: QTCREATORBUG-14410
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Turns out that using Id::uniqueIdentifier() is not deterministic across
invocations of Creator...
Change-Id: I8b78a5b36c2cd61e4b9c5d8cc8eb2c6083282c01
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Use aggregation instead of inheritance for customization of validation.
Gets rid of a few additional classes.
Change-Id: Iaf8f12026c40a55bfde98b3786100f8ac431d750
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
I ended up not needing that, but this might be useful for others.
Change-Id: Ie3a5a731d9f3f3f456d7cd4164cfa1753e2b54f1
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
If no node is selected, e.g. no document is open, the ProjectTree
currently claims that there is no current project.
This adds a fallback to startup project in that case. This especially
fixes the case where only one project is open and as such it is clear
from context which project the user expects to be current.
Revert a few places where I implemented this fallback manually.
I do not like this. If multiple projects are open, this fallback can be
surprising and not what the user wants. Everything works fine in the
simple case with one project open but breaks with multiple projects
open, this actively hides bugs.
Change-Id: I6259834ca2220dd83bdffb16c3a0eac8f98e504b
Task-number: QTCREATORBUG-14394
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Broke in 7481bff2b4 which split up
LibraryTemplate in SharedLibraryTemplate and StaticLibrary.
Change-Id: I797c007fff09ffd09b7744cf3543217b936dea12
Task-number: QTCREATORBUG-14382
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>
This partially reverts commit e33da6a6b3.
GDB seems to hang while executing str(some_pointer) in some setups.
Task-number: QTCREATORBUG-14374
Change-Id: Ia678533b9122e505b21ef6659d404239995ddb81
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
By the use of P4CONFIG (p4config.txt) one can now specify workspace
details (P4USER, P4CLIENT, P4PORT) individually for specific projects.
Previously one had to reconfigure Qt Creator in Settings for every
workspace switch.
Change-Id: I117829ab3cf592562a4662f85314aa3c125e7610
Task-number: QTCREATORBUG-14378
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
As the default-constructed value is not zero. This was not considered in
7aa8ae54ae.
Change-Id: I1f32b1c317e0de34b48dbe003c3968f66133a64d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This dubious workaround is no longer necessary due to the new
qbs.installSourceBase property.
Change-Id: I352b82ddf445ea6e7d8f870769de805bf71e7dc4
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Missed a spot in ad4cb444fb
Task-number: QTCREATORBUG-14141
Change-Id: I1a6a25ce3e9c2a680e1b8eebec01a17749cdb026
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
It is used in some comments but doesn't compile...
Change-Id: I5ba3afbe927c3b625218c0c2fee2c9ee6f53f4aa
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
