Commit Graph

11 Commits

Author SHA1 Message Date
Nikolai Kosjar
b09c2cd36c CppEditor: Fix leaking ClassItem
...in InsertVirtualMethodsOp. Leak occurred while running

    test_quickfix_InsertVirtualMethods(final_function_removed)

in valgrind memcheck.

Change-Id: I1119b68feb25ecd6e210201c7e0f1e651e2542f9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-09-22 10:49:42 +02:00
hjk
02d26f9221 CppEditor: Compile fix for clang after renaming
Change-Id: Iaabb45fb066afb600718d874a0461bc88fae92e5
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
2014-08-28 13:32:56 +02:00
Nikolai Kosjar
acbc4b9f07 C++: Get rid of {Name,Type}::isEqualTo()
...since it's superseded by the class Matcher.

For consistency, rename FullySpecifiedType::isEqualTo() to match().

Change-Id: I07640f9218d814e0350265de45f05929e5d595a9
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-05-23 14:43:30 +02:00
Nikolai Kosjar
4dd8a8fdd9 CppEditor: Tests: Fix newline handling
removeTrailingWhitespace() appended one '\n' too much. As time went by,
excess '\n' where added to the test code.

* Remove excess '\n'.
* For consistency, ensure that each test code line ends with '\n'.

Change-Id: Ie2d4a1b8b27989f26bf154cb3b891dfb8fe6b2fd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-05-15 14:46:30 +02:00
Orgad Shaneh
f4f8f97258 CppEditor: Hide only functions that are implemented in the target class
... in Insert Virtual Methods

Change-Id: Ifc5ece2e98c316190331f56187fe39954e49b519
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-02-04 22:31:53 +01:00
Orgad Shaneh
fd31b4716c CppEditor: Remove final functions from virtuals tree
Change-Id: I2daad43539927e012af23b19dbca00f3aaa644e2
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-02-04 11:33:42 +01:00
Orgad Shaneh
d89d26ab4d CppEditor: Enable choosing any override in Insert Virtual Methods
Change-Id: I839cfeb2650f991bcf9660e5ccbfa52452917eb8
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-02-04 11:30:26 +01:00
Orgad Shaneh
499c3d352b CppEditor: Fix Qt4 compilation
Change-Id: Icf86c9c1f39ce5f97e34a27ea456688cba1cd210
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-01-28 13:23:44 +01:00
Orgad Shaneh
175066af68 CppEditor: Use a custom model for InsertVirtualMethods
Simplifies the code, enables easier enhancing

Change-Id: I644befc903b2537053b214dfdef3f51dc7af216a
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-01-27 18:10:47 +01:00
Alessandro Portale
b305af0aef CppEditor: build fix (Qt5)
Change-Id: I8771ee574f9b2d0cd78786f6cd7c2e19d8865412
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-01-24 12:12:14 +01:00
Orgad Shaneh
b728045588 CppEditor: Move InsertVirtualMethods to its own file
It contains many components, doesn't make sense to have it with all
other quickfixes.

Change-Id: Idede14c90ba9b612ae9e9048f5795d674811acfe
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
2014-01-24 11:35:03 +01:00