Old value fails with Qt 5.5.0.
Changing binary value 0.00110011 to 0.0011.
Task-number: QTCREATORBUG-14757
Change-Id: I6de62241089d50256cfef6f7cba61389da58b6ed
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Commit d765cd73a2 pulled in more stuff into the diassembler.
Change-Id: I83e0907abaef84a9cebb3c63d957182707af012d
Reviewed-by: hjk <hjk@theqtcompany.com>
In the QmlEngine, a few tr() have been replaced by
QCoreApplication::translate().
In other files, Q_OBJECT has been added to the class definitions.
Change-Id: Ia0505c19934dc691cd3d67f4946293290c2fec68
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
Recent builds of GDB started to deliver *running and *stopped
notifications for expression evaluation, even unpaired at times.
Since we know that we are stopped when we start variable extraction
and we are stopped when it ends, the intermediate notifications
can be ignored.
Change-Id: I800082afb7df600ad4e6f97b534f4ea901c02d8a
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
using CodeCompletions = QVector<CodeCompletion>;
using CodeCompletionChunks = QVector<CodeCompletionChunk>;
Change-Id: Id729a43566c23dc000e44d79ccf4a49e4f235f51
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
We can not offer proper constructor completion with libclang <= 3.6, so
fall back to normal/global completion.
Change-Id: I90bb8d981ae20ed4c228f829ad4267221b92f8a1
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
The renames will improve the readability of the follo-up change.
Change-Id: If1f5ae2a2798c13ce7268e436dae1b3963f01d5e
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
Broken by d765cd73a2
QWidget is included in runconfiguration.h, so QT = widgets is required.
Change-Id: I254ae5dca8f537b5d8e3f8977be50cadcaa053b4
Reviewed-by: Kevin Funk <kevin.funk@kdab.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
locker only exists with PROPARSER_THREAD_SAFE defined.
Broken by dedcd25924
Change-Id: Ieee60dc6f567ab1c3a59697a1760afb2990496f6
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
There are two ways to hot fix the dependency problem. First version is to
disable the caching(not the preamble) but it is triggering bugs. Second
version is to enable caching and reparse before every complete. I opted
for the second version because it is the commonly used path for most
implementations. Later we have to minimize the reparse calls but for that
we need the cooperation of editor.
Change-Id: I878afb896cbf2338cbeb13d9e596a7776dd49854
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
We reparse before every code completion so this code can be removed. We
will reuse some of it later.
This reverts commit 2443f18b85.
Change-Id: Ifcadfaa09b87ce5b58bfe5fe3cbaa2a86a59c5a6
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
- speed up the test by not waiting for C++ parsing
- measure the time for parsing qtcreator.pro and fail if too long
Task-number: QTCREATORBUG-10733
Change-Id: I1d00812a3e8e56a5ee6e1828bc60aa6eb3d2da41
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Q_STATIC_BYTE_ARRAY_DATA_HEADER_INITIALIZER is entirely private and may
change at any time.
More importantly, this macro is not necessary at all. QByteArrayLiteral
solves the problem neatly.
Change-Id: Ib306f8f647014b399b87ffff13f2c0f38c459ab1
Reviewed-by: Adam Majer <adamm@zombino.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
QML files are utf8 encoded, therefore we have to use utf8
consistently. There is no gurantee that identifiers and names
are just latin1.
Change-Id: I4aa58d4c68c126d74badfc699a239ef9b2790faa
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
The user needs some clue what buffer is about to be saved,
even if this is not a real file name.
Task-number: QTCREATORBUG-14602
Change-Id: I7d81a50079d8aa1a3b2ba63130d54515667a6663
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>
GCC 4.9.1 + GDB 7.8 (and likely more combinations) produce
sizeof(QProcess[3]) == 0, making the dumpers report no child
entries for the array.
To work around, try to parse the array size from the type name itself.
Task-number: QTCREATORBUG-14755
Change-Id: I1f17d5d6fde6bc5fe66d2ad4a73f77185503f9ab
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
ProFileCacheManager::discardFile(s) may remove an entry from
the ProfileCache only when it is unused (which is the case iff
ent->locker is zero).
Change-Id: I9df2079087af6bd0d35dd121db6222e8a6ec9389
Task-number: QTCREATORBUG-14730
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
If the build directory is empty, which can happen if we are parsing
a completely unconfigured project, then UIDIR might end up being '/'.
The uiHeaderFile function appeneded /ui_XXX.h to that, leading to
a network path.
Fix that by ensuring in various places that we handle this case.
Task-number: QTCREATORBUG-10733
Change-Id: Ib848ed4efbeacc6ee7ff862bef861a58f6d3ea34
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
... and use it to toggle breakpoints by file and line,
and for jumping to file and line.
Task-number: QTCREATORBUG-14278
Change-Id: I799d085eb53339905ea3608022aeae5a9aef1fda
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
GDB does not report register sizes using the MI protocol, so sizes were
infered from the register name. This is fragile, better use
"maintenance print raw-registers" which reports the sizes and even
if not part of the official interface, is unlikely to change.
Change-Id: If7c7182751a496084a351aaef3a97dcdac6c500b
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This makes 100M a hard limit, reducing the likelihood that an
uninitialized byte array will look valid.
Change-Id: I51dc5f39e0c7327faa8c1d0640934a6074d8c559
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Change 7309e8bb64
caused "console" to be added to the CONFIG variable,
which resulted in qtcdebugger launching an additional
command prompt window.
Change-Id: I05c74c4ba7a4441ba2a7d3a1ad96fe3b11c74663
Task-number: QTCREATORBUG-14759
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
In the default format of ssh-keygen.
Change-Id: Ibea5f4bde5cc6ea343f75c73f786437178e4350e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
All host keys can be used with all HMACs.
Change-Id: I71055d3085d13683e53491ac9a9d98734dd6e7e5
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
... when listing members of a struct in the Locals and
Expressions view.
Task-number: QTCREATORBUG-14767
Change-Id: I5089dd3bcba40ab335be164c5de2f2d70c3ed4f4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
... after deletion. The breakpoint itself was actually removed from
the breakpoint view but the red blob stayed until the next update
(e.g. after the next 'step')
Change-Id: I120059a6e643df7c104a8f6d96e09b9c707d14d8
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
The settings page has now its own scrollarea if a settings page gets
to big, so the kits page doesn't need its own scroll area.
This behaves a bit differently.
Change-Id: I3c78abf332cec07d34350112fd66cc4d6e81dd15
Task-number: QTCREATORBUG-14750
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Include hexadecimal, octal, and binary values as well
Task-number: QTCREATORBUG-7528
Change-Id: I73989414352c455fbad8aa210fc762c8cfc06c76
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
... when passing data from the dumpers to the GUI. This reduces
the need to guess whether a value contains a translatable string.
Change-Id: I5e2210b8d028bd71f0087a2ba5c7c5b04331b882
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
By using some of the infrastructure in Utils::Environment. Due to
wanting to find all cmake executables in PATH and not just the
first one, we need some custom code.
(cherry picked from commit ca8b43f6c8)
Change-Id: If3161d712b9f6e659450a3d0647f83344e68ba5d
Task-number: QTCREATORBUG-14740
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
... when using Debug->Start->Attach to Running Debug Server
Task-number: QTCREATORBUG-14747
Task-number: QTCREATORBUG-7459
Change-Id: I98c3d4f2d565d972369f2716ff2b72b4d3d04b2b
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Qt Creator's Perforce plugin uses "fstat" command to gather the files in
the project.
This takes ~40 seconds on a 12.000 files project.
By using "files" command the operation of gathering the files in the
project takes ~1 second.
Change-Id: Id8257d33a5dda2e06f0f365d5e3b30a49a094483
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Perforce repositories configured with P4CONFIG had a bug
in the submit dialog, one could not see the differences for
the submited files.
Change-Id: Ie15fd66667dca1c0863a29e87ff76583d9aa3bbb
Task-number: QTCREATORBUG-14538
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
... to engines that actually support JumpToLine and make it
work in disassembler views.
Change-Id: I10368ea719587caa7c4f33665eff57c2bf300d84
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Casting from a Qvariant is expensive and it happens here very often.
Change-Id: If524412f314bb8ac9e9e5e4335c7e32ff7a9ce40
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
If an editor is opened, the semantic highlighter is triggered twice:
1) From ClangEditorDocumentProcessor::onParserFinished
2) From CppEditorDocument::applyFontSettings
Caller 1) is expected, it creates an m_unit. However, if threads are
scheduled differently, the semantic highlighter triggered from 2) will
encounter an invalid m_unit.
I'm not sure whether the call to 2) is correct at all.
Change-Id: Ia6ff2852e7d38418ebb01edc3eca3680fac1820a
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>